16:21 PM
yvanzo
It is unknown whether the tmp file location changes would cause any decrease, but if it does it would be due to the underlying filesystem, thus more a deployment issue.
2023-08-09 22124, 2023
16:22 PM
yvanzo
The ionice stuff doesn’t seem to work at the moment, possibly due to a deployment issue too. It is unknown how much effect it would have really either.
2023-08-09 22156, 2023
16:23 PM
yvanzo
By “deployment issue” I mean something external to MBS such as cgroup driver.
2023-08-09 22122, 2023
16:24 PM
bitmap
ok, makes sense
2023-08-09 22106, 2023
16:25 PM
bitmap
"Allow specifying the path to temporary directory" seems generally useful but we can probably scrap the rest
2023-08-09 22123, 2023
16:26 PM
yvanzo
Alright, I will shrink this PR and attach the scrapped part to the ticket just in case, thanks for looking into it.
2023-08-09 22151, 2023
16:28 PM
bitmap
👍 thanks for all your work on it
2023-08-09 22153, 2023
16:29 PM
iconoclasthero has quit
2023-08-09 22136, 2023
16:33 PM
lucifer
mayhem: spotify export still fails for me when using tag radio, i'll look into again.
2023-08-09 22130, 2023
16:34 PM
mayhem
thanks!
2023-08-09 22113, 2023
16:38 PM
yvanzo
bitmap: On a related topic: the alert about disk space usage during weekly cron jobs; Are there some archives we could rotate to a different volume/host? For example JSON dumps on a yearly basis?
2023-08-09 22155, 2023
16:54 PM
bitmap
yvanzo: yes, we could probably do with archiving incremental json dumps (and maybe replication packets) more than a year old back onto aretha
2023-08-09 22149, 2023
16:56 PM
yvanzo
alright, I can make a ticket for this
2023-08-09 22151, 2023
16:56 PM
jasje
2023-08-09 22113, 2023
16:57 PM
jasje
2023-08-09 22152, 2023
16:57 PM
lucifer
jasje: i think if you download chrome or firefox it will work on api level below 25 too
2023-08-09 22108, 2023
16:58 PM
jasje
2023-08-09 22141, 2023
16:58 PM
jasje
lucifer: but then we can't parse the html to get token
2023-08-09 22142, 2023
16:58 PM
bitmap
yvanzo: moving the incremental json dumps would be a lot more impactful to start with, anyway, since they take up a lot more space
2023-08-09 22117, 2023
16:59 PM
jasje
So it bricks login on api 25 and below
2023-08-09 22151, 2023
16:59 PM
jasje
Should I bypass the error then?
2023-08-09 22122, 2023
17:00 PM
lucifer
jasje: use chrome webview?
2023-08-09 22149, 2023
17:00 PM
jasje
2023-08-09 22103, 2023
17:01 PM
jasje
lucifer: thats new
2023-08-09 22108, 2023
17:01 PM
lucifer
jasje: bypass it conditionally.
2023-08-09 22118, 2023
17:01 PM
lucifer
if the error is on API 24 or low, ignore.
2023-08-09 22135, 2023
17:01 PM
lucifer
jasje: there's probably a compat version available.
2023-08-09 22105, 2023
17:02 PM
lucifer
this is something that we can't really control, so add a comment and ignore the error if it works.
2023-08-09 22137, 2023
17:02 PM
jasje
alright so bypass it api 24 and below?
2023-08-09 22143, 2023
17:02 PM
lucifer
yes
2023-08-09 22154, 2023
17:02 PM
jasje
because thats the only affected are
2023-08-09 22158, 2023
17:02 PM
jasje
area
2023-08-09 22101, 2023
17:03 PM
jasje
okeys
2023-08-09 22126, 2023
17:05 PM
ssam has quit
2023-08-09 22140, 2023
17:06 PM
yvanzo
bitmap: Updated the PR about temporary directories.
2023-08-09 22117, 2023
17:10 PM
bitmap
thank you
2023-08-09 22136, 2023
17:13 PM
bitmap
2023-08-09 22121, 2023
17:14 PM
yvanzo
bitmap: that’s me ^
2023-08-09 22124, 2023
17:14 PM
bitmap
I don't'recognize the query as being from MBS. (also not certain if this was what actually triggered the event)
2023-08-09 22156, 2023
17:14 PM
yvanzo
I’m setting up a replica with edit data on wolf as a fallback.
2023-08-09 22117, 2023
17:16 PM
bitmap
alright
2023-08-09 22134, 2023
17:16 PM
bitmap
if it is problematic we might need some new indexes for it
2023-08-09 22154, 2023
17:16 PM
BrainzGit
2023-08-09 22157, 2023
17:17 PM
yvanzo
2023-08-09 22126, 2023
17:29 PM
BrainzGit
2023-08-09 22123, 2023
17:35 PM
ssam joined the channel
2023-08-09 22152, 2023
17:36 PM
yvanzo
2023-08-09 22119, 2023
17:37 PM
yvanzo
(2010)
2023-08-09 22150, 2023
17:40 PM
bitmap
heh, I left a comment already before I saw your ping
2023-08-09 22155, 2023
17:40 PM
bitmap
but no, it does not
2023-08-09 22127, 2023
17:43 PM
BrainzGit
2023-08-09 22147, 2023
17:43 PM
BrainzGit
2023-08-09 22152, 2023
17:43 PM
BrainzGit
2023-08-09 22105, 2023
17:46 PM
BrainzGit
2023-08-09 22114, 2023
17:46 PM
BrainzGit
2023-08-09 22124, 2023
17:46 PM
BrainzGit
2023-08-09 22155, 2023
17:47 PM
BrainzGit
2023-08-09 22148, 2023
17:49 PM
akshaaatt
Dude jasje, the Feed looks INSANELY good in the app! Wow! 🔥🔥🔥🔥
2023-08-09 22117, 2023
17:50 PM
jasje
Glad you liked it!
2023-08-09 22144, 2023
17:50 PM
jasje
Stuff is as reusable as it can be
2023-08-09 22147, 2023
17:50 PM
akshaaatt
The best thing we’ve had in the app so far for me
2023-08-09 22137, 2023
17:51 PM
jasje
Heh there's alot more to come
2023-08-09 22150, 2023
17:51 PM
jasje
im thinking of doing notifications after gsoc
2023-08-09 22107, 2023
17:52 PM
jasje
that would just complete it all
2023-08-09 22143, 2023
17:52 PM
jasje
i recommend a song to you, pop! there's a notification
2023-08-09 22112, 2023
17:53 PM
akshaaatt
Killer ⚡️🔥
2023-08-09 22121, 2023
17:53 PM
akshaaatt
Can’t wait to have this jn beta
2023-08-09 22158, 2023
17:53 PM
jasje
Me too!!
2023-08-09 22150, 2023
17:58 PM
yvanzo
bitmap: thanks for your time, off for a meal
2023-08-09 22138, 2023
17:59 PM
bitmap
same and likewise :)
2023-08-09 22118, 2023
18:18 PM
jasje
2023-08-09 22136, 2023
18:18 PM
jasje
read the comments of first reply
2023-08-09 22150, 2023
18:18 PM
jasje
i don't think ignore ssl error is a good idea
2023-08-09 22158, 2023
18:18 PM
jasje
ignoring*
2023-08-09 22120, 2023
18:19 PM
jasje
Itll put the app's reputation at risk
2023-08-09 22137, 2023
18:19 PM
jasje
akshaaatt^
2023-08-09 22103, 2023
18:22 PM
BrainzGit
2023-08-09 22142, 2023
18:25 PM
akshaaatt
2023-08-09 22136, 2023
18:26 PM
jasje
That violates google's policy
2023-08-09 22139, 2023
18:26 PM
BrainzGit
2023-08-09 22110, 2023
18:27 PM
jasje
because showing info about ssl errors in web view is just not it for them
2023-08-09 22135, 2023
18:27 PM
jasje
They say the user can't make an informed decision
2023-08-09 22107, 2023
18:28 PM
BrainzGit
[listenbrainz-android] 14akshaaatt merged pull request #205 (03main…dependabot/gradle/org.jetbrains.kotlinx-kotlinx-coroutines-test-1.7.3): Bump org.jetbrains.kotlinx:kotlinx-coroutines-test from 1.7.1 to 1.7.3
https://github.com/metabrainz/listenbrainz-androi…
2023-08-09 22126, 2023
18:28 PM
jasje
Plus we really don't want to risk the popularity on playstore
2023-08-09 22140, 2023
18:28 PM
BrainzGit
2023-08-09 22147, 2023
18:34 PM
jasje
Prolly bring back the old login screen and throw in mix of if else imo
2023-08-09 22148, 2023
18:43 PM
BrainzGit
2023-08-09 22157, 2023
18:43 PM
BrainzGit
2023-08-09 22117, 2023
19:31 PM
BrainzGit
2023-08-09 22142, 2023
20:02 PM
lucifer
2023-08-09 22123, 2023
20:03 PM
mayhem
hmmm. duplicates in the data.
2023-08-09 22151, 2023
20:03 PM
mayhem
different recordings, but same names. does the data need to be canonicalized before going into this process?
2023-08-09 22146, 2023
20:04 PM
lucifer
where?
2023-08-09 22108, 2023
20:05 PM
mayhem
row 0, row 1
2023-08-09 22125, 2023
20:05 PM
lucifer
hmm those are different for me
2023-08-09 22127, 2023
20:05 PM
mayhem
oh, sorry. that's the album. ignore me.
2023-08-09 22132, 2023
20:05 PM
lucifer
ah cool
2023-08-09 22149, 2023
20:05 PM
lucifer
this MLHD+ dataset so the dataset is already canonicalized.
2023-08-09 22134, 2023
20:06 PM
lucifer
2023-08-09 22144, 2023
20:06 PM
mayhem
yes, looks great!
2023-08-09 22147, 2023
20:06 PM
mayhem
!m lucifer
2023-08-09 22147, 2023
20:06 PM
BrainzBot
You're doing good work, lucifer!
2023-08-09 22117, 2023
20:07 PM
lucifer
just use `caa_release_mbid` instead of `release_mbid`
2023-08-09 22118, 2023
20:13 PM
lucifer
mayhem: i am not sure why but tag radio picks standalone recordings even when the non-standalone versions are available.
2023-08-09 22127, 2023
20:13 PM
lucifer
any ideas why?
2023-08-09 22104, 2023
20:14 PM
mayhem
troi does very little for the tag radio. I literally just choose a section and then randomly pick recordings.
2023-08-09 22119, 2023
20:14 PM
mayhem
if the recordings that I am picking are bad, its because they came that way from the tag query.
2023-08-09 22100, 2023
20:16 PM
lucifer
i see what exactly happens when we just use an artist seed?
2023-08-09 22148, 2023
20:16 PM
mayhem
the top recordings for artists, the old one, is used for the seed artists and its similar artists.
2023-08-09 22105, 2023
20:17 PM
mayhem
2023-08-09 22118, 2023
20:17 PM
mayhem
I need to switch to the new popularity endpoint
2023-08-09 22143, 2023
20:17 PM
lucifer
that is weird.
2023-08-09 22158, 2023
20:17 PM
lucifer
iirc we removed standalone recordings from MLHD+ dataset
2023-08-09 22124, 2023
20:18 PM
lucifer
2023-08-09 22129, 2023
20:18 PM
lucifer
2023-08-09 22126, 2023
20:19 PM
mayhem
seems that "it happens randomly" can't possibly be the answer, can it?
2023-08-09 22105, 2023
20:20 PM
mayhem shrugs
2023-08-09 22109, 2023
20:20 PM
lucifer
sure it can be but that means the dataset generating script had a bug and we'll have to generate this from scratch
2023-08-09 22134, 2023
20:20 PM
lucifer
not the popularity data, MLHD+ itself.
2023-08-09 22144, 2023
20:20 PM
mayhem
yeah.
2023-08-09 22148, 2023
20:21 PM
mayhem
wait is the MHLD+ data part of the tag query results?
2023-08-09 22122, 2023
20:22 PM
arsh
Thanks lucifer: I will take a look
2023-08-09 22123, 2023
20:22 PM
mayhem
the tag data comes from MB, no?
2023-08-09 22102, 2023
20:23 PM
mayhem
do you exclude standalone recordings from the tag queries?
2023-08-09 22117, 2023
20:23 PM
lucifer
mayhem: the tag data comes from MB, MLHD+ data is part of that as in it is used to order the tags based on popularity.
2023-08-09 22145, 2023
20:23 PM
mayhem
ok, order, but not a data source.
2023-08-09 22148, 2023
20:23 PM
lucifer
nope i don't exclude standalone recs from tags queries because those shuoldn't be in the dataset in the first place.
2023-08-09 22118, 2023
20:24 PM
mayhem
if the MLHD is used to order, but not as a data source, then this could be the problem, no?
2023-08-09 22138, 2023
20:24 PM
lucifer
sorry not sure what you mean?
2023-08-09 22107, 2023
20:25 PM
lucifer
but yes in general standalone recording are a problem, regardless of how those come into LB.
2023-08-09 22109, 2023
20:25 PM
mayhem
the recording_mbids come from MB tag data queries... tagged recordings. yes?
2023-08-09 22127, 2023
20:25 PM
lucifer
anything mapping related will break when it encounters a standalone recording mbid.
2023-08-09 22143, 2023
20:25 PM
mayhem
and then those tagged recordings are ordered by MLHD+ data. but is recording_mbids taken from MHLD+?
2023-08-09 22154, 2023
20:26 PM
lucifer
recording mbids are from MB only.
2023-08-09 22113, 2023
20:27 PM
lucifer
for tags dataset
2023-08-09 22128, 2023
20:27 PM
lucifer
2023-08-09 22129, 2023
20:27 PM
mayhem
yes, and if the standalone recording MBIDs are not filtered out, then they get returned as part of the tag query no?
2023-08-09 22138, 2023
20:27 PM
lucifer
yes
2023-08-09 22107, 2023
20:28 PM
lucifer
2023-08-09 22118, 2023
20:28 PM
lucifer
it also has standalone recording MBIDs
2023-08-09 22100, 2023
20:30 PM
mayhem
ok, so there is the source of standalone recordings then. unless I am too tired to understand. in which case we should continue tomorrow.
2023-08-09 22135, 2023
20:30 PM
lucifer
yes that is right.
2023-08-09 22144, 2023
20:30 PM
lucifer
just to clarify, we have multiple sources of standalone recordings.
2023-08-09 22111, 2023
20:31 PM
lucifer
regardless of whether we redo the dataset, we'll need to handle this in LB better.
2023-08-09 22138, 2023
20:31 PM
mayhem
oh, I think i understand what you are saying. you're saying it doesn't happen on artist, but it happens on tag, even though they are fed from the same data. is that it?
2023-08-09 22110, 2023
20:32 PM
lucifer
uh no, i am saying it can happen on both.
2023-08-09 22109, 2023
20:33 PM
mayhem
that is what I was trying to say.
2023-08-09 22121, 2023
20:33 PM
mayhem
now, what I should try is switch the artist source to the new popularity dataset.
2023-08-09 22159, 2023
20:33 PM
mayhem
then then problem might start appearing in the artist source of lb radio. then it would make sense, and somehow the old popularity data set had no standalone recordings.
2023-08-09 22142, 2023
20:35 PM
lucifer
i see makes sense.
