derat: thank you for working on that ticket!! Will be extremely useful! (I haven't looked at the code though)
2023-08-14 22635, 2023
jasje
aerozol: same thoughts
2023-08-14 22610, 2023
jasje
But where to use orange is the question
2023-08-14 22651, 2023
jasje
also did you brainstorm ideas for showing similar listens
2023-08-14 22656, 2023
jasje
My thought is to use the same UI component used to show content of cb reviews for this as well
2023-08-14 22658, 2023
aerozol
jasje: you don't *have* to use orange at all
2023-08-14 22650, 2023
jasje feels bad for orange but not enough to hang onto it
2023-08-14 22619, 2023
jasje
so about the similar listens design
2023-08-14 22630, 2023
aerozol
We already have it on some icons and visuals in the app proper
2023-08-14 22639, 2023
aerozol
With similar listens can you remind me? I believe you had enough to start putting it together, and then afterwards we were going to look at how to show the similarity score
Its missing the time tag and a quick follow button
2023-08-14 22601, 2023
jasje
mostly the time tag
2023-08-14 22649, 2023
jasje
If i add it below the listen, things just look too spaced out and gets out of sync with the padding i have on every list on the app
2023-08-14 22633, 2023
jasje
aerozol: something like this would be good i think. Not sure what to fill the bottom side with. But all in all I already have a component ready for this https://usercontent.irccloud-cdn.com/file/76EXWVm…
2023-08-14 22631, 2023
reosarevok
mayhem: do we have any current last.fm contacts to talk to about last.fm users coming to make a mess in MB?
2023-08-14 22640, 2023
reosarevok
I'm not sure they'll care and/or be able to do anything, but
2023-08-14 22646, 2023
mayhem
not really no.
2023-08-14 22626, 2023
aerozol
jasje: Looking at this I’m still leaning towards not having the similarity or the follow button duplicated everywhere
2023-08-14 22628, 2023
lucifer
mayhem: the listening now tags PR is already mergred.
2023-08-14 22614, 2023
mayhem
is it not enabled? or do I just not know how to use it?
2023-08-14 22650, 2023
lucifer
it should be working normally.
2023-08-14 22629, 2023
mayhem
are you able to tag on now listening? I can't see how to do it.
I’m going to ask monkey for a second opinion, but we’ve gone back and forth for long enough that I’m probably going to make a call on it
2023-08-14 22656, 2023
aerozol
If you want to give reasons as to what/why/how you don’t like it that will help!
2023-08-14 22640, 2023
jasje
this bar has totally independent state than that of listens list
2023-08-14 22639, 2023
jasje
its like first finding a listen and then matching it with a user in this component
2023-08-14 22622, 2023
aerozol
I see that as a positive - as you’ve noticed, myself and a few others see this as a playlist first, and a follow similar users display second. I’m not saying the second part isn’t important, but it’s not necessarily what everyone’s after
2023-08-14 22615, 2023
aerozol
What would you prefer - we discuss it with monkey and make a call, or I put the different options on the forums for some user feedback and thoughts (and then me and monkey make a call)
2023-08-14 22614, 2023
jasje
something minimal which can be added as extension to the listen card
2023-08-14 22634, 2023
jasje
i really just want the extra similarity and thats it
2023-08-14 22605, 2023
jasje
rest of the card looks cool
2023-08-14 22646, 2023
aerozol
There are a few problems solved by a separate section, with the ten users ordered by similarity: It explains what this ‘similar listens’ tab does/shows, at a glance. And it lets us see the % and click through to follow without duplicating everything.
2023-08-14 22651, 2023
lucifer
mayhem: can you logout and login again?
2023-08-14 22608, 2023
lucifer
it should start working for a while, and will probably break down when the token expires. will look at it again, have a hunch as to why its happening.
2023-08-14 22641, 2023
aerozol
My call right now is that I don’t want the % and the follow button duplicated on every listen, I don’t think it’s good UI. I’ll let monkey chime in as well. As said, happy to get community feedback if you think users will prefer your version
2023-08-14 22602, 2023
mayhem
I'm viewing in the app itself -- there are no means to navigate, so how can I log out?
2023-08-14 22638, 2023
lucifer
mayhem: login and logout from browser and then restart metadata viewer.
2023-08-14 22646, 2023
mayhem
ah.
2023-08-14 22607, 2023
lucifer
we should improve metadata viewer UX though in future.
2023-08-14 22622, 2023
jasje
aerozol: the follow button is stupid i agree
2023-08-14 22628, 2023
mayhem
!m lucifer
2023-08-14 22628, 2023
BrainzBot
You're doing good work, lucifer!
2023-08-14 22638, 2023
mayhem
tags working well!
2023-08-14 22648, 2023
lucifer
all monkey's work :)
2023-08-14 22610, 2023
mayhem
you worked out how to fix it. but yeah...
2023-08-14 22613, 2023
lucifer
the token refresh is still broken but i have added logging on test for helping in debugging, should have more data after 1 hour.
2023-08-14 22614, 2023
mayhem
!m monkey
2023-08-14 22614, 2023
BrainzBot
You're doing good work, monkey!
2023-08-14 22604, 2023
mayhem follows up on the ticket
2023-08-14 22617, 2023
mayhem
I'm sooo happy right now. :)
2023-08-14 22620, 2023
monkey
> My call right now is that I don’t want the % and the follow button duplicated on every listen, I don’t think it’s good UI
2023-08-14 22620, 2023
monkey
aerozol, jasje : ^this also sums up my opinion. Extending the listencard and taking more space just to repeat information that could be collated at the top just seems like a waste to me (also because I want this to be a way to play and discover tracks first and foremost and the other data gets in the way. I'd rather see it tucked away in it own section
2023-08-14 22611, 2023
monkey
But honestly at this point it feels like we're repeating ourselves. The conversation feels like deja vu.
2023-08-14 22608, 2023
monkey
mayhem: Thanks, i'll note down that greying and disabling the add tag button would be better than hiding it which is probably what happens currently
2023-08-14 22631, 2023
monkey
As for token refresh issues, lucifer will be my savior
2023-08-14 22609, 2023
aerozol
monkey: It is a repeat, but last time I was a bit vague on the outcome. This time if you feel the same then I would say decision made
2023-08-14 22619, 2023
mayhem
are you going to make another pass at the listening now page?
2023-08-14 22652, 2023
mayhem
if I wasn't about to get on vacation I would make a couple of improvements on it. (artist summary and artist info)
2023-08-14 22658, 2023
lucifer
mayhem: when will you be back from vacation?
2023-08-14 22638, 2023
monkey
aerozol: Seems pretty clear to me. information repeat is undesirable so I would select another way to show that information. If the one with the percentage gauge with the username underneath (posted above) isn't satisfying to you jasje I think we're open for discussion, but UX-wise I think the two professionals are in agreement
2023-08-14 22647, 2023
mayhem
Officially Sept 4. but I'm mostly sort of around this week.
2023-08-14 22655, 2023
monkey
mayhem: Yeh, improvements required
2023-08-14 22659, 2023
mayhem
tday - wed, I won;t be around for afternoons.
2023-08-14 22619, 2023
lucifer
oh cool, wanted to discuss further tasks other than MeB ouath.
2023-08-14 22620, 2023
monkey
In particular I'm starting to hate that you have to hide some of the info to see the rest. Accordions be gone !
2023-08-14 22650, 2023
mayhem
lucifer: I'll be around an hour each day as per my "vacation" policy.
2023-08-14 22613, 2023
mayhem
but, we can discuss oauth tomorrow morning. I might also work for a little while this afternoon.
2023-08-14 22621, 2023
lucifer
hehe, makes sense.
2023-08-14 22636, 2023
mayhem
it is actually a weird feeling. I am so engaged in work, I'd be happy to skip vacation. but I haven't had a proper break since march, so I should really go. :)
2023-08-14 22635, 2023
lucifer
yup indeed
2023-08-14 22612, 2023
lucifer
mayhem: since GSoC without extension deadline is on 28th, we should ask all students on that timeline to start working on their blog posts for submission.
2023-08-14 22638, 2023
mayhem
indeed. a topic for the meeting?
2023-08-14 22648, 2023
lucifer
we can then schedule those for publishing between 21-28, the submission week.
2023-08-14 22648, 2023
mayhem
(if people bother showing up this time, lol)
2023-08-14 22601, 2023
lucifer
yup makes sense
2023-08-14 22602, 2023
lucifer
lol
2023-08-14 22617, 2023
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | BookBrainz: #bookbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda: Reviews, GSoC blog posts (ruaok)
2023-08-14 22626, 2023
Sophist-UK has quit
2023-08-14 22644, 2023
Sophist-UK joined the channel
2023-08-14 22641, 2023
Pratha-Fish
Hey reosarevok bitmap would you guys be free for a discussion regarding the project extension after the meeting today?
2023-08-14 22658, 2023
Pratha-Fish
Or before. Whatever suits you
2023-08-14 22627, 2023
reosarevok
I should be around a bit before and a bit after so both work for me
lucifer (maybe mayhem ?): thoughts about dropping the snapshot tests in LB frontend tests when we move away from enzyme to use react testing library?
2023-08-14 22640, 2023
monkey
I haven't really been able to find much use to them myself as the diffs are often unreadable. By that point, they're mostly just in the way and a chore I could do without.
[listenbrainz-android] 14dependabot[bot] closed pull request #212 (03main…dependabot/gradle/navigationVersion-2.7.0): Bump navigationVersion from 2.6.0 to 2.7.0 https://github.com/metabrainz/listenbrainz-androi…
2023-08-14 22601, 2023
kellnerd
Hey monkey, I'm currently working on my GSoC project and the submission of my research project in parallel, which proved to be not that effective.
2023-08-14 22601, 2023
kellnerd
So I wanted to ask whether it's possible for me to pause GSoC for two weeks, get my written draft and presentation for the research project done, and then fully focus on GSoC again.
2023-08-14 22608, 2023
kellnerd
Of course I will compensate the missed weeks by appending them to the end of my schedule.
2023-08-14 22614, 2023
mayhem
monkey: not sure what the negative impact of that could be. but I'd be happy to see them gone. every time I want to make a simple text edit, it takes me 10 seconds to make the edit and then an hour of fighting with snapshots.
2023-08-14 22642, 2023
monkey
Yeah, that's pretty much everyone's experience as far as I can tell.
2023-08-14 22604, 2023
outsidecontext
Picard uses to update some of its data (the list of media formats and release and release group types) from the attributes.pot file of the musicbrainz-server. I noticed that this has not been working. There have been a couple of additions to medium formats and release types that are not present in this file, which was updated last time in May. Is this intentional?
2023-08-14 22609, 2023
mayhem
monkey: has it cauight bugs that would've caused us issues in prod? If not, then there is not question about yanking it.
2023-08-14 22620, 2023
kellnerd
outsidecontext: As far as I remember the idea was not to update these files while the migration from Transifex to Weblate is still in progress.
2023-08-14 22639, 2023
outsidecontext
ok, makes sense.
2023-08-14 22609, 2023
outsidecontext
yvanzo: what's the state here? could we start using weblate soon?
2023-08-14 22617, 2023
monkey
I can't remember a specific example, but it's possible. However they would have been minor things, and I don't think the tradeoff is worth it. And mind you, I waited for a couple of years before I came to that conclusion, so it hasn't been noticeably useful (while being noticeably a hindrance)
2023-08-14 22620, 2023
yvanzo
outsidecontext: yes, I was looking into available languages atm
2023-08-14 22632, 2023
mayhem
nuke it.
2023-08-14 22653, 2023
yvanzo
outsidecontext: we have a short list of supported languages in MB Server, but there isn't such list in MB Picard.
2023-08-14 22627, 2023
outsidecontext
yvanzo: cool. Very much looking forward to use this for Picard. I had already disabled updates for the secondary translation components in Transifex
2023-08-14 22651, 2023
monkey
The new testing library is predicated on testing inputs and results from the user's point of view rather than testing the implementation details, so i think the move will do a better job at ensuring good UX than the snapshots are doing (because we tend to ignore them as gaff/ unable to review)
2023-08-14 22611, 2023
monkey
Will nuke poc a poc as we rewrite the test files
2023-08-14 22618, 2023
outsidecontext
yvanzo: supported languages for Picard has multiple answers :)
yvanzo: for the main UI there is a list of languages supported explicitly in the UI. It includes those languages that had been fairly good coverage. See https://github.com/metabrainz/picard/blob/master/… . Other minor languages with existing partial translations can still be used though, if system language is being used.
2023-08-14 22641, 2023
outsidecontext
Installer and app store metadata are a different thing and only those languages that are complete (or at least nearly complete) are actually used
2023-08-14 22652, 2023
mayhem
lucifer: I started using the new popularity datasets and LB radio is actually a bit degraded right now.
2023-08-14 22618, 2023
outsidecontext
yvanzo: not sure why we should list the languages in the wiki. the available languages can be seen in weblate. the list can change, but any translation is welcome
2023-08-14 22625, 2023
mayhem
the current popularity set is all MLHD+ and then old dataset was all LB listens.
2023-08-14 22653, 2023
mayhem
the new (MHLD+) is missing artists that are more recent than the MHLD+ data.
2023-08-14 22656, 2023
yvanzo
outsidecontext: the variations en_* have very few translated messages (~1%) for example
2023-08-14 22622, 2023
yvanzo
outsidecontext: not listing the languages
2023-08-14 22629, 2023
mayhem
how much effort would it be to make popularity data based on MHLD and LB and combine them?
2023-08-14 22610, 2023
outsidecontext
yvanzo: ah, got it. misunderstood this.
2023-08-14 22618, 2023
outsidecontext
the en variations are a bit special, because IvanDobsky wanted to edit those parts that are actually different instead of copying all strings.
2023-08-14 22626, 2023
yvanzo
outsidecontext: just that some components are very independent that it can be worth fully translating some of these even the others are not.
2023-08-14 22601, 2023
yvanzo
outsidecontext: Weblate has some features for country specific locales.
