#metabrainz

Ahh, I forgot to mail in my meeting review. Now I have to give myself a black mark on the notes :(

[listenbrainz-android] 14akshaaatt merged pull request #220 (03dev…feed-section-phase-2.3): Feed section phase 2.3 Part 1 https://github.com/metabrainz/listenbrainz-andr...

akshaaatt: you said you checked off the designs for me, I saw a video of the feed and said it looks okay. But if there are a bunch of changes, I don’t know if I would call them ‘signed off’?

bitmap: when around - do you know why the recording editor drops the name, but the release editor does not? https://tickets.metabrainz.org/browse/MBS-13232 - the release editor also does not complain at first at least, for what it's worth, but I think the error is expected, just the name disappearing is not.

MBS-13232: Editor drops artist name when submitting single recording from Picard

I can easily reproduce this by just adding this to seed-love-bug.html

I'm just not sure where to go from there

Only the changes that you saw in the video are part of the feed for now. We are strictly only following your designs for it. Nothing else is signed off from you yet

aerozol^

Great thanks akshaaatt, just checking that I haven’t accidentally signed off some massive overhaul ;)

XD

The overheaul has fixed a lot more like adding the suggested settings screen, etc

But I think a couple more tweak will be required at places, which we can discuss once the feed is done

Tweaks*

Nice! It would be good to see the final for sign off

Awesome!

wtf is this about jasje not getting paid!? sounds like MeB is covering it at least?

aerozol: yeah they told me that they aren’t going to pay me because of some stupid reason they don’t even care to specify

🫠

aerozol: btw some changes in feed are just temporary. ive just gone the simple way till i have some other dependent components complete

the feed one’s exactly the same

jasje: np, we can look at it at the end

similar listens one requires some components rn

just did it so we can get beta out

its been very long since something new came out

btw I am much harsher on you re. designs because you are creating stuff that will go live directly. A lot of the other gsoc students we wouldn’t ask to do UI at all, or monkey would give it a once-over

But what I saw of the feed looked just like the mockup, so should be smooth sailing!

heh no problem its part of the package

im a little ill headed when it comes to designs so seems reasonable:P

jasje: It’s the classic situation of “you’re doing so well that our expectations are higher and now everything’s harder for you”. Congratulations :)

aerozol: I appreciate the nice comments ❤️ keeps me going ;)

don't worry tho, I like to finish stuff with quality as well otherwise it icks me alot

outsidecontext: eeek, how do you do drag and drop on picard to accidentally delte files?!

i deffo want to AVOID that so tell me :o

I think it was some sort of shift-dragging files in in Windows issue?

IIRC

eeeeek

delee to thrash or?

doesn't it warn?

how does that delete??

week

eh

eek

hi aerozol, which day of the week would work for you if any?

ApeKattQuest: you don't use Windows, right? then you are save

yvanzo: around? :)

yes

If so, does https://musicbrainz.org/relationship/34beaf28-c... seem like good wording for your STYLE-778 ?

STYLE-778: Add "ticketing" URL relationships for Artist, Label, Event, Place, and Series https://tickets.metabrainz.org/browse/STYLE-778

if you are using windows you can use Picard to delete files by holding shift while dragging the files into picard.

windows marks this as a "move" operation, picard approves this once it has loaded the file and in return windows thinks it's good to delete the file permanently

lucifer: I freed some disk space on wolf from ~musicbrainz; Can you please check if some GBs can be freed from your ~ and ~snaek?

yvanzo: sure will do

Pratha-Fish: almost sure, its fine but to confirm I am deleting /home/snaek/MLHD/warehouse and /home/snaek/MLHD_repo_test/warehouse from wolf.

lucifer: you're good to go :)

I'll go ahead and clean what I can from my profile on wolf, just in case

yvanzo: i freed up about 30G from wolf. there's 600 G on alastairp's home dir mostly from MLHD+ dumps.

lucifer: I saw that but it's mostly archives, isn't it?

yes

we have the dumps available on prod FTP now.

great

so its probably fine to remove

I don't know anything about it.

But there is also some disk space to reclaim from Docker.

lucifer: Do you have any stopped Docker container that should not be removed?

ok lets reclaim from docker for now and wait for alastairp or mayhem to confirm that its fine to delete the dumps.

yvanzo: nope

is ~snaek/musicbrainz-docker still in use?

Pratha-Fish: ^

yvanzo: not really

Let me nuke it if you want

Can do, no worry

Pratha-Fish: Did you stop the containers beforehand?

yvanzo: no 💀

I don't think I ran them in the first place

Ok, thank you :)

I didn't run them as I was worried it would interfere with the existing musicbrainz server

you're welcome :)

That’s correct, there is a project running under the same name, so it would likely have interfered.

To prevent that the repository has to be cloned under a different directory name.

that+,

I will keep that in mind for the next time!

reosarevok: LGTM, thanks. Are you adding the same for places and series?

Places, series, labels, and events

👍

Events might not be super long lasting, but archival links might contain a lot of data for the event so I think it's worth it

Yes, it is usually not long lasting, but there might some more useful custom pages (outside of the main ticket platforms).

lucifer: yvanzo : MHLD+ is done and released, we can probably nuke those dumps.

Thanks!

lucifer: I reclaimed 15GB from Docker.

aerozol: no change in ticket prices today. will keep monitoring.

lucifer: So it's probably worth nuking what you did find earlier. :)

yvanzo: I assume it's fine to then autoselect stuff like ticketmaster to this new rel, right? :)

reosarevok: yes, that's the idea

Perfect

Will do :)

yvanzo: done.

lucifer: Thanks, that freed ~30% disk :)

[listenbrainz-android] 14akshaaatt opened pull request #221 (03main…dev): Dev to Prod https://github.com/metabrainz/listenbrainz-andr...

yvanzo: flat out all week this week sorry! (and thanks)

thanks for keeping up with flight prices mayhem

np :)

[listenbrainz-server] 14MonkeyDo opened pull request #2547 (03master…fix-user-search): Fix user search when user not logged in https://github.com/metabrainz/listenbrainz-serv...

[listenbrainz-android] 1407jasjeet opened pull request #222 (03dev…feed-section-phase-2.3): MOBILE-140: Feed section phase 2.3 Part 2 https://github.com/metabrainz/listenbrainz-andr...

[listenbrainz-android] 14akshaaatt merged pull request #222 (03dev…feed-section-phase-2.3): MOBILE-140: Feed section phase 2.3 Part 2 https://github.com/metabrainz/listenbrainz-andr...

[listenbrainz-android] 14akshaaatt merged pull request #221 (03main…dev): Dev to Prod https://github.com/metabrainz/listenbrainz-andr...

yvanzo: I am confused, maybe you can help. I'm getting an issue where my ticketmaster test does not pass cleanup... but for some reason it passes validation and the url passed to validation, which I understand is the cleaned url, is the expected clean url

console.log(url) under validate: https://www.ticketmaster.com/artist/734907

Have you ever seen this? I might be doing something dumb, but

That's the actual handling code so far

(not sure if there's a better way to deal with optional slugs here than the (?:[\w-]+\/)? thing, suggestions happily accepted if so)

reosarevok: should be ticketmaster.com not .org

(in the clean function)

the regexp for slugs is fine

`([0-9]*)(?:[^0-9].*)` can be replaced with `([0-9]+).*`

... lol, thanks

But really not sure why it worked in validate

And yeah, fair - that was copied from a second one

We probably have a lot of improvable regexes

yes, validate uses the test data, not the output of the clean functoin

Ooooh

That makes sense

So it picks the expected given URL

it uses both the input url and the expected clean url

so you can still test validate if clean breaks

sorry, yes just the expected url

Thanks :)

Seems ticketmaster event pages do have pretty much no useful info even for classical music, so maybe these ones are worth not supporting

What do you think?

I don’t think that event ticketing pages from main platforms are worth it.

Even for classical, https://www.ticketmaster.com/seongjin-cho-engle...

It feels a bit harsh to entirely block them, but then, maybe it's not a bad idea

If they'd be too hard to maintain otherwise

Maybe there should be a disclaimer to the event-url ticketing rel: only add if it has some useful info.

Wonder if we should have a specific error message though

Yeah, or allow it with a guideline - if people read those :p

I’m not sure it should be blocked either.