Well, if we add autoselect it's either block (with a message that says the links have a short lifespan) or autoselect (with a guideline that says use only if useful) I guess
2023-08-15 22747, 2023
reosarevok
You think the latter might be better?
2023-08-15 22703, 2023
yvanzo
Yes
2023-08-15 22708, 2023
reosarevok
Ok, let's do that
2023-08-15 22730, 2023
reosarevok
It seems events use IDs such as 00005ED3057A881F so we need to be more specific with them then
2023-08-15 22742, 2023
reosarevok
Or less, rather :D
2023-08-15 22708, 2023
yvanzo
reosarevok: About things too obvious to be seen, do you have an idea of why the cover art image is not displayed for “Add cover art” edits with merged release with https://github.com/metabrainz/musicbrainz-server/… ?
2023-08-15 22723, 2023
reosarevok
Gimme a sec and I'll look
2023-08-15 22740, 2023
yvanzo
I checked the first example, the cover art image is still accessible from the CAA.
2023-08-15 22731, 2023
ApeKattQuest
outsidecontext: I use windows to tag files because mac is very very old and the only picard that works on it can't even access th new api so it can't pullreleases from mb, it's 1.4
2023-08-15 22730, 2023
ApeKattQuest
outsidecontext: right. will make sure never to use "shift" while pulling files to picard (or alt or ctrl either :D)
2023-08-15 22759, 2023
reosarevok
yvanzo: what do you think about sidebar or not for these btw? Any preferences?
2023-08-15 22725, 2023
outsidecontext
ApeKattQuest: 2.9.1 will be out soon and will fix this
2023-08-15 22719, 2023
ApeKattQuest
👍
2023-08-15 22733, 2023
yvanzo
reosarevok: I’m not really interested but I’m pretty sure that it will be soon requested if not added.
2023-08-15 22746, 2023
reosarevok
I guess
2023-08-15 22747, 2023
reosarevok
Ok
2023-08-15 22700, 2023
reosarevok
"Since these pages are often temporary and get removed after the event passes, only link to them if there is useful information provided that might prove useful later (for example when viewing an archived version of the page)."
2023-08-15 22706, 2023
reosarevok
Something like that for the event-url rel?
2023-08-15 22732, 2023
yvanzo
👍
2023-08-15 22751, 2023
reosarevok
Ok, updated that
2023-08-15 22756, 2023
yvanzo
Thanks!
2023-08-15 22702, 2023
reosarevok
Will commit the ticketmaster select, then look into your PR
2023-08-15 22720, 2023
reosarevok
yvanzo: Hmm. you're doing $self->c->model('Release')->get_by_gid($self->data->{entity}{mbid}) and setting the edit data mbid if so
2023-08-15 22740, 2023
reosarevok
But if that exists, but is a redirect, don't you want to set the destination MBID rather than the one stored in the edit?
2023-08-15 22742, 2023
reosarevok
(untested)
2023-08-15 22711, 2023
reosarevok
And the numeric id would be gone in that case?
2023-08-15 22720, 2023
yvanzo
line 114?
2023-08-15 22729, 2023
reosarevok
Of AddCoverArt yes
2023-08-15 22753, 2023
yvanzo
This `field_release` variable is not used to load the image.
2023-08-15 22727, 2023
reosarevok
Hmm
2023-08-15 22749, 2023
yvanzo
It is loaded from `artwork_release` instead.
2023-08-15 22715, 2023
reosarevok
EditArtwork displays the error we're getting if there's no release.gid and that comes from display.release though
2023-08-15 22730, 2023
reosarevok
Is the gid being passed null?
2023-08-15 22748, 2023
reosarevok
Wait, no
2023-08-15 22758, 2023
reosarevok
If there *is* a gid but there's an error
2023-08-15 22759, 2023
reosarevok
My bad
2023-08-15 22739, 2023
yvanzo
Thank you
2023-08-15 22757, 2023
yvanzo
I will check the git history of EditArtwork, that seems to be the cause of it.
2023-08-15 22719, 2023
yvanzo
*.js
2023-08-15 22701, 2023
yvanzo
It actually comes from the TT implementation which assumed a GID for removed releases.
But because we're intentionally skipping CAA to save calls...
2023-08-15 22740, 2023
reosarevok
I expect it's that, anyway?
2023-08-15 22724, 2023
yvanzo
yes
2023-08-15 22753, 2023
yvanzo
lucifer: reclaimed 100GB more from Docker on wolf :)
2023-08-15 22750, 2023
lucifer
awesome!
2023-08-15 22748, 2023
outsidecontext
zas: I already prepared the blog post for the Picard 2.9.1 release. If you have time, can you look over it (it's in Wordpress' post draft list)
2023-08-15 22739, 2023
outsidecontext
lucifer: has your visa trouble been resolved?
2023-08-15 22727, 2023
lucifer
outsidecontext: nope, consulted multiple people. all said nothing that can be done in time to attend this year's summit :/
2023-08-15 22706, 2023
outsidecontext
oh no, that's a bummer :( I had been looking forward to meet in person
2023-08-15 22716, 2023
outsidecontext
such a BS
2023-08-15 22729, 2023
lucifer
yup, same here.
2023-08-15 22736, 2023
Maxr1998_ has quit
2023-08-15 22744, 2023
lucifer
indeed :(
2023-08-15 22718, 2023
Maxr1998 joined the channel
2023-08-15 22756, 2023
rdswift
outsidecontext, I know you're planning on issuing Picard 2.9.1 tomorrow. Is it worth me trying to add the list of plugins requiring update and a button to open the Options -> Plugins page directly today?
2023-08-15 22732, 2023
rdswift
* add to the notification messagebox
2023-08-15 22704, 2023
outsidecontext
rdswift: I think the button in the notification can be definitely still added. not sure about the plugin list (not sure how well this works, especially if there should be a long list)
2023-08-15 22750, 2023
rdswift
Okay, I'll take a look this morning. As for the potential long list, I could limit the list to 5 plugins and if there are more then add "plus others" or something like that.
2023-08-15 22705, 2023
outsidecontext
good idea
2023-08-15 22748, 2023
rdswift
On it. Thanks.
2023-08-15 22719, 2023
lucifer
mayhem: about popularity dataset, i have tried to generate it twice on combined data but it fails. memory issues probably. another run currently underway takes 3hrs to know if it'll work.
2023-08-15 22739, 2023
mayhem
ok, if it fails, I can probably do the merge of the two datasets in PG or just straight off the FS.
2023-08-15 22740, 2023
mayhem
we will need to examine the j5 / resource question before too long. :(
2023-08-15 22710, 2023
lucifer
yeah makes sense. MLHD is a bit for the cluster to handle.
2023-08-15 22737, 2023
zas
outsidecontext: the blog post looks ok, I did few minor changes in phrasing, and made the part about recommended upgrade for win users more visible.
2023-08-15 22751, 2023
mayhem
ugh. now disk issues on kiss.
2023-08-15 22703, 2023
mayhem
lucifer: are you current projects possibly causing problems on kiss?
2023-08-15 22706, 2023
mayhem
disk wise?
2023-08-15 22745, 2023
lucifer
mayhem: no its the full dumps.
2023-08-15 22703, 2023
mayhem
ah, mid month.
2023-08-15 22713, 2023
lucifer
yup.
2023-08-15 22719, 2023
mayhem
I think we really should switch to zstd compression, that will help a little.