Well, if we add autoselect it's either block (with a message that says the links have a short lifespan) or autoselect (with a guideline that says use only if useful) I guess
You think the latter might be better?
yvanzo
Yes
reosarevok
Ok, let's do that
It seems events use IDs such as 00005ED3057A881F so we need to be more specific with them then
Or less, rather :D
yvanzo
reosarevok: About things too obvious to be seen, do you have an idea of why the cover art image is not displayed for “Add cover art” edits with merged release with https://github.com/metabrainz/musicbrainz-serve... ?
reosarevok
Gimme a sec and I'll look
yvanzo
I checked the first example, the cover art image is still accessible from the CAA.
ApeKattQuest
outsidecontext: I use windows to tag files because mac is very very old and the only picard that works on it can't even access th new api so it can't pullreleases from mb, it's 1.4
outsidecontext: right. will make sure never to use "shift" while pulling files to picard (or alt or ctrl either :D)
reosarevok
yvanzo: what do you think about sidebar or not for these btw? Any preferences?
outsidecontext
ApeKattQuest: 2.9.1 will be out soon and will fix this
ApeKattQuest
👍
yvanzo
reosarevok: I’m not really interested but I’m pretty sure that it will be soon requested if not added.
reosarevok
I guess
Ok
"Since these pages are often temporary and get removed after the event passes, only link to them if there is useful information provided that might prove useful later (for example when viewing an archived version of the page)."
Something like that for the event-url rel?
yvanzo
👍
reosarevok
Ok, updated that
yvanzo
Thanks!
reosarevok
Will commit the ticketmaster select, then look into your PR
yvanzo: Hmm. you're doing $self->c->model('Release')->get_by_gid($self->data->{entity}{mbid}) and setting the edit data mbid if so
But if that exists, but is a redirect, don't you want to set the destination MBID rather than the one stored in the edit?
(untested)
And the numeric id would be gone in that case?
yvanzo
line 114?
reosarevok
Of AddCoverArt yes
yvanzo
This `field_release` variable is not used to load the image.
reosarevok
Hmm
yvanzo
It is loaded from `artwork_release` instead.
reosarevok
EditArtwork displays the error we're getting if there's no release.gid and that comes from display.release though
Is the gid being passed null?
Wait, no
If there *is* a gid but there's an error
My bad
yvanzo
Thank you
I will check the git history of EditArtwork, that seems to be the cause of it.
*.js
It actually comes from the TT implementation which assumed a GID for removed releases.
But because we're intentionally skipping CAA to save calls...
I expect it's that, anyway?
yvanzo
yes
lucifer: reclaimed 100GB more from Docker on wolf :)
lucifer
awesome!
outsidecontext
zas: I already prepared the blog post for the Picard 2.9.1 release. If you have time, can you look over it (it's in Wordpress' post draft list)
lucifer: has your visa trouble been resolved?
lucifer
outsidecontext: nope, consulted multiple people. all said nothing that can be done in time to attend this year's summit :/
outsidecontext
oh no, that's a bummer :( I had been looking forward to meet in person
such a BS
lucifer
yup, same here.
Maxr1998_ has quit
indeed :(
Maxr1998 joined the channel
rdswift
outsidecontext, I know you're planning on issuing Picard 2.9.1 tomorrow. Is it worth me trying to add the list of plugins requiring update and a button to open the Options -> Plugins page directly today?
* add to the notification messagebox
outsidecontext
rdswift: I think the button in the notification can be definitely still added. not sure about the plugin list (not sure how well this works, especially if there should be a long list)
rdswift
Okay, I'll take a look this morning. As for the potential long list, I could limit the list to 5 plugins and if there are more then add "plus others" or something like that.
outsidecontext
good idea
rdswift
On it. Thanks.
lucifer
mayhem: about popularity dataset, i have tried to generate it twice on combined data but it fails. memory issues probably. another run currently underway takes 3hrs to know if it'll work.
mayhem
ok, if it fails, I can probably do the merge of the two datasets in PG or just straight off the FS.
we will need to examine the j5 / resource question before too long. :(
lucifer
yeah makes sense. MLHD is a bit for the cluster to handle.
zas
outsidecontext: the blog post looks ok, I did few minor changes in phrasing, and made the part about recommended upgrade for win users more visible.
mayhem
ugh. now disk issues on kiss.
lucifer: are you current projects possibly causing problems on kiss?
disk wise?
lucifer
mayhem: no its the full dumps.
mayhem
ah, mid month.
lucifer
yup.
mayhem
I think we really should switch to zstd compression, that will help a little.