aerozol: re https://docs.google.com/document/d/1aPeAM0wQyPWuz… you write about adding more columns but honestly i couldn't get it to work well. the pages are already way too narrow (why does an electronic document have wide margins anyway?) and i can't change it or anything
2023-10-16 28924, 2023
MonkeyPython
aerozol: there are quite a lot of "aerozol to create tickets" in https://docs.google.com/document/d/1bz32duq95jSfi… so I assume this is not for me to do (but if you want I can create those tickets and link them in the doc for you to edit. would they be MBS or DESIGN?)
(I always find it near impossible to figure out the common-chunks errors)
2023-10-16 28931, 2023
reosarevok
We get a surprisingly high amount of "The “X” relationship between “Foo” and “Bar” already exists." errors
2023-10-16 28951, 2023
reosarevok
Does that show even if the relationship editor itself detects and blocks the rels?
2023-10-16 28959, 2023
reosarevok
Or are these dupes getting through to perl somehow?
2023-10-16 28924, 2023
kellnerd
I've seen this kind of error in the relationship editor.
2023-10-16 28923, 2023
kellnerd
It probably should not be logged in sentry as it is a recoverable user error.
2023-10-16 28956, 2023
kellnerd
Oh, wait no, it shows "This relationship already exists.", sorry :)
2023-10-16 28910, 2023
outsidecontext
yvanzo, reosarevok: weblate 5.1 is out and allows customization of the translation workflow per language. That means we have the ability to e.g. introduce a translate -> review worklfow for languages where there is a large enough translator team (and interest to work this way)
2023-10-16 28938, 2023
outsidecontext
it's not yet on our instance, but will be updated in the next days usually.
2023-10-16 28925, 2023
bitmap
reosarevok: I think it's legit, I'll check once I'm awke and caffeinated
2023-10-16 28920, 2023
tux0r has quit
2023-10-16 28940, 2023
yellowhatpro_ has quit
2023-10-16 28948, 2023
reosarevok
outsidecontext: sounds good :) For now I think most of our "teams" are currently one-person affairs, but it would be nice to expand that...
2023-10-16 28934, 2023
outsidecontext
reosarevok: yes, that's also why I argued for this not being needed. actually I think we probably first need to build up something like "teams", that also use e.g. the forums to coordinate.
2023-10-16 28903, 2023
outsidecontext
But if there are 1-3 users that actively translate a language and that then also act as reviewers I think this would work well.
reosarevok: where do you see the high number of relationship-already-exists errors? I only see one with two users and another with one user
2023-10-16 28927, 2023
bitmap
but I believe it's possible to trigger this if the relationship gets added in another tab/session, whether by the same user or a different one
2023-10-16 28917, 2023
bitmap
I'm not actually sure how to reproduce the first release-editor one, but the "loop" bindingHandler is known to be buggy
2023-10-16 28934, 2023
bitmap
the url one is kinda expected due to the way the function is written...there's a race condition where a concurrent transaction can use the url before the DELETE obtains a lock
2023-10-16 28938, 2023
bitmap
this is tricky to fix but I'll open a ticket
2023-10-16 28950, 2023
bitmap
basically delete_unused_urls needs to use `SELECT ... FOR UPDATE`, and whichever transaction is inserting the conflicting row should use `SELECT ... FOR SHARE` ... I think
2023-10-16 28925, 2023
reosarevok
bitmap: I see a few every time I check sentry, so I guess it's a few a week?
2023-10-16 28941, 2023
bitmap
ah probably my search query isn't finding them
2023-10-16 28924, 2023
reosarevok
Maybe I'm remembering it wrong, also possible :D
2023-10-16 28930, 2023
mayhem
reosarevok: due to flight delay i can make the meeting. My summary: summit.
2023-10-16 28945, 2023
reosarevok
Ok
2023-10-16 28957, 2023
mayhem
All the things I can share, lucifer also knows about, so I'm sure he'll share
2023-10-16 28900, 2023
reosarevok
"mayhem says: just the right amount of chocolate"
2023-10-16 28925, 2023
mayhem
I'm hoping to work half days this week, that is it for me.
reosarevok: yvanzo: given that the RemoveEmpty script works on URLs I'm not sure we really need delete_unused_url and associated triggers?
2023-10-16 28956, 2023
reosarevok
Possibly not? The main benefit I guess is that they are gone immediately rather than after a day, but
2023-10-16 28908, 2023
reosarevok
That's mostly just relevant to spam I guess
2023-10-16 28934, 2023
bitmap
that's the only benefit I can see, but doesn't seem worth maintaining much to me
2023-10-16 28938, 2023
reosarevok
I would not be too bothered if we dropped it, yes
2023-10-16 28950, 2023
bitmap
I mean, the RemoveEmpty script probably has a race condition too, but it's fine if that crashes; if delete_unused_url crashes it brings the whole transaction with it (probably applying some innocuous edit)
2023-10-16 28953, 2023
reosarevok
Does the RemoveEmpty script restart if crashed?
2023-10-16 28950, 2023
bitmap
no but we could at least add some exception handling
2023-10-16 28913, 2023
yvanzo
the question was: wouldn't [this added relationship attribute] be redundant with the work’s language [attribute]?
2023-10-16 28911, 2023
reosarevok
And I'm confused how that could be redundant given it's not connected to works in anyway :)
2023-10-16 28915, 2023
reosarevok
*any way
2023-10-16 28958, 2023
yvanzo
To follow the example provided in the ticket, one can add a work and set the language to English.
2023-10-16 28951, 2023
reosarevok
But the relationship is artist-artist, voice actor to character
2023-10-16 28954, 2023
yvanzo
Maybe more examples are needed to explain how it can be needed.
2023-10-16 28903, 2023
reosarevok
Well, all the Disney films for example will have different actors voicing the (singing) characters in Spanish and in English :)
2023-10-16 28915, 2023
yvanzo
Ok, IIUC, it’s the whole relationship “voice of” that would be redundant with artist-recording relationships (I expected but doesn’t seem to exist) on a period of time.
2023-10-16 28918, 2023
yvanzo
(There is no relationship to say that an artist A interpreted a character C on a recording R.)
2023-10-16 28932, 2023
MonkeyPython
uhm
2023-10-16 28934, 2023
reosarevok
Yeah, we cannot have that right now because that would be a 3-point relationship :)
2023-10-16 28943, 2023
MonkeyPython
bang?
2023-10-16 28945, 2023
reosarevok
We can only say artist A sang or whatever
2023-10-16 28951, 2023
reosarevok
MonkeyPython: in one min, from my clock!
2023-10-16 28958, 2023
reosarevok
:)
2023-10-16 28901, 2023
MonkeyPython
oh, it's 19:03 here
2023-10-16 28904, 2023
reosarevok
<BANG>
2023-10-16 28905, 2023
yvanzo
<BANG BANG>
2023-10-16 28922, 2023
MonkeyPython
my baby shot me down
2023-10-16 28927, 2023
reosarevok
<https://www.youtube.com/watch?v=2ips2mM7Zqw>
2023-10-16 28948, 2023
reosarevok
Welcome to the first post-summit MeB meeting!
2023-10-16 28918, 2023
reosarevok
Hope you're ready for more of the good old talking to your screen rather than to physical people
2023-10-16 28932, 2023
reosarevok
I have two written reviews:
2023-10-16 28958, 2023
reosarevok
mayhem didn't send anything specific, but basically said "GSoC summit" and "we ate all the chocolate"
2023-10-16 28902, 2023
reosarevok
Living the life
2023-10-16 28909, 2023
reosarevok
And aerozol said:
2023-10-16 28909, 2023
MonkeyPython
lol
2023-10-16 28911, 2023
reosarevok
'''
2023-10-16 28924, 2023
reosarevok
I had something big on earlier this month… hmm what was it… nope, can’t remember.
2023-10-16 28928, 2023
reosarevok
Anyway, since the last meeting I:
2023-10-16 28933, 2023
reosarevok
Made some tiny PRs - a small step for devs, a giant leap for aerozol-kind - to add new players to the ListenBrainz-enabled apps list, which is looking nice and healthy now (https://listenbrainz.org/add-data/)
2023-10-16 28939, 2023
reosarevok
Did some work on a nice MeB OBS/streaming overlay that would probably not work and we would end up having to use zoom instead (huh, that’s a weird thing to imagine)
2023-10-16 28944, 2023
reosarevok
Spent a ton of time on a plane (hmm, why was I on a plane??) sanitizing and trying to make sense of 2017 survey data
2023-10-16 28948, 2023
reosarevok
Some interesting mockups and discussion on MBS-13292 + MBS-11748 (to be continued)
Spent a whole weekend writing notes and drafting an enormous blog post on something big that happened early this month… strange… nope still not ringing any bells
