Sounds good, not that I remember what the issue with it was
2023-11-20 32421, 2023
bitmap
right now it removes it from the table if there are pending edits...instead of doing + edits_pending it should check them separately & just skip temporarily if there are edits_pending
2023-11-20 32418, 2023
bitmap
I'm not sure we can address point 2 easily, but 1 is better than nothing
2023-11-20 32437, 2023
reosarevok
Ok
2023-11-20 32415, 2023
fletchto99 joined the channel
2023-11-20 32401, 2023
bitmap
the only other idea I had for point 2 is to count the edits themselves as references, so increment the ref_counts when the edits are opened and decrement them when they are closed. but I think that would be a lot of work
[bookbrainz-utils] 14dependabot[bot] opened pull request #43 (03master…dependabot/npm_and_yarn/importer/babel/traverse-7.23.4): chore(deps-dev): bump @babel/traverse from 7.22.4 to 7.23.4 in /importer https://github.com/metabrainz/bookbrainz-utils/pu…
[bookbrainz-utils] 14dependabot[bot] opened pull request #44 (03master…dependabot/npm_and_yarn/cleaner/xml2js-and-typeorm--removed): chore(deps): bump xml2js and typeorm in /cleaner https://github.com/metabrainz/bookbrainz-utils/pu…
2023-11-20 32425, 2023
BrainzGit
[bookbrainz-utils] 14dependabot[bot] opened pull request #45 (03master…dependabot/npm_and_yarn/cleaner/minimist-and-mkdirp-1.2.8): chore(deps): bump minimist and mkdirp in /cleaner https://github.com/metabrainz/bookbrainz-utils/pu…
2023-11-20 32426, 2023
BrainzGit
[bookbrainz-utils] 14dependabot[bot] closed pull request #30 (03master…dependabot/npm_and_yarn/cleaner/typeorm-0.2.25): chore(deps): bump typeorm from 0.2.7 to 0.2.25 in /cleaner https://github.com/metabrainz/bookbrainz-utils/pu…
reosarevok: sorry for the late report, just mailed it in.
2023-11-20 32423, 2023
mayhem waves and disappers
2023-11-20 32439, 2023
reosarevok
np
2023-11-20 32404, 2023
Sophist-UK joined the channel
2023-11-20 32408, 2023
MonkeyPython
lbbbb? is that like mbssssssss?
2023-11-20 32421, 2023
prout has quit
2023-11-20 32445, 2023
prout joined the channel
2023-11-20 32414, 2023
reosarevok
<BANG>
2023-11-20 32417, 2023
reosarevok
It's time for our Monday meeting, aerozol's favourite part of Tuesday!
2023-11-20 32424, 2023
aerozol
yayyyyyzzzzzz
2023-11-20 32425, 2023
MonkeyPython
:DDD
2023-11-20 32438, 2023
reosarevok
I have two mailed-in reviews today
2023-11-20 32440, 2023
reosarevok
mayhem says:
2023-11-20 32441, 2023
reosarevok
'''
2023-11-20 32456, 2023
reosarevok
Hi!
2023-11-20 32405, 2023
reosarevok
Last week was all about the summit. Prepare for the summit, travel to the summit and hold the summit.
2023-11-20 32415, 2023
reosarevok
I haven't had a chance to summarize the event, because India. Hopefully, lucifer and the others can actually do a better job. But it was a great summit with great people.
- handled a network issue with flobot (it was inspected, nothing found, but the issue disappeared, perhaps due to reboot), another issue just appeared on this node (an hard drive to replace, it will be handled tomorrow).
2023-11-20 32436, 2023
reosarevok
- plus usual PR reviews, user support, upgrades (discourse was upgraded), MB edits
2023-11-20 32438, 2023
reosarevok
'''
2023-11-20 32415, 2023
reosarevok
MonkeyPython: what about your week :)
2023-11-20 32421, 2023
MonkeyPython
Arararara~! hi!
2023-11-20 32424, 2023
reosarevok
Other people in my list: reosarevok, bitmap, yvanzo, monkey, lucifer, akshaaatt, atj, aerozol, ansh, kellnerd, Pratha-Fish, jasje
Last week I did some maintenance, one day moving MB Redis, another day preparing the move of MeB.o and its dependencies.
2023-11-20 32435, 2023
yvanzo
Also I drafted a patch to drop hundreds of MB admin-only messages from translation.
2023-11-20 32443, 2023
yvanzo
Last I reviewed a fair amount of pull requests, plus some tickets and support.
2023-11-20 32455, 2023
yvanzo
Fin, how did you deal with moving MeB.o bitmap?
2023-11-20 32406, 2023
bitmap
hey
2023-11-20 32456, 2023
bitmap
last week I was looking into some MB fullexport failures and found out it was due to lack of disk space on trille, so I helped move services to hendrix (thanks atj, yvanzo, zas), as yvanzo mentioned, which went fine
2023-11-20 32428, 2023
bitmap
after that I was looking into some warnings/errors in our hourly/daily cron logs, and fixed a few issues - MBS-13300, MBS-13372, MBS-13310
other than that I think I was mostly working on some misc. React stuff for the add-cover-art page and artist credit editor, and doing code review
2023-11-20 32425, 2023
bitmap
fin. go monkey
2023-11-20 32431, 2023
monkey
Hello everyone !
2023-11-20 32448, 2023
reosarevok
People left in my list: reosarevok, lucifer, akshaaatt, atj, aerozol, ansh, kellnerd, Pratha-Fish, jasje
2023-11-20 32455, 2023
monkey
Last week I continued rewriting the LB test suite to react-testing-library. I do like RTL's philosophy of "don't test internal implementation", but I have to say it's a huge pain in the ass once I got to testing how some LB pages react to websockets messages. Faking a socket.io websocket server and also a client is a big headache. Finally made some breakthrough just 30 minutes ago.
2023-11-20 32412, 2023
monkey
I also did a bit of CSS magic for the fresh releases page helping ansh out, and continued work on the entity pages a bit
2023-11-20 32440, 2023
monkey
I also looked into some smaller LB API tickets and improvements, and reviewed aerozol's designs for YIM
2023-11-20 32450, 2023
monkey
Aaaaaand some PR reviews.
2023-11-20 32402, 2023
monkey
That's it for me. ansh are you ready?
2023-11-20 32406, 2023
monkey
To
2023-11-20 32412, 2023
monkey
Rrrrrrrumbleeee ?
2023-11-20 32412, 2023
ansh
Hi Everyone!
2023-11-20 32435, 2023
ansh
Last week, I attended the Delhi Summit and had a blast meeting with everyone. Had some great conversations regarding couple of features.
2023-11-20 32446, 2023
ansh
Other than that I continued working on adding play queues to BrainzPlayer.
2023-11-20 32403, 2023
ansh
Did some UI fixes to fresh releases and reviewed a PR.
2023-11-20 32414, 2023
ansh
lucifer next?
2023-11-20 32452, 2023
ansh
or
2023-11-20 32456, 2023
ansh
reosarevok next?
2023-11-20 32402, 2023
reosarevok
Hi!
2023-11-20 32422, 2023
Pratha-Fish appreciates the play queues in brainzplayer
2023-11-20 32412, 2023
reosarevok
Last week I did a bunch of code review, fixed a few minor bugs (including MBS-13368) and merged quite a few PRs
Also fixed a few tests that had broken in the PR lowercasing stuff (turns out Selenium tests looking for specific text don't like it when the test changes, who would have thought)
