0:02 AM
petitminion joined the channel
2023-11-28 33231, 2023
0:02 AM
opal has quit
2023-11-28 33201, 2023
0:13 AM
opal joined the channel
2023-11-28 33231, 2023
1:29 AM
petitminion has quit
2023-11-28 33204, 2023
1:55 AM
lusciouslover has quit
2023-11-28 33201, 2023
2:11 AM
lusciouslover joined the channel
2023-11-28 33207, 2023
2:18 AM
lusciouslover has quit
2023-11-28 33249, 2023
5:35 AM
BrainzGit
2023-11-28 33247, 2023
5:44 AM
BrainzGit
2023-11-28 33257, 2023
5:44 AM
BrainzGit
2023-11-28 33218, 2023
5:45 AM
BrainzGit
2023-11-28 33237, 2023
5:59 AM
yvanzo
!m lucifer
2023-11-28 33237, 2023
5:59 AM
BrainzBot
You're doing good work, lucifer!
2023-11-28 33258, 2023
6:12 AM
BrainzGit
2023-11-28 33235, 2023
6:14 AM
BrainzGit
2023-11-28 33207, 2023
6:44 AM
BrainzGit
2023-11-28 33205, 2023
6:47 AM
yvanzo
2023-11-28 33218, 2023
6:47 AM
lucifer
yvanzo: thanks! taking a look
2023-11-28 33232, 2023
8:26 AM
Lotheric_ joined the channel
2023-11-28 33204, 2023
8:27 AM
Lotheric has quit
2023-11-28 33243, 2023
8:43 AM
mayhem
jasje: akshaaatt : how/when can I test the new LB app with the improved workflow??
2023-11-28 33227, 2023
8:44 AM
aerozol
I want to put up my #listenbrainzmonday but I get an error when I try to load time range ‘this week’ + template ‘designer top 10’ :(
2023-11-28 33239, 2023
8:44 AM
aerozol
“There was an error trying to load statistics for this user and time range: TypeError: Failed to fetch Please check the username or try another time range.”
2023-11-28 33216, 2023
8:45 AM
aerozol
Works fine when I enter another username
2023-11-28 33233, 2023
8:45 AM
mayhem
yea, works fine for me. lucifer? ^^
2023-11-28 33203, 2023
8:46 AM
aerozol
Does mine work if you put in ‘aerozol’ Rob?
2023-11-28 33246, 2023
8:46 AM
aerozol
2023-11-28 33234, 2023
8:47 AM
aerozol
That’s weird but I guess it’s possible :D
2023-11-28 33242, 2023
8:47 AM
aerozol
Maybe I was in a coma
2023-11-28 33249, 2023
8:48 AM
mayhem
2023-11-28 33202, 2023
8:49 AM
mayhem
seems to
2023-11-28 33206, 2023
8:49 AM
mayhem
so
2023-11-28 33220, 2023
8:49 AM
aerozol
The only broken one is template ‘designer top 10’
2023-11-28 33230, 2023
8:49 AM
aerozol
(I assume because I don’t have 10 albums)
2023-11-28 33202, 2023
8:53 AM
mayhem
inded, that borks.
2023-11-28 33209, 2023
8:53 AM
ApeKattQuest
how do you.. only listen to 10 albums.. in one whole week ??? :o
2023-11-28 33238, 2023
8:53 AM
ApeKattQuest
wait how does mine look
2023-11-28 33241, 2023
8:53 AM
mayhem
2023-11-28 33253, 2023
8:53 AM
mayhem
mostly for me, but this is the exception.
2023-11-28 33205, 2023
8:54 AM
aerozol
ApeKattQuest: Exactly!! How do you log a bug report for a human behavioural bug
2023-11-28 33221, 2023
9:38 AM
lucifer
mayhem: will fix
2023-11-28 33214, 2023
9:52 AM
lusciouslover joined the channel
2023-11-28 33207, 2023
9:57 AM
lusciouslover has quit
2023-11-28 33203, 2023
9:59 AM
jasje
mayhem: should be on your device by the end of the week
2023-11-28 33216, 2023
9:59 AM
jasje
we just have to update the beta app
2023-11-28 33225, 2023
9:59 AM
mayhem
👍
2023-11-28 33238, 2023
9:59 AM
jasje
akshaaatt: is busy rn
2023-11-28 33201, 2023
10:21 AM
monkey
mayhem: regarding the stats art error above: I had started PR LB#2595 if you think it it is relevant to add the fix to it
2023-11-28 33202, 2023
10:21 AM
BrainzBot
2023-11-28 33254, 2023
10:31 AM
mayhem
sounds like lucifer is on that. lucifer ^^
2023-11-28 33217, 2023
10:34 AM
lucifer
monkey: sure, i'll add the fix there
2023-11-28 33226, 2023
10:34 AM
monkey
Thanks !
2023-11-28 33201, 2023
10:53 AM
lucifer
mayhem: release-colors cronjob for huesound has been broken for like ~4 months now. there was a simple bug in the program name to convert image to color, i fixed and ran the job, it worked fine but it refuses to terminate. probably an issue with concurrency, i am planning to rewrite it with a threadpoolexecutor.
2023-11-28 33218, 2023
10:54 AM
mayhem
I figured -- its taking some time to catch up -- I'm running it right now
2023-11-28 33235, 2023
10:54 AM
lucifer
its all caught up.
2023-11-28 33203, 2023
10:55 AM
lucifer
i synced it all last night but the watermark timestamps are all messed up so its executing 4 months of work everytime you launch it
2023-11-28 33211, 2023
10:55 AM
mayhem
my script is still running and seems to be fetching things as we speak.
2023-11-28 33219, 2023
10:55 AM
mayhem
ah. ok. let me stop it.
2023-11-28 33235, 2023
10:55 AM
mayhem
then I can start downloading the images to my local machine.
2023-11-28 33248, 2023
10:55 AM
lucifer
makes sense, i'll rewrite the script meanwhile.
2023-11-28 33211, 2023
10:56 AM
mayhem
k
2023-11-28 33217, 2023
11:45 AM
petitminion joined the channel
2023-11-28 33221, 2023
12:08 PM
reosarevok
2023-11-28 33236, 2023
12:09 PM
yvanzo
Hi reosarevok, I didn’t complete/submit my review yet but found it's conflicting with the other PR for admin messages.
2023-11-28 33231, 2023
12:10 PM
reosarevok
Well, that much is obvious, that's specifically why I asked for it to be reviewed and merged before that one
2023-11-28 33242, 2023
12:10 PM
yvanzo
The template should be either moved to non-admin path or split under admin/non-admin paths.
2023-11-28 33257, 2023
12:10 PM
reosarevok
It is all being moved to non-admin paths
2023-11-28 33238, 2023
12:11 PM
reosarevok
IIRC from /admin/attributes to just /attributes
2023-11-28 33246, 2023
12:11 PM
yvanzo
I mean the path in the repository, not in the URL.
2023-11-28 33212, 2023
12:12 PM
reosarevok
Yes, so do I :) Maybe I forgot to move some files? IIRC the templates all move, but I might have missed some
2023-11-28 33214, 2023
12:12 PM
yvanzo
Anything under /root/admin/ should be admin-only.
2023-11-28 33241, 2023
12:12 PM
reosarevok
2023-11-28 33242, 2023
12:12 PM
yvanzo
Ok, cool!
2023-11-28 33207, 2023
12:13 PM
reosarevok
But if you do find some stuff I might have missed on review do let me know and I'll fix that! :)
2023-11-28 33235, 2023
12:14 PM
yvanzo
Ok thanks for having double-confirmed it :)
2023-11-28 33255, 2023
12:14 PM
reosarevok
No worries :)
2023-11-28 33230, 2023
12:15 PM
reosarevok
I think the right order for these would be merge the attributes one, you rebase/amend the admin one, we merge that, I rebase/amend the lowercasing one, we merge that
2023-11-28 33236, 2023
12:15 PM
reosarevok
If that seems ok to you?
2023-11-28 33238, 2023
12:15 PM
yvanzo
O agree
2023-11-28 33243, 2023
12:15 PM
reosarevok
No huge rush, tomorrow would be fine too tbh
2023-11-28 33201, 2023
12:16 PM
reosarevok
As long as we have at least a week and a bit for translators to reconfirm rows, it seems ok
2023-11-28 33210, 2023
12:17 PM
yvanzo
Can do today
2023-11-28 33250, 2023
13:06 PM
fletchto99_ joined the channel
2023-11-28 33247, 2023
13:07 PM
fletchto99 has quit
2023-11-28 33247, 2023
13:07 PM
fletchto99_ is now known as fletchto99
2023-11-28 33216, 2023
13:59 PM
Pratha-Fish
2023-11-28 33255, 2023
13:59 PM
Sophist-UK joined the channel
2023-11-28 33215, 2023
14:23 PM
mayhem
lucifer: I'm working on a PR to have test.sh set a env var to indicate tests are running. so far so good, but when trying to grant table perms, this happens when connected as the postgres user:
2023-11-28 33217, 2023
14:23 PM
mayhem
2023-11-28 33252, 2023
14:23 PM
mayhem
actually, never mind. grant != permissions.
2023-11-28 33207, 2023
14:24 PM
lucifer
👍
2023-11-28 33225, 2023
14:24 PM
mayhem
yet... "sqlalchemy.exc.ProgrammingError: (psycopg2.errors.InsufficientPrivilege) permission denied for sequence release_color_id_se"
2023-11-28 33245, 2023
14:25 PM
mayhem
I guess the test user is using the wrong pg user then.
2023-11-28 33234, 2023
14:33 PM
petitminion has quit
2023-11-28 33221, 2023
14:36 PM
lucifer
mayhem: you are only granting privileges on tables, you need to grant privileges on sequences separately
2023-11-28 33220, 2023
14:37 PM
mayhem
is it possible to GRANT everyone in one go?
2023-11-28 33211, 2023
14:38 PM
lucifer
afaik not without making that user a superuser
2023-11-28 33222, 2023
14:38 PM
lucifer
2023-11-28 33250, 2023
14:38 PM
lucifer
but in general
2023-11-28 33253, 2023
14:38 PM
mayhem
hmm, I don't quite understand how things used to work before I mucked with them. :(
2023-11-28 33235, 2023
14:40 PM
lucifer
what do you want to do?
2023-11-28 33219, 2023
14:41 PM
mayhem
I set the PYTHON_TESTS_RUNNING in docker-compose.test.yml and then in init-db I want to check for that being set. if so, set up test db.
2023-11-28 33241, 2023
14:43 PM
lucifer
i see, there are a couple of complex interactions to it. i can fix it later today.
2023-11-28 33254, 2023
14:43 PM
mayhem
yes, I've found them.
2023-11-28 33206, 2023
14:44 PM
mayhem
but I think I see what needs doing now, I'll continue for a bit.
2023-11-28 33218, 2023
14:44 PM
lucifer
okay cool
2023-11-28 33244, 2023
14:59 PM
reosarevok
yvanzo, bitmap: any idea what might cause MBS-13389 ? (to ISE rather than be caught earlier)
2023-11-28 33245, 2023
14:59 PM
BrainzBot
2023-11-28 33241, 2023
15:00 PM
yvanzo
no, that’s a second bug
2023-11-28 33208, 2023
15:01 PM
yvanzo
but that’s also proving database constraints to be useful :)
2023-11-28 33227, 2023
15:02 PM
yvanzo
it would be helpful to know if it could be a case of double submission.
2023-11-28 33248, 2023
15:02 PM
yvanzo
(like clicking more than once on the submit button)
2023-11-28 33252, 2023
15:05 PM
petitminion joined the channel
2023-11-28 33245, 2023
15:07 PM
bitmap
it shouldn't be possible (in theory...) unless the needs-disambiguation check failed
2023-11-28 33227, 2023
15:08 PM
bitmap
since we actually lock the table before we check for duplicates
2023-11-28 33204, 2023
15:12 PM
reosarevok
I think I've seen stuff like this in sentry before
2023-11-28 33237, 2023
15:12 PM
bitmap
see Edit::Role::CheckDuplicates
2023-11-28 33245, 2023
15:14 PM
bitmap
I guess either is_disambiguation_needed failed, or the $duplicate_violation query
2023-11-28 33229, 2023
15:47 PM
mayhem
2023-11-28 33251, 2023
15:47 PM
mayhem
lucifer: when I do a ./develop.sh build I get the following error. have you seen this before?
2023-11-28 33201, 2023
15:51 PM
lucifer
mayhem: nope seeing for the first time
2023-11-28 33214, 2023
15:51 PM
lucifer
afk at the moment but can take a look in a few hours
2023-11-28 33256, 2023
15:53 PM
q3lont joined the channel
2023-11-28 33248, 2023
15:54 PM
mayhem digs
2023-11-28 33250, 2023
15:57 PM
reosarevok
bitmap: the fix for MBS-13391 is basically "convert it to React", right?
2023-11-28 33251, 2023
15:57 PM
BrainzBot
2023-11-28 33241, 2023
15:59 PM
bitmap
not necessarily, but it would probably help
2023-11-28 33224, 2023
16:00 PM
reosarevok
I mean, I'm sure it can be fixed beforehand
2023-11-28 33214, 2023
16:01 PM
reosarevok
What was the plan for converting the editors? First release, then all others will be trivial? Or can we get the smaller ones done sooner?
2023-11-28 33232, 2023
16:01 PM
reosarevok
Oh, btw
2023-11-28 33242, 2023
16:01 PM
reosarevok
MBS-13390 does seem new? I also hit it today
2023-11-28 33243, 2023
16:01 PM
BrainzBot
2023-11-28 33251, 2023
16:01 PM
reosarevok
Did we change anything in test?
2023-11-28 33211, 2023
16:03 PM
lusciouslover joined the channel
2023-11-28 33215, 2023
16:03 PM
bitmap
hmm, not that I can remember
2023-11-28 33238, 2023
16:03 PM
bitmap
re: converting the editors I'm about to submit a PR to refactor the artist credit editor
2023-11-28 33205, 2023
16:08 PM
lusciouslover has quit
2023-11-28 33254, 2023
16:09 PM
reosarevok
yvanzo: can you think what might have changed in test?
2023-11-28 33238, 2023
16:21 PM
yvanzo
I don’t know, maybe it’s just running an old branch?
2023-11-28 33232, 2023
16:22 PM
yvanzo
Yup, it is still running the Node 20 upgrade, at best.
2023-11-28 33246, 2023
16:23 PM
yvanzo
reosarevok: I pushed master to test and launched a new build.
2023-11-28 33207, 2023
16:26 PM
BrainzGit
2023-11-28 33235, 2023
16:28 PM
BrainzGit
2023-11-28 33207, 2023
16:30 PM
reosarevok
yvanzo: whoops, we missed the favicon_class for metalmusicarchives :) ^ that adds it too
2023-11-28 33234, 2023
16:30 PM
yvanzo
👍
2023-11-28 33224, 2023
16:34 PM
reosarevok
yvanzo: also, any thoughts on when a style IMPLEMENTATION REQUESTED ticket should be closed?
2023-11-28 33236, 2023
16:34 PM
reosarevok
Once the implementation is sent for review? merged? released?
2023-11-28 33242, 2023
16:34 PM
reosarevok
I cannot decide
2023-11-28 33259, 2023
16:34 PM
reosarevok
Released seems the most precise but also by far the easiest to forget
2023-11-28 33227, 2023
16:35 PM
yvanzo
I would close only when it is delivered.
