#metabrainz

/

      • yvanzo
        That's can be added to our checklist for releasing.
      • 2023-11-28 33206, 2023

      • yvanzo
        -'s
      • 2023-11-28 33241, 2023

      • BrainzGit
        [musicbrainz-server] 14mwiencek opened pull request #3113 (03master…artist-credit-editor-refactor): ArtistCreditEditor refactor (including MBS-12715) https://github.com/metabrainz/musicbrainz-server/…
      • 2023-11-28 33206, 2023

      • reosarevok
        "+1,916 −1,595" ouch :D
      • 2023-11-28 33223, 2023

      • reosarevok
        Ok, a fair chunk is the mutate one
      • 2023-11-28 33210, 2023

      • bitmap
        if you only count the last commit and ignore whitespace, 1165 insertions(+), 694 deletions(-) :)
      • 2023-11-28 33236, 2023

      • bitmap
        it's expected to be more code since it adds Flow types
      • 2023-11-28 33248, 2023

      • reosarevok
        Sure. I'll take a first look in a bit
      • 2023-11-28 33258, 2023

      • monkey
        mayhem: Any idea what this issue is about? (running LB on wolf, can't log in):
      • 2023-11-28 33202, 2023

      • monkey
      • 2023-11-28 33248, 2023

      • mayhem
        one sec
      • 2023-11-28 33244, 2023

      • monkey
        (For reference, I tried re-creating my databases, but no luck)
      • 2023-11-28 33208, 2023

      • mayhem
        what is MUSICBRAINZ_OAUTH_URL set to in config.py?
      • 2023-11-28 33218, 2023

      • petitminion has quit
      • 2023-11-28 33249, 2023

      • outsidecontext
        monkey: the oldest timestamp thing works great now
      • 2023-11-28 33200, 2023

      • monkey
        Great outsidecontext :)
      • 2023-11-28 33206, 2023

      • monkey
        mayhem: `MUSICBRAINZ_OAUTH_URL = f"{MUSICBRAINZ_BASE_URL}/oauth2/userinfo"`
      • 2023-11-28 33217, 2023

      • mayhem
        and BASE_URL ?
      • 2023-11-28 33220, 2023

      • monkey
        (and `MUSICBRAINZ_BASE_URL = "https://musicbrainz.org"`)
      • 2023-11-28 33229, 2023

      • monkey
        Tried opening that in my browser. After authentication I do get a JSON object that looks fine to me
      • 2023-11-28 33247, 2023

      • mayhem
        when do you get this error?
      • 2023-11-28 33254, 2023

      • bitmap
        reosarevok: yvanzo: this is odd, I wonder if it's related to the artist ISE from earlier https://community.metabrainz.org/t/disambiguation…
      • 2023-11-28 33257, 2023

      • mayhem
        what is MB_DATABASE_URI set to in config.py?
      • 2023-11-28 33244, 2023

      • monkey
        `MB_DATABASE_URI = "postgresql://musicbrainz:musicbrainz@musicbrainz-docker_db_1:5432/musicbrainz_db"`
      • 2023-11-28 33255, 2023

      • bitmap
        but it seems to be the inverse issue (won't accept any disambiguation rather than not require one at all)
      • 2023-11-28 33202, 2023

      • monkey
        I get the error after being redirected from the MB website after providing my credentials
      • 2023-11-28 33204, 2023

      • reosarevok
        bitmap: sort name was empty
      • 2023-11-28 33213, 2023

      • reosarevok
        The red is a red herring AFAICT
      • 2023-11-28 33226, 2023

      • reosarevok
        It just doesn't go away, as per the other ticket, even if you fill it
      • 2023-11-28 33256, 2023

      • bitmap
        I saw that, but see Beckfield's comment...is he also talking about the UI bug?
      • 2023-11-28 33209, 2023

      • reosarevok
        Yes, I think so
      • 2023-11-28 33218, 2023

      • reosarevok
        They expect that if this doesn't go away you cannot submit
      • 2023-11-28 33225, 2023

      • reosarevok
        Which is not a strange expectation to be fair
      • 2023-11-28 33230, 2023

      • bitmap
        right, makes sense
      • 2023-11-28 33229, 2023

      • reosarevok
        Answered
      • 2023-11-28 33245, 2023

      • bitmap
      • 2023-11-28 33212, 2023

      • reosarevok
        Ok :)
      • 2023-11-28 33228, 2023

      • dseomn has quit
      • 2023-11-28 33240, 2023

      • dseomn joined the channel
      • 2023-11-28 33211, 2023

      • monkey
        mayhem: You put me on the right track with the DB connection. I think I found the issue: I had to set `TESTING` to false in the config, because look at this: https://github.com/metabrainz/listenbrainz-server…
      • 2023-11-28 33230, 2023

      • monkey
        So, for my immediate needs, I can now log in and everything works, thanks for helping. More generally though, either the TESTING thing doesn't work as we want, or I didn't understand how it should be set in local dev
      • 2023-11-28 33231, 2023

      • relaxoMob has quit
      • 2023-11-28 33244, 2023

      • relaxoMob joined the channel
      • 2023-11-28 33239, 2023

      • mayhem
        yeah, sorry. that is exactly what I was working on today.
      • 2023-11-28 33242, 2023

      • mayhem
        wanna try a fix?
      • 2023-11-28 33215, 2023

      • mayhem
        monkey: make a new branch off your branch. merge use-unique-testing-env-var into this new branch. see if your problems go away
      • 2023-11-28 33228, 2023

      • q3lont has quit
      • 2023-11-28 33233, 2023

      • monkey
        I'm done for the day but I can try tomorrow
      • 2023-11-28 33207, 2023

      • q3lont joined the channel
      • 2023-11-28 33251, 2023

      • mayhem
        did anyone else just get logged out of spotify?
      • 2023-11-28 33233, 2023

      • bitmap
        not me (using it in the browser)
      • 2023-11-28 33258, 2023

      • relaxoMob has quit
      • 2023-11-28 33235, 2023

      • ApeKattQuest
        [15:00] <Pratha-Fish> I can't describe how happy the existance of local and unpopular songs on MusicBrainz makes me. The editor community seriously irreplacable 🙏 https://usercontent.irccloud-cdn.com/file/7t3vmUm…
      • 2023-11-28 33235, 2023

      • ApeKattQuest
        [15:00] * Sophist-UK (Sophist@IKR?
      • 2023-11-28 33235, 2023

      • ApeKattQuest
        mb awesome
      • 2023-11-28 33208, 2023

      • Pratha-Fish
        😎
      • 2023-11-28 33248, 2023

      • Pratha-Fish
        I was adding some bootlegs to MusicBrainz, and found this really cool site
      • 2023-11-28 33251, 2023

      • Pratha-Fish
      • 2023-11-28 33229, 2023

      • Pratha-Fish
        How cool would it be to somehow integrate it with MusicBrainz to exchange more data about bootlegs. At least the EDM ones.
      • 2023-11-28 33208, 2023

      • Pratha-Fish
        Not to mention, the ability to directly scrobble a whole ass DJ set to your LB profile with a 1001tracklists integration
      • 2023-11-28 33235, 2023

      • q3lont has quit
      • 2023-11-28 33207, 2023

      • q3lont joined the channel
      • 2023-11-28 33230, 2023

      • ApeKattQuest
        Pratha-Fish: hm, it depends, how official is that site (what i'm asking do they link to places to dl tracks from bootlegs/buy them/etc) or is it simply an info site (if an info site then we could atleast link t othem)
      • 2023-11-28 33233, 2023

      • ApeKattQuest
        :yawn: long day. night ya'll!
      • 2023-11-28 33242, 2023

      • ApeKattQuest
        🐟 🐒 🐈
      • 2023-11-28 33226, 2023

      • Pratha-Fish
        ApeKattQuest: it's an info site. It just takes YouTube links for popular DJ sets, and creates timestamps for every released/unreleased tracks played in the set. Check the link I shared above for an example 👀
      • 2023-11-28 33228, 2023

      • Pratha-Fish
        GN!
      • 2023-11-28 33245, 2023

      • relaxoMob joined the channel
      • 2023-11-28 33217, 2023

      • prathamg has quit
      • 2023-11-28 33259, 2023

      • q3lont has quit
      • 2023-11-28 33258, 2023

      • q3lont joined the channel
      • 2023-11-28 33201, 2023

      • q3lont has quit
      • 2023-11-28 33223, 2023

      • lusciouslover joined the channel
      • 2023-11-28 33201, 2023

      • djl has quit
      • 2023-11-28 33257, 2023

      • djl joined the channel
      • 2023-11-28 33217, 2023

      • lusciouslover has quit
      • 2023-11-28 33259, 2023

      • lusciouslover joined the channel
      • 2023-11-28 33219, 2023

      • kilos_ joined the channel
      • 2023-11-28 33247, 2023

      • petitminion joined the channel
      • 2023-11-28 33245, 2023

      • Kladky has quit