20:23 PM
lucifer
2024-02-05 03651, 2024
20:24 PM
mayhem
ok, so then we would clone the repo and add a submodule to our pyproject?
2024-02-05 03608, 2024
20:25 PM
lucifer
yes
2024-02-05 03645, 2024
20:25 PM
mayhem[m]
ok.
2024-02-05 03617, 2024
20:26 PM
lucifer
but uh actually
2024-02-05 03629, 2024
20:26 PM
lucifer
this is a c++ project with python bindings
2024-02-05 03652, 2024
20:26 PM
mayhem[m]
indeed.
2024-02-05 03617, 2024
20:29 PM
lucifer
hmm i am unsure if this would work then even with submodules
2024-02-05 03622, 2024
20:31 PM
lucifer
could we upload a locally built wheel with a patched nmslib to pypi?
2024-02-05 03627, 2024
20:32 PM
mayhem[m]
I have no idea. I wonder if gcrk (he/him) would know.
2024-02-05 03650, 2024
20:32 PM
lucifer
2024-02-05 03634, 2024
20:33 PM
lucifer
if we could have a branch where nmslib dep points to the github repo and then we could build wheels on that branch and publish to pypi.
2024-02-05 03651, 2024
20:33 PM
lucifer
and publish the source distribution using the normal branch.
2024-02-05 03632, 2024
20:34 PM
lucifer
it might work, not very desirable ofc.
2024-02-05 03646, 2024
20:34 PM
theflash__ has quit
2024-02-05 03657, 2024
20:35 PM
mayhem[m]
lets see what gcrk (he/him) says about this tomorrow and then take it from there.
2024-02-05 03614, 2024
20:36 PM
lucifer
alternatively, we could remove nmslib from requirements. and ask users to install it manually.
2024-02-05 03640, 2024
20:36 PM
steinke joined the channel
2024-02-05 03644, 2024
20:36 PM
lucifer
sure
2024-02-05 03610, 2024
20:37 PM
lucifer
2024-02-05 03609, 2024
20:39 PM
mayhem[m]
lucifer (IRC): do you happen to know where in the LB docs we document command line options, so I can copy that?
2024-02-05 03602, 2024
20:40 PM
mayhem[m]
daaaaaamn, those pictures.
2024-02-05 03617, 2024
20:40 PM
lucifer
2024-02-05 03651, 2024
20:40 PM
lucifer
you can check sphinx-click docs on how to document specific commands at specific places, in LB we just document it all one on page.
2024-02-05 03648, 2024
20:41 PM
mayhem[m]
thx
2024-02-05 03652, 2024
20:46 PM
davic joined the channel
2024-02-05 03614, 2024
20:52 PM
SothoTalKer_ joined the channel
2024-02-05 03614, 2024
20:55 PM
SothoTalKer__ has quit
2024-02-05 03646, 2024
21:00 PM
tux0r- is now known as tux0r
2024-02-05 03644, 2024
21:10 PM
pranavkonidena[m has quit
2024-02-05 03640, 2024
21:27 PM
mayhem[m]
ok, that's done too. PR updated, lucifer. lets look at packaging tomorrow.
2024-02-05 03639, 2024
21:31 PM
lucifer
mayhem[m]: sounds good
2024-02-05 03619, 2024
21:32 PM
lucifer
aerozol: would you prefer the sharebrainz idea to be on LB or MB or MeB page?
2024-02-05 03651, 2024
21:36 PM
aerozol
lucifer: I think it has more to do with MusicBrainz, even though it's aimed at a more casual audience (which makes us think 'LB').
2024-02-05 03620, 2024
21:37 PM
yvanzo[m]
bitmap: Is there a bug or is it correct? “This doesn't seem to resolve any bug, since the old IDs were still deleted correctly by `_delete_and_redirect_gids`.” It seems that the first commit is just a refactoring.
2024-02-05 03622, 2024
21:37 PM
aerozol
MB project (with a prominent link to LB in the page itself)
2024-02-05 03642, 2024
21:37 PM
lucifer
ahan cool, makes sense.
2024-02-05 03628, 2024
21:39 PM
bitmap
yvanzo[m]: IIRC it was just refactoring, but I don't remember the context (it might've been to simplify something in a later commit)
2024-02-05 03649, 2024
21:39 PM
yvanzo[m]
aerozol: Does my comment to your ticket makes sense? Should we elaborate a GSoC idea from that?
2024-02-05 03615, 2024
21:40 PM
yvanzo[m]
bitmap: The citation is from the commit message.
2024-02-05 03629, 2024
21:40 PM
bitmap
yes
2024-02-05 03615, 2024
21:41 PM
bitmap
if you're asking if the commit message is correct, then it looks correct
2024-02-05 03658, 2024
21:41 PM
yvanzo[m]
Ok, I just could not connect the two parts of the sentence.
2024-02-05 03617, 2024
21:42 PM
yvanzo[m]
But the code change itself is good.
2024-02-05 03624, 2024
21:43 PM
bitmap
I think because I initially thought there would be a bug due to this line in sub merge: $self->_delete_and_redirect_gids('artist', $new_id, @$old_ids);
2024-02-05 03617, 2024
21:44 PM
BrainzGit
2024-02-05 03649, 2024
21:44 PM
BrainzGit
2024-02-05 03607, 2024
21:45 PM
bitmap
er, sorry, that's the working line
2024-02-05 03615, 2024
21:46 PM
bitmap
2024-02-05 03604, 2024
21:47 PM
bitmap
I thought I was fixing a bug there, because the old ids wouldn't be passed there correctly (they would be in an array ref)
2024-02-05 03651, 2024
21:47 PM
bitmap
which is correct, but also (explicitly) delete them from the cache via $self->_delete_and_redirect_gids('artist', $new_id, @$old_ids);
2024-02-05 03641, 2024
21:48 PM
mayhem[m]
2024-02-05 03644, 2024
21:48 PM
mayhem[m]
verified, btw.
2024-02-05 03647, 2024
21:48 PM
bitmap
so the bug is accidentally worked around because the "old IDs were still deleted" by that line
2024-02-05 03637, 2024
21:49 PM
rdswift[m] has quit
2024-02-05 03604, 2024
21:50 PM
lucifer
mayhem: oh :/, can you please revert lb prod to v-2024-01-31.0 ?
2024-02-05 03614, 2024
21:50 PM
mayhem[m]
on it.
2024-02-05 03616, 2024
21:50 PM
lucifer
I just logged off 5 mins ago
2024-02-05 03619, 2024
21:50 PM
lucifer
Thanks!
2024-02-05 03620, 2024
21:50 PM
mayhem[m]
k
2024-02-05 03604, 2024
21:51 PM
lucifer
Of course was one thing I didn't test and it had to break.
2024-02-05 03611, 2024
21:51 PM
lucifer
*login was
2024-02-05 03632, 2024
21:51 PM
mayhem[m]
hahahahahaha, of course.
2024-02-05 03637, 2024
21:51 PM
mayhem[m]
I didn't see it either.
2024-02-05 03653, 2024
21:51 PM
mayhem[m]
fixed.
2024-02-05 03621, 2024
21:52 PM
lucifer
thanks
2024-02-05 03608, 2024
21:53 PM
KartikOhri[m] has quit
2024-02-05 03614, 2024
21:56 PM
BrainzGit
2024-02-05 03637, 2024
22:32 PM
Cthulhu-fi joined the channel
2024-02-05 03602, 2024
22:33 PM
Cthulhu-fi
hello
2024-02-05 03610, 2024
22:34 PM
Cthulhu-fi
2024-02-05 03642, 2024
22:34 PM
Cthulhu-fi
seems like someone's scrobbler is bugging out in a big way
2024-02-05 03651, 2024
22:46 PM
Cthulhu-fi
that's all I have to show. bye for now
2024-02-05 03657, 2024
22:46 PM
Cthulhu-fi has quit
2024-02-05 03640, 2024
23:08 PM
opal has quit
2024-02-05 03609, 2024
23:09 PM
opal joined the channel
