#metabrainz

Yeah

I think I'd enjoy working on this project as a whole a lot :)

JadedBlueEyes: from a first look, it seems too much work for us to do.

>This means that it doesn't quite have the stability guarantees a library might have (when you call data.sort() you don't think about "what if it fails?"), nor does it have the surrounding infrastructure of a DryadLINQ or Spark style of experience. Part of this burden is simply passed to you, and this may be intolerable depending on your goals for your program.

rimskii[m]: Interesting, wet to check out that SpotifyAPIService. Indeed we used these in the past to create playlists from the front-end but we have since moved it to the back-end. Might be worth doing a cleanup in a follow-up to your PR if you're interested

maybe a year or two later, it matures enough to become usable for us.

but at the moment, i don't think it worth it.

Spark supports streaming too and we could look into utilising that if it helps improve performance.

Where's that quote from?

monkey (IRC): sure ! will try to move other other functions to back-end then

rimskii[m]: I guess you can probably move getAlbumArtFromSpotifyTrackID somewhere else (probably in frontend/js/src/utils/utils.tsx which uses it) and remove the SpotifyAPIService class entirely.

I don't think there's much else that needs moving

good idea! will do it

oh I used one function from there to fetch the playlists

might leave it as well

or is it better to do it in backend?

the more code in the backend the better

ideally the import code will go in troi library and then that will be used by LB backend.

the frontned should only need to display a list of playlists to the user or let them copy paste a link.

okay!

lucifer that chapter was last updated 6 years ago from what I can see

so basically I need to create a new api endpoint for LB to import from spotify?lucifer (IRC)

rimskii[m]: yup

Hey akshaaatt (IRC) , after going thru all the Gsoc ideas for LB Android, I would like to work on the Artist, album and user pages in the LB App. Hope that’s fine. I have read the scrobble service’s code for the listens.. will try to sort that out asap..

lucifer I imagine a part of it still holds true - Rust being Rust - but the library has probably moved on a bit from then xD

JadedBlueEyes: i see, makes sense.

yeah true. and the bar for replacing spark would be high. there's a lot of exist code and it performs reasonably well at what it does.

i have a feeling there are more gains to be had from using spark streams or reorganising our data.

pranav[m]: Sounds good to me! You can apply for gsoc and we will see accordingly. Cannot commit to anything. Also, jasje has a PR open for fixing the listens submission and looks good to me almost. Can you base your work on top of it?

Yeah, it'd definately be a large project, although I don't think it needs to be replaced wholesale

Sure will do..

Using spark sreams is something I will have to evaluate though

But I'm guessing that I have the go-ahead to at least scope out the project?

yeah sure, assuming you mean improving the performance of our spark cluster.

Yep!

awesome, i would suggest first set it up locally and play with the data yourself.

It might also be easier to start some Rust development for something new that doesn’t exist yet.

also if its worth it. unless its performance critical, its pain for no reason.

Do you have any ideas for what people would like to see re new development yvanzo?

I mean having more than one string at your bow :)

Not that you shouldn’t follow the idea you have at the moment :)

Oh yeah, I've also had a look at the Mailer idea, which could be interesting

I'm not sure with that whether generating the text email from the HTML is the best method, at least for the quality of the output

And potentially enabling translations could be a good feature for that

That’s one indeed.

Given that you will know the HTML code that is generated, you will just need html2text to support this subset of HTML.

Unless you implement a parallel plain text rendering in MRML directly.

I guess it depends how you're writing the email templates - if you're effectively taking the existing templates and giving them nice formatting, html2text should work perfectly fine, but if you make your HTML templates more visual, like what is common from more commercial senders, the plain text of the html wouldn't really make sense

So it depends on the template I guess

That’s it, the thing is that you are also writing the templates, so you control everything.

It shouldn't necesarly be hard to make a seperate plain text template either though

Especially if the strings are seperated out for i18n

But yeah, that's definately a project I could do - I'd have to learn a bit of perl though xD

Some ideas from previous years could also be implemented in Rust: “Integrate Internet Archive in MusicBrainz” for example.

yeah, for sure

No Perl involved, it would be a separate codebase.

I'd need to be able to integrate whatever I do into the main codebase somehow, right?

For example adding the triggers for the email

Even if it's in a seperate repo & deployed seperately

The current templates are useful but it’s better to start with a clean slate.

JadedBlueEyes: Yes, for example sending subscription emails is currently called by a daily cron job: https://github.com/metabrainz/musicbrainz-serve...

For instant edit notes/votes emails, the server could call your program instead of calling its own current Perl modules.

Yeah, it could be running seperately as a REST API or something along those lines

Or send it through a socket like we currently do for the React.js renderer: https://github.com/metabrainz/musicbrainz-serve...

Oh, that's interesting

In any case, the amount of needed Perl code is very small and we can handle that part.

Well thank you :)

You’re welcome!

diptanil: next step would be finding a ticket on the issue tracker to work on and submit a PR.

working on it.

the incremental JSON dumps are paused for now, there are some replication issues (due to the presence of foreign keys in the databases). I may need to re-import the database, but it will take a few hours

[bookbrainz-site] 14MonkeyDo opened pull request #1067 (03master…react-redux-downgrade): chore(deps): Revert react-redux package upgrade https://github.com/metabrainz/bookbrainz-site/p...

[bookbrainz-site] 14MonkeyDo merged pull request #1067 (03master…react-redux-downgrade): chore(deps): Revert react-redux package upgrade https://github.com/metabrainz/bookbrainz-site/p...

[bookbrainz-site] 14dependabot[bot] opened pull request #1068 (03master…dependabot/npm_and_yarn/nodemailer-6.9.9): chore(deps): bump nodemailer from 6.7.2 to 6.9.9 https://github.com/metabrainz/bookbrainz-site/p...

[bookbrainz-site] release 03v-2024-02-23.0 has been published by 14release-drafter[bot]: https://github.com/metabrainz/bookbrainz-site/r...

can someone help me? I created a new endpoint, but cant access it :(

Access to fetch at 'https://api.listenbrainz.org/1/playlist/import/spotify' from origin 'http://localhost:8100' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: It does not have HTTP ok status.

rimskii[m]: you need to set API_URL to `http://localhost:8100`

in config.py

[bookbrainz-site] 14MonkeyDo opened pull request #1069 (03master…override-dep): chore(deps): Override dependency for react-select-fast-filter-options https://github.com/metabrainz/bookbrainz-site/p...

[bookbrainz-site] 14MonkeyDo merged pull request #1068 (03master…dependabot/npm_and_yarn/nodemailer-6.9.9): chore(deps): bump nodemailer from 6.7.2 to 6.9.9 https://github.com/metabrainz/bookbrainz-site/p...

<lucifer> "rimskii: you need to set API_URL..." <- ah, i see. TYSM

is LB-1502 fixed? i tried to run 'troi list' command but i didn't get any error.

LB-1502: Fix troi cli list command https://tickets.metabrainz.org/browse/LB-1502