#metabrainz

It's not the best order, but...

(this whole system is a spaghetti mess)

Yeah, translating this thing already was a nightmare before, so just leave it as is for now.

I'll move it to the start for now

Least bad option

There, "fixed"

Great :) It shouldn't even get any worse for the German translation, luckily a capella does not change the article (which currently varies for medley).

And added MBS-13496 - bitmap, I think our interpolation code makes more assumptions than it should, we should check it when you're around :)

MBS-13496: Link phrase interpolation dies on multi-word attribute names https://tickets.metabrainz.org/browse/MBS-13496

[bookbrainz-site] 14MonkeyDo merged pull request #1069 (03master…override-dep): chore(deps): Override dependency for react-select-fast-filter-options https://github.com/metabrainz/bookbrainz-site/p...

huhridge: I can go to your page of listens and play any track. Let's say I don't have spotify or any other service connected, BrainzPlayer can search on the IA for a match and if there is one, play from that IA resource

monkey: okay that makes sense, so if a track is not on any streaming service then the integration is moot right

i guess adding those to musicbrainz can be another project

seperate from this

What BrainzPlayer currently does is try on each connected service it can, and if there are no matches it skips the track

okay okay that makes sense

i understand it now finally! thanks!!!

👍 don't hesitate if you have more questions

monkey: i probably will 😭😭 i'll be sure to ask them

so should i start working on it right away or work on the proposal and stuff first

or should i open some more PRs first?

akshaaatt (IRC): Hi, while creating a proposal for The Artist Pages in LB app, I found user profile pages in Figma. So can I implement the same in the project or shud I make ui mocks for user pages as well? Thanks

huhridge: We always request to post the proposal on our public forum first (template here: https://wiki.musicbrainz.org/Development/Summer...).

We also want to see the quality of your code so opening PRs is also a requirement

monkey: okay will definitely do!

bitmap: oh, so Error: Failed to parse string "{a cappella} {live} {medley:medley including a} {partial} {instrumental} {cover} {karaoke} recording of" at position 0: unexpected token

I guess it's a wider issue with expand not supporting the spaces?

* akshaaatt (IRC) @aerozol: Hi,

pranav[m]: the artist’s page should replicate the one on website

For example

akshaaatt (IRC): I went thru all the pages on the web.. but it has too many components to offer a sleek look on the LB app… so I was confused on what to include..

I don’t have a great design mind so wanted to chat with aerozol but he might not me up

Be*

I'm going to assume he's not, it's almost 2 AM for him

Yeah that’s why..

That sounds fair then pranav[m] . Wait for aerozol to be around and have a chat with him. He’s the decision maker here.

He'll be around at meeting time I expect

Yup I’ll have a chat with him post today’s meeting

Great!

monkey: could you point me to few of the issues that I can work on as someone new to the project for my initial PRs?

I am particularly interested on the LB project

Shivam2002: you can look at the good-first-bug tickets, or any other unassigned ticket that tickles your fancy: https://tickets.metabrainz.org/issues/?filter=1...

Im sorry for repeating the message, but i still couldnt resolved it. I have encountered the problem

"[webpack-cli] HookWebpackError: The "path" argument must be of type string. Received undefined" when launching static-builder

is there any way to solve it? :_)

aerozol (IRC): hey, long time. Could we please have a chat after today’s meet? I have prepare some wireframes for what the artist pages album pages and user pages shud look on LB ANDROID.. would love for your feedback so I can start working on the UI for my GSoC application.. thanks :)

reosarevok: you can support spaces by modifying `varSubst` and `condSubstStart` RegExps in expand2.js, and `linkSubstStart` in expand2react.js

Is that safe or will it cause issues elsewhere though?

if we're assuming this is not a thing that happen

I'll check in a bit anyway

dunno, I'd suggest using an underscore instead (which is already supported), since they're intended to map to object property names, but adding space seems okay if it helps prevent breaking the website

`Entity::Relationship::_interpolate` may already support spaces

Well, we display the attribute names in places, so we shouldn't make them be underscored (at least the non-interpolated ones, anyway)

Another thing is that we *could* make it so that the attributes with spaces get interpolated as underscores, though?

yeah that could work

it's not a big deal if we have to quote them though

Not sure where that should get done though :)

Also in the same places in expand2?

`getVarSubstScalarArg` I guess?

rimskii[m]: No idea what's going on, but what I usually do in this case is rebuild the static_builder image

`./develop.sh build static_builder`

Sometimes when we move, add or remove front-end files or dependencies we need to rebuild the builder

i see

ok i will try thank you very much :)

[musicbrainz-server] 14reosarevok opened pull request #3185 (03master…MBS-12441): MBS-12441: Handle Yandex Music links https://github.com/metabrainz/musicbrainz-serve...

bitmap: Hmm. Do we have any documentation for all these layers upon layers of things?

Logging what gets passed to getVarSubstScalarArg it includes all sort of things, including things like "choir vocals" where we very much would not want to underscore anything

I'd start with just adding support for spaces and see if anything breaks

(it shouldn't)

if that works I wouldn't bother mapping anything to underscores...now that I think of it, it might cause other problems in linkPhrase.js

Yeah that seems to just work so

Thanks

[musicbrainz-server] 14reosarevok opened pull request #3186 (03master…MBS-13496): MBS-13496: Support attributes with spaces in link phrase interpolation https://github.com/metabrainz/musicbrainz-serve...

hi yellowhatpro, see for example https://github.com/metabrainz/musicbrainz-serve...

monkey: hi! tagging should be fixed for all users on test, beta and prod.

Wunderbar ! Thank you for looking into it and fixing the issues

monkey, ansh: test.lb was running on spa image, i replaced it with the latest release image.

OK

if not already done, please spa branch on latest master.

*rebase spa branch

I think I merged master into it a few days ago, but re-erging now

+m

Okay

Are you on it ansh or should I?

(I already have the branch checked out FWIW)

I'm not on my machine right now, can you do it?

Sure thing

Yeah, it's already up to date from 3 days ago :+1/

Hi guys, gotta wake up early tomorrow. So heading to bed. I reviewed many prs for apps last week and we fixed many bugs. Looking forward to doing a beta release this week.

akshaaatt: you can email/pm reosarevok wit your review

reosarevok ^ IRCed-review :)

Good night!

<3 bitmap

I see you, rabbit!

:D

🐒

🐇 ?

reosarevok

was just about to ping

i wonder if he is afk for osme reason

well, I could start the meeting, if y'all want.

still getting used to timesones

I ean, sure go for it

Welcome everyone, I'll be your host until our regular slacker appears.

ApeKattQuest: go

Arararara~! hi!

added hungarian duda (magyar duda)

Sorry!

will work on polish dudy/koza this week and then I'll have only the lithuanian dūdmaišis and the czechian dudy/bock left and I will be done with the dude(y/a)s!

fin go yvanzo[m] !