great! it had been a couple of months, I should have guessed it'd take a few...
2024-03-12 07248, 2024
moufl
idk why it stopped working tho
2024-03-12 07250, 2024
mayhem
its not the quantity of listens, but whatever spotify does.
2024-03-12 07209, 2024
mayhem
spotify auth is also weird -- did you get an email from us about it?
2024-03-12 07228, 2024
mayhem
we send an email when the connection is broken and we can't import more listens.
2024-03-12 07225, 2024
Tarun_0x0 joined the channel
2024-03-12 07244, 2024
Sciencentistguy has quit
2024-03-12 07242, 2024
Tarun_0x0 has quit
2024-03-12 07255, 2024
Sciencentistguy joined the channel
2024-03-12 07231, 2024
Sciencentistguy has quit
2024-03-12 07242, 2024
minimal joined the channel
2024-03-12 07219, 2024
Sciencentistguy joined the channel
2024-03-12 07247, 2024
aabbi15 has quit
2024-03-12 07223, 2024
passerby joined the channel
2024-03-12 07201, 2024
passerby has quit
2024-03-12 07204, 2024
Tarun_0x0 joined the channel
2024-03-12 07210, 2024
bitmap
yvanzo: reosarevok: should we post the schema change announcement?
2024-03-12 07247, 2024
yvanzo
works for me
2024-03-12 07245, 2024
bitmap
okay, I reviewed it again and it looks good to me, so I'll post
2024-03-12 07224, 2024
arsh has quit
2024-03-12 07250, 2024
yvanzo
aabbi15: The “options” to “evaluate” are rather about the “promising frameworks” that can be used (fluent, i18next…). The translation folder should be in the repository where you are internationalizing the code, so `bookbrainz-site` at least since it seems to have the website UI, but I’m not into BB development. For example (using gettext), see the `po` folder in `picard` and `musibcbrainz-server` repos.
2024-03-12 07247, 2024
moufl has quit
2024-03-12 07230, 2024
moufl joined the channel
2024-03-12 07213, 2024
moufl has quit
2024-03-12 07250, 2024
moufl joined the channel
2024-03-12 07238, 2024
rimskii[m] joined the channel
2024-03-12 07238, 2024
rimskii[m]
lucifer (IRC): Hi, im teribly sorry for disturbing again
2024-03-12 07238, 2024
rimskii[m]
I wanted to ask a question regarding a troi. So Im trying to generate a playlist in LB using mbids, and found this [troi patch](https://github.com/metabrainz/troi-recomme…. But it only accepts a filename to work with.
2024-03-12 07238, 2024
rimskii[m]
Should I change the code for this patch, Are there other troi patches that might work for me?
2024-03-12 07201, 2024
rimskii[m]
im terribly sorry for being a little inactive recently, trying to finish my midterms
I'm not entirely sure what's causing it to wrap the message in hr's, but the output isn't exactly terrible .
2024-03-12 07251, 2024
JadedBlueEyes
I also realized that I cut off the links in the pastebin - at the bottom, it has a numbered list of the links from earlier in the email
2024-03-12 07232, 2024
bitmap
JadedBlueEyes: that looks quite nice for something you threw together :) the "─" characters seem to correspond to the mj-divider and hr tags in the original message, which makes sense, but perhaps you can configure html2text's line width to limit them?
2024-03-12 07219, 2024
JadedBlueEyes
Thanks :)
2024-03-12 07254, 2024
JadedBlueEyes
The --- lines don't seem to entirely match the hr's - there are two at the top, when there is only one hr in the template there, and there's no line between subscriptions and the sig, where there is in the template.
2024-03-12 07248, 2024
JadedBlueEyes
I think the html2text crate expects you to write your own formatter, so I expect it should be fixable there at least.
2024-03-12 07235, 2024
Tarun_0x0 has quit
2024-03-12 07254, 2024
bitmap
ah, you're right
2024-03-12 07229, 2024
bitmap
if it allows for a customer formatter then that's great, otherwise I suppose we could have a post-processing step
2024-03-12 07235, 2024
bitmap
custom*
2024-03-12 07240, 2024
JadedBlueEyes
Yeah.
2024-03-12 07206, 2024
JadedBlueEyes
More layers of processing xD
2024-03-12 07214, 2024
bitmap
html2text | text2finaltext4real
2024-03-12 07254, 2024
JadedBlueEyes
xD
2024-03-12 07222, 2024
JadedBlueEyes
| finaltextfinaliser9001
2024-03-12 07254, 2024
JadedBlueEyes
Application flow wise for that project, I've drawn this:
One is do we want any kind of queue for retrys? At the moment I don't think there's anything
2024-03-12 07214, 2024
JadedBlueEyes
For simplicity's sake I don't think it's worth setting up a whole queue system, but running a second try on a failed send could help with flaky delivery
2024-03-12 07219, 2024
JadedBlueEyes
Second is do we want any kind of batching mechanism? I think bulk subscription updates is a significant part of the workload, and reducing communication overhead could help there.
2024-03-12 07225, 2024
JadedBlueEyes
And third, on a slightly different note, is there any interest in enabling internationalization for the emails?
2024-03-12 07246, 2024
JadedBlueEyes
I don't think there's any support for that in the current systems, and I'm not sure how well mixing templates with links, formatting, etc and translation would go to be honest
2024-03-12 07214, 2024
JadedBlueEyes
But it could have a positive impact for non-english-speaking users
2024-03-12 07232, 2024
bitmap
I don't think we need a queue, necessarily. unless the email address is dead, send failures aren't very common, and failing to send the mail doesn't actually lose the updates (as we keep track of the last edit # which was succesfully sent for each editor)
2024-03-12 07246, 2024
JadedBlueEyes
Yeah, exactly. And I know from experience that setting up systems like RabbitMQ is a pain
2024-03-12 07256, 2024
bitmap
but we could perhaps detect certain failures and retry the send, as you said (I would have to check the logs again to see what kind of errors occur)
2024-03-12 07225, 2024
JadedBlueEyes
Actually, I think the SMTP server is responsible for retrying?
2024-03-12 07204, 2024
JadedBlueEyes
And when it fails there isn't any immediate feedback to the sender.
2024-03-12 07229, 2024
JadedBlueEyes
So ignore my bad there
2024-03-12 07248, 2024
bitmap
for 2, having the mail server in your diagram accept a batch of submissions makes sense to me (Perl is not the ideal place for concurrency, and sending these one-by-one would probably slow down subscriptions significantly)
2024-03-12 07246, 2024
JadedBlueEyes
That sounds good to me, and was pretty much my thought.
2024-03-12 07242, 2024
JadedBlueEyes
I'm willing to bet that that would be a bigger performance improvement than any super efficient template library
2024-03-12 07214, 2024
bitmap
yeah, just moving the email-sending to a separate process should be a measurable improvement
2024-03-12 07256, 2024
bitmap
for 3, there is certainly interest in that, but I'm also not sure how it would fit into our current i18n setup tbh
2024-03-12 07246, 2024
bitmap
it's beyond the scope of the initial idea, but we could discuss it with yvanzo
2024-03-12 07201, 2024
JadedBlueEyes
Yeah, it's definitely something to consider though
