Will do (I assumed it was safe, just wanted to make sure it wouldn't make a difference for the measurements)
2024-03-25 08525, 2024
reosarevok
Ok, on it
2024-03-25 08542, 2024
huhridge joined the channel
2024-03-25 08546, 2024
huhridge
mayhem: okay, just so i can confirm everything, we wanna store the url of the track on IA, if found, in the MB database right?
2024-03-25 08535, 2024
huhridge
in the external links section right?
2024-03-25 08543, 2024
mayhem
if tracks are found on the IA, we want to store it in a seperate DB, much like how we store the caches for spotify and apple music. so, no MB involved.
2024-03-25 08523, 2024
huhridge
oh okay! i'll take a look into it
2024-03-25 08505, 2024
pranav[m]
akshaaatt (IRC): I have applied the migration.. so things are working fine now.. I just checked on a real device.. there is no data loss. The playlist dao tests are failing with the exception that unconsumed events were found .. I am not sure what is causing this.. I tried googling if I have to do the migrations in the tests as well, I did those but still it is failing due to the same reason..
2024-03-25 08554, 2024
munishk joined the channel
2024-03-25 08511, 2024
discordbrainz
<07munishk> Hi lucifer
2024-03-25 08515, 2024
discordbrainz
<07munishk> @lucifer
2024-03-25 08544, 2024
huhridge
mayhem: you are referring to the metadata-cache right? for the internet archive, how should i proceed with it? the 78 rpm collection has around 520k items, do we want to crawl through all of them?
2024-03-25 08506, 2024
mayhem
yep
2024-03-25 08513, 2024
mayhem
that's small potatoes. :)
2024-03-25 08519, 2024
lucifer
huhridge: you can take a look at the spotify metadata cache in the LB codebase on how to do that.
2024-03-25 08537, 2024
huhridge
lucifer: i'll look into it, where is the cache used btw?
2024-03-25 08504, 2024
lucifer
munishk: for the websockets test, 1. you need to add the websockets container to the test docker compose file, you can probably just copy paste from dev docker compose file. 2. you need to a dev dependency to LB for a python socket-io client and use it to connect to the websockets container in your test. 3. you need to submit a listen to LB API (listenbrainz/tests/integration/test_api.py has examples on how to do that). 4.
2024-03-25 08504, 2024
lucifer
verify that the socket.io client received the listens from the websockets container.
2024-03-25 08543, 2024
lucifer
huhridge: in the content resolver, basically we have a metadata cache of the entire catalogue of tracks in LB. then we build indexes over it. given a track, artist and album name the content resolver queries the cache using the indexes and returns a set of matching items. at the moment this is used for exporting playlists only.
2024-03-25 08557, 2024
lucifer
it is similar to searching the external service using their APIs but much faster for bulk lookups.
2024-03-25 08532, 2024
huhridge
lucifer: okay makes sense!
2024-03-25 08559, 2024
huhridge
i've worked out the player implementation fully, will look into the content resolver now!
2024-03-25 08508, 2024
munishk
lucifer: thanks for the detailed steps, can you also pls tell how i can verify no 4 ? (very new to testing)
2024-03-25 08527, 2024
huhridge
i'll add the player implementation part to the proposl EOD
2024-03-25 08537, 2024
pranav[m]
akshaaatt (IRC): the tests are fixed.. should work fine now.. I am working on light theme rn..
2024-03-25 08552, 2024
pranav[m]
U can test the pr, it shud work well in dark mode.. ill fix the light mode now
2024-03-25 08506, 2024
lucifer
munishk: you can look at api tests i mentioned above.
2024-03-25 08541, 2024
lucifer
those test submit and get apis, instead of using the get api you'll use the websocket client.
2024-03-25 08532, 2024
munishk
ohkk, will start working on it
2024-03-25 08532, 2024
munishk
Thanks a lot
2024-03-25 08518, 2024
iconoclast_hero joined the channel
2024-03-25 08526, 2024
monkey[m] has quit
2024-03-25 08506, 2024
reosarevok
yvanzo: indexes loaded
2024-03-25 08508, 2024
reosarevok
What next? :)
2024-03-25 08510, 2024
theflash__
akshaaatt: I've fixed up proposal with the required changes,
<lucifer> "Satyaraj: mayhem took a look..." <- Cool, thanks :)
2024-03-25 08554, 2024
Tarun_0x0 joined the channel
2024-03-25 08519, 2024
yellowhatpro
@yvanzo, I figured I can add more to the rust binding crate, prolly adding more abstraction over sqlx queries, for example creating methods to write more complex sql queries, error handlings, which I actually forgot writing in the proposal.
2024-03-25 08519, 2024
yellowhatpro
Any suggestions on this front?
2024-03-25 08535, 2024
yvanzo
yellowhatpro: Not really, we are more expecting that the suggestions come from you :)
2024-03-25 08549, 2024
yellowhatpro
cool! I will work on some helpful traits that can come handy with the entities.
2024-03-25 08507, 2024
yvanzo
👍
2024-03-25 08501, 2024
ursa-major_ joined the channel
2024-03-25 08539, 2024
fletchto99_ joined the channel
2024-03-25 08551, 2024
Zhele has quit
2024-03-25 08551, 2024
fletchto99 has quit
2024-03-25 08551, 2024
ursa-major has quit
2024-03-25 08556, 2024
fletchto99_ is now known as fletchto99
2024-03-25 08500, 2024
ursa-major_ is now known as ursa-major
2024-03-25 08504, 2024
relaxoMob
mayhem: Is it possible to create playlists with more than 25 entries with LB radio?
2024-03-25 08504, 2024
relaxoMob
Is there a Limit for prompt parameters?
2024-03-25 08504, 2024
relaxoMob
The query hints / playlist name are a little bit too much if someone like me comes and "abuses" it.
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | BookBrainz: #bookbrainz | Channel is logged and not empty as it is bridged to IRC; see https://musicbrainz.org/doc/IRC for details | Agenda: Reviews
2024-03-25 08529, 2024
ApeKattQuest
Tis week is easter and I'll be taking a break for a while. Back week after that!
2024-03-25 08540, 2024
ApeKattQuest
next can be aerozol !
2024-03-25 08503, 2024
aerozol[m]
someone else first please :) go mayhem?
2024-03-25 08511, 2024
mayhem
ok, np.
2024-03-25 08522, 2024
mayhem
I didn't do a whole lot in the last week, since I am traveling.
2024-03-25 08532, 2024
mayhem
just the usual background emails and helping with random questions.
2024-03-25 08538, 2024
mayhem
has anyone found me yet?
2024-03-25 08543, 2024
ApeKattQuest
you are here
2024-03-25 08548, 2024
ApeKattQuest
:)
2024-03-25 08552, 2024
ApeKattQuest
C:
2024-03-25 08558, 2024
mayhem
I've been posting clues to IG/FB, in case you were wondering.
2024-03-25 08501, 2024
mayhem
fin.
2024-03-25 08503, 2024
mayhem
monkey[m]: go
2024-03-25 08519, 2024
monkey[m]
Hi!
2024-03-25 08532, 2024
mayhem
people still up: reosarevok, bitmap, zas, mayhem, yvanzo, monkey, lucifer, akshaaatt, atj, aerozol, ansh, pranav, rimskii, theflash__, Tarun_0x0
2024-03-25 08554, 2024
monkey[m]
Last week was pretty similar to the last, with lots of PR revies, ticket triage, continuing work on the single-page-app with ansh
mayhem: I was making dinner and forgot to set an alarm. Can take it from here
2024-03-25 08554, 2024
pranav[m] joined the channel
2024-03-25 08554, 2024
pranav[m]
Hi everyone!
2024-03-25 08557, 2024
mayhem
ok, slacker!
2024-03-25 08500, 2024
ApeKattQuest
reosarevok: <3
2024-03-25 08545, 2024
pranav[m]
Last week, I worked on overview screens for BrainzPlayer revamp .. those are almost done. I have opened a PR. Turns out I messed up a part of it and have rectified that. After review, I’ll work on album pages
2024-03-25 08559, 2024
pranav[m]
That’s it for me go theflash__ (IRC) ?
2024-03-25 08506, 2024
theflash__
hey
2024-03-25 08518, 2024
reosarevok
people still up: reosarevok, bitmap, zas, mayhem, yvanzo, lucifer, akshaaatt, atj, aerozol, ansh, rimskii, Tarun_0x0
2024-03-25 08547, 2024
theflash__
last week I explored new state management, SwiftData for making models
