Will do (I assumed it was safe, just wanted to make sure it wouldn't make a difference for the measurements)
Ok, on it
huhridge joined the channel
huhridge
mayhem: okay, just so i can confirm everything, we wanna store the url of the track on IA, if found, in the MB database right?
in the external links section right?
mayhem
if tracks are found on the IA, we want to store it in a seperate DB, much like how we store the caches for spotify and apple music. so, no MB involved.
huhridge
oh okay! i'll take a look into it
pranav[m]
akshaaatt (IRC): I have applied the migration.. so things are working fine now.. I just checked on a real device.. there is no data loss. The playlist dao tests are failing with the exception that unconsumed events were found .. I am not sure what is causing this.. I tried googling if I have to do the migrations in the tests as well, I did those but still it is failing due to the same reason..
munishk joined the channel
discordbrainz
<07munishk> Hi lucifer
<07munishk> @lucifer
huhridge
mayhem: you are referring to the metadata-cache right? for the internet archive, how should i proceed with it? the 78 rpm collection has around 520k items, do we want to crawl through all of them?
mayhem
yep
that's small potatoes. :)
lucifer
huhridge: you can take a look at the spotify metadata cache in the LB codebase on how to do that.
huhridge
lucifer: i'll look into it, where is the cache used btw?
lucifer
munishk: for the websockets test, 1. you need to add the websockets container to the test docker compose file, you can probably just copy paste from dev docker compose file. 2. you need to a dev dependency to LB for a python socket-io client and use it to connect to the websockets container in your test. 3. you need to submit a listen to LB API (listenbrainz/tests/integration/test_api.py has examples on how to do that). 4.
verify that the socket.io client received the listens from the websockets container.
huhridge: in the content resolver, basically we have a metadata cache of the entire catalogue of tracks in LB. then we build indexes over it. given a track, artist and album name the content resolver queries the cache using the indexes and returns a set of matching items. at the moment this is used for exporting playlists only.
it is similar to searching the external service using their APIs but much faster for bulk lookups.
huhridge
lucifer: okay makes sense!
i've worked out the player implementation fully, will look into the content resolver now!
munishk
lucifer: thanks for the detailed steps, can you also pls tell how i can verify no 4 ? (very new to testing)
huhridge
i'll add the player implementation part to the proposl EOD
pranav[m]
akshaaatt (IRC): the tests are fixed.. should work fine now.. I am working on light theme rn..
U can test the pr, it shud work well in dark mode.. ill fix the light mode now
lucifer
munishk: you can look at api tests i mentioned above.
those test submit and get apis, instead of using the get api you'll use the websocket client.
munishk
ohkk, will start working on it
Thanks a lot
iconoclast_hero joined the channel
monkey[m] has quit
reosarevok
yvanzo: indexes loaded
What next? :)
theflash__
akshaaatt: I've fixed up proposal with the required changes,
<lucifer> "Satyaraj: mayhem took a look..." <- Cool, thanks :)
Tarun_0x0 joined the channel
yellowhatpro
@yvanzo, I figured I can add more to the rust binding crate, prolly adding more abstraction over sqlx queries, for example creating methods to write more complex sql queries, error handlings, which I actually forgot writing in the proposal.
Any suggestions on this front?
yvanzo
yellowhatpro: Not really, we are more expecting that the suggestions come from you :)
yellowhatpro
cool! I will work on some helpful traits that can come handy with the entities.
yvanzo
👍
ursa-major_ joined the channel
fletchto99_ joined the channel
Zhele has quit
fletchto99 has quit
ursa-major has quit
fletchto99_ is now known as fletchto99
ursa-major_ is now known as ursa-major
relaxoMob
mayhem: Is it possible to create playlists with more than 25 entries with LB radio?
Is there a Limit for prompt parameters?
The query hints / playlist name are a little bit too much if someone like me comes and "abuses" it.
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | BookBrainz: #bookbrainz | Channel is logged and not empty as it is bridged to IRC; see https://musicbrainz.org/doc/IRC for details | Agenda: Reviews
ApeKattQuest
Tis week is easter and I'll be taking a break for a while. Back week after that!
next can be aerozol !
aerozol[m]
someone else first please :) go mayhem?
mayhem
ok, np.
I didn't do a whole lot in the last week, since I am traveling.
just the usual background emails and helping with random questions.
has anyone found me yet?
ApeKattQuest
you are here
:)
C:
mayhem
I've been posting clues to IG/FB, in case you were wondering.
fin.
monkey[m]: go
monkey[m]
Hi!
mayhem
people still up: reosarevok, bitmap, zas, mayhem, yvanzo, monkey, lucifer, akshaaatt, atj, aerozol, ansh, pranav, rimskii, theflash__, Tarun_0x0
monkey[m]
Last week was pretty similar to the last, with lots of PR revies, ticket triage, continuing work on the single-page-app with ansh
mayhem: I was making dinner and forgot to set an alarm. Can take it from here
pranav[m] joined the channel
pranav[m]
Hi everyone!
mayhem
ok, slacker!
ApeKattQuest
reosarevok: <3
pranav[m]
Last week, I worked on overview screens for BrainzPlayer revamp .. those are almost done. I have opened a PR. Turns out I messed up a part of it and have rectified that. After review, I’ll work on album pages
That’s it for me go theflash__ (IRC) ?
theflash__
hey
reosarevok
people still up: reosarevok, bitmap, zas, mayhem, yvanzo, lucifer, akshaaatt, atj, aerozol, ansh, rimskii, Tarun_0x0
theflash__
last week I explored new state management, SwiftData for making models