Ooh, a personal note to me in the LB release notes :P
2024-04-18 10948, 2024
aerozol[m]
Happy to skip posting about it. But when it comes to X/Mastodon/Bluesky I don’t think it matters if it’s a small release, it’s just letting people know we’re active. If anyone thinks I should skip posting negligible updates let me know, otherwise I’ll probably post this one tomorrow :)
2024-04-18 10920, 2024
minimal has quit
2024-04-18 10959, 2024
Maxr1998_ has quit
2024-04-18 10928, 2024
Maxr1998 joined the channel
2024-04-18 10949, 2024
huhridge joined the channel
2024-04-18 10921, 2024
huhridge has quit
2024-04-18 10948, 2024
aerozol[m] has quit
2024-04-18 10923, 2024
yano1 joined the channel
2024-04-18 10920, 2024
yano has quit
2024-04-18 10910, 2024
huhridge joined the channel
2024-04-18 10932, 2024
Kladky joined the channel
2024-04-18 10923, 2024
yellowhatpro joined the channel
2024-04-18 10937, 2024
v6lur has quit
2024-04-18 10935, 2024
huhridge has quit
2024-04-18 10935, 2024
huhridge joined the channel
2024-04-18 10915, 2024
zerodogg
aerozol: I follow you on Mastodon for just this reason, to keep somewhat up to date (even for the small releases)
2024-04-18 10919, 2024
SigHunter has quit
2024-04-18 10923, 2024
SigHunter joined the channel
2024-04-18 10908, 2024
huhridge has quit
2024-04-18 10916, 2024
hydralica has quit
2024-04-18 10944, 2024
huhridge joined the channel
2024-04-18 10905, 2024
yvanzo
aerozol: Even a recap for the last two months (since LB 2023 recap) would probably be interesting 🙂
2024-04-18 10902, 2024
discordbrainz
<05rustynova> Hi. Is there an API endpoint I can use to get the sitewide listen count of a specific recording MBID? I looked through the API docs and I can't find anything that would work. I thought I could at least use the same API as the Album pages, but it use server side data.
2024-04-18 10919, 2024
lucifer
rustynova: we don't have an api for that yet but we can add that. feel free to open a ticket.
2024-04-18 10937, 2024
lucifer
monkey, mayhem: i checked the spark cluster and user similarity seems to have fixed itself. it ran fine yesterday at least. what was the issue you were facing?
2024-04-18 10953, 2024
mayhem
for me, there was a user complaining about it not updating.
2024-04-18 10900, 2024
mayhem
glad that is "fixed".
2024-04-18 10903, 2024
mayhem
:)
2024-04-18 10948, 2024
nobiz has quit
2024-04-18 10924, 2024
nobiz joined the channel
2024-04-18 10939, 2024
discordbrainz
<05rustynova> lucider: Done. In the meantime I guess I'll resort to my good old friend website scrapping.
2024-04-18 10934, 2024
yano1 is now known as yano
2024-04-18 10914, 2024
monkey[m] joined the channel
2024-04-18 10914, 2024
monkey[m]
lucifer (IRC): Hi! The issue I was seeing with the user similarity is that huhridge and I have exactly one artist in common in our top 100 yet according to the API endpoint we just don't have a similarity calculated, not even a very low score: https://api.listenbrainz.org/1/user/mr_monkey/sim…
2024-04-18 10914, 2024
monkey[m]
I was wondering if there was a time range against which we calculate user similarity or something like that to explain that
2024-04-18 10928, 2024
ansh
monkey[m]: The BrainzPlayer SPA branch is live on test.LB The playback is working smoothly. Do give it a try and lemme know if you encounter any bugs.
2024-04-18 10944, 2024
monkey[m]
Oooohhh, exciting !
2024-04-18 10914, 2024
monkey[m] uploaded an image: (52KiB) < https://matrix.moviebrainz.org/_matrix/media/v3/download/moviebrainz.org/yHnZllmZyQpdJmZrydAkbhuB/image.png >
2024-04-18 10935, 2024
monkey[m]
Feels so good to navigate with playback uninterrupted !
2024-04-18 10942, 2024
monkey[m]
Honestly. So good.
2024-04-18 10906, 2024
ansh
Once we have the class components to functional components, the Ambient Queue will be usable accross all the pages. Currently you can just set those using music neighbourhood page.
2024-04-18 10947, 2024
monkey[m]
I see, that makes sense
2024-04-18 10919, 2024
monkey[m]
Honestly still very much usable at this stage. The ambient queue not updating on all pages feels like a minor issue
2024-04-18 10955, 2024
monkey[m]
Mm, it does break the functionality of automatic playback on those pages. For example on a playlist I can only play one track, at the end I have to manually play the next one.
2024-04-18 10904, 2024
ansh
Yep, once we merge LB#2822, we can atleast have ambient queue working on the dashboard.
Since this also converts dashboard component to functional component
2024-04-18 10944, 2024
monkey[m]
Ooohhh, and the ability to add tracks to a queue and keep moving along <3
2024-04-18 10903, 2024
monkey[m]
Yes, let's focus on that.
2024-04-18 10919, 2024
monkey[m]
I started working on refactoring the UserFeed
2024-04-18 10950, 2024
monkey[m]
With the apple stuff behind me I can continue focusing on that
2024-04-18 10956, 2024
ansh
Meanwhile i'll try rewriting tests for BrainzPlayer and ReactQuery
2024-04-18 10918, 2024
huhridge
monkey: i added the whole similar artist list thing on hover, take a look whenever
2024-04-18 10925, 2024
huhridge
also i was starting work on LB-1401, and since there is no labs endpoint for searching albums, i'm using the mb search api, should i search for 'release-group' or 'release'?
the release-group returns it as the first item tho
2024-04-18 10928, 2024
discordbrainz
<12Aerozol> Releases within release groups can have very different tracklists. You could search release-group and then let the user pick which release, if more than 1?
2024-04-18 10948, 2024
discordbrainz
<12Aerozol> p.s. Nobody @ me, I should be sleeping 😛
monkey[m]: i think we use a year's data for similarity, the not similar thing can be explained by the fact that we only keep top 25 similar users.
2024-04-18 10933, 2024
mayhem
yeah, probably needs the same treatment as the one above.
2024-04-18 10925, 2024
monkey[m]
Ahaa, thanks lucifer that could be part of it. Do you think it would be feasable to increase the range to say 2-3 years with the resources we have?
2024-04-18 10934, 2024
lucifer
can try.
2024-04-18 10938, 2024
monkey[m]
It did wonders for the fresh releases page to increase the range similarly
2024-04-18 10919, 2024
monkey[m]
Thanks !
2024-04-18 10922, 2024
lucifer
mayhem: around to discuss oauth stuff?
2024-04-18 10927, 2024
monkey[m]
No rush on that
2024-04-18 10929, 2024
mayhem
yerp
2024-04-18 10955, 2024
lucifer
so the test oauth branch is up for testing on test.mb.org
2024-04-18 10916, 2024
lucifer
you can modify a couple of configuration variables and LB will work with it seamlessly.
2024-04-18 10915, 2024
lucifer
i can update test.lb.org to start using that but we'll need to create a separate database for that. and that may make it difficult to deploy other PRs on test.lb for a while.
the oauth researchers who audited MB have published their tools under, https://oauch.io/.
2024-04-18 10925, 2024
mayhem
that is very very very good.
2024-04-18 10906, 2024
lucifer
i ran the new implementation against the test suite, it mostly is fine.
2024-04-18 10916, 2024
mayhem
ship it!!!!
2024-04-18 10919, 2024
mayhem runs away
2024-04-18 10940, 2024
monkey[m]
!m lucifer
2024-04-18 10940, 2024
lucifer
there is an issue with MB redirects which i opened a PR for, once that is deployed. i'll rerun the test suite.
2024-04-18 10940, 2024
BrainzBot
You're doing good work, lucifer!
2024-04-18 10907, 2024
lucifer
some tests cannot be run until the redirects are fixed.
2024-04-18 10931, 2024
mayhem
reosarevok: any chance you could help fasttrack the deployment of this PR??
2024-04-18 10926, 2024
reosarevok
How fast should the fast-tracking be?
2024-04-18 10936, 2024
reosarevok
It could be on beta today, does it need to be on prod or can you work with beta?
2024-04-18 10949, 2024
lucifer
but other than that, there are three things pending: 1. beautifying the oauth related pages. 2. deciding new scopes to create. 3. figuring out migration of existing oauth apps.
2024-04-18 10957, 2024
lucifer
reosarevok: only test.mb is needed.
2024-04-18 10923, 2024
reosarevok
test.mb? That doesn't use the real db, is that ok? If so, sure, I can certainly put it there
2024-04-18 10931, 2024
lucifer
yup that is totally fine.
2024-04-18 10934, 2024
mayhem
lucifer: for 1: there is a PR of the login page for meb.org. But I trust you need more than that?
2024-04-18 10958, 2024
mayhem
2. new scopes. what does that entail?
2024-04-18 10959, 2024
lucifer
mayhem: i met with aerozol for 1, he is fine with shipping it as is and making the remaining changes later.
2024-04-18 10927, 2024
mayhem
O_O
2024-04-18 10933, 2024
mayhem
getting soft in his old age, I see. :)
2024-04-18 10944, 2024
lucifer
the login page is not coming yet, that needs user migration and will happen after the MB schema change.
2024-04-18 10908, 2024
lucifer
only requirement from his side is a smooth redirection flow that does not drop off users, i'll ensure that works.
2024-04-18 10921, 2024
mayhem
k
2024-04-18 10948, 2024
lucifer
2. for scopes, basically we need to list stuff like: listen scope to submit listens, playlist scope to modify playlists so on.
2024-04-18 10919, 2024
lucifer
this is new functionality fwiw. if we just wanted to move OAuth from MB.org to MeB.org for our projects, we could postpone this.
2024-04-18 10910, 2024
mayhem
I think for this it would a good idea for you to make a google doc that outlines what you see and explains what needs doing. and then we need to get more people to read that to see what we need or are missing.
2024-04-18 10933, 2024
mayhem
scopes are tricky, for sure.
2024-04-18 10937, 2024
lucifer
sure can do that.
2024-04-18 10942, 2024
mayhem
I am not sure what concept to apply here....
2024-04-18 10901, 2024
mayhem
in other realms it is best to not over-plan. and in others over-planning is a must.
2024-04-18 10906, 2024
lucifer
we can use spotify/apple music/google etc. as inspiration.
2024-04-18 10907, 2024
mayhem
where do we fall on this?
2024-04-18 10922, 2024
mayhem
My gut feeling is that if we dont need this yet, lets skip it.
2024-04-18 10922, 2024
lucifer
i would start with just adding a listen scope.
2024-04-18 10932, 2024
mayhem
but making the doc is a good idea to capture your ideas while they are fresh.
2024-04-18 10944, 2024
lucifer
oauth support for submitting listens has been asked for before.
2024-04-18 10903, 2024
mayhem
I think that is sensible. we should add scopes as we need them, but we need an overarching plan for scopes, otherwise they get messy
2024-04-18 10912, 2024
mayhem nods
2024-04-18 10916, 2024
mayhem
clear use case
2024-04-18 10918, 2024
lucifer
yes, makes sense.
2024-04-18 10958, 2024
lucifer
3 is tricky too. migrating existing apps over, will surely need changes in MB code base.
