[listenbrainz-android] 14dependabot[bot] opened pull request #441 (03dev…dependabot/gradle/dev/androidx.lifecycle-lifecycle-viewmodel-ktx-2.8.3): Bump androidx.lifecycle:lifecycle-viewmodel-ktx from 2.8.2 to 2.8.3 https://github.com/metabrainz/listenbrainz-androi…
2024-07-03 18507, 2024
BrainzGit
[listenbrainz-android] 14dependabot[bot] opened pull request #442 (03dev…dependabot/gradle/dev/androidx.test.espresso-espresso-core-3.6.1): Bump androidx.test.espresso:espresso-core from 3.6.0 to 3.6.1 https://github.com/metabrainz/listenbrainz-androi…
2024-07-03 18512, 2024
BrainzGit
[listenbrainz-android] 14dependabot[bot] opened pull request #443 (03dev…dependabot/gradle/dev/androidx.lifecycle-lifecycle-viewmodel-compose-2.8.3): Bump androidx.lifecycle:lifecycle-viewmodel-compose from 2.8.2 to 2.8.3 https://github.com/metabrainz/listenbrainz-androi…
2024-07-03 18514, 2024
BrainzGit
[listenbrainz-android] 14dependabot[bot] opened pull request #444 (03dev…dependabot/gradle/dev/androidx.test.ext-junit-1.2.1): Bump androidx.test.ext:junit from 1.2.0 to 1.2.1 https://github.com/metabrainz/listenbrainz-androi…
2024-07-03 18519, 2024
BrainzGit
[listenbrainz-android] 14dependabot[bot] opened pull request #445 (03dev…dependabot/gradle/dev/androidx.test-monitor-1.7.1): Bump androidx.test:monitor from 1.7.0 to 1.7.1 https://github.com/metabrainz/listenbrainz-androi…
2024-07-03 18521, 2024
BrainzGit
[listenbrainz-android] 14dependabot[bot] opened pull request #446 (03dev…dependabot/gradle/dev/androidx.test-runner-1.6.1): Bump androidx.test:runner from 1.6.0 to 1.6.1 https://github.com/metabrainz/listenbrainz-androi…
2024-07-03 18532, 2024
BrainzGit
[listenbrainz-android] 14dependabot[bot] opened pull request #447 (03dev…dependabot/gradle/dev/androidx.lifecycle-lifecycle-livedata-ktx-2.8.3): Bump androidx.lifecycle:lifecycle-livedata-ktx from 2.8.2 to 2.8.3 https://github.com/metabrainz/listenbrainz-androi…
2024-07-03 18542, 2024
BrainzGit
[listenbrainz-android] 14dependabot[bot] opened pull request #448 (03dev…dependabot/gradle/dev/io.sentry.android.gradle-4.9.0): Bump io.sentry.android.gradle from 4.7.0 to 4.9.0 https://github.com/metabrainz/listenbrainz-androi…
2024-07-03 18543, 2024
BrainzGit
[listenbrainz-android] 14dependabot[bot] closed pull request #439 (03dev…dependabot/gradle/dev/io.sentry.android.gradle-4.8.0): Bump io.sentry.android.gradle from 4.7.0 to 4.8.0 https://github.com/metabrainz/listenbrainz-androi…
2024-07-03 18546, 2024
BrainzGit
[listenbrainz-android] 14dependabot[bot] opened pull request #449 (03dev…dependabot/gradle/dev/androidx.lifecycle-lifecycle-runtime-ktx-2.8.3): Bump androidx.lifecycle:lifecycle-runtime-ktx from 2.8.2 to 2.8.3 https://github.com/metabrainz/listenbrainz-androi…
2024-07-03 18521, 2024
BrainzGit
[musicbrainz-server] 14JadedBlueEyes opened pull request #3313 (03master…MBS-13676): MBS-13676: Remove alignment spacing when there is no cover art indicator https://github.com/metabrainz/musicbrainz-server/…
2024-07-03 18527, 2024
Maxr1998_ joined the channel
2024-07-03 18559, 2024
Maxr1998 has quit
2024-07-03 18505, 2024
yellowhatpro[m]
yvanzo bitmap : hi, there are couple of edits that have data but their row does not exist in edits table, should I take it into account?
2024-07-03 18505, 2024
yellowhatpro[m]
I was actually checking for each edit and edit note if the editor is spammer or not, but since for a particular edit in `edit_data` having no row in `edit` table, I don't know about the editor.
I am checking for the condition before extracting the URL from edit_data or edit_note.
2024-07-03 18544, 2024
yellowhatpro[m]
Will add tests soon related to new logics.
2024-07-03 18544, 2024
yellowhatpro[m]
So far, app works good, and I think now I should start working on the network req part of the archival task.
2024-07-03 18552, 2024
Kladky joined the channel
2024-07-03 18546, 2024
atj[m] joined the channel
2024-07-03 18546, 2024
atj[m]
[@yellowhatpro](https://matrix.to/#/@yellowhatpro:matrix.org): could you add a join on `editor` to your initial edit query and add the condition to the where?
2024-07-03 18505, 2024
atj[m]
It would save the additional lookup for each edit
2024-07-03 18521, 2024
atj[m]
I may be misunderstanding something though
2024-07-03 18517, 2024
reosarevok[m]
Jade: I took a look at your PR, found some issues with it and some issues that were there before but I didn't know about 😅
2024-07-03 18545, 2024
reosarevok[m]
Anyway, if you have the time, feel free to look into my comments - if you don't and you have enough to do with gsoc, just let me know and I can look into it myself further :)
Jade: if you want to test the RG search properly, feel free to make that change temporarily and revert for pushing ^
2024-07-03 18555, 2024
Jade[m]
reosarevok[m]: Thanks! I'll see if I can figure out how git cherry-pick works 😆
2024-07-03 18508, 2024
reosarevok[m]
Honestly, it's a one liner, I wouldn't bother
2024-07-03 18530, 2024
reosarevok[m]
But if you want to, just git cherry-pick commithash should work if you have fetched my repo
2024-07-03 18515, 2024
Lotheric joined the channel
2024-07-03 18521, 2024
yvanzo[m]
Hi yellowhatpro, thanks, it looks good. Looking forward for tests. The above suggested improvement makes sense, you might even want to retrieve the edit type at the same time.
2024-07-03 18504, 2024
monkey[m]
lucifer: Hi! I'm trying to test LB#2910 but I can't really without a paying apple music account. Do you have a trick to test it, or are you willing to lend me your token for testing ? (promise, I won't use it for anything)
yvanzo: for moving the history page out of statistics - would you create a separate `/history` folder just for it, or put it under `/doc` since it's kind of a doc, or something else entirely?
2024-07-03 18548, 2024
yvanzo[m]
reosarevok:
2024-07-03 18500, 2024
yvanzo[m]
I was suggesting /root/history
2024-07-03 18503, 2024
reosarevok[m]
So a separate folder under /root, and a separate Controller for it as well?
2024-07-03 18559, 2024
yvanzo[m]
yes
2024-07-03 18537, 2024
reosarevok[m]
Ok, I was thinking it felt like overkill but maybe it's cleaner after all
I was thinking we'd make it just l() for the strings in statistics/MusicBrainzHistory (probably just history/History after this)
2024-07-03 18524, 2024
reosarevok[m]
And keep only titles and descriptions as l_history
2024-07-03 18533, 2024
reosarevok[m]
Is that not the plan? :)
2024-07-03 18548, 2024
mayhem[m]
"It only works in practice, its a disaster in theory". I really need to add to that to my email sig
2024-07-03 18524, 2024
reosarevok[m]
yvanzo: if you mean adding a context to `'{date} - {title}'` to explain what that is about, that makes sense to me, anyway - not sure if that was the idea
2024-07-03 18530, 2024
yvanzo[m]
reosarevok: The initial plan was just to move the strings extracted from the database to a separate domain.
2024-07-03 18535, 2024
reosarevok[m]
Yes, I know, and that we're still doing. I was at first going to move the strings on the page itself to the same domain but you convinced me not to - I'm just not sure if you want me to move them to server given we both seem to agree this isn't really statistics
2024-07-03 18538, 2024
reosarevok[m]
I think it makes sense, but I didn't quite get if you think "adding translation context keys to the event’s titles and descriptions" would be needed only if I moved those strings to `history` as well, or if you meant something else, yvanzo
2024-07-03 18548, 2024
yvanzo[m]
OK, let’s pick the simplest solution and not mix history data with code in this new domain.
2024-07-03 18501, 2024
reosarevok[m]
Seems good to me - so, server is fine for the few strings? I can probably even move them from statistics to server in the po files with the same kind of bash loop I used to move the events themselves to history, so that seems good
2024-07-03 18558, 2024
yvanzo[m]
The code can even stay in its current domain for now, and we can revisit those when revisiting statistics again (about the duplication issue we discussed earlier).
2024-07-03 18541, 2024
reosarevok[m]
Hmm, ok, I can live with that - still move it to root/history though or just not touch it at all for now?
2024-07-03 18501, 2024
reosarevok[m]
(if you prefer not moving anything for now, that might be simpler for this PR so that'd be fine too)
2024-07-03 18546, 2024
yvanzo[m]
simpler! :)
2024-07-03 18502, 2024
reosarevok[m]
Ok!
2024-07-03 18515, 2024
minimal joined the channel
2024-07-03 18556, 2024
BrainzGit
[listenbrainz-server] 14MonkeyDo opened pull request #2927 (03master…fix-album-no-length): Manual submission modal: Only send duration_ms if non-null https://github.com/metabrainz/listenbrainz-server…
2024-07-03 18538, 2024
lucifer[m]
monkey: sure, can do.
2024-07-03 18501, 2024
monkey[m]
Thanks! In the meantime I asked ansh to test for me, so I think we are probably sorted :)
2024-07-03 18522, 2024
pite joined the channel
2024-07-03 18527, 2024
lucifer[m]
ah okay, cool.
2024-07-03 18500, 2024
reosarevok[m]
yvanzo: I think I managed to make the PR better and more to your liking - do check when you have some time but no rush
2024-07-03 18521, 2024
monkey[m]
Data question for lucifer and mayhem : the LB API docs say that `additional_info.tracknumber` should be an optional integer: https://github.com/metabrainz/listenbrainz-server…... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/XwRtnkqiLaqagMvHsfvvKnMH>)
2024-07-03 18542, 2024
lucifer[m]
monkey: yes, i checked and there is no validation for track number to be an integer in DB so should be fine to change it to a string.
