bitmap: I *think* the reason we keep getting wide character errors when PSQL fails is we're double-decoding in `$exception->throw( sqlstate => $state, message => decode_utf8($msg) );` - does that sound like the likely issue?
2024-07-09 19133, 2024
reosarevok[m]
Maybe I'm doing a dumb
2024-07-09 19146, 2024
reosarevok[m]
Or well, I'm fairly sure that's the problem in some cases, just want to make sure I'm not missing cases where we need that decode :)
2024-07-09 19128, 2024
rcombs has quit
2024-07-09 19101, 2024
rcombs joined the channel
2024-07-09 19109, 2024
Sophist-UK has quit
2024-07-09 19119, 2024
mayhem[m]
"Mit vorzüglicher Hochachtung," yvanzo sounds like he is standing in front of a judge. :)
2024-07-09 19152, 2024
BrainzGit
[listenbrainz-server] 14MonkeyDo opened pull request #2934 (03master…listening-now-require-login): LB-817: Disable BrainzPlayer if all sources disabled https://github.com/metabrainz/listenbrainz-server…
2024-07-09 19132, 2024
rimskii[m]
lucifer: Hi!
2024-07-09 19132, 2024
rimskii[m]
So Ive encountered problem with soundcloud. I was trying to do metadata lookup (using this endpoint https://api.listenbrainz.org/1/metadata/lookup/) but soundcloud doesnt store track and artist names like other apps, since mostly the tracks are submitted by random users to soundcloud. So track JSONs doesnt contain artist name lol. They have only title, which is usually, ( but not always) contains artist and track name like this
2024-07-09 19132, 2024
rimskii[m]
"Sabrina Carpenter - PLease Please Please". So im thinking to what to do in this situation"
2024-07-09 19139, 2024
rimskii[m]
* lucifer: Hi!
2024-07-09 19139, 2024
rimskii[m]
So Ive encountered problem with soundcloud. I was trying to do metadata lookup to search mbid by recording_name and artist_name (using this endpoint https://api.listenbrainz.org/1/metadata/lookup/) but soundcloud doesnt store track and artist names like other apps, since mostly the tracks are submitted by random users. So track JSONs dont contain artist name lol. They have only title, which is usually, (but not always) contains
2024-07-09 19139, 2024
rimskii[m]
artist and track name like this "Sabrina Carpenter - Please Please Please". So im thinking to what to do in this situation"
2024-07-09 19103, 2024
rimskii[m]
As one way, I can try to divide the track name into two parts, tho it doesnt seem to work for every song
2024-07-09 19147, 2024
rimskii[m]
rimskii[m]: success rate would be like 60%~
2024-07-09 19108, 2024
rimskii[m]
* like 60% - 70%~
2024-07-09 19126, 2024
rimskii[m]
* lucifer: Hi!
2024-07-09 19126, 2024
rimskii[m]
So Ive encountered problem with soundcloud. I was trying to do metadata lookup to search mbid by recording\_name and artist\_name (using this endpoint https://api.listenbrainz.org/1/metadata/lookup/) but soundcloud doesnt store track and artist names like other apps, since mostly the tracks are submitted by random users. So track JSONs dont contain artist name lol. They have only title, which usually contains artist and track name
2024-07-09 19126, 2024
rimskii[m]
like this "Sabrina Carpenter - Please Please Please". So im thinking to what to do in this situation"
2024-07-09 19136, 2024
lucifer[m]
rimskii: hmm i see, can you share one track json?
2024-07-09 19131, 2024
mayhem[m]
monkey: ansh lucifer : can I use test.lb for a bit?
2024-07-09 19138, 2024
monkey[m]
I'm not using it
2024-07-09 19138, 2024
lucifer[m]
sure
2024-07-09 19154, 2024
mayhem[m]
thx.
2024-07-09 19112, 2024
rimskii[m]
lucifer[m]: okay! Can I share in about an hour? Not at home rn :(
monkey: yup i have seen that, but i wanted to see the json for that particular track
2024-07-09 19145, 2024
monkey[m]
See above, indeed this sucks "title": "Sabrina Carpenter - Please Please Please",
2024-07-09 19130, 2024
lucifer[m]
publisher_metadata
2024-07-09 19136, 2024
lucifer[m]
has the correct metadata
2024-07-09 19143, 2024
monkey[m]
If publisher_metadata is available somewhere, it has the artist as a separate field
2024-07-09 19144, 2024
monkey[m]
Ya
2024-07-09 19153, 2024
monkey[m]
But not the track name
2024-07-09 19109, 2024
lucifer[m]
that's album title i think.
2024-07-09 19125, 2024
lucifer[m]
soundcloud doesn't really support albums.
2024-07-09 19133, 2024
monkey[m]
Right, my bad.
2024-07-09 19134, 2024
monkey[m]
Accroding to the API docs, publisher_metadata is not available in the returned JSON :/
2024-07-09 19151, 2024
lucifer[m]
we had a meet with the soundcloud team and they teat albums as playlists internally so i think in such cases it might be enough to use publisher metadata.
2024-07-09 19101, 2024
lucifer[m]
oh this is from the website scraping and not the api?
2024-07-09 19104, 2024
monkey[m]
Yes
2024-07-09 19115, 2024
monkey[m]
I remember running into that issue when i first looked at their API
2024-07-09 19150, 2024
monkey[m]
💩
2024-07-09 19118, 2024
lucifer[m]
hmm i see, maybe we can match just based on artist name + track title for soundcloud.
2024-07-09 19159, 2024
lucifer[m]
we already do that during search but later only consider it if artist names and track names are similar too respectively.
2024-07-09 19134, 2024
monkey[m]
Hm so it's specifically for deciding which API search result to play?
I see mbdata has a separate ReleaseUnknownCountry model, which I guess we'd need to use rather than having ReleaseCountry, so that complicates convert_release_event and the like, but AFAICT that's what needs to happen
2024-07-09 19118, 2024
reosarevok[m]
I also cannot find where the CountryDates model is coming from? I don't see it in mbdata
2024-07-09 19124, 2024
reosarevok[m]
Anyway, off to the shop for a bit
2024-07-09 19149, 2024
reosarevok[m]
Left a comment on the issue for now, feel free to expand there if I'm missing something
[listenbrainz-server] 14MonkeyDo opened pull request #2935 (03master…rec-playlist-save-button): LB-1317, LB-1318: Export to music service options on "Created for you" page https://github.com/metabrainz/listenbrainz-server…
was there not an existing messageformat v1 parser for Rust we could have used that made you decide to write your own?
2024-07-09 19143, 2024
Jade[m]
Unfortunately not
2024-07-09 19155, 2024
Jade[m]
ICU4X is conspicuously missing a MessageFormat parser
2024-07-09 19131, 2024
Jade[m]
It does have pretty much everything else though, so I've used it in the runtime
2024-07-09 19156, 2024
Jade[m]
I haven't committed that yet cause it still needs a few tweaks
2024-07-09 19139, 2024
bitmap[m]
I see. I figured that was the case, but it surprised me that nobody had written one before
2024-07-09 19130, 2024
Jade[m]
Yeah. There are a few different projects, but they all have their own syntax
2024-07-09 19146, 2024
akshaaatt[m] uploaded an image: (184KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/matrix.org/fJWjMrYqqRQJOEeOeMjLQCCN/1000000856.jpg >
2024-07-09 19108, 2024
akshaaatt[m]
theflash: this is how the android app handles notifications
2024-07-09 19112, 2024
yvanzo[m]
Hi yellowhatpro, please let us know when you want to have a meeting again this week.
2024-07-09 19154, 2024
yellowhatpro[m]
Hi yvanzo , I am available tomorrow
2024-07-09 19126, 2024
yvanzo[m]
What time so bitmap can be there too?
2024-07-09 19113, 2024
theflash__
alright!, thanks akshaaatt[m]!
2024-07-09 19139, 2024
yellowhatpro[m]
wait lemme check according to the clock you told about
2024-07-09 19110, 2024
yellowhatpro[m]
bitmap: yvanzo 1500 UTC tomorrow ?
2024-07-09 19100, 2024
bitmap[m]
yes that works for me
2024-07-09 19110, 2024
yvanzo[m]
Thank you both!
2024-07-09 19126, 2024
yvanzo[m]
mayhem: Almost 😆 I tried to pick the most formal possible salutation as I don’t know if they are/will be looking on us favorably. Let’s hope that they will have a laugh too and develop a liking! 🤞
2024-07-09 19121, 2024
yvanzo[m]
reosarevok: About `unknown_country_dates`, your assumption seems to make sense 👍️ but I didn’t dig the code to check it as a whole.
2024-07-09 19130, 2024
reosarevok[m]
bitmap: any idea where the encoding problem might be happening? Alternatively, is there a way to check programmatically whether a message is utf8 or not?
2024-07-09 19111, 2024
reosarevok[m]
The problem from MBS-11207 we tried to skip with this I mean
# 23503 DBD::Pg::st execute failed: ERROR: insert or update on table "artist_credit_name" violates foreign key constraint "artist_credit_name_fk_artist"
2024-07-09 19158, 2024
reosarevok[m]
# DETAIL: Key (artist)=(8) is not present in table "artist". [for Statement "SET client_min_messages TO 'warning';
2024-07-09 19123, 2024
reosarevok[m]
But if I replace any of the ASCII strings in that file with, say, ♥
2024-07-09 19142, 2024
reosarevok[m]
Then I get # Wide character at /home/reosarevok/musicbrainz-server/lib/MusicBrainz/Server/Connector.pm line 59. instead
2024-07-09 19131, 2024
reosarevok[m]
(which goes back to the former if I remove the decode_utf8() call)
2024-07-09 19156, 2024
reosarevok[m]
Eh. Both while running prove -lv t/tests.t :: --tests Edit::Work::Create, that is :)
2024-07-09 19119, 2024
bitmap[m]
reosarevok: if you remove `decode_utf8`, can you still reproduce MBS-11207 using the suggestion in the ticket ("change the hostname for READWRITE to something invalid that has unicode characters in it")?
<lucifer[m]> "hmm i see, maybe we can match..." <- Should I consider using fuzzy matching for this? Im still not sure about how to implement it effectively
2024-07-09 19148, 2024
lucifer[m]
rimskii: need to think about it more, for now just keep using the same endpoints regardless of the match rate.
2024-07-09 19154, 2024
lucifer[m]
we can collect some examples of data in soundcloud, what they should ideally match to and how to do that, and discuss it with mayhem later.
2024-07-09 19127, 2024
rain0r
I'm wondering if track->identifier in JSPF is a list or a string. I found both cases in the ListenBrainz API even if there is only one element in the list?
2024-07-09 19138, 2024
lucifer[m]
rain0r (IRC): it should be a list of string according to the spec, historically we had it as string but now we are migrating to list of string as well.
