denizenging: very cool. now we only need to fully support synced and unsynced lyrics in picard and hopefully also lrc files, that would be great
discordbrainz
<05denizenging> I am currently writing them to the lyrics tag directly. I chose that tag because my music server, Navidrome, uses that to parse and relay the lyrics to Subsonic-compatible clients. It works great for me and someone can easily change to write to a different tag.
<05denizenging> I would appreciate a guide on the proper tag to use, to be fair, though. I think it changes depending on the file format. Also, an optimization could be done. I think the register_track_metadata_processor process everything whether we have a match for them or not (on the right side of the panel).
Kladky joined the channel
Kladky has quit
Kladky joined the channel
outsidecontext[m
denizenging: for picard 3 we have first changes to support synced lyrics explicitly, there will be a separate syncedlyrics tag, see https://tickets.metabrainz.org/browse/PICARD-1092 . But for current version using lyrics is probably fine.
BrainzBot
PICARD-1092: Add support for preserving the SYLT tag, for synchronised lyrics
outsidecontext[m
denizinging: "Also, an optimization could be done. I think the register_track_metadata_processor process everything whether we have a match for them or not (on the right side of the panel)." <- yes, that's the idea of that processor. it also fits what you plugin needs to do, as the lrclib API seems to operate per track, so that fits
SigHunter has quit
discordbrainz
<05denizenging> I think you might've misunderstood my intention, or most probably I've put it the wrong way. It runs for each track that is shown on the right side no matter whether that track actually exists on my filesystem. That's inefficient and causes the remote API to be called unnecessarily, maybe causing that project to be, you know, financial overhead.
monkey: LB-1608, this message existed before. looking into the code, this has disappeared because the new jinja2 templates used since the SPA refactor are missing sections to render flash messages.
i guess no flash messages are working atm. i think the right way to fix this would be adding an errors section in props and checking it every page and rendering a toast or error div. thoughts?
<lucifer[m]> "monkey: LB-1608, this message..." <- Oof, thanks for finding that! I'll chat with ansh but I think indeed we probably just need to add a section to the global props passed to the front-end, and deal with rendering the error (should be in a single place now, after all the refactoring we did)
