The passbolt password manager has a release song for every release. I love that. And a password manager is totally unrelated to music. We should have this for MB releases as well :)
FYI I've deployed the mb-mail-service to aretha (where test.mb lives) and deployed your MBS branch there too
2024-08-08 22111, 2024
bitmap[m]
but I think I need to set some DBDefs values before we can try it
2024-08-08 22134, 2024
Jade[m]
Yep, that's likely
2024-08-08 22137, 2024
Jade[m]
My musicbrainz-server has a slightly modified Default.pm file cause I couldn't figure out which was the right DBDefs.pm to modify last week
2024-08-08 22117, 2024
Jade[m]
sub SMTP_SERVER { 'smtp-relay:1025' }
2024-08-08 22118, 2024
Jade[m]
sub MAIL_SERVICE_BASE_URL { "http://mail-service:3000" }
2024-08-08 22157, 2024
bitmap[m]
lib/DBDefs.pm is the one you want to modify (to override anything in Default.pm)
2024-08-08 22116, 2024
bitmap[m]
if that doesn't exist there's a DBDefs.pm.sample you can base it on
2024-08-08 22118, 2024
Jade[m]
And I've got this added to the docker compose file... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/GxYoIofhOnaLRlDtlsaCpBop>)
2024-08-08 22142, 2024
Jade[m]
Did you have any issues with the Sentry integration?
2024-08-08 22116, 2024
bitmap[m]
I haven't configured that yet actually, because I think our Sentry instance is still borked 😔
2024-08-08 22118, 2024
Jade[m]
It's a bit difficult for me to test that locally with sentry going on about free trials and stuff 😅
2024-08-08 22153, 2024
Jade[m]
It was nagging me about uploading debuginfo, but I couldn't actually find any docs for it
2024-08-08 22114, 2024
bitmap[m]
heh, so far it's been even more difficult to test in prod because it doesn't want to work at all
2024-08-08 22154, 2024
bitmap[m] set MAIL_SERVICE_BASE_URL on test.mb just now
2024-08-08 22143, 2024
Jade[m]
It feels like there's a certain category of software that's just way too complex to operate. GitLab fits too
2024-08-08 22106, 2024
bitmap[m]
yeah, sentry feels crazy bloated compared to what I remember from years ago
2024-08-08 22125, 2024
bitmap[m]
which endpoints did you implement for sending out mail so far?
2024-08-08 22129, 2024
bitmap[m]
(in MBS)
2024-08-08 22156, 2024
Jade[m]
Email verification and message sending from last week
2024-08-08 22106, 2024
Jade[m]
I haven't been too productive this week :(
2024-08-08 22141, 2024
Jade[m]
A bit distracted by something I'd best no talk about in public here, but which could be very good
2024-08-08 22104, 2024
Jade[m]
I was also meant to be packing today, was mostly procrastinating
2024-08-08 22118, 2024
Jade[m]
s/no/not/
2024-08-08 22127, 2024
bitmap[m]
that's alright, there's not a whole lot left to your project at this point:)
2024-08-08 22159, 2024
bitmap[m]
ok, I'll give email verification emails a test today
2024-08-08 22105, 2024
Jade[m]
I'm very happy that it's gone so well so far 😁
2024-08-08 22132, 2024
Jade[m]
bitmap[m]: I've had a few issues with the strings in that just being empty for some reason??
2024-08-08 22153, 2024
bitmap[m]
hmm, weird. I'll keep an eye out for that
2024-08-08 22159, 2024
Jade[m]
At first I thought it was because it was a blessed object or something
And it fixed it throwing, but still I'm getting an empty string, now in the name field too
2024-08-08 22106, 2024
Jade[m]
* And it fixed it throwing without the string concatenation, but still I'm getting an empty string, now in the name field too
2024-08-08 22109, 2024
Jade[m]
If I tried to give $verification_link directly to the JSON encoder, it would throw
2024-08-08 22134, 2024
Jade[m]
Forcing it to be a string in line 437 fixes that, or what I added in line 424
2024-08-08 22147, 2024
bitmap[m]
ok, sounds like something is being passed incorrectly, since it shouldn't be an object
2024-08-08 22157, 2024
bitmap[m]
(the JSON encoder doesn't encode blessed objects by default)
2024-08-08 22115, 2024
bitmap[m]
I'll look into it and ping you if I find something
2024-08-08 22136, 2024
Jade[m]
Thanks :)
2024-08-08 22107, 2024
Jade[m]
I also think there's probably something I should be doing other than... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/PQSgSNcTWlmtQsdETwfnQmAj>)
2024-08-08 22159, 2024
bitmap[m]
yeah, we should probably die there (I think the controller will handle that correctly and show an error to the user, but should confirm that)
2024-08-08 22157, 2024
bitmap[m]
at least for email verification, for stuff like subscriptions we probably don't want to abort the whole process
2024-08-08 22132, 2024
Jade[m]
The request should always return 200 for bulk sending anyways
2024-08-08 22154, 2024
bitmap[m]
ah, right
2024-08-08 22122, 2024
Jade[m]
I think that should be everything for this week?
2024-08-08 22138, 2024
bitmap[m]
my initial test didn't send out an email but I almost definitely misconfigured things, I'll figure it out :)
When you have a minute, please let me know what you think of LB#2956 for multi-track-linking (deployed on https://test.listenbrainz.org/settings/missing-da…) I deviated from your plans on the associated ticket, which is signifcantly harder to implement. I wanted to try a simple version first :)
Jade: got the verification emails to send out from test.mb 🎉 but yeah, the strings are empty
2024-08-08 22154, 2024
bitmap[m]
regarding verification_link being a blessed object, it is indeed a URI instance, which makes sense now. URI should overload "" already, so stringifying it like "$verification_link" should be sufficient to work around that
2024-08-08 22139, 2024
Jade[m]
That's one of the first things I tried, but it seemed to result in an empty string 😕
2024-08-08 22137, 2024
minimal has quit
2024-08-08 22125, 2024
bitmap[m]
huh, it works for me 🤷♂️
2024-08-08 22139, 2024
bitmap[m]
the empty variables in the rendered mail seems to be on the Rust side of things though (since the to_name and verification_url parameters are being sent/received correctly)
2024-08-08 22126, 2024
Jade[m]
<bitmap[m]> "the empty variables in the..." <- I'll have a deeper look into it when I get an opportunity
2024-08-08 22129, 2024
bttf joined the channel
2024-08-08 22153, 2024
bttf
hi, i tried init'ing mbslave today but came across a sql constraint error. not sure how to resolve...
2024-08-08 22108, 2024
bttf
psycopg2.errors.CheckViolation: new row for relation "label" violates check constraint "label_label_code_check"
<04dieseltech> Was told to post here for my problem: I'm getting a 504 error when trying to view my profile on LB It seems people on the forums have this issue from time to time and someone clears out the cache on the backend for it to start working again If you wait long enough for the page to load this comes up
