yvanzo[m]: That we don't need to worry about 9.8 at all at the moment and can keep working to release what we have now
yvanzo[m]
we should just be cautious about using API v2 because there can be breaking changes in Solr 9.x releases.
bitmap[m]
<yvanzo[m]> "Did anyone test the mb-solr PR?s" <- I've built it now and that was successful at least (including creating the collections at the start) -- trying it with some data
I forgot that I can no longer run sir on my laptop since upgrading to PG v17 locally, as the version of psycopg2 used in the 2to3 branch doesn't support it (and I had issues trying to upgrade it).
yvanzo[m]
Using Docker allows to work around dependency issues on your host system.
BobSwift[m]
<reosarevok[m]> "wileyfoxyx, Bob Swift: does..." <- It's supposed to happen on a merge / push, but something must have broken when I transferred the repo to MetaBrainz. For now, I've been triggering a rebuild manually on RTD.
yvanzo[m]
bitmap, reosarevok : The Table Row Counts dashboard doesn’t seem to work for me: No data. Even though I created the database more than 5 minutes ago.
reosarevok[m]
Hmm. Does it show a specific error?
yvanzo[m]
No data.
bitmap[m]
yvanzo[m]: The sir repo does contain a Dockerfile, but it appears to be intended for production use and requires consul. I could probably override the entrypoint, but the Selenium test scripts can't work use it currently either
s/work//
yvanzo[m]
bitmap: I mean musicbrainz-docker
reosarevok[m]
yvanzo[m]: Can you see the logs for sql-exporter?
yvanzo[m]
How?
reosarevok[m]
It's a separate container, isn't it? Just checking the container logs should work
(well, I didn't need to for sql-exporter but it worked when I needed the grafana ones)
bitmap[m]
yvanzo: did you already have a musicbrainz-docker branch that points to the current mb-solr branch solr-9.7.0?
Apparently it gave up before I created the database.
I just restarted it.
level=ERROR source=postgres_exporter.go:681 msg="error scraping dsn" err="Error opening connection to database (postgres://musicbrainz:PASSWORD_REMOVED@db:5432/musicbrainz_db?sslmode=disable): pq: database \"musicbrainz_db\" does not exist" dsn="postgres://musicbrainz:musicbrainz@db:5432/musicbrainz_db?sslmode=disable"
reosarevok[m]
I do mean sql-exporter - that's separate :)
yvanzo[m]
(that was before)
reosarevok[m]
But that suggests there's an issue, yeah :D
yvanzo[m]
I don't have sql-exporter
reosarevok[m]
Huh. then it cannot show the data
yvanzo[m]
I started it.
Why didn’t it start then?
reosarevok[m]
I dunno, it has always started for me
yvanzo[m]
You didn’t make grafana container depend on it.
But that can be intended.
Please document how to start it.
reosarevok[m]
I literally have only ever started it by doing docker compose up -d
Which is how we start everything else :D
yvanzo[m]
I just up grafana.
BrainzGit
[listenbrainz-server] 14MonkeyDo merged pull request #3125 (03master…LB-1528): LB-1528: Added shortcut to today's date in Fresh Releases using a Calendar Icon https://github.com/metabrainz/listenbrainz-serv...
yvanzo[m]
when working on a specific container, I don't up the rest
reosarevok[m]
I mean, that's okay but that's not what the documentation says for starting the server :) So it's not surprising things don't work
yvanzo[m]
but again, doesn't matter if it is expected to up everything or some things only, just need to be documented.
monkey[m]
mayhem, lucifer: LB stats are currently borked, is it on your radar? I saw some discussion about failed jobs earlier so i was wondering if that's what it was
mayhem[m]
I assume this is collateral damage from the fight that lucifer is fighting with the dumps
bitmap[m]
reosarevok[m]: would it make sense to add the dependency between grafana and sql-exporter?
yvanzo[m]
reosarevok: Can the history of the count be shown instead of just the current count?
reosarevok[m]
I mean, I'm fine with adding the dependency if that seems useful, that's not a problem
It can, it's trivial, but what's the point? It's not like they change fast
That's why I specifically made it a gauge
Because having a graph seemed useless
But if you think it's not I can change it 🤷
yvanzo[m]
If you have to investigate what happened at a certain time, it would be useful to have it.
Which is mostly what we are looking for.
Just like the other dashboard actually.
It can be a separate dashboard too, if they have different goals.
reosarevok[m]
Ok, that's the default anyway, so sure - it just seemed like a waste of space to have 20 graphs, but I will change it back
Hmm
Actually
When you click the three dot menu on the gauge, then explore, do you get a graph?
It kinda seems it might be built in as a "go deeper" option anyway
holycow23[m] uploaded an image: (21KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/matrix.org/aoYARSnRzLFWWikVwneSQqYo/image.png >
holycow23[m]
* For the ticket LB-1722, and discussion we had does the below attached image look good to go?
s1b1 joined the channel
BobSwift[m]
reosarevok, wileyfoxyx: I've fixed the RTD setup so that the proof of concept site now updates automatically again when there is a merge / push in the GitHub repo.
wileyfoxyx[m]
rdswift: on, that's good then. It was updating automatically with my repo, though.
monkey[m]
holycow23: Looks good. Perhaps the phrasing "Link unmatched listens" or "Link unknown listens" would sound less redundant.
Might be good to check with the user who created the ticket, to get confirmation
holycow23[m]
Sure thing, will ask the user about the same
pite_ has quit
BobSwift[m]
mayhem, reosarevok, aerozol, wileyfoxyx: I started a page listing some questions that I think we might need to consider. There are about a bazillion more, but this is a start. Feel free to add or comment (I think I've opened it up so you can make edits). The list is at https://github.com/rdswift/musicbrainz-docs/wik...
wileyfoxyx[m]
rdswift: just added my notes. I think it'll be okay that I haven't put "wileyfoxyx agrees with that" to every note of yours in it.
q3lont has quit
q3lont joined the channel
vardhan_ joined the channel
vardhan has quit
q3lont has quit
bitmap[m]
yvanzo: I was able to successfully reindex the sample database after setting `MB_SOLR_VERSION` and copying over the necessary changes to docker-compose.yml too (for the volume location and startup command)
the only issue I had was the sir container crashing initially (and having to be manually started later) due to the search service not being available immediately
