I do know the solution, and it's just making a second line for more icons, but I need to actually set up an LB instance as it would require touching the react code
And right now I need to get more time for it
dseomn joined the channel
dseomn has quit
dseomn joined the channel
relaxo[m]
mayhem Hey, I want to improve onbording for FestivalGuide. This includes to simplify how the user can add artists. I have some Ideas:... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/...>)
More ideas and tips welcome :)
dseomn has quit
dseomn joined the channel
reosarevok[m]
aerozol, bitmap: https://github.com/metabrainz/musicbrainz-serve... can now be done on the new React page. I'm thinking, given the 300 release limit affects all searches (even the ones with results, possibly) should that info be shown all the time by the search field? Or should we still just show it on search failures?
dseomn_ joined the channel
bitmap[m]
<reosarevok[m]> "aerozol, bitmap: https://github..."; <- do you remember where that 300 release limit comes from? I'm surprised there's not any way to improve the performance of this (but I don't really remember discussing it either)
monkey[m]
<rustynova[m]> "Looking at the CSS, it gets..." <- > <@_discord_492790468321607681:chatbrainz.org> Looking at the CSS, it gets removed.
> Sad, as I use mobile brainzplayer a lot...
You got it, it currently gets removed on smaller screens. That is, until we finish LB#2940 for a proper BrainzPlayer mobile interface
No idea tbh - on the original ticket I had "Ideally this search would not have a limit at all, but that will probably cause timeouts?"
Because I assume that's why the limit was added
But maybe it's old and unneeded nowç
dseomn has quit
dseomn_ is now known as dseomn
monkey[m]
(That was for rustynova @_discord_492790468321607681:chatbrainz.org)
bitmap[m]
I searched for \W300\W under lib/ and didn't find anything
never mind, I'm guessing it
* guessing it's related to `$hard_search_limit += $limit * 3;`
Kladky has quit
suvid[m]
<aerozol[m]> "Great work suvid..." <- Thanks
Will try to contribute more :)
reosarevok[m]
bitmap: is the suggestion to try and remove the limit first then and see what happens?
bitmap[m]
reosarevok[m]: I guess it will be slow but I'd like to see if we can improve the query first (I don't recall looking into it). or maybe PG 16 improved things
reosarevok[m]
Ok, we can check
At the very least, we could maybe double the limit and that'd already make it very unlikely to hit issues I hope
Like, if you couldn't get it in the top 600, maybe it's on you
So maybe change to 600 and keep the message?
aerozol[m]
Hmm I don’t think I know enough about the search to weigh in sorry, and I don’t have the time atm to research/test a bunch of searches. If you two haven’t hashed something out by tomorrow, I’m free then :)
All I’ll ask is that extra text is tidy (and tucked away, maybe at the bottom, if it only affects something like 1/1000 searches)
+1 to putting “Like, if you couldn’t get it in the top 600, maybe it’s on you” into the text /s
dvirtz[m]
reosarevok, I went back to the sampled db. Quering the DB shows the data is there but entering a release relationship editor, I see that `MB.linkedEntities` is almost empty (only work_type is filled).
Debugging the client code, I see all the `/ws/js/type-info` requests return empty.