I do know the solution, and it's just making a second line for more icons, but I need to actually set up an LB instance as it would require touching the react code
2025-01-22 02215, 2025
rustynova[m]
And right now I need to get more time for it
2025-01-22 02248, 2025
dseomn joined the channel
2025-01-22 02227, 2025
dseomn has quit
2025-01-22 02200, 2025
dseomn joined the channel
2025-01-22 02219, 2025
relaxo[m]
mayhem Hey, I want to improve onbording for FestivalGuide. This includes to simplify how the user can add artists. I have some Ideas:... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/MYTvTVRZkCkmzvxlTeDEDbvd>)
2025-01-22 02234, 2025
relaxo[m]
More ideas and tips welcome :)
2025-01-22 02200, 2025
dseomn has quit
2025-01-22 02206, 2025
dseomn joined the channel
2025-01-22 02220, 2025
reosarevok[m]
aerozol, bitmap: https://github.com/metabrainz/musicbrainz-server/… can now be done on the new React page. I'm thinking, given the 300 release limit affects all searches (even the ones with results, possibly) should that info be shown all the time by the search field? Or should we still just show it on search failures?
2025-01-22 02238, 2025
dseomn_ joined the channel
2025-01-22 02244, 2025
bitmap[m]
<reosarevok[m]> "aerozol, bitmap: https://github..." <- do you remember where that 300 release limit comes from? I'm surprised there's not any way to improve the performance of this (but I don't really remember discussing it either)
2025-01-22 02259, 2025
monkey[m]
<rustynova[m]> "Looking at the CSS, it gets..." <- > <@_discord_492790468321607681:chatbrainz.org> Looking at the CSS, it gets removed.
2025-01-22 02259, 2025
monkey[m]
> Sad, as I use mobile brainzplayer a lot...
2025-01-22 02200, 2025
monkey[m]
You got it, it currently gets removed on smaller screens. That is, until we finish LB#2940 for a proper BrainzPlayer mobile interface
No idea tbh - on the original ticket I had "Ideally this search would not have a limit at all, but that will probably cause timeouts?"
2025-01-22 02243, 2025
reosarevok[m]
Because I assume that's why the limit was added
2025-01-22 02250, 2025
reosarevok[m]
But maybe it's old and unneeded nowç
2025-01-22 02206, 2025
dseomn has quit
2025-01-22 02206, 2025
dseomn_ is now known as dseomn
2025-01-22 02221, 2025
monkey[m]
(That was for rustynova @_discord_492790468321607681:chatbrainz.org)
2025-01-22 02222, 2025
bitmap[m]
I searched for \W300\W under lib/ and didn't find anything
2025-01-22 02253, 2025
bitmap[m]
never mind, I'm guessing it
2025-01-22 02201, 2025
bitmap[m]
* guessing it's related to `$hard_search_limit += $limit * 3;`
2025-01-22 02236, 2025
Kladky has quit
2025-01-22 02227, 2025
suvid[m]
<aerozol[m]> "Great work suvid..." <- Thanks
2025-01-22 02227, 2025
suvid[m]
Will try to contribute more :)
2025-01-22 02249, 2025
reosarevok[m]
bitmap: is the suggestion to try and remove the limit first then and see what happens?
2025-01-22 02204, 2025
bitmap[m]
reosarevok[m]: I guess it will be slow but I'd like to see if we can improve the query first (I don't recall looking into it). or maybe PG 16 improved things
2025-01-22 02225, 2025
reosarevok[m]
Ok, we can check
2025-01-22 02242, 2025
reosarevok[m]
At the very least, we could maybe double the limit and that'd already make it very unlikely to hit issues I hope
2025-01-22 02253, 2025
reosarevok[m]
Like, if you couldn't get it in the top 600, maybe it's on you
2025-01-22 02203, 2025
reosarevok[m]
So maybe change to 600 and keep the message?
2025-01-22 02216, 2025
aerozol[m]
Hmm I don’t think I know enough about the search to weigh in sorry, and I don’t have the time atm to research/test a bunch of searches. If you two haven’t hashed something out by tomorrow, I’m free then :)
2025-01-22 02204, 2025
aerozol[m]
All I’ll ask is that extra text is tidy (and tucked away, maybe at the bottom, if it only affects something like 1/1000 searches)
2025-01-22 02254, 2025
aerozol[m]
+1 to putting “Like, if you couldn’t get it in the top 600, maybe it’s on you” into the text /s
2025-01-22 02228, 2025
dvirtz[m]
reosarevok, I went back to the sampled db. Quering the DB shows the data is there but entering a release relationship editor, I see that `MB.linkedEntities` is almost empty (only work_type is filled).
2025-01-22 02228, 2025
dvirtz[m]
Debugging the client code, I see all the `/ws/js/type-info` requests return empty.
