#metabrainz

[listenbrainz-server] 14Advaitgaur004 opened pull request #3140 (03master…master): Improved Nginx Configuration to Address Critical Issues in Production Environments https://github.com/metabrainz/listenbrainz-serv...

I have been adding physical (cassette and vinyl) listens to LB lately, and it is KICKING ASS. The search is so fast, setting the start/end time is a piece of cake, and it displays the cover art from my version (or the rg if none) 🥰

reosarevok: btw dvirtz asked something just above but forgot to tag ya

Hey there, is there any issue tracker for listenbrainz-server !!

if yes do let me know

[listenbrainz-server] 14samglt opened pull request #3141 (03master…update-docs-stats-1): Fix doc build error https://github.com/metabrainz/listenbrainz-serv...

listenbrainz down?

listenbrainz is not displaying top artists,albums column

aerozol: I mentioned reosarevok at the beginning of my message, Isn't that tagging or must it followed by colon?

I think the point is matrix wants you yo specifically choose my user with @username

*to

@fettuccinae:matrix.org: did you just recently import listens/start listening? If so you might have to wait a bit for your stats to be calculated

<aerozol[m]> "@fettuccinae:matrix.org: did you..." <- ive been listening since dec 24, but its the same problem for other users too

Can confirm I've also noticed it being a sitewide issue

+1

good morning lucifer , looks we have some stats issues. ^^

@fettuccinae:matrix.org and lazybookwyrm : lucifer is working on making stats much more reliable, so bear with us please.

[listenbrainz-server] 14granth23 opened pull request #3142 (03master…Improved-Marks-Mapping): Improved marks mapping https://github.com/metabrainz/listenbrainz-serv...

BrainzGit: Hi, I made a little modification to the way the percentages were calculated to map the dates to the appropriate section of the page on the `/explore/fresh-releases/` page, please review it whenever possible.

<fettuccinae[m]> "image.png" <- this stats screenshot is correct because the range selected is last week, for current week's stats you need to select this week.

oh i see you mean, top artists/albums/tracks.

reosarevok (@_discord_1151240977378463764:chatbrainz.org), I didn't build materialized tables, could this be related?

[listenbrainz-server] 14mayhem closed pull request #3140 (03master…master): Improved Nginx Configuration to Address Critical Issues in Production Environments https://github.com/metabrainz/listenbrainz-serv...

dvirtz: not sure tbh, I can try and take a look in a bit, I can't imagine the materialized tables would be connected with link types tho

lucifer or monkey: are there known issues with last.fm imports? (see "Last.Fm import" at support)

Can you forward please?

Ah, I forgot you're not on support. Sure

dvirtz: I added MBS-13908 for the issue you found

MBS-13908: Right-to-left credit rendering still broken in medium edits https://tickets.metabrainz.org/browse/MBS-13908

monkey: sent :)

reosarevok: From that email, do you know the MB username? If not I'll write back, just wanted to check

PMd

[troi-recommendation-playground] 14mayhem opened pull request #164 (03main…CVE-2024-42471): Hopefully fix CVE-2024-42471 https://github.com/metabrainz/troi-recommendati...

OK, well, I think they were just impatient. Account created this morning, and now the LB profile has 370K listens imported from LFM, so I think it's working fine :)

Will write back

Yep, checks out with their lastfm history

2 listens missing out of 376.830 , that's a pretty good score

<relaxo[m]> "mayhem Hey, I want to improve..." <- hi! 1) yes. 2) yes 3). We're going to be creating release-release similarity soon. You could have the user select a few albums as seeds and then harvest artists from it and releases from similar releases. I find genres are not great for a primary discovery tool -- too messy.

dvirtz: for type-info, it might be a cache issue

Since it checks the cache first

You could try to empty the cache (was that redis flushall? I forget exactly) or just change the code in the meantime in Controller/WS/js.pm to skip the cache check

[troi-recommendation-playground] 14mayhem merged pull request #164 (03main…CVE-2024-42471): Hopefully fix CVE-2024-42471 https://github.com/metabrainz/troi-recommendati...

[listenbrainz-server] 14MonkeyDo merged pull request #3141 (03master…update-docs-stats-1): Fix doc build error https://github.com/metabrainz/listenbrainz-serv...

reosarevok (@_discord_1151240977378463764:chatbrainz.org) I actually thought about it and ran `./admin/PruneCache` but it didn't help.

I'll look at `redis flushall`

Worst case scenario just change unless (defined $response) { to unless (0) or something temporarily to re-load anyway, see if that does it

bitmap: I tested disabling `$use_hard_search_limit` entirely for a direct release search and I didn't notice it getting significantly worse, but I'm testing through a tunnel so not ideal conditions

That choice is 16 years old, anyway - possibly worth reconsidering

For now I rebased and reworded https://github.com/metabrainz/musicbrainz-serve... a bit for when no results are found

outsidecontext: did you see this one? https://github.com/metabrainz/listenbrainz-now-...

@zas: ping

* zas (IRC): : ping

pong

see stats age is null ?

that is invalid and should be raising an alert.

what is the best way to do that? I can catch it being null and set it to something else if that is easier.

English speakers, esp. aerozol: halp, the shedding doesn't let me bike https://github.com/metabrainz/musicbrainz-serve...

Any name suggestions are appreciated

mayhem: we disabled it for some reason, let me try to re-enable it -> see https://grafana.com/docs/grafana/latest/alertin...

mayhem: if you have the time and interest to suggest a name, sure :D

I'm fine with even naming it in German as long as we name it somehting :D

s/somehting/something/

okl no problem. Go for "rindfleischetikettierungsüberwachungsaufgabenübertragungsgesetz"

mayhem: we should get an alert in 3 mins

I guess that's the same thing for other *_age metrics right?

same what? not sure what you're asking.

I mean we should alert if no data for all *age metrics in LB alerts or just this one (stats_age)

[bookbrainz-user-guide] 14MonkeyDo opened pull request #20 (03master…update-theme): Update theme https://github.com/metabrainz/bookbrainz-user-g...

<zas[m]> "I mean we should alert if no..." <- all please.

ansh: monkey May i use beta or test for a little while?

mayhem: go for test

k

Green light 🟢

mayhem: done

thanks!

heads up: soon there will be a new value to monitor: global_stats_age .

Jigen (IRC)/MonkeyPython : I refreshed the BB style guide theme and some technical stuff, preview here for evaluation: https://bookbrainz-user-guide--20.org.readthedo...

monkey: I have completed the backend for the thank you feature

I need some help in its frontend part

it seems really confusing :(

also, how should it look like?

should i make a PR with a commit for backend and partial frontend that i tried to implement?

it would be easier for you to review in that way ig

* make a draft PR with

suvid: Yes, a PR (even if incomplete) is the best way for me to review. You can even create a draft PR if you prefer, or mark a PR as a draft.

Regarding the UI, the best plan of action is for you to make a visual mockup of the way you see the feature looking, before implementing it. This can mean either just putting buttons etc. on the page in dev, or using your browser devtools to modify the html on the fly to make a screenshot. Whatever works best for you

[listenbrainz-server] 14Suvid-Singhal opened pull request #3143 (03master…thanks): LB-1688 Feature to thank a user for a pin/recommendation https://github.com/metabrainz/listenbrainz-serv...

How can I lint my python code I pushed?

* python code that I pushed?

<reosarevok[m]> "bitmap: I tested disabling `$use..." <- a good route would be to print the query from Perl and run it directly on hendrix with `EXPLAIN ANALYZE`

[listenbrainz-server] 14mayhem opened pull request #3144 (03master…LB-1710): Add global stats monitoring endpoint https://github.com/metabrainz/listenbrainz-serv...

suvid: What is your code editor? You might be able to add a python linting extension.

I use VSCode, and this extension: https://marketplace.visualstudio.com/items?item...

I installed this extension

* this extension just now

lemme try saving the file and see

monkey[m]: seems like it is also not linting 🤔

suvid[m]: ctrl + shift + i to format the file

Or using the command palette, search for "format"

ok i did this and linting errors reduced

but 2-3 are still left

Manual fix then ?

Manually fixed the remaining issues

Sometimes it do be like that

Yeah

Pls review it whenever you get time 🙏

<monkey[m]> "suvid: Yes, a PR (even if..." <- I think we can use the same UI as that for the recommendation as that also has blurb_content

and make the event listenable

or should it be something different?

[musicbrainz-server] 14reosarevok merged pull request #2734 (03master…MBS-12708): MBS-12708: Report for lonely pseudo-releases https://github.com/metabrainz/musicbrainz-serve...

[musicbrainz-server] 14reosarevok merged pull request #2916 (03master…MBS-13035): MBS-13035: Better "no results" message for CDTOC release search https://github.com/metabrainz/musicbrainz-serve...

monkey[m]: that actually looks much clearer , you're right!

Not the one I had in mind and mentioned yesterday, but I found something similar

there are still improvements, probably ,but it's definitly better thna the previous!

👍️

I also changed readthedocs config to automatically build pull requests, meaning contributors can edit docs directly in github and get a preview of their changes without needing to code or run anything on their machine

hmm...

[listenbrainz-server] 14granth23 opened pull request #3145 (03master…LB-1727): LB1727: Filters for link listens page https://github.com/metabrainz/listenbrainz-serv...