[listenbrainz-server] 14Advaitgaur004 opened pull request #3140 (03master…master): Improved Nginx Configuration to Address Critical Issues in Production Environments https://github.com/metabrainz/listenbrainz-server…
2025-01-23 02350, 2025
aerozol[m]
I have been adding physical (cassette and vinyl) listens to LB lately, and it is KICKING ASS. The search is so fast, setting the start/end time is a piece of cake, and it displays the cover art from my version (or the rg if none) 🥰
2025-01-23 02313, 2025
aerozol[m]
reosarevok: btw dvirtz asked something just above but forgot to tag ya
2025-01-23 02317, 2025
advait004[m] joined the channel
2025-01-23 02318, 2025
advait004[m]
Hey there, is there any issue tracker for listenbrainz-server !!
BrainzGit: Hi, I made a little modification to the way the percentages were calculated to map the dates to the appropriate section of the page on the `/explore/fresh-releases/` page, please review it whenever possible.
2025-01-23 02346, 2025
lucifer[m]
@fettuccinae:matrix.org: what's your LB username?
2025-01-23 02316, 2025
lucifer[m]
<fettuccinae[m]> "image.png" <- this stats screenshot is correct because the range selected is last week, for current week's stats you need to select this week.
2025-01-23 02338, 2025
lucifer[m]
oh i see you mean, top artists/albums/tracks.
2025-01-23 02351, 2025
dvirtz[m]
reosarevok (@_discord_1151240977378463764:chatbrainz.org), I didn't build materialized tables, could this be related?
2025-01-23 02333, 2025
s1b1 joined the channel
2025-01-23 02302, 2025
SigHunter has quit
2025-01-23 02351, 2025
SigHunter joined the channel
2025-01-23 02328, 2025
BrainzGit
[listenbrainz-server] 14mayhem closed pull request #3140 (03master…master): Improved Nginx Configuration to Address Critical Issues in Production Environments https://github.com/metabrainz/listenbrainz-server…
2025-01-23 02314, 2025
reosarevok[m]
dvirtz: not sure tbh, I can try and take a look in a bit, I can't imagine the materialized tables would be connected with link types tho
2025-01-23 02318, 2025
reosarevok[m]
lucifer or monkey: are there known issues with last.fm imports? (see "Last.Fm import" at support)
OK, well, I think they were just impatient. Account created this morning, and now the LB profile has 370K listens imported from LFM, so I think it's working fine :)
2025-01-23 02302, 2025
monkey[m]
Will write back
2025-01-23 02307, 2025
monkey[m]
Yep, checks out with their lastfm history
2025-01-23 02302, 2025
monkey[m]
2 listens missing out of 376.830 , that's a pretty good score
2025-01-23 02331, 2025
mayhem[m]
<relaxo[m]> "mayhem Hey, I want to improve..." <- hi! 1) yes. 2) yes 3). We're going to be creating release-release similarity soon. You could have the user select a few albums as seeds and then harvest artists from it and releases from similar releases. I find genres are not great for a primary discovery tool -- too messy.
2025-01-23 02332, 2025
reosarevok[m]
dvirtz: for type-info, it might be a cache issue
2025-01-23 02343, 2025
reosarevok[m]
Since it checks the cache first
2025-01-23 02301, 2025
reosarevok[m]
You could try to empty the cache (was that redis flushall? I forget exactly) or just change the code in the meantime in Controller/WS/js.pm to skip the cache check
reosarevok (@_discord_1151240977378463764:chatbrainz.org) I actually thought about it and ran `./admin/PruneCache` but it didn't help.
2025-01-23 02311, 2025
dvirtz[m]
I'll look at `redis flushall`
2025-01-23 02320, 2025
reosarevok[m]
Worst case scenario just change unless (defined $response) { to unless (0) or something temporarily to re-load anyway, see if that does it
2025-01-23 02320, 2025
reosarevok[m]
bitmap: I tested disabling `$use_hard_search_limit` entirely for a direct release search and I didn't notice it getting significantly worse, but I'm testing through a tunnel so not ideal conditions
2025-01-23 02333, 2025
reosarevok[m]
That choice is 16 years old, anyway - possibly worth reconsidering
monkey: I have completed the backend for the thank you feature
2025-01-23 02308, 2025
suvid[m]
I need some help in its frontend part
2025-01-23 02308, 2025
suvid[m]
it seems really confusing :(
2025-01-23 02322, 2025
suvid[m]
also, how should it look like?
2025-01-23 02347, 2025
suvid[m]
should i make a PR with a commit for backend and partial frontend that i tried to implement?
2025-01-23 02355, 2025
suvid[m]
it would be easier for you to review in that way ig
2025-01-23 02301, 2025
suvid[m]
* make a draft PR with
2025-01-23 02332, 2025
monkey[m]
suvid: Yes, a PR (even if incomplete) is the best way for me to review. You can even create a draft PR if you prefer, or mark a PR as a draft.
2025-01-23 02332, 2025
monkey[m]
Regarding the UI, the best plan of action is for you to make a visual mockup of the way you see the feature looking, before implementing it. This can mean either just putting buttons etc. on the page in dev, or using your browser devtools to modify the html on the fly to make a screenshot. Whatever works best for you
suvid[m] uploaded an image: (62KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/matrix.org/flzKMOtCxabUkwpopzPWIMEC/image.png >
2025-01-23 02323, 2025
minimal joined the channel
2025-01-23 02341, 2025
bitmap[m]
<reosarevok[m]> "bitmap: I tested disabling `$use..." <- a good route would be to print the query from Perl and run it directly on hendrix with `EXPLAIN ANALYZE`
monkey[m]: that actually looks much clearer , you're right!
2025-01-23 02353, 2025
monkey[m]
Not the one I had in mind and mentioned yesterday, but I found something similar
2025-01-23 02349, 2025
Jigen
there are still improvements, probably ,but it's definitly better thna the previous!
2025-01-23 02307, 2025
monkey[m]
👍️
2025-01-23 02307, 2025
monkey[m]
I also changed readthedocs config to automatically build pull requests, meaning contributors can edit docs directly in github and get a preview of their changes without needing to code or run anything on their machine
