bitmap: I'm setting up cesaria (hendrix/jimmy replacement), it takes some time, I'm updating documents regarding zfs setup. Also I'm installing 24.04 on it, it requires few adjustments. The other server arrived too, I'll proceed after I finished with cesaria. Ping me when around, we need to ensure the config (especially zfs) is correct for main db.
Hi suvid, I looked into it a bit yesterday, but have no clue why the tests are hanging. I'll have to carve out more time to look into it deeper, but not sure when that will be.
2025-02-11 04245, 2025
monkey[m]
If you wan to try it yourself, my next step was going to be cloning your branch to a new testing branch, and commenting out or deleting server test files until I find the one that is making CI hang, to at least have an idea where to look.
2025-02-11 04245, 2025
monkey[m]
From the few logs lines we have, comparing with my local test output, I was going to start with listenbrainz/db/tests/test_user.py and see if that is the culprit.
2025-02-11 04228, 2025
eharris joined the channel
2025-02-11 04244, 2025
zas[m]
bitmap: yvanzo reosarevok mayhem : cesaria is fully configured. Since it runs on noble + zfs, setup is a bit special, so be careful, and report any issue. I couldn't get in touch with atj (any news from him?) and some parts of the zfs setup documentation weren't up-to-date.
2025-02-11 04205, 2025
zas[m]
I'm off for lunch. I'll proceed with next server after.
2025-02-11 04214, 2025
mayhem[m]
ok. (I haven't heard anything from atj all year. :( )
can you point me to the configs we need to look at?
2025-02-11 04241, 2025
monkey[m]
ansh: One question regarding the cover art endpoint: what was the reason for it being a POST endpoint again?
2025-02-11 04241, 2025
monkey[m]
I know we want an auth header because playlists can be private, but we can do that for a GET request too. Since we're not actually sending any data to that endpoint, I think it should probably be a GET
2025-02-11 04247, 2025
reosarevok[m]
ansh: sorry, missed the endpoint question earlier
2025-02-11 04245, 2025
reosarevok[m]
I think there's nothing rn for "top for a tag", but we could add it if you need it in LB
2025-02-11 04258, 2025
reosarevok[m]
bitmap: am I forgetting something we already have? Just in case :)
<reosarevok[m]> "I think there's nothing rn for..." <- Yes, that would probably simplify the new genre page he is working on. We were looking at the MB tag pages and the content they show, and the top 10 artists on that page seemed like the most interesting for a quick overview (this is in a sidebar with not much space, there is more info on the page).
2025-02-11 04224, 2025
minimal joined the channel
2025-02-11 04220, 2025
ansh[m]
<monkey[m]> "ansh: One question regarding the..." <- > <@monkey:chatbrainz.org> ansh: One question regarding the cover art endpoint: what was the reason for it being a POST endpoint again?
2025-02-11 04220, 2025
ansh[m]
> I know we want an auth header because playlists can be private, but we can do that for a GET request too. Since we're not actually sending any data to that endpoint, I think it should probably be a GET
2025-02-11 04220, 2025
ansh[m]
Yes, we can convert it into a GET endpoint
2025-02-11 04243, 2025
monkey[m]
Cool, thanks for confirming, I'm doing that in my incoming PR, just deployed it to test.LB
I was also working on the BS5 branch to update BB to v5
2025-02-11 04224, 2025
monkey[m]
Also using a published library.
2025-02-11 04241, 2025
monkey[m]
FWIW I think for LB the style are just copy-pasted
2025-02-11 04229, 2025
monkey[m]
Presumably because before I got on there was no front-end build system, just jinja templates
2025-02-11 04256, 2025
ansh[m]
So, can we use this directly in LB?
2025-02-11 04204, 2025
monkey[m]
Shouldn't be an issue I think. It should replace the css/theme folder we have, but we probably need to keep the variables.less file for example, maybe others.
2025-02-11 04204, 2025
monkey[m]
Then fix the first import in main.less to import from node_modules
[listenbrainz-server] 14MonkeyDo opened pull request #3171 (03master…playlist-card-images): LB-1748: Add playlist cover art on the playlist overview page https://github.com/metabrainz/listenbrainz-server…
2025-02-11 04228, 2025
aerozol[m]
<mayhem[m]> "https://bsky.app/profile/jukevox..." <- Ooh, will read and share
