<NishantKumar[m]> "bitmap: could you please give..." <- I don't have any real feedback to give at the moment, because there's no content to the proposal (it's mostly just phrases copied from the idea and ticket). it's important that you demonstrate an understanding of the issue and give technical details of how you will accomplish things. I'd suggest submitting a pull request for a small ticket first to demonstrate that you can work
Hmm, it's not necessarily better having to tweak these Unicode ranges instead of having access to the character classes. The above range will fail to remove any punctuation in the higher Unicode code points.
mayhem[m]
what is in the higher unicode points that would be missed?
kellnerd[m]
Try something like The Gold It’s in The… (apostrophe, ellipsis)
The syntax is different there: [:L*:] is equivalent to \p{Letter}
Maybe std::basic_regex also supports this syntax or something similar, I'd have to dig deeper...
mayhem[m]
kellnerd[m]: I would appreciate your help doing that.
I can try installing boost in the meantime.
monkey[m] updates beta.LB, then prod if all goes well
kellnerd[m]
It's hard to research this without having a C++ compiler at hand, but it seems to be possible to match non-ASCII letters with std::wregex according to [this example](https://en.cppreference.com/w/cpp/regex/regex_traits/lookup_classname. It might not help because it explicitly sets the locale to Japanese, not sure if that's necessary.
mayhem[m]
ok, if boost does the right thing, then I'll use that. ready to test in a bit.
monkey[m]
ansh: I see in sentry issues that the donation DB query is flagged as slow. Is there anything you can think of that would improve the situation? More aggressive caching, perhaps?
is that regex ok? because text is empty after that call.
auto r = boost::regex("[_ ]|[^[]:L*:]]+");
vardhan_ has quit
gives different results but the second half doesn't remove anything at all.
kellnerd[m]
It should probably be [^[:L*:]]
mayhem[m]
just that character class or the whole thing?
kellnerd[m]
just the char class
The whole thing can most likely be optimzed further once it is working.
mayhem[m]
auto r = boost::regex("[_ ]|[^[:L*:]]+");
KrishnaCosmic joined the channel
Invalid character class name, collating name, or character range. The error occurred while parsing the regular expression: '[_ ]|[^[:>>>HERE>>>L*:]]+'.
now getting linker errors. I'll return to this tomorrow. thanks for you help kellnerd
d4rk has quit
d4rk joined the channel
d4rk has quit
d4rk joined the channel
zas[m]
julian45: configs are in prometheus-exp project (we have 2 instances of grafana)
reosarevok[m]
<BANG>
Jigen
🐟️
reosarevok[m]
Welcome to another MetaBrainz Monday Meeting!
I don't seem to have any mailed in reviews today
Jigen
🐟️
reosarevok[m]
Everyone is here, then? Let's fin dout!
On my list for today: Gautam Shorewala, jasje, kellnerd, reosarevok, mayhem, julian45, yvanzo, ansh, monkey, MonkeyPython (Jigen (IRC) ), outsidecontext, zas, lucifer, bitmap, aerozol
Gautam Shorewala: the computer says go!
Jigen
:|
GautamShorewala[
Hi everyone
derat[m] joined the channel
derat[m]
reosarevok: me too
Jigen
hi!
GautamShorewala[
Last week worked on my gsoc proposal
Also worked on the huesound feature in in LB Android
yano has quit
That all from me
jasje: next?
reosarevok[m]
Still on my list for today: kellnerd, reosarevok, mayhem, julian45, yvanzo, ansh, monkey, MonkeyPython (Jigen (IRC) ), outsidecontext, zas, lucifer, bitmap, aerozol, derat
GautamShorewala[
kellnerd @kellnerd:matrix.org: maybe then?
kellnerd[m]
Hey there!
reosarevok[m]
Oh come on, jasje was just here :) Ok, yeah, go kellnerd
kellnerd[m]
Last week I did some final polishing and wrote a bit of documentation for the Harmony provider tests.
yano joined the channel
There's still work to do, but I've had enough of it for now, so I will call it a day with [this PR](https://github.com/kellnerd/harmony/pull/93) :)
Would love to have a second opinion before I merge if anyone can be bothered.
reosarevok[m]
Would you say it was... 😎 testing?
kellnerd[m]
That's it, go ansh!
KrishnaCosmic has quit
ansh[m] joined the channel
ansh[m]
Hi Everyone!
Jigen
:|
🐟️
🐟️
ansh[m]
Last week, I mainly focused on upgrading Bootstrap in LB
I spent a lot of time reviewing and testing PRs.
That's it for me
monkey: next?
monkey[m]
Hi everyone!
reosarevok[m]
Still on my list for today: jasje, reosarevok, mayhem, julian45, yvanzo, MonkeyPython (Jigen (IRC) ), outsidecontext, zas, lucifer, bitmap, aerozol, derat
monkey[m]
Last week I worked on finishing the mobile UI for LB, and refactoring other BrainzPlayer code
I thoroughly reviewed the Bootstrap4 migration PRs in progress
(tried to) fix an issue with DOMPurify after an update, but apparently that's still broken in the version I deployed today, so stay tuned...
d4rk has quit
Did a lot of PR reviewing, and welcomed and guided prospective GSOC participants
d4rk joined the channel
Had a meeting with the LB team
And that about sums it up. What about you Jigen (IRC) ?
Still on my list for today: jasje, mayhem, julian45, yvanzo, outsidecontext, zas, lucifer, bitmap, aerozol, derat
Hi!
Last week I was looking at our possible schema change tickets
I also added missing documentation for label types, updated a few PRs with some ugly UX components and bothered people with some taste to make them less hideous...
And dealt with some smaller tickets and some code review, plus the usual
jasje: hopefully not crashed again, go! :)
jasje[m]
Heh
Alive
For now
Jigen
ALIVE
jasje[m]
Last week was PR reviews
Went into minor UX and UI details while for PR reviews
Practice for me to post video recordings of anything broken
So we push quality✨
Apart from that fixed contributor prs
Thats it
mayhem: go
mayhem[m]
hi!
last week was ramping up GSoC work and loads and loads of hacking on the new MBID mapper.
we failed to hold a board meeting, because I didn't notice the US had already changed timezone, so it split the meeting. oops.
the meeting wasn't important, so we'll just skip it.
but, it was a lovely week coding. lots of coding, even if it is 3 steps forward 8 steps back.
fin. outsidecontext go!
reosarevok[m]
Still on my list for today: julian45, yvanzo, zas, lucifer, bitmap, aerozol, derat
