<NishantKumar[m]> "bitmap: could you please give..." <- I don't have any real feedback to give at the moment, because there's no content to the proposal (it's mostly just phrases copied from the idea and ticket). it's important that you demonstrate an understanding of the issue and give technical details of how you will accomplish things. I'd suggest submitting a pull request for a small ticket first to demonstrate that you can work
Hmm, it's not necessarily better having to tweak these Unicode ranges instead of having access to the character classes. The above range will fail to remove any punctuation in the higher Unicode code points.
2025-03-17 07635, 2025
mayhem[m]
what is in the higher unicode points that would be missed?
2025-03-17 07621, 2025
kellnerd[m]
Try something like The Gold It’s in The… (apostrophe, ellipsis)
The syntax is different there: [:L*:] is equivalent to \p{Letter}
2025-03-17 07643, 2025
kellnerd[m]
Maybe std::basic_regex also supports this syntax or something similar, I'd have to dig deeper...
2025-03-17 07605, 2025
mayhem[m]
kellnerd[m]: I would appreciate your help doing that.
2025-03-17 07611, 2025
mayhem[m]
I can try installing boost in the meantime.
2025-03-17 07628, 2025
monkey[m] updates beta.LB, then prod if all goes well
2025-03-17 07620, 2025
kellnerd[m]
It's hard to research this without having a C++ compiler at hand, but it seems to be possible to match non-ASCII letters with std::wregex according to [this example](https://en.cppreference.com/w/cpp/regex/…. It might not help because it explicitly sets the locale to Japanese, not sure if that's necessary.
2025-03-17 07601, 2025
mayhem[m]
ok, if boost does the right thing, then I'll use that. ready to test in a bit.
2025-03-17 07637, 2025
monkey[m]
ansh: I see in sentry issues that the donation DB query is flagged as slow. Is there anything you can think of that would improve the situation? More aggressive caching, perhaps?
is that regex ok? because text is empty after that call.
2025-03-17 07627, 2025
mayhem[m]
auto r = boost::regex("[_ ]|[^[]:L*:]]+");
2025-03-17 07632, 2025
vardhan_ has quit
2025-03-17 07658, 2025
mayhem[m]
gives different results but the second half doesn't remove anything at all.
2025-03-17 07642, 2025
kellnerd[m]
It should probably be [^[:L*:]]
2025-03-17 07610, 2025
mayhem[m]
just that character class or the whole thing?
2025-03-17 07626, 2025
kellnerd[m]
just the char class
2025-03-17 07656, 2025
kellnerd[m]
The whole thing can most likely be optimzed further once it is working.
2025-03-17 07614, 2025
mayhem[m]
auto r = boost::regex("[_ ]|[^[:L*:]]+");
2025-03-17 07615, 2025
KrishnaCosmic joined the channel
2025-03-17 07635, 2025
mayhem[m]
Invalid character class name, collating name, or character range. The error occurred while parsing the regular expression: '[_ ]|[^[:>>>HERE>>>L*:]]+'.
now getting linker errors. I'll return to this tomorrow. thanks for you help kellnerd
2025-03-17 07634, 2025
d4rk has quit
2025-03-17 07659, 2025
d4rk joined the channel
2025-03-17 07601, 2025
d4rk has quit
2025-03-17 07625, 2025
d4rk joined the channel
2025-03-17 07625, 2025
zas[m]
julian45: configs are in prometheus-exp project (we have 2 instances of grafana)
2025-03-17 07652, 2025
reosarevok[m]
<BANG>
2025-03-17 07659, 2025
Jigen
🐟️
2025-03-17 07606, 2025
reosarevok[m]
Welcome to another MetaBrainz Monday Meeting!
2025-03-17 07652, 2025
reosarevok[m]
I don't seem to have any mailed in reviews today
2025-03-17 07602, 2025
Jigen
🐟️
2025-03-17 07604, 2025
reosarevok[m]
Everyone is here, then? Let's fin dout!
2025-03-17 07647, 2025
reosarevok[m]
On my list for today: Gautam Shorewala, jasje, kellnerd, reosarevok, mayhem, julian45, yvanzo, ansh, monkey, MonkeyPython (Jigen (IRC) ), outsidecontext, zas, lucifer, bitmap, aerozol
2025-03-17 07655, 2025
reosarevok[m]
Gautam Shorewala: the computer says go!
2025-03-17 07608, 2025
Jigen
:|
2025-03-17 07608, 2025
GautamShorewala[
Hi everyone
2025-03-17 07612, 2025
derat[m] joined the channel
2025-03-17 07612, 2025
derat[m]
reosarevok: me too
2025-03-17 07615, 2025
Jigen
hi!
2025-03-17 07633, 2025
GautamShorewala[
Last week worked on my gsoc proposal
2025-03-17 07653, 2025
GautamShorewala[
Also worked on the huesound feature in in LB Android
2025-03-17 07605, 2025
yano has quit
2025-03-17 07617, 2025
GautamShorewala[
That all from me
2025-03-17 07627, 2025
GautamShorewala[
jasje: next?
2025-03-17 07643, 2025
reosarevok[m]
Still on my list for today: kellnerd, reosarevok, mayhem, julian45, yvanzo, ansh, monkey, MonkeyPython (Jigen (IRC) ), outsidecontext, zas, lucifer, bitmap, aerozol, derat
2025-03-17 07620, 2025
GautamShorewala[
kellnerd @kellnerd:matrix.org: maybe then?
2025-03-17 07632, 2025
kellnerd[m]
Hey there!
2025-03-17 07633, 2025
reosarevok[m]
Oh come on, jasje was just here :) Ok, yeah, go kellnerd
2025-03-17 07618, 2025
kellnerd[m]
Last week I did some final polishing and wrote a bit of documentation for the Harmony provider tests.
Would love to have a second opinion before I merge if anyone can be bothered.
2025-03-17 07610, 2025
reosarevok[m]
Would you say it was... 😎 testing?
2025-03-17 07610, 2025
kellnerd[m]
That's it, go ansh!
2025-03-17 07627, 2025
KrishnaCosmic has quit
2025-03-17 07632, 2025
ansh[m] joined the channel
2025-03-17 07633, 2025
ansh[m]
Hi Everyone!
2025-03-17 07645, 2025
Jigen
:|
2025-03-17 07650, 2025
Jigen
🐟️
2025-03-17 07651, 2025
Jigen
🐟️
2025-03-17 07654, 2025
ansh[m]
Last week, I mainly focused on upgrading Bootstrap in LB
2025-03-17 07601, 2025
ansh[m]
I spent a lot of time reviewing and testing PRs.
2025-03-17 07605, 2025
ansh[m]
That's it for me
2025-03-17 07605, 2025
ansh[m]
monkey: next?
2025-03-17 07615, 2025
monkey[m]
Hi everyone!
2025-03-17 07635, 2025
reosarevok[m]
Still on my list for today: jasje, reosarevok, mayhem, julian45, yvanzo, MonkeyPython (Jigen (IRC) ), outsidecontext, zas, lucifer, bitmap, aerozol, derat
2025-03-17 07647, 2025
monkey[m]
Last week I worked on finishing the mobile UI for LB, and refactoring other BrainzPlayer code
2025-03-17 07615, 2025
monkey[m]
I thoroughly reviewed the Bootstrap4 migration PRs in progress
2025-03-17 07649, 2025
monkey[m]
(tried to) fix an issue with DOMPurify after an update, but apparently that's still broken in the version I deployed today, so stay tuned...
2025-03-17 07649, 2025
d4rk has quit
2025-03-17 07610, 2025
monkey[m]
Did a lot of PR reviewing, and welcomed and guided prospective GSOC participants
2025-03-17 07614, 2025
d4rk joined the channel
2025-03-17 07626, 2025
monkey[m]
Had a meeting with the LB team
2025-03-17 07643, 2025
monkey[m]
And that about sums it up. What about you Jigen (IRC) ?
Still on my list for today: jasje, mayhem, julian45, yvanzo, outsidecontext, zas, lucifer, bitmap, aerozol, derat
2025-03-17 07657, 2025
reosarevok[m]
Hi!
2025-03-17 07643, 2025
reosarevok[m]
Last week I was looking at our possible schema change tickets
2025-03-17 07642, 2025
reosarevok[m]
I also added missing documentation for label types, updated a few PRs with some ugly UX components and bothered people with some taste to make them less hideous...
2025-03-17 07614, 2025
reosarevok[m]
And dealt with some smaller tickets and some code review, plus the usual
2025-03-17 07629, 2025
reosarevok[m]
jasje: hopefully not crashed again, go! :)
2025-03-17 07635, 2025
jasje[m]
Heh
2025-03-17 07638, 2025
jasje[m]
Alive
2025-03-17 07646, 2025
jasje[m]
For now
2025-03-17 07646, 2025
Jigen
ALIVE
2025-03-17 07656, 2025
jasje[m]
Last week was PR reviews
2025-03-17 07638, 2025
jasje[m]
Went into minor UX and UI details while for PR reviews
2025-03-17 07601, 2025
jasje[m]
Practice for me to post video recordings of anything broken
2025-03-17 07624, 2025
jasje[m]
So we push quality✨
2025-03-17 07658, 2025
jasje[m]
Apart from that fixed contributor prs
2025-03-17 07600, 2025
jasje[m]
Thats it
2025-03-17 07615, 2025
jasje[m]
mayhem: go
2025-03-17 07619, 2025
mayhem[m]
hi!
2025-03-17 07644, 2025
mayhem[m]
last week was ramping up GSoC work and loads and loads of hacking on the new MBID mapper.
2025-03-17 07621, 2025
mayhem[m]
we failed to hold a board meeting, because I didn't notice the US had already changed timezone, so it split the meeting. oops.
2025-03-17 07632, 2025
mayhem[m]
the meeting wasn't important, so we'll just skip it.
2025-03-17 07658, 2025
mayhem[m]
but, it was a lovely week coding. lots of coding, even if it is 3 steps forward 8 steps back.
2025-03-17 07609, 2025
mayhem[m]
fin. outsidecontext go!
2025-03-17 07618, 2025
reosarevok[m]
Still on my list for today: julian45, yvanzo, zas, lucifer, bitmap, aerozol, derat
