oh right... i'm here. anyway, i went to fix the caps and didn't get disc 4 because the new warning message isn't showing up on it. i was going to fix it and thought someone ought to look at it before i do...
vardhan joined the channel
Kladky joined the channel
iconoclasthero has quit
iconoclasthero joined the channel
reosarevok[m]
iconoclasthero: we only do a few cases with the least false positives (“and”, “of”, “or”, “to”, and “the”)
"A" has a lot of false positives because of classical A keys, "By" is in a fair bunch of compound verbs
(if you changed it to "To Be Loved By The You" then it would trigger)
The message is just to teach/remind newbies that capitalization guidelines are a thing, not to always remind you to use them :)
vardhan has quit
iconoclasthero
@reosarevok[m] so here's the thing, it came up for discs 1-3 and if you look there's overlap on the titles including "How Sweet It Is (To Be Loved by You)" up on disc 1 or 2, but that warning banner isn't popping for disc 4.
so i don't understand why, if it's the same songs, it wouldn't pop for disc 4.
but if it's the indended behavior then i'll let it go.
reosarevok[m]
"It Takes a Lot to Laugh, It Takes a Train to Cry" had "To"
I expect it came up for 1 and 3 then but not 2 and 4
derat: if you put up the PR for the extra bubbles today I might be able to get it in one last beta update before freeze
(if not, next time is fine)
derat[m] joined the channel
derat[m]
reosarevok: if you and aerozol are happy with the current strings, i can probably do it today (haven't looked at the code yet, but hopefully not too different from the last one). there are a few unresolved comments in the doc, but nothing major, i guess
reosarevok[m]
Yeah it felt fairly ready
derat[m]
reosarevok: would the change need to be merged today, or just up for review today? :-) if it's the former, it might be better to wait. i already ran into one weird issue with the recording form where all of the bubbles are getting aligned at the top of the form instead of next to their fields; might take me some time to figure out what's different there
reosarevok[m]
I was thinking today or tomorrow morning but that sounds non trivial
So sure. Let's take it calmly :)
derat[m]
sounds good. this will also hopefully inspire me to move the code for initializing bubbles for external links somewhere else so it doesn't get duplicated all over the place :-)
ApeKattQuest joined the channel
ApeKattQuest has quit
ApeKattQuest joined the channel
mayhem[m]
zas: I've not forgotten mingus. I've been copying over what I saved so far and its now taken over 24 hours, lol. I guess that is to be expected when copying 1.2M files
iconoclasthero has quit
iconoclasthero[m
I guess it's possible that I thought there was the banner on 2 and it wasn't there. anyway. done now.
derat[m]
reosarevok: this issue with bubble positions in the recording form is weird. i think you can already see it in prod at https://musicbrainz.org/recording/create -- if you focus the "ISRCs" input, the bubble appears at the top of the form instead of to the right of the input (it's also missing its tail).
it seems like the jQuery positioning code in `BubbleDoc` in root/static/scripts/edit/MB/Control/Bubble.js isn't working on this page. i don't see any obvious differences between the recording form and e.g. the release-group form, though, and the `control` and `$parent` variables seem like they're set correctly. any guesses, based on the symptoms?
> This plugin extends jQuery's built-in `.position()` method. If jQuery UI is not loaded, calling the `.position()` method may not fail directly, as the method still exists. However, the expected behavior will not occur.
importing ../../lib/jquery.ui/ui/jquery-ui.custom.js in root/static/scripts/recording/edit.js fixes it. no clue whether that's the best way to handle this or if it'll cause other problems, though
it might make more sense to add the jquery-ui import to root/static/scripts/edit/MB/Control/Bubble.js, since that's where the .position() call lives
derat[m]
reosarevok: i'll actually upload a PR soon, if you want to try to get the rest of the updated doc bubbles into beta. i'll probably punt on updating all of the "type" doc bubbles, since i didn't realize that most of those (all except the RG ones, i think) already use the existing `typeBubble()` function that displays descriptions from the DB with a generic `Select any type from the list to see its description. If the entity doesn’t
seem to match any type, just leave this blank.` placeholder. i might try to update that to support entity-specific placeholders, but probably best to save that for a followup change
reosarevok: i'm going to head out soon. if the two strings suggested on the PR sound okay, let me know and i'll upload that version. (feel free to make any other changes that are needed!)
reosarevok[m]
derat: the strings seem good. I asked bitmap to take a look about the checkbox but we can certainly add it later if non-trivial
derat: just making sure - you're not changing anything else on that PR now right?
I'll merge if so
derat[m]
Nope, I'm done and AFK!
reosarevok[m]
Thanks!
_BrainzGit
[musicbrainz-server] 14reosarevok merged pull request #3531 (03master…still_more_bubbles): MBS-13980: Add recording, RG, series, and work bubbles (II) https://github.com/metabrainz/musicbrainz-serve...
