reosarevok: let me know when you have a couple of minutes for some MB schema/data use questions.
2025-05-19 13925, 2025
reosarevok[m]
If it's a couple minutes and doesn't need a keyboard, now is fine, mayhem:
2025-05-19 13953, 2025
mayhem[m]
you will need a keyboard, I believe. not urgent, but in the course of the day would be great.
2025-05-19 13923, 2025
mayhem[m]
zas: on pypi.org we previously didn't have an organization, just an account called metabrainz. we now have an organization where the members can each have their own login. I've moved all my projects over into the new org -- should picard be moved as well?
2025-05-19 13946, 2025
mayhem[m]
lucifer: same for mb-rngpy -- should that be transferred?
2025-05-19 13910, 2025
lucifer[m]
mayhem: yes
2025-05-19 13947, 2025
zas[m]
outsidecontext: ^^ about pypi
2025-05-19 13903, 2025
mayhem[m]
lucifer[m]: done
2025-05-19 13904, 2025
derat[m] has quit
2025-05-19 13920, 2025
lucifer[m]
mayhem: have you added me to the org too?
2025-05-19 13928, 2025
mayhem[m]
next step
2025-05-19 13909, 2025
mayhem[m]
remind me of your pypi account name, lucifer "lucifermorningstar"?
2025-05-19 13936, 2025
mayhem[m]
outsidecontext: same for you -- is your handle the usual?
2025-05-19 13942, 2025
lucifer[m]
techmorningstar
2025-05-19 13903, 2025
mayhem[m]
lucifer[m]: invited as owner.
2025-05-19 13928, 2025
reosarevok[m]
<mayhem[m]> "you will need a keyboard, I..." <- Ok, I'm traveling in Spain but I'll get the laptop out when I get back to the car then
2025-05-19 13900, 2025
mayhem[m]
reosarevok[m]: you're traveling on schema change day? brave!
2025-05-19 13911, 2025
mayhem[m]
when are you scheduled to be at a keyboard?
2025-05-19 13957, 2025
monkey[m] joined the channel
2025-05-19 13958, 2025
monkey[m]
mshahnawaz1: Responding to your message here regarding LB-1761, let's do tech discussions in here :)
2025-05-19 13958, 2025
monkey[m]
Since we have two different set of filters, I assume yes you will need to store them separately, using the `pageType` somewhere in the storage key name. I think that will probably be easier and more flexible than other options (some common settings, then two more type-specific settings separate).
2025-05-19 13958, 2025
monkey[m]
Regarding how you storage values refresh I can't do anything for you without any info, so why don't you open a draft PR with the code you have so I can have a look?
mglubb: we haven't broken anything yet, have we???
2025-05-19 13936, 2025
mayhem[m]
also, welcome!
2025-05-19 13923, 2025
mglubb[m] joined the channel
2025-05-19 13923, 2025
mglubb[m]
Ha! No! I've been looking at SIR and was wondering whether you'd be migrating (or have already migrated) to Python 3 as part of this release?
2025-05-19 13924, 2025
mshahnawaz1[m] joined the channel
2025-05-19 13924, 2025
mshahnawaz1[m]
Ok thanks, I will create the draft PR
2025-05-19 13952, 2025
mayhem[m]
mglubb[m]: lucifer: yvanzo : this one is for you two.
2025-05-19 13909, 2025
mayhem[m]
(I want to say that yes, py3 is happening, but lets get confirmation)
2025-05-19 13956, 2025
outsidecontext[m joined the channel
2025-05-19 13956, 2025
outsidecontext[m
mayhem: my handle on pypi is the usual "phw". yes, let's move picard as well
2025-05-19 13959, 2025
mayhem[m]
invited as manager.
2025-05-19 13901, 2025
mayhem[m]
and picard moved. all of our projects are now under the metabrainz foundation org.
2025-05-19 13948, 2025
rayyan_seliya123 joined the channel
2025-05-19 13948, 2025
rayyan_seliya123
monkey: I’ve updated the search components to expose the reset function through the imperative handle, and I’m now calling `searchInputRef.current?.reset()` from the parent after each submission. This seems to be working well it clears both the input and the search results just like we wanted. see the latest
rayyan_seliya123: Nice work! Will reveiw the PR again, just give me some time :)
2025-05-19 13954, 2025
rayyan_seliya123
monkey[m]: No worries ☺️ ! Okk 👍
2025-05-19 13912, 2025
outsidecontext[m
mayhem: btw, a few days ago I wrote jonnyJD about the python-discid package. Because Picard uses it and it hasn't seen activity from his side I think generally it would be good if we get this package also into the metabrainz org. I haven't heard back yet (not sure whether the email I have is still current). Let's see.
2025-05-19 13945, 2025
mayhem[m]
sure, let me know what needs doing when the times comes.
mayhem: do you have time today to review the dumps pr?
2025-05-19 13922, 2025
mayhem[m]
Let me do that now
2025-05-19 13933, 2025
lucifer[m]
thanks!
2025-05-19 13905, 2025
mayhem[m]
wait, was this the PR where you asked if I took a cursory look before you tested something?
2025-05-19 13916, 2025
lucifer[m]
yes
2025-05-19 13936, 2025
mayhem[m]
ah, I didn't realize that now needed the full review. I missed that message.
2025-05-19 13951, 2025
lucifer[m]
it refactors dumps code including private dumps so i haven't tested it in prod yet
2025-05-19 13926, 2025
mayhem[m]
for listenbrainz/dumps/tables.py should I take the time to go through the tables/columns table by table, column by column to make sure there are no discrepancies?
2025-05-19 13942, 2025
mayhem[m]
approved, but happy to double check all the tables/columns if you think that should be done.
2025-05-19 13918, 2025
lucifer[m]
those are mostly copied, except for wrapping in Composable/Literal as needed.
2025-05-19 13935, 2025
mayhem[m]
lucifer: last thing for now on @fettuccinae:matrix.org 's PR ( https://github.com/metabrainz/metabrainz.org/pull… ) -- that PR is ready for merging and in theory should not conflict with production for now. I think we can merge this PR, but future PRs may not be so clean.
2025-05-19 13916, 2025
mayhem[m]
would it be good to add a "approved PRs" branch for @fettuccinae:matrix.org 's work that we merge at the end of the project? what are your thoughts?
2025-05-19 13933, 2025
lucifer[m]
i think its fine to merge.
2025-05-19 13938, 2025
lucifer[m]
in master directly.
2025-05-19 13917, 2025
lucifer[m]
but if you prefer we can make an approved branch and deploy that to test.meb.org until the project is completed.
2025-05-19 13953, 2025
lucifer[m]
on second thought, yeah let's do that would be useful if we need to change the schema later for some reason.
2025-05-19 13913, 2025
mayhem[m]
@fettuccinae:matrix.org: I've created a new empty branch that will serve as the "holding pen" for all of your approved PRs: metabrainz-notifications
2025-05-19 13930, 2025
mayhem[m]
Can you please update your PR and have it target metabrainz-notifications, rather than master?
2025-05-19 13944, 2025
mayhem[m]
and then future PRs, should all attempt to merge into metabrainz-notifications, ok?
2025-05-19 13957, 2025
mayhem[m]
then at the end of the project we merge metabrainz-notifications into master and release the whole thing.
2025-05-19 13959, 2025
fettuccinae[m] joined the channel
2025-05-19 13959, 2025
fettuccinae[m]
<mayhem[m]> "Can you please update your PR..." <- Yes, on it
[metabrainz.org] 14fettuccinae opened pull request #505 (03metabrainz-notifications…notification-table): Add notification table and user preference table https://github.com/metabrainz/metabrainz.org/pull…
2025-05-19 13945, 2025
_BrainzGit
[metabrainz.org] 14fettuccinae closed pull request #505 (03metabrainz-notifications…notification-table): Add notification table and user preference table https://github.com/metabrainz/metabrainz.org/pull…
@fettuccinae:matrix.org: merged. well done on the first PR!
2025-05-19 13931, 2025
fettuccinae[m]
mayhem[m]: thank you.
2025-05-19 13951, 2025
mayhem[m]
do you need anything for your next steps? let me know!
2025-05-19 13959, 2025
fettuccinae[m]
mayhem[m]: will do!
2025-05-19 13950, 2025
mshahnawaz1[m]
I have created the draft PR, check it out when you have time.
2025-05-19 13949, 2025
bitmap[m]
mayhem, lucifer: hello, are there any LB cron jobs that depend on musicbrainz_db and would need to be paused?
2025-05-19 13903, 2025
bitmap[m]
(that can be done in the next hour if they take <1hr to run)
2025-05-19 13909, 2025
lucifer[m]
yes, i'll stop the cron jobs.
2025-05-19 13921, 2025
mayhem[m]
lucifer[m]: let me know if you'd like some help
2025-05-19 13927, 2025
lucifer[m]
will the postgres cluster be unavailable during the upgrade?
2025-05-19 13941, 2025
bitmap[m]
no, we won't be stopping PG
2025-05-19 13909, 2025
lucifer[m]
should I also disable LB's access to MB db?
2025-05-19 13915, 2025
lucifer[m]
for the duration of the upgrade.
2025-05-19 13925, 2025
mayhem[m]
yes
2025-05-19 13932, 2025
lucifer[m]
cool
2025-05-19 13929, 2025
mayhem[m]
<lucifer[m]> "suvid @fettuccinae:matrix.org..." <- here is the information for the GSoC Student welcome zoom session:... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/VAPBiEDCVjAbOMXLRCxpXvDl>)
2025-05-19 13946, 2025
mayhem[m]
please let me know that you got this link, thanks!
2025-05-19 13925, 2025
fettuccinae[m]
mayhem: In my local setup of metabrainz, for me to access some of oauth's endpoint (/client/list, /authorize etc), login is required. musicbrainz_server_session cookies are being used to verify user's credentials[login.py](https://github.com/metabrai…, but these cookies are secure so localhost isnt able to access them and i have to inject them
2025-05-19 13925, 2025
fettuccinae[m]
manually. is there a way to access these endpoints without manually setting session cookies?
2025-05-19 13923, 2025
lucifer[m]
@fettuccinae:matrix.org: you'll need to stub out those methods locally and return a hardcoded user object for local testing.
