#metabrainz

/

      • yvanzo[m]
        yes, that is a known issue
      • 2025-05-20 14047, 2025

      • yvanzo[m]
        Now sir is erroring on Solr disconnection…
      • 2025-05-20 14052, 2025

      • lucifer[m]
        oh, i wasn't aware of that.
      • 2025-05-20 14036, 2025

      • bitmap[m]
        yvanzo: would it make sense to release musicbrainz-docker without the search changes for now?
      • 2025-05-20 14005, 2025

      • yvanzo[m]
        bitmap: yes, thus the branch mbdb30-legacy-solr7
      • 2025-05-20 14041, 2025

      • yvanzo[m]
        Successfully imported release! :)
      • 2025-05-20 14001, 2025

      • bitmap[m]
        thanks! didn't see you were already on that
      • 2025-05-20 14017, 2025

      • bitmap[m]
      • 2025-05-20 14013, 2025

      • yvanzo[m]
        bitmap: Can you please provide the timestamp for the packet 177010?
      • 2025-05-20 14057, 2025

      • bitmap[m]
        yvanzo[m]: 2025-05-19 17:03:33.534972+00
      • 2025-05-20 14009, 2025

      • yvanzo[m]
        Thank you!
      • 2025-05-20 14008, 2025

      • _BrainzGit
        [sir] 14yvanzo merged pull request #164 (03master…fix-id-delete): doc_id for pysolr.delete should be a string https://github.com/metabrainz/sir/pull/164
      • 2025-05-20 14005, 2025

      • lucifer[m]
        artist core shows 2x speedup in indexing after patch, running it for all cores now.
      • 2025-05-20 14040, 2025

      • _BrainzGit
        [musicbrainz-docker] 14yvanzo merged pull request #299 (03master…eaa-dump): Fetch the event-art-archive dump https://github.com/metabrainz/musicbrainz-docker/…
      • 2025-05-20 14013, 2025

      • yvanzo[m]
        lucifer: running sir?
      • 2025-05-20 14020, 2025

      • lucifer[m]
        yes
      • 2025-05-20 14024, 2025

      • lucifer[m]
        on trille.
      • 2025-05-20 14029, 2025

      • yvanzo[m]
        I was doing that too.
      • 2025-05-20 14056, 2025

      • yvanzo[m]
        Ok, I stopped mine.
      • 2025-05-20 14009, 2025

      • davic has quit
      • 2025-05-20 14016, 2025

      • lucifer[m]
        oh
      • 2025-05-20 14010, 2025

      • yvanzo[m]
        Only artist, recording, and url are left.
      • 2025-05-20 14049, 2025

      • yvanzo[m]
        (plan: if we can smoothly reindex artist & url, then we can start reindexing recording)
      • 2025-05-20 14005, 2025

      • lucifer[m]
        sounds good
      • 2025-05-20 14011, 2025

      • yvanzo[m]
        lucifer: In my experience, reindexing artist may fail after 10-20min, keep me informed.
      • 2025-05-20 14028, 2025

      • lucifer[m]
        yvanzo: artist succeeded for me in 10mins.
      • 2025-05-20 14045, 2025

      • yvanzo[m]
        In mb-docker you mean? Yes.
      • 2025-05-20 14050, 2025

      • lucifer[m]
        it used to take 20 mins before today's fix.
      • 2025-05-20 14056, 2025

      • yvanzo[m]
        I mean in production.
      • 2025-05-20 14000, 2025

      • lucifer[m]
        these numbers are for trille.
      • 2025-05-20 14002, 2025

      • lucifer[m]
        yes.
      • 2025-05-20 14011, 2025

      • lucifer[m]
        ah okay
      • 2025-05-20 14011, 2025

      • yvanzo[m]
        Oh, ok, an mb-docker on trille.
      • 2025-05-20 14028, 2025

      • lucifer[m]
        yes
      • 2025-05-20 14037, 2025

      • yvanzo[m]
        Again, the main issue is with our main instance, not with mb-docker, even though that is nice to have some improvements.
      • 2025-05-20 14039, 2025

      • davic joined the channel
      • 2025-05-20 14048, 2025

      • lucifer[m]
        sorry for the confusion, i am currently not running anything in production.
      • 2025-05-20 14006, 2025

      • lucifer[m]
        i wanted to test my fix before deploying it to prod. hence testing it on mb docker to confirm no regressions.
      • 2025-05-20 14036, 2025

      • lucifer[m]
      • 2025-05-20 14006, 2025

      • lucifer[m]
        this is the branch, i can build an image and deploy it to prod if you feel its fine
      • 2025-05-20 14038, 2025

      • _BrainzGit
        [sir] 14amCap1712 opened pull request #165 (03master…defer-column-property): Improve deferred loading https://github.com/metabrainz/sir/pull/165
      • 2025-05-20 14050, 2025

      • yvanzo[m]
        I will try it right away.
      • 2025-05-20 14000, 2025

      • lucifer[m]
        great
      • 2025-05-20 14005, 2025

      • yvanzo[m]
        (just patching the container)
      • 2025-05-20 14019, 2025

      • yvanzo[m]
        I guess that it is partly amending #160.
      • 2025-05-20 14042, 2025

      • lucifer[m]
        yes, the gid was accessed by one of the convert function but not added to searchpaths so it would have led to multiple sql queries. it was caught by the raiseloads adding in the new pr.
      • 2025-05-20 14002, 2025

      • lucifer[m]
        s/adding/added/
      • 2025-05-20 14011, 2025

      • reosarevok[m]
        Oh, ok
      • 2025-05-20 14032, 2025

      • reosarevok[m]
        I wasn't sure if it was needed because a lot of things seemed to be missing from there
      • 2025-05-20 14011, 2025

      • reosarevok[m]
        I think in the end I added some but didn't even think about track medium
      • 2025-05-20 14020, 2025

      • lucifer[m]
        yeah its not very intuitive, that's why added i the raiseload to catch these errors.
      • 2025-05-20 14044, 2025

      • _BrainzGit
        [sir] 14amCap1712 closed pull request #154 (03master…raiseload): SEARCH-688 (I): Use raiseload in query loading options https://github.com/metabrainz/sir/pull/154
      • 2025-05-20 14045, 2025

      • BrainzBot
        SEARCH-688: Improve performance and track regressions https://tickets.metabrainz.org/browse/SEARCH-688
      • 2025-05-20 14038, 2025

      • texke has quit
      • 2025-05-20 14005, 2025

      • Kladky_ joined the channel
      • 2025-05-20 14042, 2025

      • nbin_ joined the channel
      • 2025-05-20 14002, 2025

      • Kladky has quit
      • 2025-05-20 14002, 2025

      • nbin has quit
      • 2025-05-20 14003, 2025

      • Kladky_ is now known as Kladky
      • 2025-05-20 14021, 2025

      • _BrainzGit
        [musicbrainz-docker] 14yvanzo opened pull request #305 (03master…mbdb30-legacy-solr7): Upgrade MB DB schema version to 30 and downgrade Solr version to 7 https://github.com/metabrainz/musicbrainz-docker/…
      • 2025-05-20 14024, 2025

      • _BrainzGit
        [musicbrainz-docker] 14yvanzo opened pull request #306 (03master…mbdb30-solr9): Upgrade MB DB schema version to 30, search, and requirements https://github.com/metabrainz/musicbrainz-docker/…
      • 2025-05-20 14041, 2025

      • _BrainzGit
        [metabrainz.org] 14fettuccinae opened pull request #506 (03metabrainz-notifications…notification-table): Add required endpoints for notifications (and for digest settings). https://github.com/metabrainz/metabrainz.org/pull…
      • 2025-05-20 14055, 2025

      • yvanzo[m]
        lucifer: Reindexing artist in production still is disconnected by Solr after some time. Trying again with lower solr.batch_size (100).
      • 2025-05-20 14008, 2025

      • lucifer[m]
        yvanzo: any error logs?
      • 2025-05-20 14023, 2025

      • yvanzo[m]
        It claims to have successfully imported it though!
      • 2025-05-20 14035, 2025

      • texke joined the channel
      • 2025-05-20 14046, 2025

      • yvanzo[m]
        lucifer: https://gist.github.com/yvanzo/07d4befbe9f0a8a741… (it was called with `reindex --entity-type artist`)
      • 2025-05-20 14053, 2025

      • yvanzo[m]
        Just a glitch I guess.
      • 2025-05-20 14003, 2025

      • yvanzo[m]
        bitmap: I opened a PR for each option ^
      • 2025-05-20 14028, 2025

      • yvanzo[m]
        Currently reindexing url, only recording will be left after that.
      • 2025-05-20 14056, 2025

      • lucifer[m]
        that will take ~45-50 mins i think.
      • 2025-05-20 14037, 2025

      • lucifer[m]
        i couldn't test recording on trille because it hasn't been updated to latest schema change yet.
      • 2025-05-20 14049, 2025

      • yvanzo[m]
        I will test that on hip.
      • 2025-05-20 14002, 2025

      • lucifer[m]
        thanks
      • 2025-05-20 14000, 2025

      • bitmap[m]
        <yvanzo[m]> "bitmap: I opened a PR for each..." <- thanks! there was an existing PR at https://github.com/metabrainz/musicbrainz-docker/… too. I think we should delegate these tasks more clearly next time to avoid duplicating our efforts
      • 2025-05-20 14014, 2025

      • _BrainzGit
        [musicbrainz-docker] 14mwiencek closed pull request #303 (03master…schema-change-2025-q2): Provisioning for the v-2025-05-19.0-schema-change version https://github.com/metabrainz/musicbrainz-docker/…
      • 2025-05-20 14058, 2025

      • lucifer[m]
        bitmap: when you are done with MB release, can you please look at https://github.com/metabrainz/docker-server-confi… ?
      • 2025-05-20 14006, 2025

      • lucifer[m]
        we should probably redeploy sir with that soon, it might help debug the solr connection issues.
      • 2025-05-20 14012, 2025

      • lucifer[m]
        yvanzo: before indexing recording in prod, can you please change the logging level to debug? we have some debug logs already in the solr submission code which might help see how many, if any, documents are not being indexed?
      • 2025-05-20 14055, 2025

      • bitmap[m]
        lucifer[m]: will do, sorry for the delay
      • 2025-05-20 14004, 2025

      • lucifer[m]
        no worries, thanks!
      • 2025-05-20 14010, 2025

      • bitmap[m]
        er, that was in reply to the previous message
      • 2025-05-20 14046, 2025

      • bitmap[m]
        is sentry.metabrainz.org already pointing to the new instance?
      • 2025-05-20 14013, 2025

      • lucifer[m]
        the new instance is at metabrainz-foundation-inc.sentry.io
      • 2025-05-20 14052, 2025

      • lucifer[m]
        sentry.metabrainz.org will be retired eventually.
      • 2025-05-20 14033, 2025

      • bitmap[m]
        ah, because MBS stopped receiving events recently, so I wondered if they allowed custom domains and it was moved over or something
      • 2025-05-20 14011, 2025

      • lucifer[m]
        yeah i noticed that it stopped receiving events and i am puzzled too because it exists and should be working normally.
      • 2025-05-20 14048, 2025

      • lucifer[m]
        but then this has happened in the past twice and the only recourse was to soft or hard reset the instance.
      • 2025-05-20 14055, 2025

      • yvanzo[m]
        lucifer: Can pass the debug flag but it will slow it down even more. (url is still being indexed atm.)
      • 2025-05-20 14044, 2025

      • lucifer[m]
        yvanzo: yes fair point. we can update sentry config alternatively.
      • 2025-05-20 14008, 2025

      • lucifer[m]
      • 2025-05-20 14055, 2025

      • lucifer[m]
        you can patch the config in the container directly i guess until the PR is deployed.
      • 2025-05-20 14058, 2025

      • yvanzo[m]
        lucifer: 24min until importing url errored with solr disconnection.
      • 2025-05-20 14002, 2025

      • lucifer[m]
        i see
      • 2025-05-20 14048, 2025

      • yvanzo[m]
        I will try again with lower batch_size and debug flag.
      • 2025-05-20 14052, 2025

      • lucifer[m]
        can you point me to the solr 9 nodes? want to see if there is anything useful in solr server logs.
      • 2025-05-20 14057, 2025

      • yvanzo[m]
        I checked mb-solrcloud-7 logs and found out that someone is looking for an album named “Glitches Errors and Crashes”…
      • 2025-05-20 14010, 2025

      • lucifer[m]
        lol
      • 2025-05-20 14052, 2025

      • yvanzo[m]
        It is the leader for the url collection and did receive a lot of POST /solr/url_… queries.
      • 2025-05-20 14023, 2025

      • yvanzo[m]
        Started reindexing url with both debug and the new dsn.
      • 2025-05-20 14026, 2025

      • yvanzo[m]
        zas: should we check haproxy logs preferably for this connection issue?
      • 2025-05-20 14015, 2025

      • zas[m]
        Which issue?
      • 2025-05-20 14035, 2025

      • zas[m]
        504s?
      • 2025-05-20 14053, 2025

      • yvanzo[m]
        SIR got sometimes disconnected from Solr when reindexing stuff.
      • 2025-05-20 14010, 2025

      • yvanzo[m]
        Last time was at 2025-05-20 19:04:22,399 (running from rakim).
      • 2025-05-20 14037, 2025

      • yvanzo[m]
        (UTC)
      • 2025-05-20 14021, 2025

      • zas[m]
        Weird, what is the exact error you get? logs look normal to me on haproxy side on solr 1
      • 2025-05-20 14018, 2025

      • yvanzo[m]
        pysolr.SolrError: Failed to connect to server at https://solrcloud-privileged.metabrainz.org/solr/…: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))
      • 2025-05-20 14047, 2025

      • yvanzo[m]
        bitmap: docker compose release notes are up for review
      • 2025-05-20 14058, 2025

      • zas[m]
        What does sir in this case? I guess the connection was refused because the node was too busy
      • 2025-05-20 14021, 2025

      • lucifer[m]
        submits a batch of documents to the solr node for indexing.
      • 2025-05-20 14038, 2025

      • zas[m]
        It should retry after a delay, and do few attempts before giving up
      • 2025-05-20 14012, 2025

      • lucifer[m]
        yeah i was checking the same whether pysolr the library we use for making these api calls does that or not
      • 2025-05-20 14031, 2025

      • zas[m]
        since indexes update use quite a lot of resources on solr nodes, connections are maintained during a long time, which increase the risk of reaching limits (250 simultaneous connections per node)
      • 2025-05-20 14015, 2025

      • zas[m]
      • 2025-05-20 14039, 2025

      • zas[m]
        that's due to sir for sure
      • 2025-05-20 14006, 2025

      • yvanzo[m]
        It is running atm
      • 2025-05-20 14021, 2025

      • yvanzo[m]
        (since 19:21 UTC)
      • 2025-05-20 14027, 2025

      • zas[m]
        so basically you should decrease the rate of sir queries, in order to let nodes enough resources to process updates
      • 2025-05-20 14036, 2025

      • dseomn has quit
      • 2025-05-20 14036, 2025

      • yvanzo[m]
        Will do that for the next attempt by decreasing the number of import threads.
      • 2025-05-20 14002, 2025

      • dseomn joined the channel
      • 2025-05-20 14025, 2025

      • yvanzo[m]
        Thank you for having looked into it.
      • 2025-05-20 14044, 2025

      • zas[m]
      • 2025-05-20 14055, 2025

      • zas[m]
        the problem is that sir updates are quite heavy, because each update leads to sync between nodes
      • 2025-05-20 14031, 2025

      • bitmap[m]
        <yvanzo[m]> "bitmap: docker compose release..." <- after step 5, can we add something like this?
      • 2025-05-20 14031, 2025

      • bitmap[m]
        > 6. This is an optional step. If you had previously [built materialized tables](https://github.com/metabrainz/musicbrainz…, a few of them have to be rebuilt:
      • 2025-05-20 14031, 2025

      • bitmap[m]
        > sudo docker-compose exec musicbrainz bash -c 'carton exec -- ./admin/BuildMaterializedTables --database=MAINTENANCE recording_first_release_date artist_release artist_release_group'
      • 2025-05-20 14058, 2025

      • bitmap[m]
        looks good to me otherwise, though I haven't tested them
      • 2025-05-20 14020, 2025

      • yvanzo[m]
        OK, I'm about to test that.
      • 2025-05-20 14044, 2025

      • yvanzo[m]
        Can you please update the blog post draft accordingly meanwhile?
      • 2025-05-20 14013, 2025

      • bitmap[m]
        I just fixed the git tags for MBS and MB docker, removed the Indexed Search section, and added the list of translators from ./po/list_translators v-2025-05-05.0...production
      • 2025-05-20 14045, 2025

      • bitmap[m]
        I think it looks good now
      • 2025-05-20 14046, 2025

      • yvanzo[m]
        lucifer: stopping your mb docker instance on trille, for schema change tests.
      • 2025-05-20 14052, 2025

      • lucifer[m]
        sure
      • 2025-05-20 14005, 2025

      • dseomn has quit
      • 2025-05-20 14025, 2025

      • dseomn joined the channel
      • 2025-05-20 14042, 2025

      • Jade[m] has quit
      • 2025-05-20 14037, 2025

      • yvanzo[m]
        url successfully imported in 44min, got disconnected two times only.
      • 2025-05-20 14038, 2025

      • _BrainzGit
        [sir] 14amCap1712 opened pull request #166 (03defer-column-property…solr-retry): Add retry-enabled requests session for Solr connections https://github.com/metabrainz/sir/pull/166
      • 2025-05-20 14027, 2025

      • lucifer[m]
        yvanzo: i haven't been able to test this yet but if might be useful for recording core ^
      • 2025-05-20 14007, 2025

      • yvanzo[m]
        bitmap: Got this from running `upgrade-db-schema.sh`:... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/CaoXmpukWAgqmwwTktNhIhky>)
      • 2025-05-20 14036, 2025

      • yvanzo[m]
        bitmap: Does this issue come from the prebuilt image?
      • 2025-05-20 14043, 2025

      • bitmap[m]
        yvanzo: looks like it's running the schema 29 upgrade from last year
      • 2025-05-20 14004, 2025

      • bitmap[m]
        is DB_SCHEMA_SEQUENCE up to date?
      • 2025-05-20 14050, 2025

      • yvanzo[m]
        No
      • 2025-05-20 14035, 2025

      • yvanzo[m]
        I'm rebuilding a new image.
      • 2025-05-20 14026, 2025

      • Kladky has quit
      • 2025-05-20 14023, 2025

      • yvanzo[m]
        Started reindexing recording with solr-retry patch.
      • 2025-05-20 14041, 2025

      • yvanzo[m]
        Running db upgrade in newly prebuilt mb image…