#metabrainz

<lucifer> "rayyan_seliya123: you can push..." <- Hey lucifer: I have pushed the latest changes on that pr waiting for your review to move ahead !

julian45: hey! today is the day I check in with you about the test VM we made a few weeks back. still need it?

<mayhem[m]> "julian45: hey! today is the..." <- hey! i think i need it for 1 more week, and then we can probably get rid of it. would that work for you?

rayyan_seliya123, suvid, m.amanullah7 will answer your questions later today.

mayhem: gentle reminder about similarity data.

on it. (very soon anyways)

Hey guys, I'm working on joining release_first_release_date on release to determine the earliest released track. This is what SQL script I have so far:... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/...>)

s/released track/release/

Do the release ids have any significance? I am thinking to just stick to the one with the lowest release id. But to me that makes the whole join process irrelevant.

If the date is the same, by definition any of them are equally earliest :)

Heya, I won't be at the meeting today, being on holiday :)

Release ids will just depend on what was added first, which has nothing to do with the actual date

If you don't really care about earliest as such but want a canonical release for each group, the LB people have code for that

mayhem: ^

But that's a different thing of course :)

Jade: enjoy!

reosarevok[m]: Thank you ❤️

Yeah, I guess you're right, it's the "earliest" release and there can be multiple "earliest" releases. I am just trying to decide how to find the "best" earliest release.

I'm thinking if I combine the two processes, get the "earliest" releases, then see what was added first (by release ID), it'll be satisfactory. But I'll be happy to look into the "canonical release" determination code as well

bitmap: do you know if there's any real reason we don't show ACs in duplicates? (MBS-14065)

MBS-14065: Show artist credits in release editor duplicates tab https://tickets.metabrainz.org/browse/MBS-14065

<reosarevok[m]> "If you don't really care about..." <- See this blog post: https://blog.metabrainz.org/2023/06/12/new-data...

Thanks guys! ❤️

loving this open project

bitmap, zas, outsidecontext: not sure what changes we need to do for MBS-14062 - maybe you know more about it? (I'm not sure why it shouldn't work when allowing it, but that's what the ticket claims)

MBS-14062: Tagger link on tag lookup no longer works with Chrome's local network access restrictions https://tickets.metabrainz.org/browse/MBS-14062

reosarevok: not sure, I also think it should work once permission was granted. I can test

I looked into this recently for my magic tagger button user script. There it still works without prompt due to user scripts having different permissions

But it generally looked like the normal button on the page should work once granted

This is more or less the same issue than with Safari right? Do we really need the Tagger button ? I know it's convenient but it is more and more a problem it seems

I think safari is different

reosarevok: the difference between https://musicbrainz.org/taglookup and the other pages is that everywhere else the tagger buttons have a click event and the call to the local networks is controlled by scripting. That makes Chrome show the prompt to grant access. On taglookup it is just a link and Chrome disallows the navigation.

Actually reloading that page then works (but this is not pretty anyway)

So the fix would be to enable the script handling of the tagger buttons on the taglookup page as well

Ok, I wonder if it's a React vs TT thing

I'll check

lucifer: labs.api is running quite slowly -- the similarity data takes eons to return, making eval hard. are there some missing indexes, perhaps?

hey, is there a way to populate the cover_art_archive schema after setting up the musicbrainz-server? I am currently retrieving cover art using the CAA API and caching it. Wondering if I could just populate the schema and not need to query the API anymore

outsidecontext: I don't have Picard installed here - what's the link you get when tag-lookuping from Picard?

Does it have the ?tport=8000 bit or? (any example works)

reosarevok: I think it is not possible to directly open the taglookup page from within Picard. But yes, there are multiple cases where Picard can open a MB website, and it will always append the `tport` parameter

e.g. this https://musicbrainz.org/search/textsearch?limit...

Hmm, ok - I thought that page was made specifically to use it from Picard :D

AFAICT the same code is used for tagger everywhere, weird

reosarevok: I was wrong. Looking up clusters uses the taglookup page. Such as https://musicbrainz.org/taglookup?artist=Savana...

reosarevok: and the code in both cases includes the click handler?

Checking

https://github.com/metabrainz/musicbrainz-serve... the handler is defined inside TaggerIcon which is what the search uses...

outsidecontext: what search has links that fail for you in taglookup? Release? Recording? Both?

(and the same do not fail for normal not tag-lookup searches?)

reosarevok: they behave both the same

on taglookup they are just html links, on search pages and elsewhere they have the click handlers

but you should be able to reproduce this. it's independent of browser

also no need for picard

for the working case, open https://musicbrainz.org/search/textsearch?limit... . Look at the network tab of the developer tools, then click on a tagger button. You should see a request to http://127.0.0.1:8000/openalbum?...

for the broken case open https://musicbrainz.org/taglookup/index?tag-loo...

when clicking on the tagger button the browser will navigate to the the local address

Hmm,ok, yeah, I see the difference

Now, where does it come from :)

buildTaggerLink always returns http://127.0.0.1:${tport}/${path}?id=${gid}

Aaah

The hydration is missing for the taglookup code, heh

I think anyway. Let me test locally

Yeah. Trivial fix. Thanks!

[musicbrainz-server] 14reosarevok opened pull request #3573 (03master…MBS-14062): MBS-14062: Add TaggerIcon manifest to TagLookup results https://github.com/metabrainz/musicbrainz-serve...

MBS-14062: Tagger link on tag lookup no longer works with Chrome's local network access restrictions https://tickets.metabrainz.org/browse/MBS-14062

bitmap: ^ if you can review that when around we can put it in beta later today