Hi jasje , for fetching music apps during onboarding, I was planning to query apps based on the below intents.... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/CDzQpGeSSRkjhrmycLSWmnBf>)
2025-06-19 17013, 2025
jasje[m] joined the channel
2025-06-19 17013, 2025
jasje[m]
I think you can also use category that is provided by playstore and merge the two results
2025-06-19 17027, 2025
jasje[m]
Whether or not use likes to scrobble yt songs
2025-06-19 17046, 2025
jasje[m]
We need to give them an option
2025-06-19 17009, 2025
jasje[m]
But that option should be lower in the hierarchy
2025-06-19 17025, 2025
jasje[m]
This can be resolved via category tag
2025-06-19 17040, 2025
jasje[m]
s/scrobble/listen/
2025-06-19 17004, 2025
jasje[m]
* likes to listen/scrobble yt
2025-06-19 17017, 2025
jasje[m]
* Whether or not use likes to listen/scrobble yt videos
2025-06-19 17059, 2025
jasje[m]
* the hierarchy when list the apps
2025-06-19 17011, 2025
lusciouslover has quit
2025-06-19 17012, 2025
HemangMishra[m]
Okay, I'll work on using category tags and will get back to you.
2025-06-19 17011, 2025
d4rk-ph0enix joined the channel
2025-06-19 17013, 2025
HemangMishra[m]
<jasje[m]> "I think you can also use..." <- Can you please clarify what you mean by 'category provided by playstore'? Are u referring to Android's `ApplicationInfo.category` or actual Play Store categories like 'Music & Audio', 'Entertainment' that we might have to fetch using some third party apis, or maybe something else entirely?
2025-06-19 17016, 2025
dabeglavins60721 has quit
2025-06-19 17058, 2025
HemangMishra[m]
<HemangMishra[m]> "Can you please clarify what..." <- Also for YouTube specifically - should I show it as a separate toggle option with explanation text, or just categorize it differently but let users decide normally
2025-06-19 17053, 2025
pite has quit
2025-06-19 17014, 2025
HemangMishra[m] uploaded an image: (1090KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/matrix.org/YJOxemeNvUepyvFQcvDpjGpT/image.png >
2025-06-19 17009, 2025
jasje[m]
<HemangMishra[m]> "Also for YouTube specifically..." <- AppInfo
2025-06-19 17047, 2025
HemangMishra[m]
jasje[m]: So for that we will have to fetch all installed apps to check the category right?
2025-06-19 17048, 2025
HemangMishra[m]
HemangMishra[m]: I was trying to avoid this approach because google treats installed apps as personal info so might be a trouble in playstore.
HemangMishra[m]: My current approach only requires these queries in Manifest.... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/ShIVMKyVRWOkmRJzFBmhrBUO>)
lucifer, monkey: is this likely to be about LB? In support: `My profile, [X], tries to load and I see it for a second, then there's an error page regarding an "invalid video id".`
2025-06-19 17040, 2025
reosarevok[m]
It doesn't specify further, but I can't imagine that'd be MB, so
2025-06-19 17009, 2025
suvid[m] joined the channel
2025-06-19 17009, 2025
suvid[m]
Hi lucifer... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/HavSkJsHAjLAZNeYSmweEWzt>)
2025-06-19 17026, 2025
suvid[m]
I will commit changes after this and I think it should be ready to be merged then
2025-06-19 17027, 2025
suvid[m]
After this, I will proceed with zip file processing for Spotify
2025-06-19 17027, 2025
suvid[m]
I think I will write tests after completing the Spotify imports completely and then start with other services as they should be simpler to implement
2025-06-19 17031, 2025
suvid[m]
* Hi lucifer... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/VjaOspHuRgPKeYHMxfebNDEJ>)
2025-06-19 17028, 2025
lucifer[m]
[@suvid:matrix.org](https://matrix.to/#/@suvid:matrix.org) if it is used at only one place, you can move it to the file where import APIs are defined.
2025-06-19 17029, 2025
lucifer[m]
[@reosarevok:chatbrainz.org](https://matrix.to/#/@reosarevok:chatbrainz.org) it's a lb issue, and looking into it.
2025-06-19 17036, 2025
suvid[m]
lucifer[m]: Sorry, I didn't get it
2025-06-19 17033, 2025
lucifer[m]
suvid: have you pushed the latest changes? i think the PR is not updated yte
2025-06-19 17049, 2025
suvid[m]
yes I have pushed the changes
2025-06-19 17005, 2025
suvid[m]
<lucifer[m]> "[@suvid:matrix.org](https://..." <- I have not done this yet tho
2025-06-19 17005, 2025
suvid[m]
Apart from this, all my changes are pushed
2025-06-19 17021, 2025
lucifer[m]
the import_files API should be removed.
2025-06-19 17058, 2025
lucifer[m]
Oh i see, you removed the API from the other file. nevermind.
2025-06-19 17026, 2025
suvid[m]
yes
2025-06-19 17027, 2025
suvid[m]
working on the changes now 🫡
2025-06-19 17039, 2025
lucifer[m]
i think you had missed a couple of changes i mentioned in the first review so i have added more detailed comment explaining it again.
2025-06-19 17035, 2025
lucifer[m]
suvid: i see, where the confusion came from about using listens_importer table instead of background_tasks and related changes, `user_data_export` works differently because its standalone. but listens importer and external service oauth tables are used in multiple other places and context hence the changes i suggested
2025-06-19 17046, 2025
lucifer[m]
let's focus on building the rest of the importer and zip file processing etc for now.
2025-06-19 17031, 2025
lucifer[m]
the main thing to consider about the APIs is how to present the import progress to the user and we can discuss that with monkey later.
2025-06-19 17006, 2025
mamanullah7[m]
lucifer: is there any review on my pr!! yesterday some test failed which were passed before i think after merging master branch! if u can once review! in `MusicServices.tsx` i need to add `currentUser` which i was using in `auth_header`
2025-06-19 17024, 2025
lucifer[m]
m.amanullah7: you can get the `current_user` from `useContext`, check other files for example.
when that is merged, you can merge master into your branch to fix it
2025-06-19 17056, 2025
suvid[m]
<lucifer[m]> "let's focus on building the rest..." <- oh
2025-06-19 17056, 2025
suvid[m]
I was thinking of making a separate PR for rest of the importer
2025-06-19 17056, 2025
suvid[m]
separate from this one
2025-06-19 17006, 2025
suvid[m]
or should I just commit further in this only??
2025-06-19 17007, 2025
suvid[m]
s/??/?/
2025-06-19 17014, 2025
lucifer[m]
one PR is fine for now.
2025-06-19 17030, 2025
rayyan_seliya123
lucifer: have u reviewd that pr ?!
2025-06-19 17022, 2025
mamanullah7[m] sent a export code block: https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/lFPhtsSIswrjEGztnWStIHVr
2025-06-19 17021, 2025
Maxr1998 joined the channel
2025-06-19 17016, 2025
Maxr1998_ has quit
2025-06-19 17013, 2025
lucifer[m]
rayyan_seliya123: in general changes look fine to me, a couple of minor comments. i will take a look at IA and indexing to review the rest of the parts.
2025-06-19 17023, 2025
rayyan_seliya123
Thanks lucifer for the feedback : i have just seen your review comments , i have proposed some changes in the reviewed comments u can have a look and do confirm me that they are fine ? also waiting for your detailed feedback on my models tables , migrations and all ..and love to move forward to the api phase!!
2025-06-19 17051, 2025
lucifer[m]
rayyan_seliya123: yes, i'll finish reviewing your PR today and let you know what to do next.
monkey[m] uploaded an image: (32KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/wQduyUkzxDVkaRIeEpHabkZi/image.png >
2025-06-19 17022, 2025
monkey[m]
We will probably want a different set of details to show, but I think we should standardize in this type of UI
2025-06-19 17055, 2025
lucifer[m]
yes that's possible but my question more is, do we want to show historical imports?
2025-06-19 17044, 2025
lucifer[m]
or and if we need file import was completed sort of status.
2025-06-19 17050, 2025
lucifer[m]
rayyan_seliya123: reviewed your PR, after reviewing IA data and library. i feel the model needs to be changed and the way you fetch the metadata.
2025-06-19 17051, 2025
lucifer[m]
m.amanullah7: can you push the latest changes to the PR? I'll test it out locally
2025-06-19 17052, 2025
lucifer[m]
monkey: i am wondering how to show the import status for services that do not have an entry in the music services page.
2025-06-19 17019, 2025
monkey[m]
Right, I see.
2025-06-19 17005, 2025
lucifer[m]
need to think 3 cases in my opinion, 1. file imports for services other than in music service page. 2. file imports for services present there. 3. status when file import for say spotify with live listen ingestion enabled as well.
2025-06-19 17013, 2025
monkey[m]
I suppose we should have kept that /settings/import page after all, maybe add a "coming soon" placeholder.
2025-06-19 17013, 2025
monkey[m]
I think that would be the palce for both the file uploads and showing historical imports
2025-06-19 17002, 2025
monkey[m]
I suppose the data we would want to show for each import is number of imported listens, and first and last timestamp
2025-06-19 17019, 2025
monkey[m]
And original filename + service
2025-06-19 17022, 2025
lucifer[m]
yes makes sense
2025-06-19 17044, 2025
lucifer[m]
do you think for spotify, it makes sense to show the import status for those files in both places?
2025-06-19 17045, 2025
monkey[m]
I'm not sure I completely follow points 2 and 3. Do you think we shuold treat them differently?
2025-06-19 17055, 2025
monkey[m]
Ah, I see
2025-06-19 17005, 2025
lucifer[m]
should we show the import status for spotify on music services page too?
2025-06-19 17018, 2025
monkey[m]
Right right, let me think.
2025-06-19 17025, 2025
lucifer[m]
if the user has not conencted spotify otherwise that is.
2025-06-19 17056, 2025
lucifer[m]
i think if we can make it amply clear that the music services page is for ongoing imports and other connections and /import for one time imports.
2025-06-19 17056, 2025
mamanullah7[m]
lucifer: okay i'll push `currentUser` one now only thing is left and i'm working on integration of fw in bp i'll pushed that by 1-2 days!
2025-06-19 17006, 2025
lucifer[m]
it makes sense to separate the two.
2025-06-19 17028, 2025
monkey[m]
No, I think probably best to keep them separate and treat them separately. Probably have a note for users looking to import their extended history, pointing to the import page
2025-06-19 17039, 2025
lucifer[m]
yup that's what i had in mind.
2025-06-19 17057, 2025
monkey[m]
Sorry, the leading "no" was before I read your message. We agree :)
2025-06-19 17007, 2025
lucifer[m]
okay cool.
2025-06-19 17029, 2025
monkey[m]
Same would go for LFM, we have the connect-service option and a note for file imports
2025-06-19 17046, 2025
lucifer[m]
suvid: hi! let me know when you are around. we'll need to do some of the api/tables. apologies in advance for not thinking this through in advance.
2025-06-19 17047, 2025
monkey[m]
Linking to the import page
2025-06-19 17050, 2025
lucifer[m]
yup indeed.
2025-06-19 17000, 2025
monkey[m]
Shall I look at re-adding the import page then, with a placeholder?
2025-06-19 17004, 2025
lucifer[m]
* to do changes to some of
2025-06-19 17012, 2025
lucifer[m]
sure
2025-06-19 17016, 2025
monkey[m]
OK
2025-06-19 17040, 2025
pite joined the channel
2025-06-19 17040, 2025
rayyan_seliya123
<lucifer[m]> "rayyan_seliya123: reviewed..." <- lucifer sure I will study your reviewed changes and implement accordingly!! Will need your help if any doubts enconutered 🙂!!
2025-06-19 17021, 2025
mamanullah7[m]
lucifer: pushed the changes! u can look now it was working fine but after latest merge conflict i hope it should not show any unexpected behavior!!
2025-06-19 17022, 2025
mamanullah7[m]
\
2025-06-19 17026, 2025
mamanullah7[m]
* lucifer: pushed the changes! u can look now it was working fine but after latest merge conflict i hope it should not show any unexpected behavior!!
2025-06-19 17006, 2025
mamanullah7[m]
can u also confirm is MusicServices.tsx updated with master! some of the codes related to lastfm and librefm changed recently i manually updated and it matched i just need confirmation!
2025-06-19 17014, 2025
mamanullah7[m]
* lucifer: can u also confirm is `MusicServices.tsx` updated with master! some of the codes related to `lastfm` and `librefm` changed recently i manually updated and it matched i just need confirmation!
