[metabrainz.org] 14mayhem merged pull request #514 (03metabrainz-notifications…authorization-decorator): Add authentication to the notification endpoints. https://github.com/metabrainz/metabrainz.org/pull…
2025-06-20 17151, 2025
Jade[m] has quit
2025-06-20 17119, 2025
pite joined the channel
2025-06-20 17153, 2025
suvid[m]
<_BrainzGit> "[listenbrainz-server] MonkeyDo..." <- Thanks monkey for creating the page for it :)
2025-06-20 17113, 2025
suvid[m]
<lucifer[m]> "suvid: hi! let me know when..." <- Hi... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/jVjYPDMeZKTHioDtxmCvrrFj>)
2025-06-20 17113, 2025
lucifer[m]
[@suvid:matrix.org](https://matrix.to/#/@suvid:matrix.org) we decided to not use the listens importer or external service oauth table for the imports. but a separate table like we do for user data exports.
2025-06-20 17132, 2025
suvid[m]
oh thank god 😅
2025-06-20 17139, 2025
suvid[m]
makes life a bit easier!?
2025-06-20 17103, 2025
lucifer[m]
great, you should be able to copy most of the logic from exports and use it in import APIs.
2025-06-20 17117, 2025
suvid[m]
yes that was indeed the original plan
2025-06-20 17125, 2025
suvid[m]
* yes,, * and that was
2025-06-20 17128, 2025
lucifer[m]
The only difference is that the API to trigger the import should be uploading the files
2025-06-20 17129, 2025
suvid[m]
* yes,, * and that was, * original plan :)
2025-06-20 17139, 2025
lucifer[m]
And you don't need an api to download the files.
2025-06-20 17104, 2025
suvid[m]
i am wondering should i start from scratch 🤔
2025-06-20 17122, 2025
lucifer[m]
your call.
2025-06-20 17155, 2025
suvid[m]
just to be clear, we aren't using the listens_importer tablr now right?
2025-06-20 17159, 2025
lucifer[m]
Nope
2025-06-20 17104, 2025
suvid[m]
and we're making the new imports table right?
2025-06-20 17109, 2025
lucifer[m]
Yes
2025-06-20 17122, 2025
suvid[m]
👍️
2025-06-20 17149, 2025
suvid[m]
ok lemme think on how to go about it and will let you know in a few hours
2025-06-20 17149, 2025
suvid[m]
gotta see if i should start from scratch 😅
2025-06-20 17120, 2025
rayyan_seliya123
hey lucifer while testing my updated indexer aligining with your recent suggestions i encountered an issue that i am unable to get directly the metatdata for `artist` and `album ` they’re only present inside the `HTML` in the `description` field Should I implement a helper function like `extract_from_description` to parse these values from the description `HTML` as a fallback, or do you prefer that we only index
2025-06-20 17120, 2025
rayyan_seliya123
what’s available in the top-level metadata?
2025-06-20 17146, 2025
rayyan_seliya123
```txt
2025-06-20 17151, 2025
lucifer[m]
[@rayyan_seliya123:matrix.org](https://matrix.to/#/@rayyan_seliya123:matrix.org) can you share the item id or url with me
2025-06-20 17109, 2025
rayyan_seliya123 sent a txt code block: https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/wUWJqhuPAMwkZgwLpAeSSASX
If you have some time at some point to take a quick look at whether they look good still, I can then test running them locally etc
2025-06-20 17132, 2025
mamanullah7[m]
Hey lucifer: have u reviewed my pr? Is fw login issue solved?
2025-06-20 17156, 2025
lucifer[m]
m.amanullah7: the fw login issue won't be resolved for a few days/weeks.
2025-06-20 17113, 2025
lucifer[m]
i started reviewing your PR, will try to finish it today or tomorrow.
2025-06-20 17112, 2025
mamanullah7[m]
lucifer[m]: lucifer: I've started working on integrating fw in bp, I'll put fw at last in music priority list as of now i won't hardcode backend rather I won't give option in frontend so user cannot change fw priority?
2025-06-20 17117, 2025
mamanullah7[m]
I'll wait until the fw issue resolved it will be a bit complicated to integrate in bp without fw servers, I'll focus on fw css and styling to match the existing ui and other portions which doens't much testing at the time of implementation., then I'll start implementing fw player!
2025-06-20 17152, 2025
mamanullah7[m]
* which doens't needed much testing
2025-06-20 17120, 2025
lucifer[m]
m.amanullah7: the login works if you are already logged into funkwhale no?
2025-06-20 17129, 2025
mamanullah7[m]
lucifer: i didn't get u?
2025-06-20 17159, 2025
lucifer[m]
m.amanullah7: you only get the login issue, if you have not logged into funkwhale in advance in your browser before using listenbrainz no?
2025-06-20 17125, 2025
mamanullah7[m]
Yes
2025-06-20 17151, 2025
lucifer[m]
yes then that is fine. we will ask users to be logged into funkwhale before connecting to listenbrainz until the issue is resolved.
2025-06-20 17142, 2025
lucifer[m]
that's why i asked you to write the warning text above the connection buttons.
2025-06-20 17100, 2025
mamanullah7[m]
lucifer: yes and i have alredy added warning!
2025-06-20 17138, 2025
lucifer[m]
note that even if the issue is fixed in the new version, the users will old versions will need to ensure that.
2025-06-20 17136, 2025
mamanullah7[m]
Sure I'll take care of this in warning!
2025-06-20 17107, 2025
mamanullah7[m]
lucifer: just reminding if u missed! one more fw issue was there after upgrading fw servers to latest I'm not able to login with the user id u have created i raised this issue in fw they asked me to give logs!
2025-06-20 17111, 2025
lucifer[m]
m.amanullah7: are you able to login now?
2025-06-20 17116, 2025
lucifer[m]
or are you still unable to login
2025-06-20 17120, 2025
mamanullah7[m]
lucifer: last time when I tried I wasn't able to login, I'll try again and will let u know!
2025-06-20 17130, 2025
lucifer[m]
try logging in now and i will take a look. this is most likely now a funkwhale issue.
2025-06-20 17143, 2025
lucifer[m]
but just that i reset the database to ease upgrading
2025-06-20 17152, 2025
lucifer[m]
s/now/not/
2025-06-20 17129, 2025
mamanullah7[m] sent a code block: https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/XtwFmGvQLuUPGxBHcqyIHrPm
2025-06-20 17125, 2025
mamanullah7[m]
```<petitminion@matterbridge> another user reported this behaviour, do you have backend logs ? could you try hard reloading the browser / in a private window ?
2025-06-20 17125, 2025
mamanullah7[m]
```
2025-06-20 17125, 2025
mamanullah7[m]
lucifer this was the respond i got when i reported them! if u can share me the log?!
2025-06-20 17145, 2025
mamanullah7[m]
lucifer: this was the respond i got when i reported them! if u can share me the log?!
2025-06-20 17145, 2025
mamanullah7[m]
```<petitminion@matterbridge> another user reported this behaviour, do you have backend logs ? could you try hard reloading the browser / in a private window ?
2025-06-20 17145, 2025
mamanullah7[m]
```
2025-06-20 17120, 2025
lucifer[m]
ftr, worked now.
2025-06-20 17123, 2025
SigHunter has quit
2025-06-20 17157, 2025
BobSwift[m] has quit
2025-06-20 17112, 2025
SigHunter joined the channel
2025-06-20 17138, 2025
mamanullah7[m] sent a code block: https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/XdHhkEaigxzfKfFdzdKofiUq
2025-06-20 17127, 2025
lucifer[m]
[@m.amanullah7:matrix.org](https://matrix.to/#/@m.amanullah7:matrix.org) we delete it for other services so makes sense to delete it for funkwhale too.
2025-06-20 17123, 2025
mamanullah7[m]
lucifer: as discussed a user can have multiple `host_url` so if a user wants to add one more host_url so he'll disable simply and then he can connect again with new `host_url` and if he wants to again switched to prev one he will disable the curr one and set permission to disable and set premission to listen to the older one after verifying if the host_url exist in backend?
2025-06-20 17130, 2025
mamanullah7[m]
if we delete the db then he needs to connect again! ? it will be okay?
2025-06-20 17134, 2025
lucifer[m]
[@m.amanullah7:matrix.org](https://matrix.to/#/@m.amanullah7:matrix.org) for now let's assume there will be only one host url, I need to checkout funkwhale in more detail and discuss it with other who understand funkwhale federation better to confirm if we need multiple ones
2025-06-20 17156, 2025
mamanullah7[m]
lucifer: sure then i'll update the backend now! and i'll push the changes
