#metabrainz

/

      • pite has quit
      • Kladky joined the channel
      • lusciouslover has quit
      • lusciouslover joined the channel
      • davic has quit
      • lusciouslover has quit
      • lusciouslover joined the channel
      • lusciouslover has quit
      • lusciouslover joined the channel
      • BrainzGit has quit
      • _BrainzGit has quit
      • lusciouslover has quit
      • lusciouslover joined the channel
      • jesus2099 joined the channel
      • zas[m]
      • Services are back
      • BrainzGit joined the channel
      • _BrainzGit joined the channel
      • __BrainzGit joined the channel
      • Maxr1998_ joined the channel
      • Maxr1998 has quit
      • jesus2099 has quit
      • __BrainzGit
        [metabrainz.org] 14mayhem merged pull request #514 (03metabrainz-notifications…authorization-decorator): Add authentication to the notification endpoints. https://github.com/metabrainz/metabrainz.org/pu...
      • Jade[m] has quit
      • pite joined the channel
      • suvid[m]
        <_BrainzGit> "[listenbrainz-server] MonkeyDo..." <- Thanks monkey for creating the page for it :)
      • <lucifer[m]> "suvid: hi! let me know when..." <- Hi... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/...>)
      • lucifer[m]
        [@suvid:matrix.org](https://matrix.to/#/@suvid:matrix.org) we decided to not use the listens importer or external service oauth table for the imports. but a separate table like we do for user data exports.
      • suvid[m]
        oh thank god 😅
      • makes life a bit easier!?
      • lucifer[m]
        great, you should be able to copy most of the logic from exports and use it in import APIs.
      • suvid[m]
        yes that was indeed the original plan
      • * yes,, * and that was
      • lucifer[m]
        The only difference is that the API to trigger the import should be uploading the files
      • suvid[m]
        * yes,, * and that was, * original plan :)
      • lucifer[m]
        And you don't need an api to download the files.
      • suvid[m]
        i am wondering should i start from scratch 🤔
      • lucifer[m]
        your call.
      • suvid[m]
        just to be clear, we aren't using the listens_importer tablr now right?
      • lucifer[m]
        Nope
      • suvid[m]
        and we're making the new imports table right?
      • lucifer[m]
        Yes
      • suvid[m]
        👍️
      • ok lemme think on how to go about it and will let you know in a few hours
      • gotta see if i should start from scratch 😅
      • rayyan_seliya123
        hey lucifer while testing my updated indexer aligining with your recent suggestions i encountered an issue that i am unable to get directly the metatdata for `artist` and `album ` they’re only present inside the `HTML` in the `description` field Should I implement a helper function like `extract_from_description` to parse these values from the description `HTML` as a fallback, or do you prefer that we only index
      • what’s available in the top-level metadata?
      • ```txt
      • lucifer[m]
        [@rayyan_seliya123:matrix.org](https://matrix.to/#/@rayyan_seliya123:matrix.org) can you share the item id or url with me
      • rayyan_seliya123 sent a txt code block: https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/wUWJqhuPAMwkZgwLpAeSSASX
      • rayyan_seliya123
        see this
      • for some different recording i got the data as like this see the gist https://gist.github.com/RayyanSeliya/89ba8bf48e...
      • lucifer[m]
        rayyan_seliya123: i see okay, lets try to use the metadata if available directly otherwise try to extract from the html description
      • let's use beautifulsoup or some other html parsing for this task though instead of hand written regex.
      • rayyan_seliya123
        lucifer[m]: yeah for sure i will use this and check again !!
      • reosarevok[m]
        yvanzo, lucifer: any idea if there's any good reason why area and label index `F("sortname", "aliases.sort_name")` in `sir`?
      • (or, alternatively, why other entities do not)
      • I think I'll drop it from my genre impl unless there's any reason we do want it
      • lucifer[m]
        no idea.
      • holycow23[m] has quit
      • __BrainzGit
        [metabrainz.org] 14mayhem merged pull request #516 (03master…dependabot/pip/urllib3-2.5.0): Bump urllib3 from 2.4.0 to 2.5.0 https://github.com/metabrainz/metabrainz.org/pu...
      • reosarevok[m]
      • If you have some time at some point to take a quick look at whether they look good still, I can then test running them locally etc
      • mamanullah7[m]
        Hey lucifer: have u reviewed my pr? Is fw login issue solved?
      • lucifer[m]
        m.amanullah7: the fw login issue won't be resolved for a few days/weeks.
      • i started reviewing your PR, will try to finish it today or tomorrow.
      • mamanullah7[m]
        lucifer[m]: lucifer: I've started working on integrating fw in bp, I'll put fw at last in music priority list as of now i won't hardcode backend rather I won't give option in frontend so user cannot change fw priority?
      • I'll wait until the fw issue resolved it will be a bit complicated to integrate in bp without fw servers, I'll focus on fw css and styling to match the existing ui and other portions which doens't much testing at the time of implementation., then I'll start implementing fw player!
      • * which doens't needed much testing
      • lucifer[m]
        m.amanullah7: the login works if you are already logged into funkwhale no?
      • mamanullah7[m]
        lucifer: i didn't get u?
      • lucifer[m]
        m.amanullah7: you only get the login issue, if you have not logged into funkwhale in advance in your browser before using listenbrainz no?
      • mamanullah7[m]
        Yes
      • lucifer[m]
        yes then that is fine. we will ask users to be logged into funkwhale before connecting to listenbrainz until the issue is resolved.
      • that's why i asked you to write the warning text above the connection buttons.
      • mamanullah7[m]
        lucifer: yes and i have alredy added warning!
      • lucifer[m]
        note that even if the issue is fixed in the new version, the users will old versions will need to ensure that.
      • mamanullah7[m]
        Sure I'll take care of this in warning!
      • lucifer: just reminding if u missed! one more fw issue was there after upgrading fw servers to latest I'm not able to login with the user id u have created i raised this issue in fw they asked me to give logs!
      • lucifer[m]
        m.amanullah7: are you able to login now?
      • or are you still unable to login
      • mamanullah7[m]
        lucifer: last time when I tried I wasn't able to login, I'll try again and will let u know!
      • lucifer[m]
        try logging in now and i will take a look. this is most likely now a funkwhale issue.
      • but just that i reset the database to ease upgrading
      • s/now/not/
      • mamanullah7[m] sent a code block: https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/XtwFmGvQLuUPGxBHcqyIHrPm
      • mamanullah7[m]
        ```<petitminion@matterbridge> another user reported this behaviour, do you have backend logs ? could you try hard reloading the browser / in a private window ?
      • ```
      • lucifer this was the respond i got when i reported them! if u can share me the log?!
      • lucifer: this was the respond i got when i reported them! if u can share me the log?!
      • ```<petitminion@matterbridge> another user reported this behaviour, do you have backend logs ? could you try hard reloading the browser / in a private window ?
      • ```
      • lucifer[m]
        ftr, worked now.
      • SigHunter has quit
      • BobSwift[m] has quit
      • SigHunter joined the channel
      • mamanullah7[m] sent a code block: https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/XdHhkEaigxzfKfFdzdKofiUq
      • [@m.amanullah7:matrix.org](https://matrix.to/#/@m.amanullah7:matrix.org) we delete it for other services so makes sense to delete it for funkwhale too.
      • mamanullah7[m]
        lucifer: as discussed a user can have multiple `host_url` so if a user wants to add one more host_url so he'll disable simply and then he can connect again with new `host_url` and if he wants to again switched to prev one he will disable the curr one and set permission to disable and set premission to listen to the older one after verifying if the host_url exist in backend?
      • if we delete the db then he needs to connect again! ? it will be okay?
      • lucifer[m]
        [@m.amanullah7:matrix.org](https://matrix.to/#/@m.amanullah7:matrix.org) for now let's assume there will be only one host url, I need to checkout funkwhale in more detail and discuss it with other who understand funkwhale federation better to confirm if we need multiple ones
      • mamanullah7[m]
        lucifer: sure then i'll update the backend now! and i'll push the changes
      • davic joined the channel
      • Kladky has quit
      • davic has quit