so for now, we stay put and hope for the best that the US/California doesn't totally melt down.
2025-06-23 17444, 2025
mayhem[m]
good week, overall, really!
2025-06-23 17450, 2025
mayhem[m]
monkey: go!
2025-06-23 17457, 2025
monkey[m]
Hello everyone!
2025-06-23 17450, 2025
monkey[m]
Last week i worked on the Libre.FM backend importer, specifically looking at the UI portions and replacing the now-empty manual imports page with a placeholder, awaiting the file importers being developed over the course of this GSOC
2025-06-23 17401, 2025
monkey[m]
I looked into improving our error boundaries for thye ListenBrainz player after a suggestion by bitmap (thanks!), but there is more than meets the eye. I found one improvement but looking into it deeper.
2025-06-23 17424, 2025
monkey[m]
I refactored some front-end tests from enzyme to testing-library (ongoing work)
2025-06-23 17436, 2025
monkey[m]
And some PR reviewing to top it all off.
2025-06-23 17445, 2025
monkey[m]
yvanzo: Your turn!
2025-06-23 17452, 2025
yvanzo[m]
Hi!
2025-06-23 17436, 2025
yvanzo[m]
Got worse last week, skipped it too.
2025-06-23 17442, 2025
yvanzo[m]
Fin, go kellnerd?
2025-06-23 17401, 2025
kellnerd[m]
Hey there!
2025-06-23 17412, 2025
kellnerd[m]
Last week I had to fix Harmony's Tidal provider again because of a breaking API change.
2025-06-23 17423, 2025
kellnerd[m]
The change wasn't announced AFAIK, so I had to hotfix this by temporarily losing cover art from Tidal.
2025-06-23 17443, 2025
kellnerd[m]
Since the API query parameters have changed, I finally had to implement support for legacy URLs in Harmony's caching logic (in order to avoid breaking old permalinks).
2025-06-23 17402, 2025
kellnerd[m]
Seems to work as expected and Tidal images are back, but I should do some more tests (and write unit tests) before releasing this.
2025-06-23 17430, 2025
kellnerd[m]
And after more than two years, I've released a new version of my *Guess Unicode punctuation* userscript, which integrates new rules for Hebrew contributed by dvirtz.
2025-06-23 17457, 2025
kellnerd[m]
Go Hemang Mishra!
2025-06-23 17428, 2025
HemangMishra[m] joined the channel
2025-06-23 17429, 2025
HemangMishra[m]
Hello!!
2025-06-23 17433, 2025
reosarevok[m]
Still on my list for today: suvid , m.amanullah7 , Gautam_coder , reosarevok , zas
2025-06-23 17400, 2025
HemangMishra[m]
This week, I mostly worked on implementing Listening Apps Selection Screen and opened a PR for the same.
Figured out most of the stuff already and kinda back on track
2025-06-23 17457, 2025
suvid[m]
This time it looks more organized and I understand it better :)
2025-06-23 17406, 2025
suvid[m]
Implemented the file upload part and background tasks part
2025-06-23 17427, 2025
suvid[m]
I will make the new schema and test things
2025-06-23 17427, 2025
suvid[m]
after that I will move on to zip file processing for spotify and then make functions that process files for other services as well
2025-06-23 17437, 2025
suvid[m]
That's all for this week
2025-06-23 17446, 2025
suvid[m]
Gautam_coder: next?
2025-06-23 17453, 2025
reosarevok[m]
Not sure they're active, I can go
2025-06-23 17436, 2025
reosarevok[m]
Last week I worked on updating my PRs for extra genre data in the API, since now that we have a new search server those things are unblocked and just need to slowly arise from their sleep
2025-06-23 17404, 2025
reosarevok[m]
Also worked on a couple small improvements, such as MBS-14065
auth will have latest docker major, most others will not afaik because defaults for metabrainz-ansible are pretty behind
2025-06-23 17402, 2025
yvanzo[m]
Thanks everyone!
2025-06-23 17418, 2025
julian45[m]
ok yeah --time was only renamed in docker engine 28 per the docs you linked and i think most MeB servers are pretty far behind that last i checked
2025-06-23 17403, 2025
reosarevok[m]
Hmm, I see. Some were warning, but I didn't think some might not work at all. I guess I should revert for now, and hope it's backwards-compatible for long enough that the servers get updated in the meantime :D
2025-06-23 17423, 2025
reosarevok[m]
(and the new ones don't start rejecting it outright)
2025-06-23 17420, 2025
julian45[m]
yeah, i don't imagine it'd get removed outright till docker engine 29 or so, and latest is 28.2 or so
2025-06-23 17443, 2025
reosarevok[m]
Ok
2025-06-23 17438, 2025
reosarevok[m]
Pushed a revert commit, let's see
2025-06-23 17404, 2025
zas[m] joined the channel
2025-06-23 17405, 2025
zas[m]
Sorry, I had an emergency to handle, nothing special this week anyway; usual stuff, system maintenance, upgrades & fixes, Picard, MB edits, user support.
2025-06-23 17410, 2025
reosarevok[m]
Ok, running the prod update again, now without breakages, hopefully :)
2025-06-23 17452, 2025
holycow23[m]
Hey lucifer, I tried running the query got a huge trace which ended with... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/uEkqChyDmnVpwgBushcuiBTh>)
2025-06-23 17427, 2025
lucifer[m]
holycow23: need to the entire stack trace to help
2025-06-23 17436, 2025
lucifer[m]
* need to see the entire
2025-06-23 17443, 2025
holycow23[m]
Yeah how do I see the entire trace of the pyspark shell?
2025-06-23 17408, 2025
lucifer[m]
no i mean just paste whatever you do see into a file and upload that to a gist
2025-06-23 17420, 2025
holycow23[m]
But it was something related to Mkdirs failed to create file:/stats/user/bookkeeping/genre_trend/last_week/incremental/...
2025-06-23 17407, 2025
lucifer[m]
makes sense but even then need to see that complete section of the stack trace
holycow23: did you configure the hdfs_connection properly?
2025-06-23 17420, 2025
holycow23[m]
I think I did
2025-06-23 17451, 2025
lucifer[m]
in particular, this set config.HDFS_CLUSTER_URI = "hdfs://127.0.0.1:9000"
2025-06-23 17425, 2025
lucifer[m]
just print that variable and confirm that is set to that value
2025-06-23 17439, 2025
holycow23[m]
yes it is set correctly
2025-06-23 17410, 2025
mamanullah7[m]
Hey lucifer: any update on my pr?
2025-06-23 17422, 2025
lucifer[m]
m.amanullah7: yes i reviewed the backend parts of it and one major change is needed. funkwhale has an api to create oauth apps, we should use that instead of harcoding the client id and client secret in the config. take a look at the section on the top of the page: https://docs.funkwhale.audio/swagger/#/
2025-06-23 17425, 2025
mamanullah7[m]
I've pushed the changes and ive integrated fw in bp! U can have a look rn its its priority is lowest but u can change its like other services to top and can test !! I tried to add songs in fw but failed and when i tried to play song I was getting error authentication required!!
2025-06-23 17427, 2025
lucifer[m]
i think rest everything should remain the same just instead of reading the client id/secret from config file, you have to call that api to get the data.
2025-06-23 17452, 2025
lucifer[m]
there are other smaller changes that i would like and also i am thinking if we should change the existing tables schema to simplify funkwhale implementation, reduce the specific code needed for it at least.
as for frontend changes i will ask monkey to do that.
2025-06-23 17436, 2025
holycow23[m]
* entire trace which was visible
2025-06-23 17445, 2025
petitminion has quit
2025-06-23 17435, 2025
mamanullah7[m]
lucifer[m]: lucifer: I'll update this and let u know!
2025-06-23 17414, 2025
mamanullah7[m]
lucifer[m]: What u can change in schema like removing client id and secret?
2025-06-23 17418, 2025
lucifer[m]
m.amanullah7: i am thinking that access token and refresh token's could be stored in external service oauth table. the tokens for spotify/apple music etc. are stored there for example.
2025-06-23 17456, 2025
mamanullah7[m]
What about host url?
2025-06-23 17410, 2025
lucifer[m]
that would remain in the funkwhale servers table.
2025-06-23 17445, 2025
lucifer[m]
and the client id and client secret would also be added to that table.
2025-06-23 17423, 2025
lucifer[m]
so we still have a new table but I am trying to think if it can simplify our implementation.
2025-06-23 17436, 2025
lucifer[m]
i'll think more about it and we can see how to move forward on that.
2025-06-23 17457, 2025
mamanullah7[m]
lucifer[m]: lucifer: you're referring to external oauth table?
2025-06-23 17409, 2025
lucifer[m]
no the funkwhale servers table.
2025-06-23 17426, 2025
mamanullah7[m]
Okay!!
2025-06-23 17424, 2025
mamanullah7[m]
I'll move access token and refresh token I'm external oauth table and rest all will be in funkwhale servers
2025-06-23 17432, 2025
lucifer[m]
holycow23: okay i see, restart pyspark. run the setup commands again. and then import your stats and run it. i think you had imported it before running the setup so the outdated empty value got hardcoded there.
2025-06-23 17438, 2025
mamanullah7[m]
s/I'm/in/
2025-06-23 17426, 2025
lucifer[m]
m.amanullah7: you can't do that right now because then you would need to add a new column to store the funkwhale server id to which the token belongs.
2025-06-23 17443, 2025
holycow23[m]
lucifer[m]: So re run the shell and then the same commands right?
2025-06-23 17455, 2025
holycow23[m]
* commands right? cause I already did that and got the same
2025-06-23 17457, 2025
lucifer[m]
yes but ensure that the setup commands are run before any stats imports.
2025-06-23 17408, 2025
holycow23[m]
okay
2025-06-23 17410, 2025
lucifer[m]
m.amanullah7: i am thinking that we could change the `service` column in external oauth table to store that id.
2025-06-23 17447, 2025
lucifer[m]
so its a bigger change if we want to do that. so focus on the remaining parts of your project for now.
2025-06-23 17424, 2025
lucifer[m]
i'll discuss with mayhem and monkey this later and if we decide to do it, i'll migrate the existing services first and then you can make the relevant funkwhale changes.
2025-06-23 17444, 2025
holycow23[m]
lucifer[m]: should I run this... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/BrWfGoAxysPFooUYkhiFxRrr>)
2025-06-23 17411, 2025
holycow23[m]
* should I run this... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/geGqDwAeuDNscMSaCxBOHHaa>)
2025-06-23 17419, 2025
lucifer[m]
holycow23: move line 4 to line 12. otherwise yes.
2025-06-23 17437, 2025
lucifer[m]
also remove line 1 actually
2025-06-23 17406, 2025
lucifer[m]
it shouldn't change anything but is also not needed for the setup anyway.
2025-06-23 17441, 2025
lucifer[m]
the key is moving the import on line to after you have patched the config.
2025-06-23 17449, 2025
lucifer[m]
* on line 4 to after
2025-06-23 17451, 2025
mamanullah7[m]
lucifer: I've to once look external service table can't we create any kind of relationship with both the tables and connect them!
