suvid: i left some comments, but i stopped reviewing because I think it has a lot of code details. I suggest to take a look at it again, and remove the code snippets where not necessary. If you'd like to keep all of them, that is also fine by me and let me know.
2025-08-29 24129, 2025
petitminion has quit
2025-08-29 24110, 2025
suvid[m]
<lucifer[m]> "suvid: i left some comments, but..." <- I think I would keep the code snippets
2025-08-29 24102, 2025
kellnerd[m] has quit
2025-08-29 24115, 2025
rcombs has quit
2025-08-29 24152, 2025
rcombs joined the channel
2025-08-29 24145, 2025
rayyan_seliya123
hey monkey i have added frontend test you can have alook on my pr and all passed see below https://gist.github.com/RayyanSeliya/5bb8b06adcb5… and let me know if any tweaks needed !! and lucifer i have pushed the backend tests too which i was unable to test coz od funkwhale_tokens error !!
2025-08-29 24132, 2025
elkiensad[m] has quit
2025-08-29 24104, 2025
ansh[m] joined the channel
2025-08-29 24104, 2025
ansh[m]
<holycow23[m]> "ansh, lucifer and monkey can you..." <- Looks good
2025-08-29 24115, 2025
lucifer[m]
holycow23: don't have comment access
2025-08-29 24105, 2025
lusciouslover has quit
2025-08-29 24131, 2025
lusciouslover joined the channel
2025-08-29 24124, 2025
monkey[m]
<suvid[m]> "I think I would keep the code..." <- IMO, unless the code solves a special novel problem or in a novel way, this is not what people want to read in your blog post, especially if there is a lot of boilerplate sort of code.
2025-08-29 24122, 2025
aerozol[m] has quit
2025-08-29 24105, 2025
lusciouslover has quit
2025-08-29 24127, 2025
lusciouslover joined the channel
2025-08-29 24113, 2025
Jade[m]
Maybe put them in details tags, so they're collapsed and people who are interested can read them and those that aren't can skip them
2025-08-29 24126, 2025
monkey[m]
holycow23: Your blog post on notion looks great 👍️ My only comment is on "I relied on wolf for initial development" <- nobody outside the dev team knows what you mean by 'wolf', so i would replace that with "a development server" or add it in parenthesis.
@fettuccinae:matrix.org: lots of code details in the beginning itself, focus on the features and high level overview first. code deails if any towards the end.
2025-08-29 24106, 2025
suvid[m]
Hi lucifer... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/rrmZCpqUGXMagLwMOzLURbNu>)
suvid: you can update wordpress and i'll directly make any changes necessary there and publish.
2025-08-29 24148, 2025
suvid[m]
okay!
2025-08-29 24100, 2025
fettuccinae[m]
lucifer: I have put all the code in a detail tag, and made the change suggested on doc.
2025-08-29 24110, 2025
fettuccinae[m]
s/doc/docs/
2025-08-29 24119, 2025
mamanullah7[m]
lucifer: in docs the flow chart is not visible completely but on wordpress it does can i use it the existing one for now?
2025-08-29 24129, 2025
mamanullah7[m]
monkey: i've corrected all grammar suggested by docs and you and revised as you suggested you can have a look should i also remove frontend code the blog becomes too long i think even i'm using very few lines of codes but still becoz i've to write both funkwhale & navidrome!
