Hey!, any thoughts on the current progress(or mvp)?
monkey
I haven't caught up to everything yet, but I'm spending all day tomorrow testing everything and progressing on the PRs.
The video you made looks like great progress! I'll go over details tomorrow, and hopefully put the feature branch on test.bb
Shubh
For testing locally, I'm using temporary branch where i merge all other branches related to uf (namely uf-frontend, uf-routes, master)
monkey
Yes, I'm keen on merging some of the PRs, then we can update the feature branch followed by the uf-frontend PR, then I can deploy that to test
Shubh
also if possible please make sure to merge it with master, since it may cause slowdown without redux optimization on language field due to having large state
monkey
Roger
Shubh
Also i went with another state option from proposed one since i realized that wasn't practical
monkey
I'm curious to see that. What was the issue witht he proposed structure?
Shubh
You see, previously we managed each entity state separately i.e for work entity we had `newWork` (having modal state for work) and `Works` (containing all works), this cause the issue of state duplication so if `UPDATE_NAME_FIELD` action is dispatched it will update all name fields in the unified form including the edition one.
monkey
Ah, I see. That makes sense, the actions only have their name, which isn't attached to an entity per se
Shubh
not to mention how large the state will become
monkey
What was your solution? I figure I'll see it in the code, but… :)
Shubh
might not be the best way but here what i did to resolve this issue
Now redux will only manage one entity state at a time
For eg. if we click on `create new work`, it first save the current form in `Editions` state, later when we submit the new work it will load back the old form state from `Editions`and save the current form state ( work entity state ) to `Works`
also i'm wondering if it would be a good idea to have separate tab for showing duplicate entities (like mb)...
monkey
I'm not an expert in Redux, but this pattern matches what I've seen for more complexe states that need different slices
Shubh
monkey: also for the heads-up i might be inactive for few days due to my mid semester exams but i hope that shouldn't cause any slowdown for the project :)
monkey
Eek, good luck on the exams !
Shubh
Thanks!
monkey
I think you've been going at a good pace and you're still nicely on track; I'm not worried
As a matter of fact I'm the slowing down element in the mix :)
Shubh
Nah!, i also think we are doing just fine :)
CatQuest
I have tested author credits. i couldn't find anything really problematic and it seems firly slick enough.
!m everyone working on it
BrainzBot
You're doing good work, everyone working on it!
CatQuest
uh
farly slick enough.
monkey
CatQuest stamp of approval for beta :)
Shubh
next up, multiple publishers on the test?
CatQuest
oh oh
neat!
(just why al lthis this week sicne it's midsummer and i was off. lmao)
(just kidding. ping me on kass or catquest and i'll test it)