mayhem, alastairp: just a heads up, i am going to run the query from LB#2279 on the db. expected invalidation's are ~22M out of total 75M rows therefore i am creating a copy of the original table first, just in case we discover something was wrong.
Is this something we could improve somehow, it seems to me adding new indexes cost a lot cpu-wise, on all cluster members
2022-12-08 34202, 2022
d4rkie joined the channel
2022-12-08 34244, 2022
jivte has quit
2022-12-08 34235, 2022
d4rk has quit
2022-12-08 34203, 2022
vibhoo_24 has quit
2022-12-08 34257, 2022
monkey
mayhem, lucifer, alastairp, aerozol: I was looking into how to add social media sharing buttons for YIM without loading third-party javascript as discussed during the summit.
2022-12-08 34257, 2022
monkey
We can pretty easily add buttons to share a page URL (user's YIM page) + title/text and a generic image (with OpenGraph `<meta>` tags in the html), which requires us to host that image somewhere and point to its URL.
2022-12-08 34257, 2022
monkey
I suppose that restricts us to non-user-specific images, unless we want to generate and store an image for each user (which I assume wouldn't include cover art anyway). Are we OK with the non-user-specific image sharing?
2022-12-08 34240, 2022
mayhem
non-user specific is pretty trivial, no? I mean that just means linking to an image that is part of YIM, right?
2022-12-08 34248, 2022
monkey
Yes
2022-12-08 34217, 2022
monkey
I.e. the header withe this is fine doggo
2022-12-08 34245, 2022
monkey
Maybe a small tagline with a short explanation
2022-12-08 34204, 2022
mayhem
yeah, easy. and do we actually have any generated images for users?
2022-12-08 34226, 2022
mayhem
We could ship some of the new cover arts for people, but SVGs don't share as nicely...
2022-12-08 34236, 2022
jasje joined the channel
2022-12-08 34215, 2022
jasje
akshaaatt: Any recommended addons or actions for the pr on listenBrainz?
2022-12-08 34220, 2022
akshaaatt
Hi jasje! It looks good to me. Let me just test once and then merge
2022-12-08 34232, 2022
jasje
okay and for future (after my exams) i would converting the settings to composable activity and getting rid of the deprecated OnAttach function bec i think playstore usually isnt happy about the deprecated functions.
2022-12-08 34237, 2022
jasje
is this what i should do?
2022-12-08 34221, 2022
akshaaatt
Deprecated function aren’t a problem until and unless playstore sends the devs a warning in general, asking to eliminate those.
2022-12-08 34253, 2022
akshaaatt
I think we should focus more on features for the app
2022-12-08 34213, 2022
akshaaatt
One thing which we would like is Year in Music to be available from the app
2022-12-08 34241, 2022
yvanzo
zas: It seems to be expected. It should hopefully improve with Solr 9. It also brings a way to throttle updates.
2022-12-08 34209, 2022
jivte joined the channel
2022-12-08 34257, 2022
jasje
akshaaatt: can you brief me on this feature anytime soon?
2022-12-08 34223, 2022
jasje
also just fixed the onAttach deprecated function pushing changes now.
2022-12-08 34242, 2022
vibhoo_24 joined the channel
2022-12-08 34258, 2022
vibhoo_24 has quit
2022-12-08 34207, 2022
rdswift
<monkey> "... two radio options: "now" and "past listen". Next to past listen you can put that date-time select component": Or perhaps just include the date/time picker and default it to "now"?
monkey: mayhem: I think we need to let people share their personal stats
2022-12-08 34243, 2022
aerozol
For yim
2022-12-08 34241, 2022
mayhem
yes, clearly. but what parts of those are images? do they contain cover art?
2022-12-08 34201, 2022
aerozol
I think they should contain cover art where appropriate... Which I now realize may be a concern?
2022-12-08 34201, 2022
aerozol
I've seen a few Spotify yim pics without images so I guess it's not necessary. I could mock up some stuff. How much work do we want to put into the shareable images monkey? Since we don't want to overwork ourselves!
2022-12-08 34208, 2022
lucifer
iirc spotify shares had only had 1 or 2 images and people still liked it. if cover art is an issue.
2022-12-08 34242, 2022
aerozol
We could do some similar stuff with just text but it would need a bit of work to look nice. But maybe the ground work was done by mayhem and monkey already with the colorful top 10 text 'grids'?
2022-12-08 34202, 2022
jasje has quit
2022-12-08 34203, 2022
mayhem
as long as YIM uses the output of the art api endpoints and embeds SVGs files, we're good to go.
2022-12-08 34224, 2022
mayhem
if we need a new composition, send me the SVG files and I'll get a PR in.
2022-12-08 34232, 2022
aerozol
Fun!
2022-12-08 34255, 2022
mayhem
got something in mind?
2022-12-08 34208, 2022
mayhem
I've got some spare time this evening, could make it happen quickly.
2022-12-08 34249, 2022
lucifer
i hate the part that we can't share to instagram from web :(. i guess twitter then ...
2022-12-08 34209, 2022
mayhem
what we need is a "share screenshot" function. the user loads that on mobile and the shares to instagram. should be an acceptable process, methinks.
2022-12-08 34232, 2022
mayhem
any prs that are ready lucifer ?
2022-12-08 34251, 2022
aerozol
I haven't used insta in ages... Guess we would have a download option for the same images anyway? Can you upload those to insta?
2022-12-08 34205, 2022
lucifer
nope. all merged for now.
2022-12-08 34231, 2022
aerozol
Hmm I'm a bit hungover mayhem so having something for you to implement tonight (this morning) is probably too ambitious :D
lucifer: why not instagram from web? I thought Instagram allowed browser uploads now
2022-12-08 34247, 2022
lucifer
reosarevok: huh, i wasn't aware of that. i'll check if thats possible.
2022-12-08 34209, 2022
tandy1000
<reosarevok> "lucifer: why not instagram..." <- dont think so
2022-12-08 34227, 2022
reosarevok
I dunno, it shows me a "Create" button for a new post?
2022-12-08 34234, 2022
reosarevok
I haven't tried it tho
2022-12-08 34243, 2022
tandy1000
i think it says go to the app
2022-12-08 34252, 2022
tandy1000
or at least it did a few months ago
2022-12-08 34202, 2022
reosarevok
I checked, it gives me an upload image button, lets me apply filters, etc
2022-12-08 34206, 2022
reosarevok shrugs
2022-12-08 34249, 2022
lucifer
reosarevok: oh i think we aren't on the same page. the issue is that 3rd party can't upload to instagram, they probably have an internal api to allow uploads from their own site.
2022-12-08 34200, 2022
reosarevok
Ooooh, gotcha
2022-12-08 34205, 2022
lucifer
the public api for sharing is only for android and ios apps
2022-12-08 34218, 2022
reosarevok
Well, you can have an instruction to download + upload :p
2022-12-08 34227, 2022
reosarevok
But yeah, not the same
2022-12-08 34245, 2022
rain0r has quit
2022-12-08 34220, 2022
rain0r joined the channel
2022-12-08 34223, 2022
mayhem
lucifer: I'm looking at the artist similarity data and I really think we need to change how we treat artists.
2022-12-08 34249, 2022
mayhem
we're getting individual band members of the bands in similar results and thats not quite what people would expect.
2022-12-08 34233, 2022
mayhem
should we be doing similarity on the array of mbids? we're doing it on single artist mbids right now, yes?
2022-12-08 34211, 2022
vibhoo_24 has quit
2022-12-08 34237, 2022
vibhoo_24 joined the channel
2022-12-08 34215, 2022
vibhoo_24 has quit
2022-12-08 34226, 2022
aerozol
Just had a shower thought re. socializing LB without having to deal with a dreaded chat box. What about allowing people to react to people's listens with the full array of emojis? Reasonably 'safe' and actually quite versatile
