Hi there!I was trying to explore listenbrainz-pylistens.Is there any issue in it on which I can work on.
2023-01-10 01014, 2023
yvanzo
O’Moin
2023-01-10 01042, 2023
yvanzo
alastairp, mayhem ^
2023-01-10 01014, 2023
yvanzo
vibhoo_24: LB staff is currently offline but I just pinged them so they will get your message when they are up. You can stay connected or check later answers from https://chatlogs.metabrainz.org/libera/metabrainz…
2023-01-10 01057, 2023
vibhoo_24
Okay thanks!
2023-01-10 01023, 2023
v6lur has quit
2023-01-10 01022, 2023
jasje joined the channel
2023-01-10 01004, 2023
jasje has quit
2023-01-10 01034, 2023
Maxr1998_ is now known as Maxr1998
2023-01-10 01022, 2023
Maxr1998
Is something wrong with ListenBrainz at the moment? My reports haven't been updated since Jan. 4th, maybe the report generator topped working?
We should probably try to talk about this this week, decide what to block together and then do so. We had some talks about disallowing @ - the Discourse example there is another reason why we probably should
isn't this just going to lead to a buttload of single-track releases that should be full albums + duplicates because those things are already *inn* mb, just not linked for some reason?
2023-01-10 01040, 2023
KassOtsimine
if new people are comming in via LB (a goal we have iiuc)
2023-01-10 01040, 2023
KassOtsimine
and don't understand the mb datamodel as much + mb has teh steep learning curve
2023-01-10 01040, 2023
KassOtsimine
this is jsut going to result in A LOT of garbage data and unhappy new users being yelled at by old unhappy frustrated users
2023-01-10 01042, 2023
yvanzo
Freso, bitmap, reosarevok: It is still on top of my list.
2023-01-10 01052, 2023
KassOtsimine
reo, re, MBS-9557 people can still, like call themselves 🍆 ✨cheese right?
KassOtsimine: that's already in the plans re missing data - for now you can link listens to an MBID from the listens history page
2023-01-10 01020, 2023
KassOtsimine
because there isa person called just a smilie emoji face and that's hilarious
2023-01-10 01027, 2023
reosarevok
And I dunno, but I surely hope not, re : usernames
2023-01-10 01033, 2023
KassOtsimine
:(
2023-01-10 01034, 2023
reosarevok
(although we probably won't touch existing ones)
2023-01-10 01037, 2023
vibhoo_24 has quit
2023-01-10 01018, 2023
KassOtsimine
so what you are saying is i have to make the account "🍆 ✨cheese" NOW while i syill can
2023-01-10 01046, 2023
reosarevok
Well, we also would prefer people not to make multiple accounts ;p
2023-01-10 01034, 2023
KassOtsimine
i agree with special funtion characters like zerowith space and combining only and / \ etc. but otherwise i say allow the full gamut of unicode
2023-01-10 01012, 2023
KassOtsimine
also, - for changing mb data becasue outside stuff can't deal. eg, this ticket for discourse problem
2023-01-10 01016, 2023
reosarevok
The problem is (see ticket) what happens when those usernames get sent to places that do not support it
2023-01-10 01033, 2023
KassOtsimine
see my ciomment. it's a discourse problem
2023-01-10 01050, 2023
KassOtsimine
wtf is "sso" anyway
2023-01-10 01005, 2023
reosarevok
Single Sign On - not having to have a separate account for everything
2023-01-10 01010, 2023
KassOtsimine
aha
2023-01-10 01011, 2023
Maxr1998
Unicode is pretty wild though, so picking a subset is only sane. It should still be possible to use non-latin scripts like CJK though, imo.
2023-01-10 01014, 2023
KassOtsimine
well that an issue
2023-01-10 01022, 2023
reosarevok
If this was *useful* to MB in any way, then I'd say we should still allow it even if it causes issues
2023-01-10 01028, 2023
KassOtsimine
yes
2023-01-10 01032, 2023
yvanzo
reosarevok: It’s YIM 2022. I don’t see any other occurrence.
2023-01-10 01043, 2023
KassOtsimine
banning dumb silly names is bad. banning cjk is really bad
2023-01-10 01045, 2023
reosarevok
yvanzo: I fixed it already from the title and the tag
2023-01-10 01058, 2023
reosarevok
But it really isn't - people have managed forever with stuff like ascii only, and we're not even suggesting that
2023-01-10 01013, 2023
reosarevok
I think most stuff probably can deal with stuff like CJK by now
2023-01-10 01021, 2023
KassOtsimine
my point is (yes freso) is that i'm not agaisnt it at all. but i think allowing most things is ok
2023-01-10 01051, 2023
reosarevok
It's a lot safer to block most things than it is to keep blocking stuff only when we realize there's a new problem though :)
2023-01-10 01004, 2023
reosarevok
(because in the meantime someone might have managed to exploit the problem)
2023-01-10 01004, 2023
yvanzo
reosarevok: I’ve been fighting with saving this draft. Please remind not to edit it at the same time.
2023-01-10 01005, 2023
Freso
KassOtsimine: As long as specifically allow those things, sure, but we should explicitly allow those things, not specifically disallow certain (other) things.
2023-01-10 01025, 2023
KassOtsimine
i think ya guys aren't understanding me. i am actually reallyfor fixing things like malicious names and bad function codepoints etc etc
2023-01-10 01035, 2023
reosarevok
yvanzo: sure, I thought you weren't using it because it normally doesn't let me save if you are :) Sorry!
2023-01-10 01053, 2023
reosarevok
KassOtsimine: I do get it, I just think that emojis in usernames are likely to break other software, and also they're very stupid :p
2023-01-10 01013, 2023
reosarevok
You're the one who hates it when like Jira shows you emojis, how come you now want to allow them? :D
2023-01-10 01038, 2023
KassOtsimine
i hate whne meoji's turn inot images isntead of being text, i don't mind emojies
2023-01-10 01050, 2023
KassOtsimine
anyway, coping with things like askii, is lame af. all a the sites in 2005, didn't evne allow spaces. i didn't put a space in my username becasue i *assumed* it was not llowed. i didn't reralise we allowed spaces until i saw Yllona's name with a space
2023-01-10 01005, 2023
yvanzo
Freso, bitmap, reosarevok: Sorry I mistook this ticket with the spam report stuff.
2023-01-10 01014, 2023
KassOtsimine
so we where (and are, still) one of the only places that allow all kinds of crap in usernames
2023-01-10 01019, 2023
reosarevok
Yeah - this is related to it, but not exactly it
2023-01-10 01026, 2023
KassOtsimine
of course it can all be fixed with siite spesific displaynames
2023-01-10 01038, 2023
reosarevok
Just we were talking about it yesterday :)
2023-01-10 01044, 2023
KassOtsimine
wich i'e been saying we need
2023-01-10 01044, 2023
reosarevok
(@ specifically)
2023-01-10 01049, 2023
KassOtsimine
hm
2023-01-10 01058, 2023
yvanzo
Freso, bitmap, reosarevok: MBS-9557 is partly implemented with yesterday’s hotfix already (a blog post is drafted already)
Guess you missed the "a select collection of non-ASCII alphabets/letter-characters as well" part then.
2023-01-10 01016, 2023
KassOtsimine
no i didn't. i was reacting to a-z as a range for letters
2023-01-10 01035, 2023
KassOtsimine
askii is dumb af
2023-01-10 01036, 2023
Freso
KassOtsimine: That’s the limitation for allowed characters in domains.
2023-01-10 01000, 2023
KassOtsimine
and it's dumb. "non askii" or rather. letters in languages other thna englidsh. are also letters
2023-01-10 01010, 2023
Freso
Yes, hence "a select collection of non-ASCII alphabets/letter-characters as well"
2023-01-10 01023, 2023
reosarevok
yvanzo: I think it's fine to leave current legitimate accounts be, while still restricting registration of new usernames using any characters we don't like
2023-01-10 01051, 2023
KassOtsimine
i also want to point out AGAIN i'm not disagree wrt reos comment jsut now
2023-01-10 01059, 2023
yvanzo
reosarevok: Yes, but it just requires a different implementation.
2023-01-10 01032, 2023
KassOtsimine
deff disallow problematic glyps
2023-01-10 01016, 2023
reosarevok
yvanzo: why? we're only checking on registration with the new bitmap code anyway, aren't we? :)
2023-01-10 01022, 2023
KassOtsimine
but i dislike the idea of "ascii + some not ascii" idea
2023-01-10 01022, 2023
reosarevok
(and name update, I guess)
2023-01-10 01043, 2023
KassOtsimine
like defining so many letters as "not ascii"
2023-01-10 01051, 2023
KassOtsimine
i'm not saying what i mean
2023-01-10 01056, 2023
KassOtsimine
i am bad at this
2023-01-10 01059, 2023
KassOtsimine
uh
2023-01-10 01002, 2023
KassOtsimine
i mean
2023-01-10 01011, 2023
reosarevok
Those letters... are not ASCII, that's fine :D Nobody is saying we should disallow øæå
(I would have nothing against ASCII-only usernames, tbh, but I understand I'm probably in the minority there and that's not required for safety anyway)
2023-01-10 01024, 2023
KassOtsimine
a "collection of non-ascii alphabets"... why noyt AL other alphabets?
2023-01-10 01000, 2023
Freso
KassOtsimine: All other alphabets would be… a collection of non-ascii alphabets.
2023-01-10 01000, 2023
KassOtsimine
by all means, exclude thingsthat will fuck up usernames and other sso and whatever with people being jerkhats and malicious and shit
2023-01-10 01007, 2023
KassOtsimine
...
2023-01-10 01014, 2023
KassOtsimine
"a collection" is a subset of all
2023-01-10 01023, 2023
KassOtsimine
so like 4-54
2023-01-10 01026, 2023
KassOtsimine
erh
2023-01-10 01030, 2023
KassOtsimine
4-5 other scripts
2023-01-10 01042, 2023
KassOtsimine
do you know how many glyps there are in unicode?
2023-01-10 01046, 2023
KassOtsimine
?!?!
2023-01-10 01047, 2023
Freso
A subset of all can still be all. And we don’t know if we want all until we’ve looked into it and can verify that it’s safe to use.
2023-01-10 01055, 2023
KassOtsimine
ikke faen ,a subset is never all
2023-01-10 01000, 2023
Freso
Okay.
2023-01-10 01014, 2023
yellowhatpro
akshaaatt: I have added the fix for changing songs, playlists, albums. Earlier, if we played any song from the playable(any artist, album), the next songs of that albums were not playing.
2023-01-10 01016, 2023
reosarevok
Technically, it is :)
2023-01-10 01018, 2023
KassOtsimine
but if we are arguing semantics thne fine. i missunderstand your intent.
2023-01-10 01021, 2023
KassOtsimine
that's on me
2023-01-10 01047, 2023
reosarevok
"set A is a subset of a set B if all elements of A are also elements of B; B is then a superset of A. It is possible for A and B to be equal; if they are unequal, then A is a proper subset of B"
2023-01-10 01053, 2023
reosarevok
So it's a subset, but not a proper one :D
2023-01-10 01001, 2023
KassOtsimine
sight
2023-01-10 01030, 2023
KassOtsimine
so i am kinda correct to. it's only a non-proper subset :P
2023-01-10 01044, 2023
yellowhatpro
Currently its working fine. I'll add more fixes soon for playlists and other stuff. The current impl in itself was kinda imp so only did the most imp part in this PR.
2023-01-10 01028, 2023
KassOtsimine
but i mean sure "all alphabets, and gyps, as long as they do not casue issues" is soemthing i'm 100% behind?
2023-01-10 01046, 2023
yellowhatpro
Please let me know anything breaks, if there are any edge cases, I'll fix them.
2023-01-10 01031, 2023
KassOtsimine
reo, you mentioned a differnt page to be able to link already excisting unlinked stuff on LB what was that?
2023-01-10 01040, 2023
reosarevok
From your listen history, by the listen, click the ... menu and you should have a link to MB option
2023-01-10 01052, 2023
reosarevok
Maybe only in beta.lb? I forget
2023-01-10 01036, 2023
yvanzo
reosarevok: validate_username is used to edit user profile too, so it would likely block editing current users, just a guess, didn't test.
2023-01-10 01006, 2023
reosarevok
Oh, maybe. We should test that - whether it validates also when it's not being changed
