You can try creating that file manually as they did in that PR #104
2023-01-23 02350, 2023
monkey
And if that solves the issue open a PR forreact-datetime-picker
2023-01-23 02344, 2023
jivte
actually this fix i also experimented
2023-01-23 02351, 2023
jivte
but no luck :(
2023-01-23 02307, 2023
jivte
so for the time being using a dummy declaration
2023-01-23 02305, 2023
monkey
OK
2023-01-23 02347, 2023
vibhoo_24 joined the channel
2023-01-23 02337, 2023
Freso
alastairp: Going to close all my MeB tabs for a couple of hours now until the meeting. Might be better if you send me an e-mail if you have questions.
2023-01-23 02351, 2023
alastairp
Freso: OK, I'll prepare some notes or we can talk tomorrow. I guess that means that none of the botbot items from the docsprint were on your radar for last week?
2023-01-23 02311, 2023
agatzk joined the channel
2023-01-23 02328, 2023
Thuraabtech joined the channel
2023-01-23 02339, 2023
vibhoo_24 has quit
2023-01-23 02359, 2023
reyku joined the channel
2023-01-23 02315, 2023
serial-ata joined the channel
2023-01-23 02315, 2023
jivte
monkey: while updating snapshots getting this error ( TS2307: Cannot find module 'react-datetime-picker/dist/entry.nostyle' or its corresponding type declarations. import DateTimePicker from "react-datetime-picker/dist/entry.nostyle";
2023-01-23 02325, 2023
jivte
getting this error
2023-01-23 02301, 2023
reyku has quit
2023-01-23 02336, 2023
vibhoo_24 joined the channel
2023-01-23 02349, 2023
jivte_ has quit
2023-01-23 02315, 2023
BrainzGit
[musicbrainz-android] 14dependabot[bot] opened pull request #192 (03master…dependabot/gradle/com.google.android.material-material-1.9.0-alpha01): Bump material from 1.8.0-beta01 to 1.9.0-alpha01 https://github.com/metabrainz/musicbrainz-android…
2023-01-23 02321, 2023
BrainzGit
[musicbrainz-android] 14dependabot[bot] closed pull request #182 (03master…dependabot/gradle/com.google.android.material-material-1.8.0-rc01): Bump material from 1.8.0-beta01 to 1.8.0-rc01 https://github.com/metabrainz/musicbrainz-android…
2023-01-23 02344, 2023
reosarevok
bitmap: ping
2023-01-23 02301, 2023
bitmap
reosarevok: pong
2023-01-23 02318, 2023
reosarevok
Remember how I told you to hide the attributes help link for dates-only?
2023-01-23 02333, 2023
bitmap
yeah
2023-01-23 02336, 2023
reosarevok
I just took another look at prod, and noticed an additional help link:
Which I guess you accidentally dropped when converting, and I didn't even remember existed so never noticed
2023-01-23 02325, 2023
reosarevok
So we could re-add that instead :)
2023-01-23 02338, 2023
bitmap
ah I forgot about that too, I can add it back
2023-01-23 02308, 2023
reosarevok
Thanks! No need to make a ticket I guess then
2023-01-23 02322, 2023
reosarevok
Also, remind me, do we have any docs about how to get files served by staticbrainz?
2023-01-23 02359, 2023
reosarevok
(since I guess eventually I'd want the OpenAPI specs I'm writing to be served by SB)
2023-01-23 02308, 2023
bitmap
I believe there are some docs for that in syswiki
2023-01-23 02338, 2023
bitmap
StaticBrainz.md
2023-01-23 02321, 2023
jivte has quit
2023-01-23 02342, 2023
jasje_ joined the channel
2023-01-23 02346, 2023
jasje has quit
2023-01-23 02352, 2023
bitmap
but if those will be stored in the mbs repo then it should be pretty easy to modify the 'MusicBrainz Static Resources' jenkins job to upload them
2023-01-23 02345, 2023
monkey
jivte: I tried locally, rebuilt the container first (`./test.sh fe -b`)`and re-ran the test script to update the snapshot (`./test.sh fe -u`), it worked for me.
I guess we could just run that in /doc/API, but ideally I imagine we'd want to still have the MB style and whatnot on the page? Or should it just be a fully static HTML page?
2023-01-23 02322, 2023
reosarevok
(we don't have many of those except for tests like root/static/scripts/tests/web.html)
2023-01-23 02338, 2023
bitmap
maybe we can customize the theme a bit? but I think static pages are fine for developer docs
2023-01-23 02342, 2023
vibhoo_24 has quit
2023-01-23 02354, 2023
reosarevok
Oh, btw, I was thinking
2023-01-23 02310, 2023
reosarevok
If we can make the release editor accept seeding for everything (rather than just most things as now)
2023-01-23 02322, 2023
reosarevok
Wouldn't that make it trivial to add a "save and continue later" button, at least for additions?
2023-01-23 02343, 2023
reosarevok
I guess if it's all on React state, that'd also kinda be the same
2023-01-23 02313, 2023
bitmap
yep, we could already do the same with the new relationship editor if we wanted (it already saves everything when you submit the form)
2023-01-23 02354, 2023
reosarevok
Yeah
2023-01-23 02308, 2023
reosarevok
My worry with editing releases and the relationship editor is that there can be conflicts
2023-01-23 02313, 2023
reosarevok
(someone can change them in between)
2023-01-23 02324, 2023
reosarevok
But that won't be a problem with an addition, so probably easier to start there
2023-01-23 02335, 2023
bitmap nods
2023-01-23 02353, 2023
reosarevok
(plus with the relationship editor you usually can submit all to continue later at least)
2023-01-23 02308, 2023
bitmap
I was working on finishing the docs for react state last week, will hopefully submit a PR before the meeting
2023-01-23 02321, 2023
reosarevok
<3
2023-01-23 02351, 2023
reosarevok
Also, I haven't seen this before (Sentry): "RangeError: Attempt to access memory outside buffer bounds"
2023-01-23 02336, 2023
bitmap
is that from the template renderer? that's the only place I can remember where we use Buffer
yeah it is, looks like the perl sent less data than it expected. we really need to modify the template renderer to include the URL in the setry data
2023-01-23 02308, 2023
bitmap
I'd guess a script or someone modifying the URL by hand
2023-01-23 02352, 2023
vibhoo_24 joined the channel
2023-01-23 02307, 2023
vibhoo_24 has quit
2023-01-23 02343, 2023
reyku joined the channel
2023-01-23 02308, 2023
reyku has quit
2023-01-23 02326, 2023
BrainzGit
[listenbrainz-android] 14dependabot[bot] opened pull request #37 (03main…dependabot/gradle/room_version-2.5.0): Bump room_version from 2.4.3 to 2.5.0 https://github.com/metabrainz/listenbrainz-androi…
2023-01-23 02342, 2023
BrainzGit
[listenbrainz-android] 14dependabot[bot] opened pull request #38 (03main…dependabot/gradle/com.google.android.material-material-1.9.0-alpha01): Bump material from 1.8.0-beta01 to 1.9.0-alpha01 https://github.com/metabrainz/listenbrainz-androi…
2023-01-23 02346, 2023
BrainzGit
[listenbrainz-android] 14dependabot[bot] closed pull request #28 (03main…dependabot/gradle/com.google.android.material-material-1.8.0-rc01): Bump material from 1.8.0-beta01 to 1.8.0-rc01 https://github.com/metabrainz/listenbrainz-androi…
2023-01-23 02313, 2023
vibhoo_24 joined the channel
2023-01-23 02304, 2023
reosarevok
bitmap: is that something we haven't done because it's hard, or we just never spent the 10 minutes? :)
2023-01-23 02325, 2023
jasje_ has quit
2023-01-23 02306, 2023
reosarevok
yvanzo: I'm writing a ton of suggestions on the URL document, hope it's not too annoying :D
2023-01-23 02333, 2023
aerozol
Ata mārie tīmu!
2023-01-23 02329, 2023
aerozol
mayhem: Did you see the extended mockup for the Fresh Releases design? Just looking at your comments now, I’ll do another version on that ‘page’ in the figma
2023-01-23 02330, 2023
yvanzo
reosarevok: Take all the time you need. It took me about two days.
(and apparently also Community Manager Appreciation Day)
2023-01-23 02304, 2023
Freso
I haven’t received any mailed in reviews, so…
2023-01-23 02305, 2023
Freso
People up: reosarevok, monkey, mayhem, yvanzo, akshaaatt, atj, lucifer, zas, alastairp, bitmap, vibhoo_24, jasje, Pratha-Fish, riksucks, CatQuest, jivte, yellowhatpro, Freso – anyone else who wish to give review, please let me know ASAP.
2023-01-23 02305, 2023
Freso
reosarevok: Go!
2023-01-23 02318, 2023
KassOtsimine
dun wanna measure my feet :(
2023-01-23 02318, 2023
reosarevok
alastairp (yvanzo): basically I'm waiting for yvanzo to decide what's best for the field names and then either I or he can merge
2023-01-23 02325, 2023
reosarevok
Hi!
2023-01-23 02346, 2023
reosarevok
Last week I mostly spent time on documentation (as one would hope)
2023-01-23 02356, 2023
alastairp
you know what they say. big feet...
2023-01-23 02302, 2023
alastairp
large shoes
2023-01-23 02315, 2023
CatQuest
bwahaha
2023-01-23 02320, 2023
reosarevok slaps alastairp with a large arctic char
2023-01-23 02327, 2023
CatQuest
wtf is a char?
2023-01-23 02334, 2023
CatQuest
is that a fish?
2023-01-23 02347, 2023
aerozol throws a pompano
2023-01-23 02352, 2023
CatQuest
wtf guys XD
2023-01-23 02353, 2023
reosarevok
I also worked quite a bit on testing (and somewhat improving) the relationship editor (the version on test.mb looks really nice IMO, thanks bitmap and aerozol)
2023-01-23 02316, 2023
CatQuest
lmao
2023-01-23 02343, 2023
reosarevok
And lately I've been looking into a decent set of interactive API docs using Swagger (thanks alastairp for starting the work and being a big help with the whole thing)
2023-01-23 02323, 2023
reosarevok
I'm not even done with artist, so this is going to take quite a while, and I'm afraid it's not going to be very easy to automate it from the code (it might be easier to actually generate bits of the code using the OpenAPI spec, if anything)
2023-01-23 02304, 2023
reosarevok
But it feels a lot more useful to me than the current wiki mess I spent a lot of time trying to get to a decent level without even getting there (all I can say is they suck less than they used to) so I'm happy with the progress
2023-01-23 02324, 2023
reosarevok
Oh, and I helped CatQuest a bit with merging a weird catch-all instrument which wasn't really working out
2023-01-23 02329, 2023
reosarevok
Speaking of, CatQuest, go? :)
2023-01-23 02332, 2023
CatQuest
Meow! `😺`
2023-01-23 02336, 2023
aerozol
reosarevok: So this is a system that would replace the wiki?
2023-01-23 02340, 2023
aerozol
Sorry can talk after :)
2023-01-23 02348, 2023
alastairp
aerozol: specifically for API docs, yes
2023-01-23 02351, 2023
CatQuest
wait for documentaiton or everything?
2023-01-23 02354, 2023
CatQuest
:( I liek the wiki
2023-01-23 02300, 2023
CatQuest
Last week I looked through my backlog and cleaned it up
2023-01-23 02320, 2023
CatQuest
WE did some research and put in a merge for an old messed up catch-all instrument
2023-01-23 02326, 2023
CatQuest
I've also added heaps of aliases on instruments and have also added an instrument - this week I will be adding more bagpipes.
make sure it's not already in mb or already has a ticket in jira
2023-01-23 02358, 2023
CatQuest
also don't add novelties or ones with no info available, but else. go wild! ♑
2023-01-23 02358, 2023
CatQuest
♑
2023-01-23 02358, 2023
CatQuest
fin ΦωΦ, go monkey
2023-01-23 02306, 2023
monkey
Hi everyone
2023-01-23 02329, 2023
monkey
Last week I spent a bunch of time improving the BookBrainz user docs
2023-01-23 02329, 2023
reosarevok
yvanzo: three, but that shows the docs suck if you might not even have found the third :D
2023-01-23 02352, 2023
reosarevok
!m monkey
2023-01-23 02352, 2023
BrainzBot
You're doing good work, monkey!
2023-01-23 02359, 2023
monkey
Diagnosed an issue with the live API docs for BB (problem was between my computer and my chair it turns out), so that's back online after a hiatus
2023-01-23 02301, 2023
yvanzo
anyway not all the wiki
2023-01-23 02307, 2023
KassOtsimine
oh good
2023-01-23 02323, 2023
Pratha-Fish wonders if KassOtsimine and CatQuest are the same 🗿
2023-01-23 02329, 2023
KassOtsimine
is indeed
2023-01-23 02331, 2023
Freso
Pratha-Fish: They are.
2023-01-23 02335, 2023
monkey
Looked at cleaning up the autogenerated JSDocs as well, which are pretty unreadable all jumbled up
2023-01-23 02335, 2023
aerozol
Good to know! Though a Wiki refresh wouldn’t hurt let’s be honest!
2023-01-23 02337, 2023
Pratha-Fish
```wauw```
2023-01-23 02316, 2023
monkey
Also accepted some help from brand new contributors to improve the developer docs (specifically for getting set up locally and troubleshooting install issues)
2023-01-23 02300, 2023
reosarevok
Always the best way to figure out what's not working
