[musicbrainz-server] 14mwiencek merged pull request #2937 (03schema-change-2023-q2…mbs-12107): MBS-12107: Enable replication with dbmirror2 by default https://github.com/metabrainz/musicbrainz-server/…
2023-05-15 13514, 2023
aerozol
mayhem: If we’re not updating reports then shall we remove this link from the menu? It makes MetaBrainz looks like it’s not being maintained if it happens to be one of the first pages you visit: https://metabrainz.org/reports/2017
2023-05-15 13553, 2023
bukwurm joined the channel
2023-05-15 13509, 2023
outsidecontext
aerozol: that apiseeds lyrics question is odd. They say they registered an API key on apiseeds.com, but this has not been available since 2 years, the Picard plugin also got removed 2 years ago. 🤔
2023-05-15 13502, 2023
aerozol
outsidecontext: Yeah I clicked to that after looking at the Google translate results a bit closer. Maybe someone wants to tell them they’re out of luck in French :D
2023-05-15 13559, 2023
outsidecontext
There was happi.dev as the successor, and even that shut down earlier this year
2023-05-15 13531, 2023
aerozol
Yeah, lyrics sites aren’t worth putting heaps of effort into supporting imo, unless they’re some ma$$ive outfit like Genius
2023-05-15 13535, 2023
outsidecontext
aerozol: indeed. there have been several lyrics plugins come and go. everything with an open API will have a short time span :)
2023-05-15 13555, 2023
outsidecontext
I reactivated my old reddit account and answered in English
2023-05-15 13524, 2023
aerozol
<3
2023-05-15 13506, 2023
Pratha-Fish
Hey reosarevok would the codebase for the bot be on MetaBrainz's GitHub profile, or my own GitHub profile? Just confirming
2023-05-15 13545, 2023
reosarevok
Probably MeB, I can open a repo at some point
2023-05-15 13504, 2023
reosarevok
Then you can work on your fork and send PRs against the MeB one as needed
2023-05-15 13511, 2023
BrainzGit has quit
2023-05-15 13525, 2023
BrainzGit joined the channel
2023-05-15 13555, 2023
aerozol has quit
2023-05-15 13503, 2023
aerozol joined the channel
2023-05-15 13508, 2023
Hobbyboy|BNC joined the channel
2023-05-15 13509, 2023
pbryan8 joined the channel
2023-05-15 13530, 2023
Hobbyboy has quit
2023-05-15 13530, 2023
DjSlash has quit
2023-05-15 13530, 2023
KassOtsimine has quit
2023-05-15 13505, 2023
yvanzo has quit
2023-05-15 13505, 2023
pbryan has quit
2023-05-15 13505, 2023
riksucks has quit
2023-05-15 13506, 2023
pbryan8 is now known as pbryan
2023-05-15 13540, 2023
kgz has quit
2023-05-15 13522, 2023
KassOtsimine joined the channel
2023-05-15 13523, 2023
yvanzo joined the channel
2023-05-15 13533, 2023
Hobbyboy|BNC is now known as Hobbyboy
2023-05-15 13506, 2023
DjSlash joined the channel
2023-05-15 13521, 2023
riksucks joined the channel
2023-05-15 13517, 2023
KT03 joined the channel
2023-05-15 13520, 2023
aerozol
reosarevok: Do we have a media at metabrainz email? Just making a generic comms/marketing form to fill out, and need a default email. I know you check the community manager email but not sure if that’s quite right
2023-05-15 13508, 2023
KT03 has quit
2023-05-15 13513, 2023
kgz joined the channel
2023-05-15 13527, 2023
antlarr has quit
2023-05-15 13500, 2023
antlarr joined the channel
2023-05-15 13555, 2023
lucifer
mayhem: hi! I had filled the Soundcloud form to change redirect uri about 8-9 days ago but haven't received any response. should we reach out to the person we had a meet with the other day? also, can we request him to make one more application for us that we can deploy on test.lb for testing.
2023-05-15 13557, 2023
yvanzo
About one hour of downtime is expected starting from 5pm UTC to upgrade to the MusicBrainz database to its latest schema.
i prefer to pivot and then touch base to make sure we're in lockstep
2023-05-15 13555, 2023
aerozol
everyone: I’m putting together a list of news sites to send news to - where do you get your tech/open source/music information from, that might suit us? Especially smaller nerdy outfits. New-fangled podcasts and youtube channels, etc, qualify just fine.
2023-05-15 13512, 2023
aerozol
mayhem: maybe those docs are a good start re. stuff for Rassami to look at and feed back on or add to
2023-05-15 13552, 2023
aerozol
okay, bed time for me. Hope the schema change goes well all!
reosarevok: yvanzo: hey, I finished running upgrade.sh against a clone of the production DB (musicbrainz_schema_change_2023_q2 on aretha) last night, and didn't have any issues
2023-05-15 13538, 2023
yvanzo
👍
2023-05-15 13552, 2023
reosarevok
<3
2023-05-15 13526, 2023
bitmap
also, I was checking the consistency of the first-release-date data
2023-05-15 13534, 2023
yvanzo
I set up a mirror using Docker Compose to be able to test upgrade after main server has been upgraded in proudciton.
release_first_release_date is identical to a query that computes it from scratch, which is good
2023-05-15 13550, 2023
yvanzo
(very proudly)
2023-05-15 13501, 2023
bitmap
I did notice that some first-release-date data in release_group_meta and recording_first_release_date is wrong/inconsistent, but then checked the production DB, and those problems already exist there. so it appears to be unrelated to withdrawn releases or the upgrade script
2023-05-15 13526, 2023
bitmap
and I think I know why the recording ones are wrong, but it'll have to be a future schema change
2023-05-15 13547, 2023
yvanzo
Oh, it's that bad? :/
2023-05-15 13506, 2023
bitmap
well, I'm pretty sure we're missing a trigger for medium updates - when releases are merged using the append strategy, some medium.release columns are updated, which affects all of those mediums' recordings' dates
2023-05-15 13533, 2023
yvanzo
I see
2023-05-15 13505, 2023
yvanzo
Fortunately this can be changed in production ahead of the next schema change release since it doesn't require any change on mirror side.
2023-05-15 13512, 2023
yvanzo
bitmap: Why is it recommended to restart Redis for the schema change (last year at least)?
2023-05-15 13557, 2023
yvanzo
I guess it was related to some change but couldn't find it. Not sure it is still needed this year.
2023-05-15 13552, 2023
bitmap
I'm guessing just in case there are any code changes that affect cached entities (like changing the Moose entity models)
2023-05-15 13509, 2023
bitmap
right, it may not be needed this year
2023-05-15 13514, 2023
reosarevok
Do mirrors get the date info from us or do they calculate it with their own triggers? I forget
2023-05-15 13540, 2023
yvanzo
Good question, not sure.
2023-05-15 13511, 2023
bitmap
release_group_meta is replicated, but the other two materialized tables (release_first_release_date, recording_first_release_date) are not and are updated by triggers on mirrors.
2023-05-15 13524, 2023
bitmap
we could rebuild recording_first_release_date as part of our upgrade steps and recommend mirrors do too. though it will lengthen upgrade process by a little bit and won't fix the underlying issue, just existing data.
2023-05-15 13547, 2023
reosarevok
Yeah, that's what I was thinking
2023-05-15 13555, 2023
reosarevok
How hard is that fix?
2023-05-15 13547, 2023
reosarevok
(as in, is there any chance we can offer a way to fix it for schema change users if they want to fix it as part of this SC even though it was not announced, or is it hard and we should wait with it anyway?)
2023-05-15 13509, 2023
bitmap
well, I don't think writing the trigger will be hard, but would rather wait to test it properly. we could always mention the upgrade script in future MBS/docker release notes
2023-05-15 13556, 2023
yvanzo
I would just wait with it, we can probably come with a workaround to fix existing first release dates before the next schema change.
2023-05-15 13522, 2023
reosarevok
I'm sure we can, it's just they'd need to run it repeatedly :)
2023-05-15 13539, 2023
reosarevok
But I guess there's no reason we can't say that we'll publish an updated trigger later
2023-05-15 13547, 2023
reosarevok
And they can install it outside the schema change themselves
