A user installs the LB app. Now they start listening to songs on Youtube Music, for example.
2023-06-26 17754, 2023
akshaaatt
Should the scrobbler automatically submit the listens or take confirmation from the user first so that they enavle the submissions from YouTube music?
2023-06-26 17722, 2023
mayhem
I think prompting the user would be nice.
2023-06-26 17738, 2023
akshaaatt
Cool. I think a push notification should do
2023-06-26 17747, 2023
mayhem
agreed/
2023-06-26 17758, 2023
akshaaatt
So the user will have to explicitly add the apps they want to scrobble
2023-06-26 17706, 2023
mayhem
yes!
2023-06-26 17718, 2023
akshaaatt
Sounds good. I’ll get the update added to the pipeline
2023-06-26 17724, 2023
mayhem
great, thanks!
2023-06-26 17712, 2023
atj
would it scrobble when you watch a video in the browser?
2023-06-26 17751, 2023
akshaaatt
Not yet atj. But that’s a good question hmmm
2023-06-26 17730, 2023
akshaaatt
I’ll have to check once though. We basically listen to the notifications and submit listens via it
2023-06-26 17731, 2023
atj
IIUC it gets data from media playback notifications?
2023-06-26 17750, 2023
akshaaatt
I’m unsure if the browser submits a notification for this
2023-06-26 17758, 2023
akshaaatt
Yuss atj
2023-06-26 17737, 2023
mayhem
monkey: LB radio now has a new syntax and supports artist name in queries`artist:(pretty lights):2 artist:(ott):1`
2023-06-26 17749, 2023
mayhem
tags are now comma separated.
2023-06-26 17755, 2023
theflash_ joined the channel
2023-06-26 17713, 2023
monkey
Awesome !
2023-06-26 17754, 2023
monkey
I was wondering about that (MBIDs are cumbersome), but didn't want to add on your plate while you were knee deep.
2023-06-26 17713, 2023
mayhem
its a useful testing shorthand and wasn't that much work to add.
2023-06-26 17721, 2023
monkey
Out of curiosity, what happens for homonyms?
2023-06-26 17727, 2023
mayhem
I have a couple of minor improvements to make, then I will make a PR to get this merged.
2023-06-26 17728, 2023
theflash_
Hi akshaaatt! I have fixed user-name issue
2023-06-26 17731, 2023
mayhem
this PR is too huge already.
2023-06-26 17703, 2023
mayhem
it picks the first one for homonyms.
2023-06-26 17713, 2023
mayhem
not intended to solve all problems.
2023-06-26 17741, 2023
monkey
Yep, makes sense
2023-06-26 17734, 2023
akshaaatt
atj, browser also works fine😂🔥
2023-06-26 17726, 2023
akshaaatt
I didn’t know browsers also give a media playback notification on mobile
2023-06-26 17754, 2023
atj
akshaaatt: this is an area where you could really piss off users if you're not careful
2023-06-26 17727, 2023
akshaaatt
Agreed
2023-06-26 17732, 2023
atj
i doubt people expect or want scrobbles from videos in browsers
2023-06-26 17719, 2023
akshaaatt
Yeah! I’m against it as well. It’ll end up scrobbling unwanted shit
2023-06-26 17740, 2023
akshaaatt
I would love a way for us to be able to distinguish normal videos from music
2023-06-26 17753, 2023
akshaaatt
monkey, can you help think of a solution for this?
2023-06-26 17700, 2023
monkey
I've been dreaming of this since I added scrobbling from BrainzPlayer
2023-06-26 17731, 2023
monkey
I don't have a good way to do this unfortunately. But if any inspiration is needed, I would point to WebScrobbler
2023-06-26 17752, 2023
akshaaatt
Yeah, you did give the YT example of webscrobbler
2023-06-26 17755, 2023
monkey
They do use some internal youtube api for example to determine if the video is music
2023-06-26 17702, 2023
monkey
Yeah, that's all Ive got :p
2023-06-26 17705, 2023
monkey
:/
2023-06-26 17715, 2023
monkey
But it looks quite unstable
2023-06-26 17727, 2023
akshaaatt
Why can’t we use MB for this?
2023-06-26 17742, 2023
monkey
How do you suggest doing that?
2023-06-26 17701, 2023
akshaaatt
If there were an api which could take in the title and artist and tell us whether it’s a song or not
2023-06-26 17721, 2023
akshaaatt
Isn’t that what you would expect from an encyclopaedia?
2023-06-26 17722, 2023
monkey
IMO we should stray away from scrobbling from browser entirely, and offer a good and easy way fo users to manually add listens
2023-06-26 17740, 2023
monkey
I guess, but what if the track is not in MB?
2023-06-26 17747, 2023
monkey
I don't see this as a viable solution
2023-06-26 17752, 2023
akshaaatt
Agreed
2023-06-26 17713, 2023
akshaaatt
I can hardcode to omit the browsers from submission
2023-06-26 17720, 2023
akshaaatt
But that again isn’t a complete solution
2023-06-26 17723, 2023
monkey
I think that would be the safe way to go. However some users might want to enable it. I guess it could be disabled by default and have a warning message when you enable it the first time
2023-06-26 17735, 2023
Pratha-Fish
Hey where do I send mail in reviewS?
2023-06-26 17749, 2023
akshaaatt
Hmmm
2023-06-26 17758, 2023
kepstin
FYI, i opened MOBILE-160 on the weekend since i hit the problem of unintentionally submitted listens.
Thanks for the ticket, kepstin. The discussion has been in your favour. I’ll get the update in beta soon.
2023-06-26 17753, 2023
monkey
What I think would make it easy to use would be a way to manually submit a listen from any active media notification. So I could have scrobbling disabled for my browser, but if I listen to a song I can open the LB app and click on a a button to manually scrobble the current media notification
2023-06-26 17715, 2023
akshaaatt
Interesting
2023-06-26 17755, 2023
kepstin
On android, a persistent notification would be nice for that - it would say that auto-submission is disabled, show the currently selected song, and could have a "submit" button in the notification itself.
2023-06-26 17714, 2023
akshaaatt
I love that solution kepstin
2023-06-26 17744, 2023
akshaaatt
That also gives us the idea to add more features to the notification. We can add all sorts of options there
2023-06-26 17707, 2023
kepstin
can't add too much, there's not much room in a notification for actions. no more than 2 or so is good :)
2023-06-26 17735, 2023
akshaaatt
Right
2023-06-26 17756, 2023
monkey
Ability to edit on the fly would be nice
2023-06-26 17706, 2023
monkey
edit the details of the listen before submission, I mean
2023-06-26 17712, 2023
akshaaatt
Awesome!
2023-06-26 17730, 2023
kepstin
looks like pano scrobbler currently shows up to three actions, as icons (not text). A heart button (always visible), and edit and cancel buttons, which are only visible up until the listen has been submitted.
right now I have an bug of preview song playing when you play a song, which I have to fix
2023-06-26 17750, 2023
theflash_
akshaaatt: Sure, bring it on !
2023-06-26 17719, 2023
vscode_
Type bindings for Musickit are not working for some reason so I have created a file where I copied the the type bindings from a library but if I try to use the library directly it was not working for some reason (https://github.com/wsmd/musickit-typescript)
2023-06-26 17742, 2023
vscode_
riksucks:^
2023-06-26 17704, 2023
riksucks
vscode_: noted, can you add that in the description of the PR so that we don't forget that
2023-06-26 17720, 2023
akshaaatt
theflash_: I want you to explore shazamkit and musickit. So the task is to make the BrainzPlayer and try adding a shazamkit feature to discover the song and submit it
2023-06-26 17739, 2023
vscode_
riksucks: okay I will do that
2023-06-26 17749, 2023
akshaaatt
Listens submission will be a big task but this should be a good start theflash_
2023-06-26 17757, 2023
riksucks
Thanks :)
2023-06-26 17717, 2023
akshaaatt
Also, don’t stress too much on the UI for the BP rn theflash_ .
2023-06-26 17731, 2023
theflash_
Alright! Captain:) , will hop on it and tell ya
2023-06-26 17749, 2023
akshaaatt
Awesome!
2023-06-26 17715, 2023
theflash_
Please elaborate about submitting listens, akshaaatt
2023-06-26 17759, 2023
akshaaatt
So whenever you’re playing a song on your device or your BP, we want it to be submitted to the LB server so that it gets added to your listening history
2023-06-26 17716, 2023
akshaaatt
We usually call this scrobbling
2023-06-26 17727, 2023
akshaaatt
Theoretically, when on the app and the user clicks a song, we play it via spotify/yt music/amazon music etc because LB doesn’t provide streaming
2023-06-26 17737, 2023
akshaaatt
But we want to log that to the listening history
2023-06-26 17703, 2023
akshaaatt
So currently on android, we listen to the notifications tray of the device and submit whatever is playing there to LB
2023-06-26 17734, 2023
akshaaatt
Same way, when the user plays something via the app on the BP, we submit that
Seems like user-token is going to play its part here
2023-06-26 17716, 2023
akshaaatt
Yus!
2023-06-26 17753, 2023
theflash_
Alright!
2023-06-26 17701, 2023
reosarevok
<BANG>
2023-06-26 17719, 2023
reosarevok
Welcome to How is it Monday again and Why is June Ending
2023-06-26 17730, 2023
reosarevok
We have two mailed reviews this week!
2023-06-26 17746, 2023
reosarevok
Pratha-Fish says:
2023-06-26 17747, 2023
reosarevok
'''
2023-06-26 17752, 2023
reosarevok
Hi all, last week was quite productive!
2023-06-26 17756, 2023
reosarevok
So much so that I am going to bunk this meet and go complete the sleep I sacrificed!
2023-06-26 17701, 2023
reosarevok
- I was able to setup musicbrainz-docker locally to setup tests, which was a challenge in itself. (super धन्यवाद to bitmap and atj)
2023-06-26 17706, 2023
reosarevok
- Had the opportunity to learn a lot of new stuff about Docker, Python Packages, postgres, and testing!
2023-06-26 17712, 2023
reosarevok
- After a few discussions and I was left *confused af* and decided to make a "problem tree" to visualize the issues - which unfortunately happens to be growing faster than bamboo. 💀
2023-06-26 17718, 2023
reosarevok
- However, if we keep up this level of quality, I am positive the AreaBot would come out better than we envisioned! Complete with some generic improvements to the MusicBrainz-Bot (potentially as a complete python package as opposed to just a repository), as well as a new stable AreaBot with better tests, CI/CD, and deployment using docker :)
2023-06-26 17724, 2023
reosarevok
- Looking forward to some PR reviews soon, to be able to move ahead with some of the other caveats in the testing setup.
2023-06-26 17727, 2023
reosarevok
fin 🐟
2023-06-26 17729, 2023
reosarevok
'''
2023-06-26 17743, 2023
reosarevok
bitmap: let's try to look at Pratha-Fish's stuff after the meeting :)
2023-06-26 17751, 2023
reosarevok
The other review is our eternal sleeper aerozol:
2023-06-26 17759, 2023
ApeKattQuest
💤
2023-06-26 17710, 2023
reosarevok
'''
2023-06-26 17716, 2023
reosarevok
Hey all! Happy 5am!
2023-06-26 17720, 2023
reosarevok
I mailed this to reo last week, so it didn’t get read out at the last meeting, because he is a slacker, but I will be on holiday from 7 - 27 July.
2023-06-26 17724, 2023
reosarevok
I will still have my laptop and will do the usual bits and pieces, but if you have something bigger for me to do let me know ASAP, and let’s get it done.
2023-06-26 17729, 2023
reosarevok
Last week I polished off some new MB icons with reo, might try to do some more before I go, but those are the main ones that have bugged me. Preview the new ones here: MBS-13130, MBS-12942, MBS-12951
I spent a while discussing and pencilling out possible guidelines for LLM/’AI’ use in MeB, which you can all have fun arguing about later this meeting.
2023-06-26 17741, 2023
reosarevok
Quite a bit of moderation on CB (very much related to the above)
2023-06-26 17744, 2023
reosarevok
Worked on some app mockups with jasje and akshaaatt, looking forward to doing more.
2023-06-26 17748, 2023
reosarevok
Made some fun ’Not made with AI’ stickers for mayhem’s current LB project, LB-1304. Can be used until we replace mayhem with a LLM.
