#metabrainz

If you’re free, I would like to discuss the default behaviour of the scrobbler

sure

Ugh

A user installs the LB app. Now they start listening to songs on Youtube Music, for example.

Should the scrobbler automatically submit the listens or take confirmation from the user first so that they enavle the submissions from YouTube music?

I think prompting the user would be nice.

Cool. I think a push notification should do

agreed/

So the user will have to explicitly add the apps they want to scrobble

yes!

Sounds good. I’ll get the update added to the pipeline

great, thanks!

would it scrobble when you watch a video in the browser?

Not yet atj. But that’s a good question hmmm

I’ll have to check once though. We basically listen to the notifications and submit listens via it

IIUC it gets data from media playback notifications?

I’m unsure if the browser submits a notification for this

Yuss atj

monkey: LB radio now has a new syntax and supports artist name in queries`artist:(pretty lights):2 artist:(ott):1`

tags are now comma separated.

Awesome !

I was wondering about that (MBIDs are cumbersome), but didn't want to add on your plate while you were knee deep.

its a useful testing shorthand and wasn't that much work to add.

Out of curiosity, what happens for homonyms?

I have a couple of minor improvements to make, then I will make a PR to get this merged.

Hi akshaaatt! I have fixed user-name issue

this PR is too huge already.

it picks the first one for homonyms.

not intended to solve all problems.

Yep, makes sense

atj, browser also works fine😂🔥

I didn’t know browsers also give a media playback notification on mobile

akshaaatt: this is an area where you could really piss off users if you're not careful

Agreed

i doubt people expect or want scrobbles from videos in browsers

Yeah! I’m against it as well. It’ll end up scrobbling unwanted shit

I would love a way for us to be able to distinguish normal videos from music

monkey, can you help think of a solution for this?

I've been dreaming of this since I added scrobbling from BrainzPlayer

I don't have a good way to do this unfortunately. But if any inspiration is needed, I would point to WebScrobbler

Yeah, you did give the YT example of webscrobbler

They do use some internal youtube api for example to determine if the video is music

Yeah, that's all Ive got :p

:/

But it looks quite unstable

Why can’t we use MB for this?

How do you suggest doing that?

If there were an api which could take in the title and artist and tell us whether it’s a song or not

Isn’t that what you would expect from an encyclopaedia?

IMO we should stray away from scrobbling from browser entirely, and offer a good and easy way fo users to manually add listens

I guess, but what if the track is not in MB?

I don't see this as a viable solution

Agreed

I can hardcode to omit the browsers from submission

But that again isn’t a complete solution

I think that would be the safe way to go. However some users might want to enable it. I guess it could be disabled by default and have a warning message when you enable it the first time

Hey where do I send mail in reviewS?

Hmmm

FYI, i opened MOBILE-160 on the weekend since i hit the problem of unintentionally submitted listens.

MOBILE-160: App selection for listen submission should be opt-in, not opt-out https://tickets.metabrainz.org/browse/MOBILE-160

Similar to what we do with the spotify toggle

Thanks for the ticket, kepstin. The discussion has been in your favour. I’ll get the update in beta soon.

What I think would make it easy to use would be a way to manually submit a listen from any active media notification. So I could have scrobbling disabled for my browser, but if I listen to a song I can open the LB app and click on a a button to manually scrobble the current media notification

Interesting

On android, a persistent notification would be nice for that - it would say that auto-submission is disabled, show the currently selected song, and could have a "submit" button in the notification itself.

I love that solution kepstin

That also gives us the idea to add more features to the notification. We can add all sorts of options there

can't add too much, there's not much room in a notification for actions. no more than 2 or so is good :)

Right

Ability to edit on the fly would be nice

edit the details of the listen before submission, I mean

Awesome!

looks like pano scrobbler currently shows up to three actions, as icons (not text). A heart button (always visible), and edit and cancel buttons, which are only visible up until the listen has been submitted.

Sound very reasonable

ah, MOBILE-149 has some screenshots of that

MOBILE-149: ListenBrainz scrobbling notifications https://tickets.metabrainz.org/browse/MOBILE-149

Hi theflash_ ! Thanks a lot for the awesome work!

I think you’ve come to a point where you can pace up

Let me know if you want to deal with more challenging problems

Otherwise, it’s a good idea to continue learning and gripping over existing knowledge

Hi riksucks: I have made a branch for the apple integration https://github.com/vardansaini/listenbrainz-ser...

In the code you have to use the apple api key that you sent me

Gotcha, feel free to open a PR. If you feel like it's not complete enough then feel free to mark it draft :)

[listenbrainz-server] 14vardansaini opened pull request #2508 (03master…apple-player): apple music player initial https://github.com/metabrainz/listenbrainz-serv...

Thanks vscode_ :)

I can make a video to demonstrate if you want

Sure, you can put it in the pr itself so others can see too

It is an initial implementation so error handling is not done yet

No worries, checking the logic is the main goal here. Afterwards let's work on error handling and the tests

[listenbrainz-server] 14vardansaini closed pull request #2508 (03master…apple-player): apple music player initial https://github.com/metabrainz/listenbrainz-serv...

[listenbrainz-server] 14vardansaini opened pull request #2509 (03master…apple-player): apple music player initial https://github.com/metabrainz/listenbrainz-serv...

okay I have opened a draft pull request

right now I have an bug of preview song playing when you play a song, which I have to fix

akshaaatt: Sure, bring it on !

Type bindings for Musickit are not working for some reason so I have created a file where I copied the the type bindings from a library but if I try to use the library directly it was not working for some reason (https://github.com/wsmd/musickit-typescript)

riksucks:^

vscode_: noted, can you add that in the description of the PR so that we don't forget that

theflash_: I want you to explore shazamkit and musickit. So the task is to make the BrainzPlayer and try adding a shazamkit feature to discover the song and submit it

riksucks: okay I will do that

Listens submission will be a big task but this should be a good start theflash_

Thanks :)

Also, don’t stress too much on the UI for the BP rn theflash_ .

Alright! Captain:) , will hop on it and tell ya

Awesome!

Please elaborate about submitting listens, akshaaatt

So whenever you’re playing a song on your device or your BP, we want it to be submitted to the LB server so that it gets added to your listening history

We usually call this scrobbling

Theoretically, when on the app and the user clicks a song, we play it via spotify/yt music/amazon music etc because LB doesn’t provide streaming

But we want to log that to the listening history

So currently on android, we listen to the notifications tray of the device and submit whatever is playing there to LB

Same way, when the user plays something via the app on the BP, we submit that

Makes sense, theflash_ ?

https://listenbrainz.readthedocs.io/en/latest/u... is the endpoint for listen submission

Yeah, pretty much clear

Seems like user-token is going to play its part here

Yus!

Alright!

Welcome to How is it Monday again and Why is June Ending

We have two mailed reviews this week!

Pratha-Fish says:

'''

Hi all, last week was quite productive!

So much so that I am going to bunk this meet and go complete the sleep I sacrificed!

- I was able to setup musicbrainz-docker locally to setup tests, which was a challenge in itself. (super धन्यवाद to bitmap and atj)

- Had the opportunity to learn a lot of new stuff about Docker, Python Packages, postgres, and testing!

- After a few discussions and I was left *confused af* and decided to make a "problem tree" to visualize the issues - which unfortunately happens to be growing faster than bamboo. 💀

- However, if we keep up this level of quality, I am positive the AreaBot would come out better than we envisioned! Complete with some generic improvements to the MusicBrainz-Bot (potentially as a complete python package as opposed to just a repository), as well as a new stable AreaBot with better tests, CI/CD, and deployment using docker :)

- Looking forward to some PR reviews soon, to be able to move ahead with some of the other caveats in the testing setup.

fin 🐟

'''

bitmap: let's try to look at Pratha-Fish's stuff after the meeting :)

The other review is our eternal sleeper aerozol:

💤

'''

Hey all! Happy 5am!

I mailed this to reo last week, so it didn’t get read out at the last meeting, because he is a slacker, but I will be on holiday from 7 - 27 July.

I will still have my laptop and will do the usual bits and pieces, but if you have something bigger for me to do let me know ASAP, and let’s get it done.

Last week I polished off some new MB icons with reo, might try to do some more before I go, but those are the main ones that have bugged me. Preview the new ones here: MBS-13130, MBS-12942, MBS-12951

MBS-13130: Update pencil/edit icon https://tickets.metabrainz.org/browse/MBS-13130

MBS-12942: Indicate pending edits for an entity in the relationship editor https://tickets.metabrainz.org/browse/MBS-12942

MBS-12951: Make (+) and (x) icons match https://tickets.metabrainz.org/browse/MBS-12951

I spent a while discussing and pencilling out possible guidelines for LLM/’AI’ use in MeB, which you can all have fun arguing about later this meeting.

Quite a bit of moderation on CB (very much related to the above)

Worked on some app mockups with jasje and akshaaatt, looking forward to doing more.

Made some fun ’Not made with AI’ stickers for mayhem’s current LB project, LB-1304. Can be used until we replace mayhem with a LLM.