yvanzo: do you have a good sample string to test with?
2023-08-28 24008, 2023
yvanzo
I can craft one
2023-08-28 24046, 2023
yvanzo
Actually it should be a pair source/target, right?
2023-08-28 24050, 2023
outsidecontext
yes. wen can either check one of the existing strings in the imported project, or we do some test with just a text file or such and setup a new component for that
2023-08-28 24001, 2023
yvanzo
`{entity1} has a BookBrainz page at {entity0}` from relationships
2023-08-28 24031, 2023
yvanzo
`is/was {additional:an|a} {additional} {original} {eponymous} member of` from relationships too
2023-08-28 24055, 2023
outsidecontext
let me check
2023-08-28 24043, 2023
yvanzo
`{additional} {instrument:%|instruments} {co:co-}arranger`from relationships as well (with a `%` placeholder)
2023-08-28 24005, 2023
outsidecontext
those are good. check needs some tweaking, but I think I got it. Just a minute
Hi abhinavohri ! I hope you don't mind too much my taking over of the stats art PR !
2023-08-28 24041, 2023
monkey
To be honest I wasn't nearly sure enough of how everything would be implemented to make good suggestions without trying to implement it myself ! Quite complex on many levels it turns out, and I'm far from done!
2023-08-28 24000, 2023
monkey
I was thinking this could be an easy ticket if you're looking for an easy one :) LB-1306
outsidecontext: I guess that if there is no `:` and a `|` then there are only two groups and `alternative` is None.
2023-08-28 24027, 2023
outsidecontext
I ran the code locally. it should work "{doc|license page}" has no consequent but alternative -> type "hyperlink"
2023-08-28 24053, 2023
yvanzo
outsidecontext: pushed a fix
2023-08-28 24054, 2023
outsidecontext
and "{doc:Nichts|Lizenzseite}" has both and gets type "replacement"
2023-08-28 24007, 2023
yvanzo
oh, ok
2023-08-28 24039, 2023
yvanzo
the commit is not fixing it but is probably safe to keep still
2023-08-28 24059, 2023
yvanzo
then the issue might be in assigning/comparing sets
2023-08-28 24040, 2023
outsidecontext
yvanzo: the problem might be as well me messing up copying the file over to my server :D but just done again freshly, now for sure
2023-08-28 24057, 2023
outsidecontext
but you change makes definitely sense anyway
2023-08-28 24002, 2023
outsidecontext
yvanzo: yes, seems to work now
2023-08-28 24022, 2023
yvanzo
🥳
2023-08-28 24033, 2023
yvanzo
outsidecontext: thanks for the last fix too, I can rearrange commits if you like
2023-08-28 24047, 2023
yvanzo
LGTM otherwise
2023-08-28 24052, 2023
outsidecontext
yvanzo: hooray, great teamwork. I guess we can squash most of the commits. Please clean this up as you see fit. I need to look into another issue now anyway
2023-08-28 24011, 2023
yvanzo
OK, on it
2023-08-28 24047, 2023
Maxr1998_ joined the channel
2023-08-28 24016, 2023
Maxr1998 has quit
2023-08-28 24015, 2023
reosarevok
yvanzo: are you running the meeting tonight? :)
2023-08-28 24027, 2023
yvanzo
reosarevok: can do
2023-08-28 24014, 2023
reosarevok
Ok, I'll forward a few reviews to you plus send mine
2023-08-28 24028, 2023
yvanzo
Thanks
2023-08-28 24032, 2023
reosarevok
Everyone: if you have a review and haven't sent it yet, send it to yvanzo since I will be in the air
lucifer: Hi! Are you using test.LB at the moment? I see the apple music PR is on there.
2023-08-28 24002, 2023
lucifer
monkey: yes should be fine
2023-08-28 24019, 2023
monkey
👍
2023-08-28 24007, 2023
lucifer
mayhem: fyi, matrix libera.chat IRC bridge shutdown a while ago and people can't use matrix clients to join
2023-08-28 24021, 2023
lucifer
#metabrainz IRC channel unless we setup our own bridge.
2023-08-28 24005, 2023
lucifer
i think it makes sense to do it, should be as simple as letting libera.chat people know about it, and configuring and running a docker container.
2023-08-28 24011, 2023
mayhem
lucifer: we should do that then.
2023-08-28 24052, 2023
mayhem
And yes, htmx is more for react, but I feel something is missing on the server side. All those html fragments would be a pain to deal with
2023-08-28 24032, 2023
lucifer
cool, i'll ask in the libera.chat IRC channel about necessary approval.
2023-08-28 24007, 2023
lucifer
yeah true that. but htmx is nice and simple too.
2023-08-28 24059, 2023
bitmap
zas: yep, if convenient for all we could schedule a day for the move this week or next
2023-08-28 24002, 2023
yvanzo
bitmap: I drafted a blog post for today’s release (for after the meeting), just missing an intro.
2023-08-28 24033, 2023
bitmap
ok, I'll review
2023-08-28 24018, 2023
yvanzo
thanks
2023-08-28 24029, 2023
yvanzo
<BANG>
2023-08-28 24052, 2023
yvanzo
Hi everyone!
2023-08-28 24000, 2023
yvanzo
Happy Race Your Mouse Around The Icons Day!
2023-08-28 24011, 2023
yvanzo
You probably did it already, so let’s jump into our weekly meeting.
2023-08-28 24015, 2023
ApeKattQuest
lol
2023-08-28 24030, 2023
yvanzo
I received the three following reviews by email:
2023-08-28 24041, 2023
yvanzo
reosarevok wrote:
2023-08-28 24041, 2023
yvanzo
"""
2023-08-28 24041, 2023
yvanzo
Hi! I'm on a plane!
2023-08-28 24041, 2023
yvanzo
This week I was in Spain since my brother got married, and I mostly only dealt with email, reports and a little bit of code review.
2023-08-28 24041, 2023
yvanzo
Thanks yvanzo for running this meeting too while I fly back home; more proper work starting tomorrow or at latest on Wednesday.
2023-08-28 24042, 2023
yvanzo
"""
2023-08-28 24053, 2023
yvanzo
mayhem wrote:
2023-08-28 24053, 2023
yvanzo
"""
2023-08-28 24053, 2023
yvanzo
Hi!
2023-08-28 24053, 2023
yvanzo
Thanks for running the meeting and sorry for my spotty presence last week.
2023-08-28 24053, 2023
yvanzo
This week I didn't work but answer[ed] some emails and not much else.
2023-08-28 24054, 2023
yvanzo
Vacation continues.
2023-08-28 24054, 2023
yvanzo
Back next monday.
2023-08-28 24055, 2023
yvanzo
"""
2023-08-28 24008, 2023
yvanzo
aerozol wrote:
2023-08-28 24008, 2023
yvanzo
"""
2023-08-28 24008, 2023
yvanzo
Nothing exciting to report, the usual stuff last week.
2023-08-28 24008, 2023
yvanzo
Thank you to yvanzo for taking the time to walk me through some *&^#i% github rebasing and basics via video chat :)
2023-08-28 24008, 2023
yvanzo
Congrats to all the GSoC participants whose blog posts have popped up, and hang in there the rest of you!
2023-08-28 24009, 2023
yvanzo
The prettiest person can go next
2023-08-28 24009, 2023
yvanzo
"""
2023-08-28 24025, 2023
yvanzo
People up for reviews: arsh, lucifer, kellnerd, akshaaatt, Pratha-Fish, ApeKattQuest, atj, bitmap, jasje, zas, vscode_, ShivamAwasthi, monkey, pixelpenguin, yvanzo. If other people want to share their own reviews, please let me know directly ASAP.
2023-08-28 24045, 2023
yvanzo
Personally I’m not sure how git rebasing cannot be exciting and who is most the prettiest.
2023-08-28 24048, 2023
yvanzo
arsh: Would you like to go next?
2023-08-28 24000, 2023
arsh
Sure thanks
2023-08-28 24004, 2023
arsh
Hi everyone
2023-08-28 24053, 2023
arsh
Sorry I lost my wifi connection
2023-08-28 24008, 2023
yvanzo
no problem, do you want to go later on?
2023-08-28 24014, 2023
arsh
Sure
2023-08-28 24020, 2023
yvanzo
Maybe lucifer then?
2023-08-28 24037, 2023
Pratha-Fish
may I go next? (IN a little hurry rn) :D
2023-08-28 24047, 2023
yvanzo
Pratha-Fish: Sure, go now :)
2023-08-28 24051, 2023
Pratha-Fish
Hi all!
2023-08-28 24053, 2023
ApeKattQuest
🐟
2023-08-28 24058, 2023
Pratha-Fish
Last week was a little more productive :)
2023-08-28 24022, 2023
Pratha-Fish
I worked on 2 of my PRs, and also worked on setting up the actual Musicbrainz-areabot to auto-post new areas!
2023-08-28 24031, 2023
Pratha-Fish
(Still in early phase tho)
2023-08-28 24049, 2023
Pratha-Fish
Worked on some more tests, making sure tests actually tested what was supposed to be tested lol
