#metabrainz

yvanzo: do you have a good sample string to test with?

I can craft one

Actually it should be a pair source/target, right?

yes. wen can either check one of the existing strings in the imported project, or we do some test with just a text file or such and setup a new component for that

`{entity1} has a BookBrainz page at {entity0}` from relationships

`is/was {additional:an|a} {additional} {original} {eponymous} member of` from relationships too

let me check

`{additional} {instrument:%|instruments} {co:co-}arranger`from relationships as well (with a `%` placeholder)

those are good. check needs some tweaking, but I think I got it. Just a minute

yvanzo: works, e.g. https://translate.uploadedlobster.com/translate... and

outsidecontext: I just found out that there is another format, mostly used in server, that is not handled by my check: `Please {search|try again}`

So the `:`* before the `|` should not be mandatory.

outsidecontext: the first example works but why is the second example not matching?

The "{eponymous}" is missing in the target (intentionally to test the check)

yes, that is sthe first example.

ah, the other one had both placeholders in the target, hence it did not fail

I now changed one of them and it is failing

I fixed the first example, and the check passes.

OK, I fixed both now.

For some reason, the second example had a correct target string and a failed check, was probably changed in the meantime.

monkey: Hi, can you please suggest me a ticket to work on?

yvanzo: I had changed it in between to make it fail, now it is correct again after your change

yvanzo: I'll restart my weblate again, but check https://github.com/metabrainz/musicbrainz-webla... for latest changes (including the optional colon)

outsidecontext: I pushed a commit to allow the above `{search|try again}`

hi reosarevok just left a new comment on PR #5 👀

yvanzo: latest changes are now on my instance. please check

outsidecontext: "latest changes" match which commit?

yvanzo: for the {foo|bar} syntax take a look at https://translate.uploadedlobster.com/translate...

I’m trying to improve this with named groups

findall does not do named groups. you can add them to the regex for readability, though

alright

is there a way to handle named groups?

I think using re.finditer, not sure

yes, finditer does

yvanzo: https://github.com/metabrainz/musicbrainz-webla...

outsidecontext: Thanks, pushed a commit on top of it

yvanzo: great. did some syntax fix and deployed it

oops, thanks for the fixes

outsidecontext: I probably messed up list comparison as the latest example keeps passing (makes sure to refresh): https://translate.uploadedlobster.com/translate...

found the bug

pushed fixes

Hi abhinavohri ! I hope you don't mind too much my taking over of the stats art PR !

To be honest I wasn't nearly sure enough of how everything would be implemented to make good suggestions without trying to implement it myself ! Quite complex on many levels it turns out, and I'm far from done!

I was thinking this could be an easy ticket if you're looking for an easy one :) LB-1306

LB-1306: Deleting a listen has an overlapping visual glitch https://tickets.metabrainz.org/browse/LB-1306

If not, well… I'd suggest having a look at the list of ticket and choosing one that grabs your attention :p

There's also this ticket that should be some simple CSS to add somewhere: LB-1278

LB-1278: Now playing notifications not displayed correctly https://tickets.metabrainz.org/browse/LB-1278

yvanzo: ok, deployed again. but the example you gave above still passes the test

Also maybe LB-1280

LB-1280: Manual mbid mapping: Duplicate text/fill search field https://tickets.metabrainz.org/browse/LB-1280

And if you're masochistic and want to dig into some browser-specific SVG issues, there's this juicy one :) LB-1267

LB-1267: Graphs no more showing in Stats https://tickets.metabrainz.org/browse/LB-1267

yvanzo: it should be different, I'm trying to debug what's going on

outsidecontext: might it be due to how we pass arguments to `set`?

outsidecontext: it might be safer to call `.group` with group names than getting all the groups.

[bookbrainz-site] 14anshg1214 opened pull request #1013 (03master…fix-redirection): fix: Redirect users after login https://github.com/metabrainz/bookbrainz-site/p...

outsidecontext: I guess that if there is no `:` and a `|` then there are only two groups and `alternative` is None.

I ran the code locally. it should work "{doc|license page}" has no consequent but alternative -> type "hyperlink"

outsidecontext: pushed a fix

and "{doc:Nichts|Lizenzseite}" has both and gets type "replacement"

oh, ok

the commit is not fixing it but is probably safe to keep still

then the issue might be in assigning/comparing sets

yvanzo: the problem might be as well me messing up copying the file over to my server :D but just done again freshly, now for sure

but you change makes definitely sense anyway

yvanzo: yes, seems to work now

🥳

outsidecontext: thanks for the last fix too, I can rearrange commits if you like

LGTM otherwise

yvanzo: hooray, great teamwork. I guess we can squash most of the commits. Please clean this up as you see fit. I need to look into another issue now anyway

OK, on it

yvanzo: are you running the meeting tonight? :)

reosarevok: can do

Ok, I'll forward a few reviews to you plus send mine

Thanks

Everyone: if you have a review and haven't sent it yet, send it to yvanzo since I will be in the air

So can't forward it for you :)

Or just PM

[listenbrainz-server] 14MonkeyDo opened pull request #2560 (03master…LB-1327): LB-1327: Listening now: Deduplicate tags after fetching user's tags https://github.com/metabrainz/listenbrainz-serv...

lucifer: Hi! Are you using test.LB at the moment? I see the apple music PR is on there.

monkey: yes should be fine

👍

mayhem: fyi, matrix libera.chat IRC bridge shutdown a while ago and people can't use matrix clients to join

#metabrainz IRC channel unless we setup our own bridge.

i think it makes sense to do it, should be as simple as letting libera.chat people know about it, and configuring and running a docker container.

lucifer: we should do that then.

And yes, htmx is more for react, but I feel something is missing on the server side. All those html fragments would be a pain to deal with

cool, i'll ask in the libera.chat IRC channel about necessary approval.

yeah true that. but htmx is nice and simple too.

zas: yep, if convenient for all we could schedule a day for the move this week or next

bitmap: I drafted a blog post for today’s release (for after the meeting), just missing an intro.

ok, I'll review

thanks

Hi everyone!

Happy Race Your Mouse Around The Icons Day!

You probably did it already, so let’s jump into our weekly meeting.

lol

I received the three following reviews by email:

reosarevok wrote:

"""

Hi! I'm on a plane!

This week I was in Spain since my brother got married, and I mostly only dealt with email, reports and a little bit of code review.

Thanks yvanzo for running this meeting too while I fly back home; more proper work starting tomorrow or at latest on Wednesday.

"""

mayhem wrote:

"""

Hi!

Thanks for running the meeting and sorry for my spotty presence last week.

This week I didn't work but answer[ed] some emails and not much else.

Vacation continues.

Back next monday.

"""

aerozol wrote:

"""

Nothing exciting to report, the usual stuff last week.

Thank you to yvanzo for taking the time to walk me through some *&^#i% github rebasing and basics via video chat :)

Congrats to all the GSoC participants whose blog posts have popped up, and hang in there the rest of you!

The prettiest person can go next

"""

People up for reviews: arsh, lucifer, kellnerd, akshaaatt, Pratha-Fish, ApeKattQuest, atj, bitmap, jasje, zas, vscode_, ShivamAwasthi, monkey, pixelpenguin, yvanzo. If other people want to share their own reviews, please let me know directly ASAP.

Personally I’m not sure how git rebasing cannot be exciting and who is most the prettiest.

arsh: Would you like to go next?

Sure thanks

Hi everyone

Sorry I lost my wifi connection

no problem, do you want to go later on?

Sure

Maybe lucifer then?

may I go next? (IN a little hurry rn) :D

Pratha-Fish: Sure, go now :)

Hi all!

🐟

Last week was a little more productive :)

I worked on 2 of my PRs, and also worked on setting up the actual Musicbrainz-areabot to auto-post new areas!

(Still in early phase tho)

Worked on some more tests, making sure tests actually tested what was supposed to be tested lol

And that's mostly it for me unfortunately 🫠

lucifer: would you like to go next?