#metabrainz

/

      • Maxr1998 joined the channel
      • Maxr1998_ has quit
      • zerodogg has quit
      • lucifer
        yvanzo: there are some differences in behavior between the new Oauth provider and existing MB provider, so to discuss if those differences are fine and if any changes are needed. also to discuss some security related trade-offs and finally what changes would be needed in MB codebase to support tokens issued by the new Oauth provider.
      • zerodogg joined the channel
      • aerozol[m] joined the channel
      • aerozol[m]
        ansh: monkey: uninterrupted playback doesn’t work for me on Beta. If it’s working for you/not an obvious issue I can provide more info
      • mayhem: I’m not a user of playlists so I can’t provide in-depth feedback, but easy medium hard seems good to me! Unfortunately not that many users listen to my genres (yet) so it’s hard to accurately pinpoint the difference the code is making vs a limited pool of listeners. Setting country:(new zealand) gives me a lot of non-nz bands though? Other settings I would expect fuzziness, but probably not country
      • Gave it a share, I know there are playlist fanatics out there, hopefully some of them take a keen (but not too keen!! you know what I mean haha) interest
      • derat: I’ve been seeing the English alias in beta search results for all of 5 minutes now, and it already feels like it was always there! And I already added a few missing English aliases 😊
      • BrainzGit
        [metabrainz.org] 14Aerozol opened pull request #463 (03master…master): Dataset 'crate' logo images https://github.com/metabrainz/metabrainz.org/pu...
      • aerozol[m]
        ^ related, MEB-160
      • BrainzBot
        MEB-160: Add images to dataset subpages https://tickets.metabrainz.org/browse/MEB-160
      • aerozol[m]
        ansh: monkey: Is this something either of you have experience with? I can do it, but I suspect I will spend ages noodling about with the code and then one of you will replace it with something better immediately! LB-1572
      • BrainzBot
        LB-1572: Add preview/social/meta image https://tickets.metabrainz.org/browse/LB-1572
      • Lotheric__ has quit
      • Lotheric joined the channel
      • yvanzo
        lucifer: Ok, thank you!
      • aerozol[m] has quit
      • Kladky joined the channel
      • zerodogg has quit
      • zerodogg joined the channel
      • the4oo4 has quit
      • fletchto99 has quit
      • fletchto99 joined the channel
      • monkey
        aerozol: continuous playback is not out yet, this was a big step before we could add it. It's in development and pretty much finished, so expect it soon
      • Also yes I do have enough experience with preview images to be of some use :) will look into it.
      • zerodogg has quit
      • zas
        yvanzo: I just restart sir-prod on ludwig
      • it may happen again I guess
      • zerodogg joined the channel
      • Goldmaster[m]1 joined the channel
      • Goldmaster[m]1
        quick question, I can see that there are 2 very similar musibrainz releases for odyssey by home. there is https://musicbrainz.org/release/919fc2f5-1ab8-4... and there is https://musicbrainz.org/release/dfc34d7d-f7b0-4... both have the same link to the bandcamp page. 1 has release in 2019 even though the bandcamp doesn't list anywhere for 2019. i know there is a vinyl version. Any thoughts on these
      • release groups please?
      • ah found musicbrainz chat Chanal here https://matrix.to/#/#musicbrainz:moviebrainz.org I will ask there
      • zerodogg has quit
      • zerodogg joined the channel
      • zerodogg has quit
      • dseomn has quit
      • dseomn joined the channel
      • yvanzo
        zas: Thank you, I will create a ticket for this one.
      • bitmap, reosarevok: Should I truncate overlong names through update statements or edits? So that we can make a sane fullexport again.
      • Goldmaster[m]1 has quit
      • bitmap
        yvanzo: edits should be fine
      • yvanzo
        bitmap: Ok, I’m not auto-editor though.
      • bitmap
        ah, I can approve them if you enter them
      • zerodogg joined the channel
      • yvanzo
        Thank you, starting now.
      • bitmap
        yvanzo: I can't reject them through the website, so it'd have to be done through the database
      • can do that while you enter the edits if you'd like
      • yvanzo
        bitmap: Thank you to do so, I just left an explanation note to those edits in the meantime.
      • It means that I shouldn’t have to edit their target entities either.
      • zerodogg has quit
      • bitmap
        done, I fixed the edits_pending values too but they may not be reflected until the entities are invalidated from the cache
      • yvanzo
        bitmap: Thank you. Do you remember where is the limit for index size in PG? Or is it just `block_size`?
      • bitmap
        it's quite complicated, but it is affected by block_size, yes. however block_size can only be set at compile time AFAIK, it should be hardcoded to 8192 for every instance
      • yvanzo
        I mean “the maximum size allowed for the index type” as in https://www.postgresql.org/docs/current/sql-cre...
      • bitmap
        right
      • it's not configurable AFAIK except I think the page size is affected by block_size
      • the error message in the ticket gives 2704 bytes, which was the same for me on macOS IIRC
      • yvanzo
        Ok, that’s 1/3 of 8192.
      • bitmap
        basically, yeah
      • yvanzo
        I created MBS-13562 with 1024 characters, but that might not be restrictive enough.
      • BrainzBot
        MBS-13562: Limit titles/names to 1024 characters https://tickets.metabrainz.org/browse/MBS-13562
      • bitmap
        1024 should be no problem
      • yvanzo
        Anyway, we just need to get rid of the longest name/title at the moment (for a sane full export).
      • zerodogg joined the channel
      • zerodogg has quit
      • bitmap: That should be all of it: https://musicbrainz.org/search/edits?auto_edit_...
      • bitmap
        thanks, I approved 111225332 which was what broke the dump
      • yvanzo
        bitmap: then you should probably approve the related tracklist edit too: https://musicbrainz.org/edit/111225333
      • Similarly, this is related to the edits you rejected previously: https://musicbrainz.org/edit/111224904
      • bitmap
        right, approved that one too
      • yvanzo
        Thank you.
      • zerodogg joined the channel
      • bitmap: Last, the release-group, release, track, and recording with names “making a parody of…” have also been entered this month and their names are above 2704 characters too.
      • bitmap: I’m adding 0 to the nominated days for making dumps on tomorrow (Sunday).
      • bitmap: Dumps will start in 3:30 from now, but I still think that the edits to shorten all the “parody” names (currently above 2704 chars) should be applied beforehand.
      • bitmap
        yvanzo: sorry I'm back, I approved the parody ones
      • yvanzo
        bitmap: Thank you.
      • bitmap
        but I am guessing these did not cause an issue because they compress well (I was able to reproduce the error locally with the title from the ticket, but not a repetitious one)
      • yvanzo
        Yes, but even the recording with 3403 characters was compressed into 2504 bytes only (that is less than 2704). So I expect that the uncompressed size is more relevant.
      • I will implement a check on the string’s size in bytes additionally to the length in characters, just in case someone find interesting name a recording with 1024 4-bytes characters only.
      • *to name
      • Kladky has quit
      • bitmap
        yeah, that can be an issue as perl's length measures characters if the string isn't encoded
      • genius3000 has quit
      • genius3000 joined the channel
      • it's interesting that several of these legitimate-looking titles are only slightly above 1024 chars--that makes me wonder whether we should increase it slightly
      • using ... before the previous word instead of truncating mid-word might be a bit more elegant too
      • yvanzo
        I admit that I didn’t aim for elegance here, but thanks to the editing history, that can improved later on.
      • bitmap wasn't implying that some of these NSFW titles were elegant to begin with, either
      • Yeah, the vast majority of NSFW stuff very likely pushed me to follow the most straightforward method, using a script to truncate names.
      • JadedBlueEyes has quit
      • JadedBlueEyes joined the channel