[listenbrainz-android] 14dependabot[bot] opened pull request #439 (03dev…dependabot/gradle/dev/io.sentry.android.gradle-4.8.0): Bump io.sentry.android.gradle from 4.7.0 to 4.8.0 https://github.com/metabrainz/listenbrainz-andr...
[listenbrainz-android] 14dependabot[bot] closed pull request #430 (03dev…dependabot/gradle/dev/io.sentry.android.gradle-4.7.1): Bump io.sentry.android.gradle from 4.7.0 to 4.7.1 https://github.com/metabrainz/listenbrainz-andr...
It’s better if it is reviewed, and I can incorporate those changes
akshaaatt[m] joined the channel
akshaaatt[m]
Sure
pranav[m]
Also akshaaatt , Do u want me to send u a video of the progress or would u want to test locally? I feel if u test it once, it would be better
For now, u can navigate to user pages by clicking anywhere in the feed, or in the search results
akshaaatt[m]
I can test locally so no need of a video
discordbrainz
<05rustynova> Just wondering, does the global stats not updating ate going to get fixed soon, or it's low priority?
<05rustynova> *in lb. Should have precised
natrius[m] has quit
Maxr1998[m] has quit
SigHunter has quit
SigHunter joined the channel
lucifer[m]
rustynova: which global stats are not updating? i checked a few and all of them are up to date.
aerozol[m]
<pranav[m]> "aerozol: hope the gradients..." <- Ooh, where can I see them?
zas[m]
I updated many panels in our grafana that were using now obsolete angularjs-based panel. I also moved some old (or non-working) panels in Old/ folder. I'll prolly remove dashboards in Old in next few weeks, so please have a look if you create dashboards, you may want to update some (if it's the case move them outside Old/)
the4oo4 has quit
rimskii[m]
lucifer: hi! I almost finished with endpoint for apple
i wanted to ask regarding the mapping.spotify_metadata_index table
there is no CREATE TABLE function for it, does that mean it gets created along the way?
Also we need the same table for apple right?
lucifer[m]
rimskii: yes, a table needs to be created for the apple metadata index too.
[bookbrainz-data-js] 14dependabot[bot] opened pull request #317 (03master…dependabot/npm_and_yarn/braces-3.0.3): chore(deps): bump braces from 3.0.2 to 3.0.3 https://github.com/metabrainz/bookbrainz-data-j...
[bookbrainz-data-js] 14MonkeyDo merged pull request #317 (03master…dependabot/npm_and_yarn/braces-3.0.3): chore(deps): bump braces from 3.0.2 to 3.0.3 https://github.com/metabrainz/bookbrainz-data-j...
pite joined the channel
lucifer[m]
mayhem: hi! i had indexed artist_name, recording_name and artist_credit_id into Solr. the entire index size came to be around 6G. queries took about 15-20ms with/without sharding.
mayhem[m]
sounds promising indeed.
lucifer[m]
i did manual testing. but we can do proper stress testing like atj did for solr prod using jmeter.
mayhem[m]
let do that to understand the exact nature of its behaviour
lucifer[m]
another thing is i think if we spilt searching on artist name and recording name even typesense's performance may improve.
mayhem[m]
it would. but I doubt it would reach 15-20ms.
lucifer[m]
true but doesn't hurt to check.
one more thing we should probably look into is does the match rate drop if we search individually as opposed to combined lookup
mayhem[m]
yeah
lucifer[m]
so we probably need to build a dataset for that.
mayhem[m]
why?
lucifer[m]
to compare match rates between old approach and new approach
and if the matched recordings differ.
mayhem[m]
could we record incoming traffic and the results for that and then replay that data against the test setup?
lucifer[m]
yes that's how jmeter works i think
akshaaatt[m]
The changes to the android app are really sexy pranav !
I can see myself paying for such an app! Looks really clean and hot
[listenbrainz-android] 14dependabot[bot] closed pull request #432 (03dev…dependabot/gradle/dev/compose_version-1.6.8): Bump compose_version from 1.6.7 to 1.6.8 https://github.com/metabrainz/listenbrainz-andr...
[listenbrainz-android] 14dependabot[bot] closed pull request #434 (03dev…dependabot/gradle/dev/androidx.lifecycle-lifecycle-livedata-ktx-2.8.2): Bump androidx.lifecycle:lifecycle-livedata-ktx from 2.8.1 to 2.8.2 https://github.com/metabrainz/listenbrainz-andr...
[listenbrainz-android] 14dependabot[bot] closed pull request #433 (03dev…dependabot/gradle/dev/androidx.lifecycle-lifecycle-viewmodel-compose-2.8.2): Bump androidx.lifecycle:lifecycle-viewmodel-compose from 2.8.1 to 2.8.2 https://github.com/metabrainz/listenbrainz-andr...
[listenbrainz-android] 14dependabot[bot] closed pull request #436 (03dev…dependabot/gradle/dev/androidx.lifecycle-lifecycle-runtime-compose-2.8.2): Bump androidx.lifecycle:lifecycle-runtime-compose from 2.8.1 to 2.8.2 https://github.com/metabrainz/listenbrainz-andr...
[listenbrainz-android] 14dependabot[bot] closed pull request #435 (03dev…dependabot/gradle/dev/androidx.lifecycle-lifecycle-runtime-ktx-2.8.2): Bump androidx.lifecycle:lifecycle-runtime-ktx from 2.8.1 to 2.8.2 https://github.com/metabrainz/listenbrainz-andr...
[listenbrainz-android] 14dependabot[bot] closed pull request #438 (03dev…dependabot/gradle/dev/com.android.tools.build-gradle-8.5.0): Bump com.android.tools.build:gradle from 8.4.1 to 8.5.0 https://github.com/metabrainz/listenbrainz-andr...
[listenbrainz-android] 14dependabot[bot] closed pull request #437 (03dev…dependabot/gradle/dev/androidx.lifecycle-lifecycle-viewmodel-ktx-2.8.2): Bump androidx.lifecycle:lifecycle-viewmodel-ktx from 2.8.1 to 2.8.2 https://github.com/metabrainz/listenbrainz-andr...
[listenbrainz-android] 14dependabot[bot] closed pull request #419 (03dev…dependabot/gradle/dev/org.jetbrains.kotlin-kotlin-gradle-plugin-2.0.0): Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.9.22 to 2.0.0 https://github.com/metabrainz/listenbrainz-andr...
KartikOhri[m] has quit
kepstinbrainz has quit
aerozol[m]
pranav: Nice work on the gradient/divider! Just flip round the curve (It’s upside down) and then it looks good!
I can see some minor things, but I’m not sure what’s stil in progress. The load more button and titles don’t seem to be spaced like in the mockup, and the fonts and colours for some stuff are different?
pranav[m]
Ya, I need to work on typography
There were some changes compared to rest of the apps theme
I’m not sure if I should change them directly or I shud create new ones temporarily and then check
So I left it, will do this Tom along with new set of features and make a Pr Tom
aerozol: ^
aerozol[m]
I thought you might still be working on it :)
If you can change the whole app theme and it looks fine, and akshaaatt doesn’t have a problem with the mockup, then go for it imo. But if that is extra hassle then I’m sure you can just work on changing your GSoC part
lucifer[m]
mayhem: for soundcloud metadata cache, i am doing new tracks discovery using user uploads endpoint. so instead of having a cache time for albums we need to have a cache time for artists, at which the cache is invalidated and we recheck the user for new uploads. thoughts on 1 week or 1 month?
reosarevok: While further testing the above, I noticed that the label-release relationship type group “publishing” has “business association” link phrases; See https://musicbrainz.org/relationships/label-rel...
reosarevok[m]
I suspect that we at some point changed the phrases but not the name because it used to be something we avoided in case we broke stuff
yvanzo[m]
Fortunately, this is the only bizarre case of the kind I found.