#metabrainz

/

      • yyoung[m]
        Oh so is that a compatibility issue?
      • bitmap
        seems so. but it works fine if I just remove the text-align: center; is that needed?
      • it still looks a bit strange with so much unused space on the left size
      • side*
      • yyoung[m]
        Not that important, you can remove it
      • elomatreb[m]
        `fit-content` requires a `-moz-` prefix in Firefox for now btw
      • bitmap
        maybe we can move the "Add another link" label
      • yyoung[m]
        Yes I guess we can remove the right padding of the first td
      • bitmap Yeah that'll work, is that user friendly?
      • BrainzGit
        [musicbrainz-server] 14reosarevok opened pull request #2203 (03master…MBS-11825): MBS-11825: Use same order for art types when editing vs adding https://github.com/metabrainz/musicbrainz-serve...
      • bitmap
        if we have 'Add another link' as placeholder text, it might be fine?
      • yyoung[m]
        Yes I think so
      • elomatreb Thanks, will have a try later.
      • Sorry I have to go offline now, it's already midnight here. :)
      • reosarevok
        It's ok :)
      • yvanzo
        bitmap, cc reosarevok: https://github.com/metabrainz/musicbrainz-serve... is up for review
      • ritiek joined the channel
      • reosarevok
        if bitmap feels it's good, I say merge
      • Freso
        <BANG>
      • International Monday of the World’s Indigenous Peoples!
      • I have received one mailed in review…
      • yyoung says:
      • """
      • - Last week I enhanced the UX and UI of MBS-11680, implemented notices for existing URLs, fine-tuned details, especially tab focus and keyboard navigation, and wrote new tests.
      • BrainzBot
        MBS-11680: New UI for external links editor to display relationships as a list https://tickets.metabrainz.org/browse/MBS-11680
      • Freso
        - Added Flow support for URLCleanup.js and fixed detected bugs.
      • - Fixed old tests and adapted new tests for MBS-9902.
      • - Continued looking at code related to MBS-3774 and experimented modifying a little bit. (Surprised to find out that it seems no backend code change is required :)
      • - That's all, thank you.
      • BrainzBot
        MBS-9902: Support auto-select/cleanup/validation of more than one relationship type for external links https://tickets.metabrainz.org/browse/MBS-9902
      • MBS-3774: Add URL relationship with begin and end dates https://tickets.metabrainz.org/browse/MBS-3774
      • Freso
        """
      • Other people up today: lucifer, ruaok, yvanzo, reosarevok, alastairp, monkey, bitmap, zas, Freso, akashgp09, jasondk, akshaaatt, ritiek, CatQuest
      • lucifer: Go!
      • lucifer
        hi all!
      • Last week, I worked on migrating the remaining spark jobs to use new parquet dumps. all jobs are now able to use new format dumps. After that, i started reworking the tests. will continue working on that this week.
      • ruaok
        so happy to hear this. :)
      • lucifer
        also, did some misc work on various PythonBrainz, some rabbitmq debugging. finally, a couple of brief discussions with akshaaatt[m] about the android app.
      • that's it for me.
      • ruaok: next?
      • ruaok
        k
      • last week I did some emails, some PRs, but mostly spent my time in a serious rabbit hole.
      • monkey pointed out that releases are not correctly matched in the mbid mapping, so I decided to add another pass to the lookup and identify and lookup albums in the listens stream.
      • should be simple, no?
      • right.
      • so now we have a solr (typesense is rather quite slow) index that if you pass it artist, release name, and recordings it will attempt to lookup the canonical release for that given data.
      • I've got a script that you can feed a release id and using just the metadata it will find the most canonical release.
      • that was a fun project and solr is dammned fast -- I'm impressed.
      • next step is to throw real useful data at it to id albums.
      • alastairp
        interesting. so typesense works really well in its usecase of fuzzy lookup for a real-time user typing into a text box?
      • ruaok
        but this too has been something we've needed for a long time -- picard might be interested in using it. (zas, outsidecontext)
      • yes, that, alastairp. for fuzzy matching its great.
      • alastairp
        it looked like we were hitting up against its speed with the initial version of the mapper?
      • monkey
        Freso: i'm off and away, don't have anything to report this week or next week
      • ruaok
        but I needed something with more text matching capabilities.
      • monkey
        Also hello in passing everyone
      • alastairp
        yeah, for sure
      • lucifer
        solr supports fuzzy search, no?
      • ruaok
        alastairp: its ok, but I don't ever want to deploy a public facing typesense service.
      • alastairp
        anyway, will be really interesting to see the solr stack to see how it compares. I like solr
      • ruaok
        lucifer: it does -- and I am tempted to compare the two tassk.
      • alastairp
        lucifer: yes, depending on how you configure the index
      • ruaok
        yea, me too.
      • lucifer
        makes sense
      • ruaok
        but this index is quite promising. hopefully once this work is done I will have an LB derived ISRC and spotify album, release and recording mapping.
      • fin. alastairp !
      • alastairp
        hi. that'll serve me right for talking out of turn
      • last week I pushed a PR to LB to start the task of moving the listens table to use user_id instead of user_name, this will make it easier for us to rename users. we think it's almost there, I had some back and forth with ruaok, and need to try a few suggestions
      • jasondk
        (hey ruaok I'm around now, let's chat after the meeting if you can)
      • ruaok
        jasondk: +1
      • alastairp
        I worked with lucifer on some pythonbrainz backend tasks, and had a large discussion about rabbitmq, lots of interesting questions about how we're using it
      • lucifer: is doing a great job with looking at something in LB, saying "why are we doing it like that?" and then finding a bunch of improvements
      • !m lucifer
      • BrainzBot
        You're doing good work, lucifer!
      • lucifer
        :-D
      • alastairp
        I also continued some work on migrating AB react pages to typescript
      • yvanzo: next
      • yvanzo
        Hi!
      • Freso
        (Others still up: reosarevok, bitmap, zas, Freso, akashgp09, jasondk, akshaaatt, ritiek, CatQuest – anyone else why may wish to go, let me know ASAP. :))
      • alastairp
        oh, I also started some work on improving the way that we handle connections to external services (db, redis, rabbitmq) in LB, but this made me go down a, uh, rabbit hole
      • yvanzo
        Last week, I fixed search service once again but also welcomed lucifer’s help with updating indexer’s code.
      • Reviewed yyoung’s work always breaking through more issues hopefully identified soon enough and likely resolved today already.
      • Helped a bit lucifer with setting RabbitMQ’s config for LB.
      • Plus support, and that’s all from me. Go reosarevok!
      • ruaok
        god damn rabbits everywhere.
      • reosarevok
        Hi!
      • Last week I mostly spent a fair amount of time trying to make sense of our guess case code, update it a bit to have flow types and whatnot
      • ruaok
        the old guess case rabbit hole?
      • reosarevok
        Well, it's a bit less sucky now. I think.
      • Also a bunch of Perl::Critic improvements (so, eslint for Perl, anyway)
      • CatQuest
        delinting perl i guess
      • reosarevok
        And a bunch of small changes
      • Mostly recently requested things :)
      • This week I'm probably going to do more of that, really
      • CatQuest: what about you?
      • CatQuest
        Meow! `😺`
      • Have been pickling!
      • also been adding things to bb and writing up what will be more tickets for that.
      • so this week I'll continue looking at bb and adding things and adding tickets!
      • fin, go zas?
      • zas
        hey
      • last week we got rid of old server williams, and got a new one, named patton
      • I reviewed and merged a lot of Picard PRs, mostly related to new feature introduced by rdswift : options profiles
      • I also did usual maintenance, supervision, upgrades
      • fin. bitmap?
      • bitmap
        hi
      • Freso
        (Others still up: Freso, akashgp09, jasondk, akshaaatt, ritiek – anyone else why may wish to go, let me know ASAP. :))
      • bitmap
        last week I worked on testing releases with tons of mediums in the relationship editor, integrating the new medium/track paging code we have for release pages
      • right now there is no paging at all...
      • also worked on improving performance when there are hundreds of recordings on the page. actions seemed sluggish at that point, and I was able to improve that quite a bit
      • other than that I was mostly reviewing reosarevok's guess case refactoring
      • fin! Fresogo?
      • reosarevok
        Ooh, sweet
      • Freso
        o/
      • diru1100 joined the channel
      • This last week I mostly dealt with a lot of reported editors and forum flags. Also dealt with some more potential LB spam. (Did delete one duplicate account who thought they had deleted that account already themselves.)
      • And other than that, just trying to be around and about.
      • fin.
      • akashgp09[m]: Go!
      • akashgp09[m]
        Hi all !
      • Last week I worked on: adding relationship attributes via relationship-editor https://github.com/bookbrainz/bookbrainz-site/p....
      • Freso
        (Only jasondk, akshaaatt[m], and ritiek left on my list. Last call for anyone else who may want to give review!)
      • akashgp09[m]
        Added new relationship for series and constructed some logic to separate series items from relationships https://github.com/bookbrainz/bookbrainz-site/p...
      • diru1100
        (Freso: please add me too 🥺)
      • akashgp09[m]
      • My GSoC task is almost done. I will finalize everything in 2-3 days and start preparing a report/blog on it.
      • akshaaatt go
      • akshaaatt[m]
        Hi everyone!
      • Freso
        (Only jasondk, ritiek, and diru1100 left on my list. Last call for anyone else who may want to give review!)
      • akshaaatt[m]
        This week I was mainly focused on preparing the documentation and finalizing how I could scope post GSoC.
      • I've been thinking of ways to do that
      • Other than that it's been a few weeks of studying a lot of concepts and stuff
      • Will work on finalizing stuff this week.
      • That's it for me. Fin!
      • jasondk next?
      • jasondk
        Hi all,
      • last week I worked on some frontend stuff for the CritiqueBrainz review modal
      • and continued to refactor some code to implement making pins listenable with brainzplayer.
      • I still have a few tasks left for GSoC but will get some PR's in this week.
      • thats it for me! diru1100?
      • diru1100
        Hey Everyone 👋 Hope y'all are doing good, I am Rohit from last summer haha. Just wanted give an update that I finally graduated and working full time now :). Thank you so much for the support, especially yvanzo for helping me out when I reached out. Looking forward to contributing back to the community 🔥 fin!
      • ruaok
        hi, thanks for the update. nice to hear from someone who has gone off into the real world. :)
      • I guess ritiek is next?
      • akshaaatt[m]
        That sounds great diru1100 ! Congratulations!!
      • Freso
        diru1100: ❤️
      • ritiek
        hey
      • last week i mainly worked on implementing search on more entities: https://github.com/oknozor/musicbrainz_rs/pull/69
      • there are a few more entities still left and should be done this week