People up for reviews: zas, reosarevok, lucifer, alastairp, yvanzo, ruaok, akshaaatt[m], monkey, Freso, bitmap, CatQuest – anyone else who want to give review, let me know ASAP. :)
2021-09-13 25605, 2021
Freso
zas: Go!
2021-09-13 25609, 2021
yyoung[m]
Freso I can go in a short time
2021-09-13 25609, 2021
zas
hey
2021-09-13 25642, 2021
zas
I finished the deployment of node exporter (metrics collector for prometheus), and tuned some alerts & graphs
2021-09-13 25647, 2021
zas
I did usual maintenance, supervision, patches, and worked on Picard PRs (2.6.4 stable will be out soon, 2.7 alpha too)
2021-09-13 25654, 2021
zas
fin. reosarevok ?
2021-09-13 25600, 2021
reosarevok
yyoung[m]: go first? :)
2021-09-13 25607, 2021
CatQuest
hm
2021-09-13 25611, 2021
yyoung[m]
Thanks
2021-09-13 25615, 2021
yyoung[m]
Hi
2021-09-13 25636, 2021
yyoung[m]
Nothing much, just looking at some tickets, regular editing and making userscipts
2021-09-13 25615, 2021
CatQuest
oohhh
2021-09-13 25624, 2021
yyoung[m]
Just finishing a project, new term is starting, and hopefully everything will come back on track this week
2021-09-13 25627, 2021
yyoung[m]
Thanks, go reosarevok
2021-09-13 25627, 2021
reosarevok
That's a curious idea of "nothing much" ;)
2021-09-13 25636, 2021
reosarevok
Seems decent to me!
2021-09-13 25639, 2021
reosarevok
Anyway, hi!
2021-09-13 25634, 2021
reosarevok
I've mostly been working on a bunch of small URL cleanup changes (new URLs, better cleanup, plus a method to actually better match the favicons to the url so that she-ra.com doesn't show the resident advisor logo because it contains "ra.co")
2021-09-13 25608, 2021
reosarevok
Plus just updating a fair amount of open PRs based on comments / suggestions to put them on beta, since we have started using an actual milestone method again and getting a fair amount of reviews in :)
2021-09-13 25624, 2021
reosarevok
CatQuest: what about you?
2021-09-13 25632, 2021
CatQuest
Meow! `😺`
2021-09-13 25638, 2021
CatQuest
not much this week, was in a slump.. but things are looking up now!!
2021-09-13 25643, 2021
CatQuest
figured out that i actually *can* use atisket! so
2021-09-13 25643, 2021
CatQuest
!m atj for that
2021-09-13 25643, 2021
BrainzBot
You're doing good work, atj for that!
2021-09-13 25603, 2021
CatQuest
otherwise trying to figure things out about a ✨New Browser™✨
2021-09-13 25603, 2021
CatQuest
:O
2021-09-13 25603, 2021
CatQuest
♌
2021-09-13 25603, 2021
CatQuest
fin, go freso!
2021-09-13 25607, 2021
Freso
o/
2021-09-13 25617, 2021
riksucks
I read the same lol
2021-09-13 25627, 2021
Freso
Dealt with more reports, incl. a lot of spam (in MB and forums and a bit on LB all), did some forum admin stuff toggling options and looking into new features that turned out to not be available in our current version. :( I’ve set a reminder to look into it again for when we update to next version.
2021-09-13 25636, 2021
CatQuest
!m freso
2021-09-13 25636, 2021
BrainzBot
You're doing good work, freso!
2021-09-13 25657, 2021
Freso
Other than that, being around and about.
2021-09-13 25658, 2021
Freso
fin.
2021-09-13 25604, 2021
Freso
lucifer: Go!
2021-09-13 25612, 2021
lucifer
hi all!
2021-09-13 25635, 2021
Freso
(People still up: alastairp, yvanzo, ruaok, akshaaatt[m], monkey, bitmap – anyone else who want to give review, let me know ASAP. :))
2021-09-13 25655, 2021
lucifer
i worked mostly on sir debugging last week. followed up on some LB PRs, some spark debugging and misc stuff.
2021-09-13 25658, 2021
lucifer
alastairp: next?
2021-09-13 25629, 2021
alastairp
hi there
2021-09-13 25637, 2021
alastairp
last week seemed to run by really quickly
2021-09-13 25602, 2021
alastairp
I tried a few times to upgrade sentry (our release is about 2 years old, and has some deprecated github integrations)
2021-09-13 25630, 2021
alastairp
due to the way that our docker setup works, this was much more complex than I expected, though once I learned the right incantations things seemed to go better.
2021-09-13 25609, 2021
alastairp
we're currently upgraded from 9->10, though we still need to upgrade to the latest v21 release (in 2020 they moved to year-based versioning). I didn't want to waste any more time on that so I've put it to the side for now
2021-09-13 25640, 2021
alastairp
I did some LB reviews, and am finishing off a LB frontend PR that I opened before summer
Also tried to address biweekly load issues on aretha due to MB dumps compression (will see next Wednesday if that worked).
2021-09-13 25608, 2021
yvanzo
Resumed reviewing MBS PRs using the new approach to milestones reosarevok mentioned.
2021-09-13 25640, 2021
yvanzo
Worked on SIR: Debug, Dockerfile, and service maintenance.
2021-09-13 25657, 2021
MrClon
Hi. I rewrite my Bandcamp tags submitting script. Tested new version on test.musicbrainz.org, seems like it work correct bout i not fully sure. If things will go wrong can you delete all tags submitted by my bot?
(Only ruaok, akshaaatt[m], and monkey left on my list. Last call for anyone else who may want to give review!)
2021-09-13 25634, 2021
bitmap
last week we released a new MBS with yyoung's GSoC work (thanks again to yyoung!)
2021-09-13 25654, 2021
monkey
!m yyoung
2021-09-13 25654, 2021
BrainzBot
You're doing good work, yyoung!
2021-09-13 25622, 2021
bitmap
I spent time debugging some out-of-memory errors in the MB webservice containers and found a nasty issue in the /ws/2/isrc endpoint that I hotfixed
2021-09-13 25623, 2021
bitmap
& I also started working on MBS-10896 and MBS-10238 which are kinda related because they both require moving the email-sending functionality to ModBot (which would run more frequently, probably every 15 mins or so)
this is a schema change (since we need a way to track when edits were last processed in order to know whether to send out emails) but at least it only involves a non-replicated/internal-only table
2021-09-13 25644, 2021
bitmap
other than that, I did some code review for the next MBS milestone
2021-09-13 25654, 2021
bitmap
fin! go ruaok
2021-09-13 25607, 2021
ruaok
y
2021-09-13 25615, 2021
CatQuest
n
2021-09-13 25640, 2021
ruaok
last week was mostly catching up from vacation. loads of emails, random discussions, that stuff.
2021-09-13 25611, 2021
ruaok
I also continued working on the MBID release mapper, which I asked feedback on here -- it seems to be on track.
2021-09-13 25630, 2021
ruaok
I'll have to push that one forward this week, after I ponder how to continue.
2021-09-13 25647, 2021
ruaok
today monkey and started working on a page that allows an LB user to see their feedback (love/hate)
2021-09-13 25659, 2021
CatQuest
!m ruaok and monkey!
2021-09-13 25659, 2021
BrainzBot
You're doing good work, ruaok and monkey!!
2021-09-13 25634, 2021
ruaok
because with similar users working well now, I've been listening to collections of my similar users and there is some good stuff. so discovery is starting to work, but once I find something, I can't even <3 it or even find my <3s
2021-09-13 25620, 2021
ruaok
so over the next few weeks I want to pick off little features here and there that allow us to close the loop making LB useful for music discovery -- we're quite close, so this is exciting.\
2021-09-13 25651, 2021
ruaok
and I've also been seeing more people talking about LB and tweeting that they have moved from last.fm to LB. which is a nice milestone to see. :)\
2021-09-13 25609, 2021
ruaok
fin. monkey!
2021-09-13 25616, 2021
monkey
!m ListenBrainz
2021-09-13 25616, 2021
BrainzBot
You're doing good work, ListenBrainz!
2021-09-13 25617, 2021
monkey
Hi everyone!
2021-09-13 25641, 2021
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | BookBrainz: #bookbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda: Reviews, MBS-11938 (reo), invoices (ruaok)
2021-09-13 25647, 2021
monkey
Last week I worked on a few improvements for ListenBrainz: submitting listens when played on the LB website, showing a play button on hovering over listens, and helping lucifer with the LibreFM import page.
2021-09-13 25610, 2021
monkey
I also reviewed PR (mostly for LB) and did some testing of akashgp09[m]’s Series project for BookBrainz, as well as some general repo and CI tests housekeeping.
2021-09-13 25627, 2021
monkey
Finally I sat down with ruaok to discuss summit t-shirt ideas. Excited to work on this again :)
2021-09-13 25633, 2021
monkey
Also got my 2nd vaccine jab over the weekend, so that’s done. 🎉
2021-09-13 25641, 2021
monkey
That's it for me, go akshaaatt[m] !
2021-09-13 25650, 2021
akshaaatt[m]
Hi Everyone!
2021-09-13 25630, 2021
Freso
(akshaaatt[m] is last on my list. We’ll continue on to other agenda items afterwards if no one else speaks up, like, now(!) that they, too, want to give review!)
2021-09-13 25632, 2021
akshaaatt[m]
This week I realised I needed to code more so I dived in and worked on building components which we can use across all ours applications
2021-09-13 25649, 2021
akshaaatt[m]
I even completed two advanced courses on React which I feel was much needed.
2021-09-13 25608, 2021
akshaaatt[m]
I skimmed through the documentations for bootstrap and react very properly
2021-09-13 25626, 2021
akshaaatt[m]
Hopefully I can start making PRs to all projects this week and get our work going
2021-09-13 25603, 2021
akshaaatt[m]
Other than that I had a lot of college exams this past week. So that's about it. I see amazing changes upcoming and it is really exciting!
2021-09-13 25605, 2021
akshaaatt[m]
Fin!
2021-09-13 25617, 2021
akshaaatt[m]
And yeah,
2021-09-13 25638, 2021
akshaaatt[m]
The Android app now supports Light mode along with Dark mode!
2021-09-13 25645, 2021
CatQuest
cool!
2021-09-13 25647, 2021
Freso
Thank you everyone who gave reviews for your reviews! :)
I'd like people to take a look and see what they think :)
2021-09-13 25617, 2021
reosarevok
(I personally feel that bundling everything is not ideal, but I would be ok with that too if people prefer it - the current half-and-half seems like the worst of all 3 options)
2021-09-13 25647, 2021
CatQuest
i'd like separate rels honestly
2021-09-13 25651, 2021
Freso
I personally _feel_ like it would still be more efficient to have per-site relationships, but I don’t have any benchmarks. Theoretically it feels like it would be faster/more efficient to query an (row) id number than to do a regex or % match on all strings.
2021-09-13 25645, 2021
reosarevok
It would, but I can see that it makes it harder if you just want "give me all other databases" :)
2021-09-13 25607, 2021
bitmap
"relationship types describe/document the role of an entity towards another entity" makes sense to me
2021-09-13 25608, 2021
CatQuest
🤔 isn't that still gonig ot be a (unselectable) parent?
2021-09-13 25627, 2021
bitmap
I guess my only worry would be breaking existing code that relies on the other databases UUID to filter things?
2021-09-13 25637, 2021
Freso
CatQuest: Doesn’t help for direct db search :)
2021-09-13 25637, 2021
CatQuest
is it possible to filter/query for tings udner a spesific parent?
2021-09-13 25647, 2021
CatQuest
(if not then should be)
2021-09-13 25614, 2021
reosarevok
It is, to some degree, it just requires some more effort :)
2021-09-13 25620, 2021
CatQuest
weeeeell
2021-09-13 25621, 2021
reosarevok
From the DB, it's totally doable
2021-09-13 25623, 2021
yvanzo
It is not implemented though
2021-09-13 25626, 2021
reosarevok
From the WS for example, not really
2021-09-13 25642, 2021
CatQuest
so i should write a ticket?
2021-09-13 25652, 2021
reosarevok
Unless you implement a "grouping ID" or something and add it to the WS, but that seems hacky
2021-09-13 25654, 2021
CatQuest
(I'd need help formulating it)
2021-09-13 25601, 2021
yvanzo
It is already possible to filter by URL pattern, the code exists already.
2021-09-13 25624, 2021
CatQuest
well for other databases the url doesnt necessary have the same format for every type of database
2021-09-13 25640, 2021
yvanzo
?
2021-09-13 25647, 2021
reosarevok
CatQuest: Yeah, the idea yvanzo has is that you store all as just "other databases" and do everything else just based on the URL
2021-09-13 25649, 2021
bitmap
would the per-site rels become children of 'other databases'? maybe we can have a way to filter by parent type
2021-09-13 25657, 2021
bitmap
in the WS
2021-09-13 25659, 2021
reosarevok
bitmap: stuff like Discogs already is :)
2021-09-13 25608, 2021
bitmap
right
2021-09-13 25634, 2021
CatQuest
exactly as bitmap said was my point with all this
2021-09-13 25638, 2021
reosarevok
But this sounds like we could talk about it at a team meeting, see what possibilities we can implement
2021-09-13 25643, 2021
reosarevok
And decide from there :)
2021-09-13 25643, 2021
yvanzo
Most if not all of databases have normalized URL format, often even permalinks.
2021-09-13 25628, 2021
reosarevok
Basically, I expect we'll want to either implement stuff for display if we group all (so that Discogs still shows Discogs and not other databases, and whatnot)
2021-09-13 25634, 2021
reosarevok
Or implement stuff for querying if we split all
2021-09-13 25653, 2021
CatQuest
uh
2021-09-13 25657, 2021
CatQuest
yes
2021-09-13 25604, 2021
Freso
Definitely doesn’t seem like there’s outright consensus either way right now.
2021-09-13 25609, 2021
reosarevok
I'll write it down to bring up at a team meeting, in any case :) Freso, I think we can move on
