3:34 AM
lucifer has quit
3:34 AM
lucifer joined the channel
4:29 AM
outsidecontext has quit
4:29 AM
englishm has quit
4:29 AM
Freso has quit
4:29 AM
Lorenzo[m] has quit
4:29 AM
akashgp09[m] has quit
4:29 AM
legoktm[m] has quit
4:30 AM
englishm joined the channel
4:30 AM
Freso joined the channel
4:30 AM
outsidecontext joined the channel
4:31 AM
legoktm[m] joined the channel
4:36 AM
Lorenzo[m] joined the channel
4:40 AM
akashgp09[m] joined the channel
4:41 AM
MagnusSvensson[m has quit
4:41 AM
djinni` has quit
4:42 AM
djinni` joined the channel
4:46 AM
MagnusSvensson[m joined the channel
5:49 AM
reosarevok
I think it was an IA issue, FWIW
5:50 AM
They were temporarily down or whatnot
5:52 AM
akshaaatt[m]
Interesting
6:04 AM
lucifer
reosarevok: hi! 1) i tested sir PR, all commands and work with latest changes. 2) re username change: will need to ask alastairp about current status of the relevant PR.
6:05 AM
reosarevok
Thanks. Should we forward that mail to alastairp then?
6:05 AM
lucifer
yes makes sense.
7:22 AM
yvanzo
I restarted caa-indexer yesterday just in case, but it's likely an IA issue indeed.
7:41 AM
alastairp
hi. I had a chat with ruaok last week about the improvements that we wanted to make with the username PR
7:48 AM
reosarevok
yvanzo: moin! Should I release prod or have you noticed anything that needs fixing?
7:48 AM
(we talked about releasing earlier)
7:55 AM
yvanzo
reosarevok: No regression spotted in a week, it looks good for prod, thanks :)
7:56 AM
reosarevok
I'm looking at removing all unneeded override href_url methods, btw
7:56 AM
There's a lot more than just vimeo :)
7:56 AM
Just found that MBS-9838 didn't do all the bnf links though it seems?
7:56 AM
BrainzBot
7:56 AM
reosarevok
7:56 AM
yvanzo: do you remember whether that was intentional or something? I see some are a lot older than that ticket
7:58 AM
yvanzo
Most href_url methods were needed for transition only indeed, but not all of these.
7:58 AM
reosarevok
Yeah, I'm checking one by one
7:58 AM
CDJapan has some again, added a ticket, it's because we were missing one cleanup type
7:58 AM
Allmusic and Last.fm we have tickets for
7:59 AM
(for the last bits)
7:59 AM
But the BNF ones were unexpected :)
8:00 AM
yvanzo
How many?
8:01 AM
Looks like these 17 are the only HTTP ones.
8:04 AM
alastairp
my discover weekly has only 2 songs on it this week
8:05 AM
yvanzo
reosarevok: edited these links
8:06 AM
8:09 AM
(The normalization script does neither merge URLs nor edit URL having pending edits.)
8:14 AM
reosarevok
Oh, ok
8:15 AM
I thought if they had been from then you'd have had a ticket too, guess you just missed those or whatever
8:15 AM
Thanks!
8:15 AM
I'll deal with the allmusic and last.fm ones by hand later I think
8:27 AM
yvanzo
reosarevok: ready to update musicbrainz-docker repo.
8:44 AM
Etua joined the channel
9:07 AM
reosarevok
yvanzo: ok, will start the release cycle
9:07 AM
yvanzo
thanks
9:36 AM
Etua has quit
9:36 AM
Etua joined the channel
9:54 AM
yyoung[m]
yvanzo: Do you mean the link in duplicate notice doesn't work at all for you?
9:57 AM
yvanzo
yyoung[m]: yes
10:04 AM
reosarevok
Updating beta
10:08 AM
yyoung[m]
yvanzo Hmmm, but it works for me through anchor links.
10:09 AM
I tried to add highlight effect, but didn't get jQuery UI to work, I'll try again.
10:16 AM
reosarevok
Updating prod
10:33 AM
Updated, working on jira/blog
10:33 AM
yvanzo: you wanna do docker or did you just prepare a draft for me?
10:34 AM
yvanzo
reosarevok: yes I have another commit to push
10:34 AM
reosarevok
Ok :)
10:38 AM
yvanzo
yyoung[m]: I tested it again, rebase on master, using FF 92.0, still not working.
10:42 AM
yyoung[m]: Please split into two PRs so we can merge the new layout for icons sooner :)
10:51 AM
lucifer
alastairp: i see, makes sense.
10:58 AM
reosarevok
yvanzo: saved a draft of the blog post, can you take a look? :)
11:02 AM
Etua has quit
11:12 AM
Lunch break in the meantime
12:19 PM
Etua joined the channel
12:42 PM
BrainzGit
12:48 PM
yvanzo
reosarevok: LGTM but MBS-6140 needs to update API doc.
12:48 PM
BrainzBot
12:48 PM
reosarevok
Oh, fair point
12:48 PM
Also, heh
12:48 PM
12:48 PM
And it's not even a valid one :p
12:49 PM
yvanzo
12:49 PM
BrainzBot
12:49 PM
reosarevok
12:51 PM
yvanzo
reosarevok: maybe we should remind the user who requested it that he can use it now :)
12:51 PM
BrainzGit
12:51 PM
reosarevok
Yeah, I just posted
12:52 PM
(on the original ticket)
12:52 PM
yvanzo
(10 months have elapsed between their request and the implementation)
12:52 PM
reosarevok
Fixed all the allmusic http links, now working on the imdb ones
12:52 PM
Then we can also remove those https overrides
12:52 PM
Also, runeberg had an override - but it doesn't support https :D
12:52 PM
I'll remove that one
12:52 PM
(on a separate commit to explain why)
12:56 PM
yvanzo
reosarevok: may I tag production now? (so as to update mb docker too)
12:57 PM
reosarevok
yvanzo: sure - do you think it's fine to put the blog out as is and update the docs once I'm done with this? :)
12:57 PM
If yes, I can tag myself np
12:58 PM
Given you said LGTM I guess yes :D
12:58 PM
yvanzo
It’s probably fine: The doc is linked from the blog post, but the new inc parameters are explained in the blog post too.
12:59 PM
reosarevok
Oh, I saw the update with the link now
12:59 PM
Thanks
12:59 PM
Yeah, let's do that, I'll update the docs soon
13:01 PM
yvanzo
reosarevok: pushed the tag on both repo; Can you please take a look at mb docker release post?
13:02 PM
reosarevok
Oh, ok, I was going to do that but that works too :D
13:02 PM
Sure, let me see
13:03 PM
yvanzo: looks good to me - just wanted me to quickly check the changes section?
13:03 PM
yvanzo
yup, it's just broken links or broken instructions happen :)
13:04 PM
Thank you!
13:05 PM
BrainzGit
13:14 PM
ruaok
13:17 PM
lucifer
lol. i see most of the issues are what we already have discussed, should be fixed soon.
13:21 PM
atj
has MB been updated now?
13:22 PM
lucifer
monkey: fine if temporarly replace beta with my statsbranch?
13:22 PM
yvanzo
atj: yes
13:22 PM
monkey
Sure lucifer go ahead
13:23 PM
yvanzo
13:23 PM
lucifer
cool, thanks!
13:25 PM
atj
I don't see the fix for MBS-11799
13:25 PM
BrainzBot
13:25 PM
atj
13:26 PM
two Discogs links, one has "credited as" set
13:26 PM
BrainzGit
13:28 PM
yvanzo
atj: I have “Discogs (as Paul Hammock)” for the second link
13:29 PM
atj: Try disabling userscripts
13:32 PM
reosarevok
13:33 PM
atj: same here - maybe it's cached somehow? Try forcing a full refresh?
13:36 PM
yvanzo
reosarevok: 2 reviews seem enough, plus bitmap suggested the same layout earlier IIRC.
13:36 PM
reosarevok
Ok, then merge away! :)
13:40 PM
BrainzGit
13:40 PM
14:34 PM
bitmap
moin!
14:34 PM
ruaok
moin!
14:35 PM
reosarevok
Moin!
14:36 PM
akshaaatt[m]
moin!
14:36 PM
bitmap
reosarevok: looks like most servers haven't been updated or something?
14:37 PM
reosarevok
Huh
14:37 PM
I ran a prod and a beta update and didn't notice anything weird
14:37 PM
But maybe I just didn't pay enough attention
14:38 PM
WAIT
14:38 PM
... did I do beta twice
14:38 PM
I might have done beta twice
14:38 PM
Nah, reosarevok@reolappy:~/musicbrainz-server$ ./script/update_containers.sh prod
14:38 PM
bitmap
well I said most because I do see the credits in the sidebar if I refresh enough times, it's just usually not there
14:39 PM
reosarevok
Huh
14:39 PM
Should I try running ./script/update_containers.sh prod again I wonder? Is docker-server-configs out of date?
14:40 PM
yvanzo
reosarevok: did you update your docker-server-configs clone?
14:40 PM
reosarevok
I did
14:40 PM
I can check again
14:40 PM
atj
I just refreshed and it showed, then refreshed and it disappeared.
14:40 PM
reosarevok